Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-220496295
@yantaiv Better ask that in the mailing list, you would get more answers
But overall:
You can use any IDE you want, there is informations about dev
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/899
Fix a few image not rendering
### What is this PR for?
There was a recent PR made by @doanduyhai that was changing some images URL
to include `../assets`. However, I found a few
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218786751
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218681550
@r-kamath I don't want to make this PR wait forever.
If it was easy to do, I would prefer removing those dependencies. Mainly
because everyti
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218183698
I don't get why its not important to have additional dependencies that we
are not using in our build if its not in bower.json, maybe somebody can ex
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218139724
@r-kamath https://github.com/handsontable/hot-builder
I understand that by default it seems to be needed, however I'm reticent to
include 3 diff
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-218131360
Anyway to not have:
* zeroclipboard
* pikaday
* moment
included when installing Handsontable?
---
If your project is set up for it
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-218011682
@mwkang no problem
It seems some tests and selectors are broken with the new changes.
I will try the branch again and post if I find what is
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/725#issuecomment-217896651
@jmrr Yes, The goal was to take care of the export using #714 and #725 (for
front and back-end export).
This would allow most of the PR to be merged
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/858#issuecomment-217047637
@felixcheung No, There is still no export to CSV feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216476403
Can you try to re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-215607826
@mwkang Do you have time to fix this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-215292663
@felixcheung already saw it and I will check it.
However, while we test + discuss the other PR, there is no reason not to
merge this one.
If the
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-215016412
Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/854#issuecomment-214618652
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/854#issuecomment-214130376
Triggering the CI again, previous fail seems unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user corneadoug reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/854
ZEPPELIN-824 - Make CI Crash when there is jshint errors
### What is this PR for?
This PR has for goal to fix the CI build regarding the front-end.
The CI is currently not
Github user corneadoug closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/854
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/854
ZEPPELIN-824 - Make CI Crash when there is jshint errors
### What is this PR for?
This PR has for goal to fix the CI build regarding the front-end.
The CI is currently not
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/848#issuecomment-214099514
I found a couple of issues:
1) The current message can show this:
`Took 0 seconds. Last updated by anonymous at undefined`
It would be
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/27#issuecomment-212715184
@joku86 You would need to do an `z.angularBind` for the `selectedTable`
value beforehand.
As you can see in the documentation:
https
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/714#issuecomment-211799196
It was already discussed there.
Regarding the TODO, there is only one that is useful: `Hide/disable the
button if it is not in table/chart view`, but
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/714#issuecomment-211785324
@zhongneu Could you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/714#issuecomment-211207176
Tested after rebasing with master, no conflicts.
Let's rebase it and Merge it :)
---
If your project is set up for it, you can reply to this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-209716817
@ankurmitujjain I made a PR to your branch
https://github.com/ankurmitujjain/incubator-zeppelin/pull/1
---
If your project is set up for it, you can
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208652734
#725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208334864
@ankurmitujjain Yes exactly
I know your original goal what for the download, however having in settings
allow both server and front-end download, as
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-208236629
@ankurmitujjain I did leave a comment before
> I think we would be better off using multiple PRs:
* #761 to replace the table only (if
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-208200553
@mwkang
I found 2 problems:
1) Content of the first line is copied instead of interpreter sign only,
for example:
```
%md hello
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-207270802
The indentation wasn't fixed properly (too many changes)
Try being careful with TABS (we use spaces indentation) and line ending ([a
useful guide
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-207224689
@ankurmitujjain First, the indentation is broken in most files
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-207163317
@felixcheung @echarles does that explain a bit better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/804#issuecomment-206663670
Maybe the GIFs are not obvious enough :)
The PR is mainly trying to improve the rendering of the streaming
capability introduced in https
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-206424099
You can do a `git reset --hard lastCommitYouWantInYourHistory` then `git
push -f` to rewrite
---
If your project is set up for it, you can reply to this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-206396565
@ankurmitujjain main problem might be that you use you branch master
instead of a dedicated branch for this PR
---
If your project is set up for it, you
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-206394984
@ankurjainyash please don't use merge from master, use rebase instead
---
If your project is set up for it, you can reply to this email and have
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-205728439
I think we would be better off using multiple PRs:
* #761 to replace the table only (if it brings better performances)
* #714 to have a download
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205160036
If we create a new empty paragraph, we should add the `%..` (default, or
previous).
So this should be working for: running the last paragraph of the
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-205101528
For me, same comment as before.
There is no need for any front-end code.
---
If your project is set up for it, you can reply to this email and have
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-205101210
@doanduyhai LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-203796268
Isn't it possible not to have any front-end code for that?
Why not just include the `%..` in the empty note in the backend?
---
If your proje
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/797#issuecomment-203189083
I didn't see any effect on other part of the app, so LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/804
[ZEPPELIN-772] - Improve text append when streaming
### What is this PR for?
This PR is to improve the result output when having interpreter streaming
running.
If you
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/788#issuecomment-199598588
LGTM, however we might want to limit the size of the username with a
truncate
---
If your project is set up for it, you can reply to this email and have
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-199595583
Most of the profiles are green, including those with tests, so LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-199579294
@granturing Selenium tests failed, could you close/re-open this PR to
launch CI again?
---
If your project is set up for it, you can reply to this email
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-197157950
I found some css problems depending on the paragraph size:
https://cloud.githubusercontent.com/assets/710411/13802685/94eb8a32-eb81-11e5-8ad9
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/765#issuecomment-197129759
* Too many logs in the console, we got to turn them off:
https://github.com/tombatossals/angular-leaflet-directive/issues/1026
* The Resize handle
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195144733
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-195128515
@r-kamath Could you re-trigger the CI to be sure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-194783809
Sorry,
I had a pile of notifications.
It depends on how the error is detected, the best could be to fire the
modal on error (if multiple errors
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/740#issuecomment-194776078
Just a quick question in case I missed something, why are we limiting the
angularBind to paragraph level only?
---
If your project is set up for it, you
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/761#issuecomment-194768156
Thanks, I'll test that out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194763990
LGTM, I'm trying to figure out why the CI is failing
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/772#issuecomment-194623195
This issue made me see a bug in the grunt file. (Since build is not failing)
Could you fix it at the same time?
In Gruntfile.js: (Around
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/690#issuecomment-194071744
@ravicodder I just merged #692, could you rebase this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/767#issuecomment-194062568
I didn't test it yet, but I also think it could be nice to have feedbacks
from people who worked on some Notebook storages. (Git, S3 etc..) @vgmar
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/190#issuecomment-193620763
@zhongneu How about creating a PR instead?
It will be easier to comment on the code. You can always base your PR on
this one.
Once it's done,
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-193590836
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/728#issuecomment-193108046
I can take a look at the CI failure.
I think the heatmap is a nice addition to the basic map. Maybe it could be
toggled as an option instead of a
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/6#issuecomment-191637593
I already posted pre-requisite before.
If the angular version do not work, then what is left is:
* It improves the current Table features without
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-189077149
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-18857
Then lets remove the bookmarklet and update the template in the
contributing.md
---
If your project is set up for it, you can reply to this email and
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/744#issuecomment-188856053
We already have ngtoast for that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188853739
Should we remove the PR template part from the Contributing.md then?
---
If your project is set up for it, you can reply to this email and have your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-188605190
@ravicodder I merged one of your test, could you rebase this one?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-188546460
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/739#issuecomment-187750881
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-187324633
When you use multiple times the same XPath, it would be better to have a
reusable variable for it.
This Xpath for the title `//div[contains
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-187318586
Bad rebase again, you are replacing `testRemoveButton()`.
It could be better for you to do a batch of tests instead of a PR for each
of them, because
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/739#issuecomment-187315999
The drop-down menu is closing on mouse-up event.
Since we want to select the paragraph id to do a copy/paste, its better to
remove that behavior on
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-187293536
So, from what I saw in the front-end code, a checkbox is considered as a
group of checkbox by default?
I'm going look into it a bit more, in the
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-187291948
Question, why is that test deleting: `testCreateNewButton`? Is that a
result of the rebase?
---
If your project is set up for it, you can reply to this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/739#issuecomment-187282897
How about presenting it as the title:
```
{{paragraph.id}}
```
https://cloud.githubusercontent.com/assets/710411/13226659
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-187250818
We can keep it like that for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/691#issuecomment-186353462
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-186353043
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/720#issuecomment-186352411
@granturing Do you use any other method recently?
There used to be 2 compiledScope in the past (App level, and Notebook
level), this PR solve the
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/6#issuecomment-186340500
@adejanovski
Good thing we already have both dependencies in the project :)
Full document would be nice (and its not that hard), however I was
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/152#issuecomment-186336504
After discussion with @Madhuka, this should be rebased and finished by 1st
week of March. (since he is busy)
There has been a new PR opened
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/6#issuecomment-186331147
I'm fine with adding a new dependency for that feature if :
* Its an Angular plugin
* It improves the current Table features without degradin
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/649#issuecomment-186320828
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/6#issuecomment-185462206
Adding those buttons also means changing the table rendering to use
Datatables right?
I see no problems for testing that option with the angular plugin
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185303666
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-185301442
There is a few values or function, that seems out of place to me, for
example:
`$scope.paragraph.interpreterRestarting` should probably not be at
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/723#issuecomment-185293511
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/718#issuecomment-185295506
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/690#issuecomment-185312724
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/691#issuecomment-185311820
CI is now failing on:
```
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 187.743 sec
<<< FAIL
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/689#issuecomment-185311026
CI is now failing on:
```
Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 25.538 sec
<<< FAIL
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/719#issuecomment-185306185
CI is green, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/720#issuecomment-185025224
Its not backward compatible for some of my Notebooks.
We should ask some AngularDisplay power user to test it against theirs, so
that they can share
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/718#issuecomment-184756035
@malur yes adding drill to the supported DB in the JDBC documentation.
However most of the content of your document is already inside the JDBC, so
I
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/715#issuecomment-184484524
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183999563
You can already add a lot of different dynamic forms to one single
paragraph and it won't look good.
Hiding better be at the form level (dynamic
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-183944263
I'm not sure show/hide option is really necessary in general, since the
goal of the dynamic form is to interact with it. (We don't even hide it
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/672#issuecomment-183736608
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/712#issuecomment-183590696
@tejasrivastav Wrong repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/519#issuecomment-183590231
Yes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-183540358
@ravicodder There seems to be plenty of unnecessary files in your PR.
The only one needed should be `ParagraphActionsIT.java`
Also for the test
1 - 100 of 596 matches
Mail list logo
