[GitHub] shakuzen closed issue #7: Move repository to https://github.com/apache/incubator-zipkin-brave-karaf

shakuzen closed issue #7: Move repository to https://github.com/apache/incubator-zipkin-brave-karaf URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/7 This is an automated message from the Apache Git Servic

[GitHub] shakuzen commented on issue #7: Move repository to https://github.com/apache/incubator-zipkin-brave-karaf

shakuzen commented on issue #7: Move repository to https://github.com/apache/incubator-zipkin-brave-karaf URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/7#issuecomment-458133927 Looks like this is done now. --

[GitHub] adriancole opened a new pull request #10: Enables Apache RAT plugin for verifying dependency licenses

adriancole opened a new pull request #10: Enables Apache RAT plugin for verifying dependency licenses URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/10 This is an automated message from the Apache Git Servi

[GitHub] adriancole merged pull request #10: Enables Apache RAT plugin for verifying dependency licenses

adriancole merged pull request #10: Enables Apache RAT plugin for verifying dependency licenses URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/10 This is an automated message from the Apache Git Service. To

[GitHub] adriancole opened a new pull request #11: Switches to ASF license header

adriancole opened a new pull request #11: Switches to ASF license header URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/11 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] adriancole merged pull request #11: Switches to ASF license header

adriancole merged pull request #11: Switches to ASF license header URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/11 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] devinsba commented on issue #11: Switches to ASF license header

devinsba commented on issue #11: Switches to ASF license header URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/11#issuecomment-458978740 Side note: no more worrying about the New Years commit breakage when the year rolls over and license headers are no longer valid!!! 🎆

[GitHub] adriancole commented on issue #11: Switches to ASF license header

adriancole commented on issue #11: Switches to ASF license header URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/11#issuecomment-458980222 hah that's right! This is an automated message from the Apache Git S

[GitHub] adriancole opened a new pull request #12: Uses ASF parent and moves to ASF group IDs

adriancole opened a new pull request #12: Uses ASF parent and moves to ASF group IDs URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/12 This is an automated message from the Apache Git Service. To respond to

[GitHub] adriancole commented on issue #12: Uses ASF parent and moves to ASF group IDs

adriancole commented on issue #12: Uses ASF parent and moves to ASF group IDs URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/12#issuecomment-459022609 it is good This is an automated message from the Apache

[GitHub] adriancole merged pull request #12: Uses ASF parent and moves to ASF group IDs

adriancole merged pull request #12: Uses ASF parent and moves to ASF group IDs URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/12 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] abesto opened a new pull request #13: Create Jenkinsfile

abesto opened a new pull request #13: Create Jenkinsfile URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/13 This Jenkinsfile just builds the project and runs unit tests. This is an automated message from the A

[GitHub] abesto merged pull request #13: Create Jenkinsfile

abesto merged pull request #13: Create Jenkinsfile URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] abesto opened a new pull request #14: Whitespace change to test Jenkins-GitHub integration

abesto opened a new pull request #14: Whitespace change to test Jenkins-GitHub integration URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/14 This is an automated message from the Apache Git Service. To resp

[GitHub] abesto closed pull request #14: Whitespace change to test Jenkins-GitHub integration

abesto closed pull request #14: Whitespace change to test Jenkins-GitHub integration URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/14 This is an automated message from the Apache Git Service. To respond to

[GitHub] abesto commented on issue #14: Whitespace change to test Jenkins-GitHub integration

abesto commented on issue #14: Whitespace change to test Jenkins-GitHub integration URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/14#issuecomment-459039012 Test status is reported, we're happy, closing. Th

[GitHub] abesto opened a new pull request #15: Jenkinsfile tweaks

abesto opened a new pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15 * Remove unneeded poll trigger * Keep 30 builds instead of 10 * Don't run any stages after tests if tests fail * Time out after 30 minutes * WIP code for r

[GitHub] abesto merged pull request #15: Jenkinsfile tweaks

abesto merged pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] adriancole opened a new pull request #16: Switches build to Apache repositories

adriancole opened a new pull request #16: Switches build to Apache repositories URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/16 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] adriancole merged pull request #16: Switches build to Apache repositories

adriancole merged pull request #16: Switches build to Apache repositories URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/16 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] abesto opened a new pull request #17: [jenkins] Don't try to sign snapshot builds

abesto opened a new pull request #17: [jenkins] Don't try to sign snapshot builds URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/17 Because (1) we don't need to sign them and (2) Jenkins can't sign them, because it doesn't have any GPG keys. -

[GitHub] abesto merged pull request #17: [jenkins] Don't try to sign snapshot builds

abesto merged pull request #17: [jenkins] Don't try to sign snapshot builds URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/17 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] adriancole opened a new pull request #18: Don't deploy itests

adriancole opened a new pull request #18: Don't deploy itests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] adriancole merged pull request #18: Don't deploy itests

adriancole merged pull request #18: Don't deploy itests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] abesto opened a new pull request #19: [jenkins] More Jenkinsfile tweaks

abesto opened a new pull request #19: [jenkins] More Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/19 * Add --batch-mode to Maven invocation to reduce output spam * Change mail notifications to go to commits@ instead of notifications@ because the l

[GitHub] adriancole merged pull request #19: [jenkins] More Jenkinsfile tweaks

adriancole merged pull request #19: [jenkins] More Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/19 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] shakuzen commented on a change in pull request #15: Jenkinsfile tweaks

shakuzen commented on a change in pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252648597 ## File path: Jenkinsfile ## @@ -39,13 +56,38 @@ pipeline { sh './mvnw clean install'

[GitHub] shakuzen commented on a change in pull request #16: Switches build to Apache repositories

shakuzen commented on a change in pull request #16: Switches build to Apache repositories URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/16#discussion_r252650194 ## File path: Jenkinsfile ## @@ -57,17 +57,14 @@ pipeline { } } -

[GitHub] abesto commented on a change in pull request #15: Jenkinsfile tweaks

abesto commented on a change in pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252690062 ## File path: Jenkinsfile ## @@ -39,13 +56,38 @@ pipeline { sh './mvnw clean install'

[GitHub] abesto opened a new pull request #20: Test Jenkins triggering

abesto opened a new pull request #20: Test Jenkins triggering URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/20 This should trigger a build, but it should *not* release a snapshot. This is an automated messag

[GitHub] abesto commented on a change in pull request #15: Jenkinsfile tweaks

abesto commented on a change in pull request #15: Jenkinsfile tweaks URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/15#discussion_r252696326 ## File path: Jenkinsfile ## @@ -39,13 +56,38 @@ pipeline { sh './mvnw clean install'

[GitHub] abesto opened a new pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build

abesto opened a new pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21 This is an automated message from the Apache Git Ser

[GitHub] abesto commented on a change in pull request #16: Switches build to Apache repositories

abesto commented on a change in pull request #16: Switches build to Apache repositories URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/16#discussion_r252697844 ## File path: Jenkinsfile ## @@ -57,17 +57,14 @@ pipeline { } } -

[GitHub] abesto closed pull request #20: Test Jenkins triggering

abesto closed pull request #20: Test Jenkins triggering URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] abesto merged pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build

abesto merged pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21 This is an automated message from the Apache Git Service.

[GitHub] abesto opened a new pull request #22: [jenkins] -nsu (--no-snapshot-updates)

abesto opened a new pull request #22: [jenkins] -nsu (--no-snapshot-updates) URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/22 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] abesto commented on issue #22: [jenkins] -nsu. -DskipTests on snapshot (post-test)

abesto commented on issue #22: [jenkins] -nsu. -DskipTests on snapshot (post-test) URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/22#issuecomment-459382612  --

[GitHub] abesto merged pull request #22: [jenkins] -nsu. -DskipTests on snapshot (post-test)

abesto merged pull request #22: [jenkins] -nsu. -DskipTests on snapshot (post-test) URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/22 This is an automated message from the Apache Git Service. To respond to

[GitHub] shakuzen commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build

shakuzen commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21#discussion_r252925629 ## File path: Jenkinsfile ## @@ -62,7 +62,7 @@ pipeline {

[GitHub] abesto commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build

abesto commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21#discussion_r252993281 ## File path: Jenkinsfile ## @@ -62,7 +62,7 @@ pipeline {

[GitHub] adriancole opened a new pull request #23: Removes task dependencies in deploy when publishing snapshots

adriancole opened a new pull request #23: Removes task dependencies in deploy when publishing snapshots URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/23 Good idea from @shakuzen, we shouldn't need to run depedencies of deploy as they are done prior. --

[GitHub] adriancole merged pull request #23: Removes task dependencies in deploy when publishing snapshots

adriancole merged pull request #23: Removes task dependencies in deploy when publishing snapshots URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/23 This is an automated message from the Apache Git Service.

[GitHub] adriancole commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build

adriancole commented on a change in pull request #21: [jenkins] Snapshot phase: let's not throw away the existing build URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/21#discussion_r252993927 ## File path: Jenkinsfile ## @@ -62,7 +62,7 @@ pipeline {

[GitHub] shakuzen commented on a change in pull request #23: Removes task dependencies in deploy when publishing snapshots

shakuzen commented on a change in pull request #23: Removes task dependencies in deploy when publishing snapshots URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/23#discussion_r252994457 ## File path: Jenkinsfile ## @@ -62,7 +62,7 @@ pipeline {

[GitHub] shakuzen commented on a change in pull request #23: Removes task dependencies in deploy when publishing snapshots

shakuzen commented on a change in pull request #23: Removes task dependencies in deploy when publishing snapshots URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/23#discussion_r252997516 ## File path: Jenkinsfile ## @@ -62,7 +62,7 @@ pipeline {

[GitHub] adriancole opened a new pull request #24: Revert "Removes task dependencies in deploy when publishing snapshots"

adriancole opened a new pull request #24: Revert "Removes task dependencies in deploy when publishing snapshots" URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/24 This reverts commit 0542a961802d7a1818fbf374b4a5fe2d423f7028 from #23 This broke the build, and while t

[GitHub] adriancole commented on issue #24: Revert "Removes task dependencies in deploy when publishing snapshots"

adriancole commented on issue #24: Revert "Removes task dependencies in deploy when publishing snapshots" URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/24#issuecomment-462010989 I'm merging this just to fix the build, we can re-revert this later if we decide this was a

[GitHub] adriancole merged pull request #24: Revert "Removes task dependencies in deploy when publishing snapshots"

adriancole merged pull request #24: Revert "Removes task dependencies in deploy when publishing snapshots" URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/24 This is an automated message from the Apache Git

[GitHub] adriancole opened a new issue #25: make jenkins more automatic

adriancole opened a new issue #25: make jenkins more automatic URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/25 Right now, we have to click refresh to build. I think we were awaiting access, which we should now have. https://user-images.githubusercontent.com/6421

[GitHub] adriancole commented on issue #4: Let's polish this up for a release?

adriancole commented on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462012728 attempting a release based on dubbo's guide https://dubbo.incubator.apache.org/en-us/blog/prepare-an-apache-release.html --

[GitHub] adriancole edited a comment on issue #4: Let's polish this up for a release?

adriancole edited a comment on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462014445 https://lists.apache.org/thread.html/04ab2034ce82d9539e48530cb683cd46651a1795a1ed3ff8827118fb@%3Cdev.zipkin.apache.org%3E

[GitHub] adriancole commented on issue #4: Let's polish this up for a release?

adriancole commented on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462014445 https://lists.apache.org/thread.html/04ab2034ce82d9539e48530cb683cd46651a1795a1ed3ff8827118fb@%3Cdev.zipkin.apache.org%3E

[GitHub] adriancole edited a comment on issue #4: Let's polish this up for a release?

adriancole edited a comment on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462014445 https://lists.apache.org/thread.html/04ab2034ce82d9539e48530cb683cd46651a1795a1ed3ff8827118fb@%3Cdev.zipkin.apache.org%3E

[GitHub] abesto commented on issue #25: make jenkins more automatic

abesto commented on issue #25: make jenkins more automatic URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/25#issuecomment-462033175 I still don't have the settings tab on this repo :( FTR, there were no comments yet on [INFRA-17787](https://issues.apache.org/jira/brows

[GitHub] adriancole commented on issue #25: make jenkins more automatic

adriancole commented on issue #25: make jenkins more automatic URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/25#issuecomment-462033625 sorry my mistake. we have unrelated access :) seems upload access to the artifact repository is unrelated karma. do you mind

[GitHub] abesto commented on issue #25: make jenkins more automatic

abesto commented on issue #25: make jenkins more automatic URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/25#issuecomment-462034752 No worries. [INFRA-17787](https://issues.apache.org/jira/browse/INFRA-17787) is for this; I've edited the last point to make the request c

[GitHub] reta commented on issue #4: Let's polish this up for a release?

reta commented on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462046479 Good question, @adriancole , I think you need to skip inside the `pom.xml` direcly for `brave-itests`, as you suggested: ```

[GitHub] adriancole commented on issue #4: Let's polish this up for a release?

adriancole commented on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462047303 heh cool. I will work this in tomorrow morning On Sat, Feb 9, 2019, 9:54 PM Andriy Redko Good question, @adriancole

[GitHub] adriancole opened a new pull request #26: Skips deployment of integration tests

adriancole opened a new pull request #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26 See #4 This is an automated message from the Apache Git Service. To respond t

[GitHub] adriancole merged pull request #26: Skips deployment of integration tests

adriancole merged pull request #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] adriancole commented on issue #26: Skips deployment of integration tests

adriancole commented on issue #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26#issuecomment-462095590 thx for suggestion @reta will check on master This is an auto

[GitHub] adriancole commented on issue #26: Skips deployment of integration tests

adriancole commented on issue #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26#issuecomment-462097507 this worked ``` [INFO] --- maven-deploy-plugin:2.8.2:deploy (default-deploy) @ brave-itests --- [INFO] Skipping a

[GitHub] reta commented on issue #26: Skips deployment of integration tests

reta commented on issue #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26#issuecomment-462098050 :+1: , thanks @adriancole, I am often getting an impression that you never sleep :smile: -

[GitHub] adriancole commented on issue #26: Skips deployment of integration tests

adriancole commented on issue #26: Skips deployment of integration tests URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/26#issuecomment-462098087 timezones have changed a lot recently. I do sleep :P This is

[GitHub] adriancole opened a new pull request #27: Makes assembly create "incubating" filename and corrects baseDirectory

adriancole opened a new pull request #27: Makes assembly create "incubating" filename and corrects baseDirectory URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/27 This removes some manual work I did to rename the zip created by the package phase. It also corrects the ba

[GitHub] adriancole merged pull request #27: Makes assembly create "incubating" filename and corrects baseDirectory

adriancole merged pull request #27: Makes assembly create "incubating" filename and corrects baseDirectory URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/27 This is an automated message from the Apache Git

[GitHub] adriancole commented on issue #4: Let's polish this up for a release?

adriancole commented on issue #4: Let's polish this up for a release? URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/4#issuecomment-462101433 I left an old "release" profile in the build, and used that instead of the apache one. That's why there was no asc file @abesto

[GitHub] adriancole opened a new pull request #28: Moves integration test to integration test phase

adriancole opened a new pull request #28: Moves integration test to integration test phase URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/28 Common building and packaging shouldn't require execution of integration tests. This renames the file so that it isn't executed w

[GitHub] adriancole commented on issue #28: Moves integration test to integration test phase

adriancole commented on issue #28: Moves integration test to integration test phase URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/28#issuecomment-462132465 weird.. I thought failsafe ran as a prereq to the install phase..

[GitHub] adriancole merged pull request #28: Moves integration test to integration test phase

adriancole merged pull request #28: Moves integration test to integration test phase URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/28 This is an automated message from the Apache Git Service. To respond to

[GitHub] adriancole opened a new pull request #29: Addresses release feedback and updates build related versions

adriancole opened a new pull request #29: Addresses release feedback and updates build related versions URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/29 This adds the missing NOTICE file and removes the git plugin from the license check. Since we don't use a date expre

[GitHub] WillemJiang commented on a change in pull request #29: Addresses release feedback and updates build related versions

WillemJiang commented on a change in pull request #29: Addresses release feedback and updates build related versions URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/29#discussion_r256232327 ## File path: NOTICE ## @@ -0,0 +1,5 @@ +Apache Zipkin Brave Kara

[GitHub] adriancole commented on a change in pull request #29: Addresses release feedback and updates build related versions

adriancole commented on a change in pull request #29: Addresses release feedback and updates build related versions URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/29#discussion_r256237276 ## File path: NOTICE ## @@ -0,0 +1,5 @@ +Apache Zipkin Brave Karaf

[GitHub] adriancole merged pull request #29: Addresses release feedback and updates build related versions

adriancole merged pull request #29: Addresses release feedback and updates build related versions URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/29 This is an automated message from the Apache Git Service.

[GitHub] adriancole commented on issue #29: Addresses release feedback and updates build related versions

adriancole commented on issue #29: Addresses release feedback and updates build related versions URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/29#issuecomment-463044833 thanks for the review folks This is

[GitHub] adriancole opened a new pull request #30: Revises the NOTICE to mention prior copyright statement

adriancole opened a new pull request #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30 During our promotion of vote from PPMC to the IPMC, @justinmclean suggested a problem with our NOTICE file. I was unable t

[GitHub] adriancole opened a new pull request #31: Removes maven wrapper jar

adriancole opened a new pull request #31: Removes maven wrapper jar URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/31 During our release vote, @justinmclean noticed we had accidentally included the Maven wrapper jar. This removes it, so that we can pass the next relea

[GitHub] justinmclean commented on issue #30: Revises the NOTICE to mention prior copyright statement

justinmclean commented on issue #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30#issuecomment-463477302 See 1 b [1] and [2] the change you did looks fine tome but here's an example from another project. [3] Th

[GitHub] adriancole commented on issue #30: Revises the NOTICE to mention prior copyright statement

adriancole commented on issue #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30#issuecomment-463480486 What is strange is that we are needing to cite a placeholder which has no legal presence. "The OpenZipkin A

[GitHub] adriancole merged pull request #30: Revises the NOTICE to mention prior copyright statement

adriancole merged pull request #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30 This is an automated message from the Apache Git Service. To res

[GitHub] justinmclean edited a comment on issue #30: Revises the NOTICE to mention prior copyright statement

justinmclean edited a comment on issue #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30#issuecomment-463480859 I don't think it a big deal either way and it's nice to pay respect to where the code came from -

[GitHub] justinmclean commented on issue #30: Revises the NOTICE to mention prior copyright statement

justinmclean commented on issue #30: Revises the NOTICE to mention prior copyright statement URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/30#issuecomment-463480859 I don't think it a big deal but either way and it's nice today respect to where the code came from -

[GitHub] adriancole merged pull request #31: Removes maven wrapper jar

adriancole merged pull request #31: Removes maven wrapper jar URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] adriancole commented on issue #31: Removes maven wrapper jar

adriancole commented on issue #31: Removes maven wrapper jar URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/31#issuecomment-463528498 We discussed and next thing to do is remove the wrapper from the source distribution. That way it doesn't distract release validation, as

[GitHub] adriancole opened a new pull request #32: Removes special casing from the NOTICE file

adriancole opened a new pull request #32: Removes special casing from the NOTICE file URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/32 After reviewing with others, I've found there is in fact no requirement for us, especially the original authors of the code, to be force

[GitHub] adriancole merged pull request #32: Removes special casing from the NOTICE file

adriancole merged pull request #32: Removes special casing from the NOTICE file URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/32 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] adriancole opened a new issue #33: Consider changing export names

adriancole opened a new issue #33: Consider changing export names URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/33 We currently use "io.zipkin".. should we? ```java @Component( immediate = true, name = "io.zipkin.asyncreporter" ) ``` --

[GitHub] adriancole opened a new issue #34: README is not great for newbies (also there is no README)

adriancole opened a new issue #34: README is not great for newbies (also there is no README) URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/34 For those new to Karaf, it might be mystical what exactly an exporter is.. It seems like dependency injection wiring.. I've act

[GitHub] adriancole opened a new pull request #35: Renames tagline based on IPMC feedback

adriancole opened a new pull request #35: Renames tagline based on IPMC feedback URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/35 This is an automated message from the Apache Git Service. To respond to the

[GitHub] adriancole merged pull request #35: Renames tagline based on IPMC feedback

adriancole merged pull request #35: Renames tagline based on IPMC feedback URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/35 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] cschneider commented on issue #34: README is not great for newbies (also there is no README)

cschneider commented on issue #34: README is not great for newbies (also there is no README) URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/34#issuecomment-464598847 Maybe we should rename them to service. Like KafkaSenderService, OkHttpSenderService. Exporter is not r

[GitHub] adriancole commented on issue #34: README is not great for newbies (also there is no README)

adriancole commented on issue #34: README is not great for newbies (also there is no README) URL: https://github.com/apache/incubator-zipkin-brave-karaf/issues/34#issuecomment-464599760 ah sounds sensible and thanks for the offer On Mon, Feb 18, 2019, 2:11 PM Christian Schneider Ma

[GitHub] adriancole opened a new pull request #36: Inlines the source-release component until upstream adjusts excludes

adriancole opened a new pull request #36: Inlines the source-release component until upstream adjusts excludes URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/36 This makes sure the maven wrapper jar doesn't get into the source dist. See #31 See https://issues.apa

[GitHub] adriancole commented on issue #36: Inlines the source-release component until upstream adjusts excludes

adriancole commented on issue #36: Inlines the source-release component until upstream adjusts excludes URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/36#issuecomment-464952384 I verified this time @devinsba sorry I shouldn't have assumed this was excluded implicitly --

[GitHub] adriancole merged pull request #36: Inlines the source-release component until upstream adjusts excludes

adriancole merged pull request #36: Inlines the source-release component until upstream adjusts excludes URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/36 This is an automated message from the Apache Git Se

[GitHub] adriancole opened a new pull request #37: Filters out maven wrapper from the source distribution

adriancole opened a new pull request #37: Filters out maven wrapper from the source distribution URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/37 Maven doesn't strictly depend on the Takari wrapper. Excluding this decouples us from ongoing discussions as to whether or

[GitHub] adriancole opened a new pull request #38: updates maven wrapper and removes explicit install variable

adriancole opened a new pull request #38: updates maven wrapper and removes explicit install variable URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/38 This is an automated message from the Apache Git Servi

[GitHub] adriancole merged pull request #37: Filters out maven wrapper from the source distribution

adriancole merged pull request #37: Filters out maven wrapper from the source distribution URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/37 This is an automated message from the Apache Git Service. To resp

[GitHub] adriancole merged pull request #38: updates maven wrapper and removes explicit install variable

adriancole merged pull request #38: updates maven wrapper and removes explicit install variable URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/38 This is an automated message from the Apache Git Service. To

[GitHub] adriancole opened a new pull request #39: Works around inheritance that results in an empty DEPENDENCIES file

adriancole opened a new pull request #39: Works around inheritance that results in an empty DEPENDENCIES file URL: https://github.com/apache/incubator-zipkin-brave-karaf/pull/39 org.apache:apache:21 sets maven-remote-resources-plugin in plugins, not pluginManagement This results in exec

  1   2   3   4   >