---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12760
---
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paulo Ricardo Paz Vital updated ZOOKEEPER-1474:
---
Attachment: zookeeper-1474-v3.patch
New version of same patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484066#comment-13484066
]
Claude Falbriard commented on ZOOKEEPER-1474:
-
Dear colleagues,
When
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484068#comment-13484068
]
Hadoop QA commented on ZOOKEEPER-1474:
--
+1 overall. Here are the results of
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1474
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1239/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484256#comment-13484256
]
Jimmy Xiang commented on ZOOKEEPER-1568:
For our use case, there is no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12792
---
There's a big problem here: if the packet went unsent (fully) then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12794
---
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/
---
(Updated Oct. 25, 2012, 10:38 p.m.)
Review request for zookeeper, Patrick Hunt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/
---
(Updated Oct. 25, 2012, 10:51 p.m.)
Review request for zookeeper, Patrick Hunt
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12796
---
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java
On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134
https://reviews.apache.org/r/7730/diff/1/?file=179601#file179601line133
why are we synchronizing this? it's already protected by outgoingQueue,
is this not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7730/#review12800
---
Looks like I'm no longer passing unit tests, please hold off on
On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134
https://reviews.apache.org/r/7730/diff/1/?file=179601#file179601line133
why are we synchronizing this? it's already protected by outgoingQueue,
is this not
On Oct. 25, 2012, 11:33 p.m., Skye Wanderman-Milne wrote:
Looks like I'm no longer passing unit tests, please hold off on further
reviews for now...
Just kidding, I was testing the wrong branch :)
- Skye
---
This is an
On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134
https://reviews.apache.org/r/7730/diff/1/?file=179601#file179601line133
why are we synchronizing this? it's already protected by outgoingQueue,
is this not
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thawan Kooburat updated ZOOKEEPER-1552:
---
Attachment: ZOOKEEPER-1552.patch
Updated patch with added comments for txnlog
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1552
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1240/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484694#comment-13484694
]
Hadoop QA commented on ZOOKEEPER-1552:
--
-1 overall. Here are the results of
On Oct. 25, 2012, 9:23 p.m., Patrick Hunt wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java, lines 133-134
https://reviews.apache.org/r/7730/diff/1/?file=179601#file179601line133
why are we synchronizing this? it's already protected by outgoingQueue,
is this not
Jiannan Wang created BOOKKEEPER-443:
---
Summary: Revisit Ledger Deletion in BookKeeper
Key: BOOKKEEPER-443
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-443
Project: Bookkeeper
Issue
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483980#comment-13483980
]
Ivan Kelly commented on BOOKKEEPER-346:
---
New patch misses the case of a crash
[
https://issues.apache.org/jira/browse/BOOKKEEPER-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Kelly updated BOOKKEEPER-439:
--
Priority: Blocker (was: Critical)
No more messages delivered after deleted consumed
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484018#comment-13484018
]
Vinay commented on BOOKKEEPER-346:
--
Thanks Ivan,
You mean to say, After scanning all
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484023#comment-13484023
]
Ivan Kelly commented on BOOKKEEPER-346:
---
Yes, you can put it in
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484024#comment-13484024
]
Ivan Kelly commented on BOOKKEEPER-346:
---
.idx and .rloc should be defined as
[
https://issues.apache.org/jira/browse/BOOKKEEPER-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484087#comment-13484087
]
Ivan Kelly commented on BOOKKEEPER-439:
---
Why are you changing the return code
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay updated BOOKKEEPER-346:
-
Attachment: BOOKKEEPER-346.patch
Attaching the latest patch, which fixes Ivan's comments.
See
https://builds.apache.org/job/bookkeeper-trunk/org.apache.bookkeeper$hedwig-server/770/
See
https://builds.apache.org/job/bookkeeper-trunk/org.apache.bookkeeper$bookkeeper-server/770/
See https://builds.apache.org/job/bookkeeper-trunk/770/
[
https://issues.apache.org/jira/browse/BOOKKEEPER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484121#comment-13484121
]
Hudson commented on BOOKKEEPER-424:
---
Integrated in bookkeeper-trunk #771 (See
[
https://issues.apache.org/jira/browse/BOOKKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484120#comment-13484120
]
Uma Maheswara Rao G commented on BOOKKEEPER-416:
+1 for the patch,
See https://builds.apache.org/job/bookkeeper-trunk/771/changes
Changes:
[ivank] BOOKKEEPER-424: Bookie start is failing intermittently when zkclient
connection delays (rakeshr via ivank)
--
[...truncated 1268 lines...]
at
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484151#comment-13484151
]
Ivan Kelly commented on BOOKKEEPER-346:
---
Theres a logic error in the patch (and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484156#comment-13484156
]
Ivan Kelly commented on BOOKKEEPER-424:
---
Added missing file in r1402159
Ivan Kelly created BOOKKEEPER-444:
-
Summary: Refactor pending read op to make speculative reads
possible
Key: BOOKKEEPER-444
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-444
Project:
[
https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484184#comment-13484184
]
Uma Maheswara Rao G commented on BOOKKEEPER-428:
{code}
zk =
[
https://issues.apache.org/jira/browse/BOOKKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484190#comment-13484190
]
Flavio Junqueira commented on BOOKKEEPER-425:
-
The patch does not apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7733/
---
Review request for bookkeeper.
Description
---
The code to handle the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484206#comment-13484206
]
Ivan Kelly commented on BOOKKEEPER-444:
---
https://reviews.apache.org/r/7733/
See
https://builds.apache.org/job/bookkeeper-trunk/org.apache.bookkeeper$bookkeeper-server/772/changes
See https://builds.apache.org/job/bookkeeper-trunk/772/changes
[
https://issues.apache.org/jira/browse/BOOKKEEPER-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484209#comment-13484209
]
Hudson commented on BOOKKEEPER-424:
---
Integrated in bookkeeper-trunk #772 (See
[
https://issues.apache.org/jira/browse/BOOKKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Kelly updated BOOKKEEPER-425:
--
Attachment: 0001-BOOKKEEPER-425-Cleanup-up-address-generation.patch
new patch rebased on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484249#comment-13484249
]
Flavio Junqueira commented on BOOKKEEPER-425:
-
AuditorLedgerCheckTest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
--
Attachment: BackupTop2Sub2Seq.patch
InMemorySubscriptionManager
[
https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484267#comment-13484267
]
Yixue (Andrew) Zhu commented on BOOKKEEPER-441:
---
The consideration of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7731/
---
(Updated Oct. 25, 2012, 4:52 p.m.)
Review request for bookkeeper, Ivan Kelly,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484275#comment-13484275
]
Hudson commented on BOOKKEEPER-416:
---
Integrated in bookkeeper-trunk #773 (See
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7732/
---
(Updated Oct. 25, 2012, 5 p.m.)
Review request for bookkeeper, Ivan Kelly and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-362:
--
Attachment: rebase_remoteregion.patch
Local subscriptions fail if
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-362:
--
Attachment: (was: rebase_remoteregion.patch)
Local subscriptions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-362:
--
Attachment: (was: rebase_remoteregion.patch)
Local subscriptions
[
https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
--
Attachment: (was: BackupTop2Sub2Seq.patch)
[
https://issues.apache.org/jira/browse/BOOKKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixue (Andrew) Zhu updated BOOKKEEPER-441:
--
Attachment: (was: BackupTop2Sub2Seq.patch)
[
https://issues.apache.org/jira/browse/BOOKKEEPER-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484327#comment-13484327
]
Rakesh R commented on BOOKKEEPER-390:
-
Thanks Flavio for taking a look and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-428:
Attachment: BOOKKEEPER-428-1.patch
Expose command options in bookie scripts to
[
https://issues.apache.org/jira/browse/BOOKKEEPER-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484593#comment-13484593
]
Sijie Guo commented on BOOKKEEPER-439:
--
{quote}
Why are you changing the return
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484607#comment-13484607
]
Sijie Guo commented on BOOKKEEPER-362:
--
Thanks Yixue for the new patch. Several
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484641#comment-13484641
]
Yixue (Andrew) Zhu commented on BOOKKEEPER-362:
---
Thanks Sijie for your
[
https://issues.apache.org/jira/browse/BOOKKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484665#comment-13484665
]
Sijie Guo commented on BOOKKEEPER-362:
--
{quote}
Re. 1), it is not just for test.
On Oct. 24, 2012, 1:23 p.m., Ivan Kelly wrote:
bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/MetastoreScannableTable.java,
line 25
https://reviews.apache.org/r/7314/diff/1/?file=160306#file160306line25
My question is why is it a separate interface though? Do you
On Oct. 22, 2012, 2:11 p.m., Ivan Kelly wrote:
bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/Value.java,
line 37
https://reviews.apache.org/r/7314/diff/1/?file=160309#file160309line37
value should only be a byte[]. adding fields like this does,
overexpands
[
https://issues.apache.org/jira/browse/BOOKKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484686#comment-13484686
]
Vinay commented on BOOKKEEPER-346:
--
Thanks Ivan, I will correct the logic, also
65 matches
Mail list logo
