[jira] [Commented] (ZOOKEEPER-2867) an expired ZK session can be re-established

2017-08-08 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119431#comment-16119431 ] Michael Han commented on ZOOKEEPER-2867: bq. Should every closed session be in the ZK commit

ZooKeeper_branch34_jdk7 - Build # 1610 - Failure

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1610/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.17 MB...] [junit] 2017-08-09 03:00:45,116

[jira] [Commented] (ZOOKEEPER-2867) an expired ZK session can be re-established

2017-08-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119048#comment-16119048 ] Jun Rao commented on ZOOKEEPER-2867: [~hanm], thanks for the explanation. The client on session

[jira] [Comment Edited] (ZOOKEEPER-2867) an expired ZK session can be re-established

2017-08-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119048#comment-16119048 ] Jun Rao edited comment on ZOOKEEPER-2867 at 8/8/17 9:16 PM: [~hanm],

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119044#comment-16119044 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119045#comment-16119045 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034244 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034154 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119042#comment-16119042 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034008 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[jira] [Commented] (ZOOKEEPER-1549) Data inconsistency when follower is receiving a DIFF with a dirty snapshot

2017-08-08 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119019#comment-16119019 ] Fangmin Lv commented on ZOOKEEPER-1549: --- Is this issue still exist? Didn't go through all the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119006#comment-16119006 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff in the

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132027605 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132006551 --- Diff: src/java/test/org/apache/zookeeper/test/PersistentWatcherTest.java --- @@ -0,0 +1,228 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118997#comment-16118997 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118996#comment-16118996 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118992#comment-16118992 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118994#comment-16118994 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118995#comment-16118995 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118993#comment-16118993 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r131271126 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132023758 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132025725 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132024228 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter, boolean

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132010827 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

ZooKeeper-trunk-openjdk7 - Build # 1570 - Still Failing

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1570/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 61.14 MB...] [junit] 2017-08-08 20:15:28,025

ZooKeeper_branch34_openjdk7 - Build # 1602 - Still Failing

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1602/ ### ## LAST 60 LINES OF THE CONSOLE ### Started by timer [EnvInject] - Loading node environment

ZooKeeper_branch35_jdk8 - Build # 626 - Failure

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/626/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.60 MB...] [junit] 2017-08-08 12:21:21,362

ZooKeeper-trunk-jdk8 - Build # 1154 - Still Failing

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1154/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 64.69 MB...] [junit] 2017-08-08 12:08:20,168

ZooKeeper_branch35_openjdk7 - Build # 626 - Failure

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/626/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.58 MB...] [junit]

ZooKeeper_branch35_jdk7 - Build # 1068 - Still Failing

2017-08-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1068/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 56.95 MB...] [junit] at

[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118024#comment-16118024 ] ASF GitHub Bot commented on ZOOKEEPER-2826: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #298: ZOOKEEPER-2826: Code refactoring for `CLI` modu...

2017-08-08 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/298#discussion_r131848354 --- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java --- @@ -52,12 +52,12 @@ private String members; /* version

[jira] [Commented] (ZOOKEEPER-2826) Code refactoring for `CLI` module

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118020#comment-16118020 ] ASF GitHub Bot commented on ZOOKEEPER-2826: --- Github user maoling commented on a diff in the

[GitHub] zookeeper pull request #298: ZOOKEEPER-2826: Code refactoring for `CLI` modu...

2017-08-08 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/298#discussion_r131847801 --- Diff: src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java --- @@ -52,12 +52,12 @@ private String members; /* version -