Re: Let's cut a ZK 3.5.4-beta release

2018-05-07 Thread Patrick Hunt
There's been plenty of time for someone to get these into 3.5.4 before now. I really want to get 3.5.4 out so that folks can access/assess what's currently committed. I'm happy to drive a follow-on release with these changes soon after 3.5.4 ships if there's sufficient progress. Patrick On Mon,

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/466 Cool. :) FYI, https://issues.apache.org/jira/browse/ZOOKEEPER-2693 Particularly, this quote: _"A simple patch would provide a configuration option that disables these 4lw by default.

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/466 @eribeiro Thanks. In which case given that this PR is targeted for the master branch, I'll add them to Jetty and JMX commands. ---

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591847 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591545 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186591140 --- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java --- @@ -53,7 +54,7 @@ * @param spinDelay *

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186553219 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186546855 --- Diff: src/java/main/org/apache/zookeeper/client/HostProvider.java --- @@ -53,7 +54,7 @@ * @param spinDelay *Milliseconds

[GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...

2018-05-07 Thread fpj
Github user fpj commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/451#discussion_r186553004 --- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java --- @@ -111,9 +154,18 @@ public InetSocketAddress next(long spinDelay) {

Re: Let's cut a ZK 3.5.4-beta release

2018-05-07 Thread Alexander Shraer
Lets also get this in: https://issues.apache.org/jira/browse/ZOOKEEPER-2959 This affects anyone running observers. On Mon, May 7, 2018 at 1:45 PM, Flavio Junqueira wrote: > We should strongly consider merging this: > > https://issues.apache.org/jira/browse/ZOOKEEPER-2982 > > As

Re: Let's cut a ZK 3.5.4-beta release

2018-05-07 Thread Flavio Junqueira
We should strongly consider merging this: https://issues.apache.org/jira/browse/ZOOKEEPER-2982 As it is causing problems to anyone using ZK on K8s. -Flavio > On 7 May 2018, at 17:32, Rakesh Radhakrishnan wrote: > > I have added my feedback to the PR. Please take a look

[jira] [Comment Edited] (ZOOKEEPER-645) Bug in WriteLock recipe implementation?

2018-05-07 Thread Edward Capriolo (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466098#comment-16466098 ] Edward Capriolo edited comment on ZOOKEEPER-645 at 5/7/18 4:27 PM: --- I

[jira] [Commented] (ZOOKEEPER-645) Bug in WriteLock recipe implementation?

2018-05-07 Thread Edward Capriolo (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466098#comment-16466098 ] Edward Capriolo commented on ZOOKEEPER-645: --- I am going to suggest removing the code. It

Re: Let's cut a ZK 3.5.4-beta release

2018-05-07 Thread Rakesh Radhakrishnan
I have added my feedback to the PR. Please take a look at it. Rakesh On Mon, May 7, 2018 at 8:38 AM, Patrick Hunt wrote: > No one has looked at 2901, while I'm not super happy with it it seems fine > - I'll commit it as-is if I don't hear anything by EOD tomorrow (Monday). >

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-05-07 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r186427922 --- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java --- @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-05-07 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r186422920 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -950,6 +952,39 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-05-07 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r186415246 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -950,6 +952,39 @@ server.3=zoo3:2888:3888

[jira] [Updated] (ZOOKEEPER-3034) Facing issues while building from source

2018-05-07 Thread Namrata Bhave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Namrata Bhave updated ZOOKEEPER-3034: - Description: Building Zookeeper from source using below steps: {{git clone

[jira] [Updated] (ZOOKEEPER-3034) Facing issues while building from source

2018-05-07 Thread Namrata Bhave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Namrata Bhave updated ZOOKEEPER-3034: - Description: Building Zookeeper from source using below steps: {{git clone

[jira] [Updated] (ZOOKEEPER-3034) Facing issues while building from source

2018-05-07 Thread Namrata Bhave (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Namrata Bhave updated ZOOKEEPER-3034: - Environment: Linux x86_64, Ubuntu 18.04, Ubuntu 17.10. (was: Linux x86_64, Ubuntu

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread eribeiro
Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/466 @anmolnar Patrick is mentioning the plan to retire 4lw CLI commands in favor of Restful web service version (based on Jetty). See https://issues.apache.org/jira/browse/ZOOKEEPER-1346 ---

[jira] [Created] (ZOOKEEPER-3034) Facing issues while building from source

2018-05-07 Thread Namrata Bhave (JIRA)
Namrata Bhave created ZOOKEEPER-3034: Summary: Facing issues while building from source Key: ZOOKEEPER-3034 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3034 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2991) Server logs error on shutdown

2018-05-07 Thread Paul Millar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465582#comment-16465582 ] Paul Millar commented on ZOOKEEPER-2991: ZOOKEEPER-2795 is almost the same as this bug report

Re: [VOTE] Migrate ZK to Maven build

2018-05-07 Thread Norbert Kalmar
Yes, the plan is to backport to 3.5 and also 3.4, but the possibility to backport just the package changes is still in question. I am writing up a document which I will share for comments. Should be done in 1 or 2 days. I am also checking if they will work, so that I can get maven to work as

Failed: ZOOKEEPER- PreCommit Build #1662

2018-05-07 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1662/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.62 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics

2018-05-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465494#comment-16465494 ] Hadoop QA commented on ZOOKEEPER-2979: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #466: ZOOKEEPER-2940. Deal with maxbuffer as it relates to l...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/466 @phunt Sure, just let me try to clarify what needs to be done, because I think you wanted to link #415 instead of #466 which is this PR. - stats should be added to JMX (done, already in

[GitHub] zookeeper issue #440: ZOOKEEPER-2979 Use dropwizard library histogram for pr...

2018-05-07 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 Rebased and resolved conflicts. ---