Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/567
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2427/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2427/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 87.21 MB...]
[exec]
Github user suyogmapara commented on the issue:
https://github.com/apache/zookeeper/pull/567
Hi @breed @anmolnar, can you please take a look at this PR?
---
i think the unique port assignment (d) is more problematic than it
appears. there is a race between finding a free port and actually
grabbing it. i think that contributes to the flakiness.
ben
On Fri, Oct 12, 2018 at 8:50 AM Andor Molnar wrote:
>
> That is a completely valid point. I started to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648379#comment-16648379
]
Brian Nixon commented on ZOOKEEPER-3140:
A note on future work - it would be cool to see the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369
]
Brian Nixon commented on ZOOKEEPER-3166:
It would be cool to see the serialized format of the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648369#comment-16648369
]
Brian Nixon edited comment on ZOOKEEPER-3166 at 10/12/18 7:45 PM:
--
Brian Nixon created ZOOKEEPER-3166:
--
Summary: Support changing secure port with reconfig
Key: ZOOKEEPER-3166
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3166
Project: ZooKeeper
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224842221
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -154,6 +160,26 @@
private final
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224843197
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1566,179 @@ public boolean removeWatch(String path,
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224844559
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/AdHash.java ---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224841261
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataNode.java ---
@@ -37,6 +37,14 @@
*
*/
public class DataNode
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r224843869
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NodeHashMapImpl.java
---
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the
That is a completely valid point. I started to investigate flakies for exactly
the same reason, if you remember the thread that I started a while ago. It was
later abandoned unfortunately, because I’ve run into a few issues:
- We nailed down that in order to release 3.5 stable, we have to make
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/667#discussion_r224818567
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -146,13 +146,13 @@ public void
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-1908.
-
Resolution: Fixed
Fix Version/s: 3.5.5
3.6.0
Issue
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Committed to branch-3.5. Thanks @Reidd !
Please close this PR.
---
iirc the number of threads was increased to improve performance. Reducing
is fine, but do we understand why it's failing? Perhaps it's finding real
issues as a result of the artificial concurrency/load.
Patrick
On Fri, Oct 12, 2018 at 7:12 AM Andor Molnar
wrote:
> Thanks for the feedback.
>
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/666
Given that this is only the backport of #650 I think we're good to go.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/668
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2426/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2426/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.03 MB...]
[exec]
Thanks for the feedback.
I'm running a few tests now: branch-3.5 on 2 threads and trunk on 4 threads
to see what's the impact on the build time.
Github PR job is hard to configure, because its settings are hard coded
into a shell script in the codebase. I have to open PR for that.
Andor
On
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/668
@ivmaykov
You might be interested in this change. I wonder why only a single test was
failing, because of this.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3165:
Summary: Java 9: X509UtilTest.testCreateSSLContextWithoutTrustStorePassword
fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3165:
--
Labels: pull-request-available (was: )
> Java 10:
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/668
ZOOKEEPER-3165. Java 10:
X509UtilTest.testCreateSSLContextWithoutTrustStorePassword fails
We use JKS format explicitly, but the tests created the keystore and
truststore with the default
+1, running the tests locally with 1 thread always passes (well, I run it
about 5 times, but still)
On the other hand, running it on 8 threads yields similarly flaky results
as Apache runs. (Although it is much faster, but if we have to run 6-8-10
times sometimes to get a green run...)
Norbert
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1152/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 63.66 KB...]
[junit] Running
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2425/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2425/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 76.50 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647832#comment-16647832
]
Hudson commented on ZOOKEEPER-3161:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #228 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647833#comment-16647833
]
Hudson commented on ZOOKEEPER-3159:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #228 (See
+1
Enrico
Il ven 12 ott 2018, 13:52 Andor Molnar ha scritto:
> Hi,
>
> What do you think of changing number of threads running unit tests in
> Jenkins from current 8 to 4 or even 2?
>
> Running unit tests inside Cloudera environment on a single thread shows the
> builds much more stable. That
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647824#comment-16647824
]
Andor Molnar commented on ZOOKEEPER-3165:
-
This happens with Java 9 builds as well.
> Java
Andor Molnar created ZOOKEEPER-3165:
---
Summary: Java 10:
X509UtilTest.testCreateSSLContextWithoutTrustStorePassword fails
Key: ZOOKEEPER-3165
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3165
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
Hi,
What do you think of changing number of threads running unit tests in
Jenkins from current 8 to 4 or even 2?
Running unit tests inside Cloudera environment on a single thread shows the
builds much more stable. That would be probably too slow, but maybe running
at least less threads would
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/627
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2424/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2424/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.01 KB...]
at
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/651
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2423/
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2423/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 83.16 MB...]
[exec]
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/627
@ivmaykov Please rebase this one, because the original SSL PR has been
merged.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/651
retest this please
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3159.
-
Resolution: Fixed
Issue resolved by pull request 653
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/653
This is committed too to 3.5 and master to reduce flaky test pressure.
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/653
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3161.
-
Resolution: Fixed
Fix Version/s: 3.6.0
> Refactor QuorumPeerMainTest.java:
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/659
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/659
No response for 2 days. Committing it silently as you guys approved it.
---
Github user Reidd commented on the issue:
https://github.com/apache/zookeeper/pull/666
Shall we ping one more committer to give a review?
---
50 matches
Mail list logo
