GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/715
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
For what it's worth, builds 2732 and 2733 ran concurrently on H19, and
both failed for what I think are resource-conflict reasons. It would
probably help to modify the PreCommit-ZOOKEEPER-github-pr-build queue
so that it doesn't attempt concurrent builds on the same
(uncontainerized) host.
On
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/718
---
Michael K. Edwards created ZOOKEEPER-3198:
-
Summary: Handle port-binding failures in a systematic and
documented fashion
Key: ZOOKEEPER-3198
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3198
Thanks for the guidance. Feel free to assign ZOOKEEPER-2778 to me (I
don't seem to be able to do it myself). I've updated that pull
request against 3.5 to address all reviewer comments. When it looks
ready to land, I'll port it to master as well.
I have updated ZOOKEEPER-1636 and
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/717
---
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/717
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696267#comment-16696267
]
Michael K. Edwards commented on ZOOKEEPER-1818:
---
#718 is just Fangmin's patch against
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/718
ZOOKEEPER-1818: Correctly handle potentially inconsistent
zxid/electionEpochâ¦
⦠and peerEpoch during leader election. (This is Fangmin's patch, I'm
just firing off a CI build against
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696264#comment-16696264
]
Michael K. Edwards commented on ZOOKEEPER-1818:
---
#714 now has just Fangmin's patch,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696263#comment-16696263
]
Michael K. Edwards commented on ZOOKEEPER-1636:
---
#717 is Thawan's patch as a pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1636:
--
Labels: pull-request-available (was: )
> c-client crash when zoo_amulti failed
>
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/717
ZOOKEEPER-1636: cleanup completion list of a failed multi request
(from Thawan Kooburat)
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696226#comment-16696226
]
Hudson commented on ZOOKEEPER-3152:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #278 (See
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235808196
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -108,7 +109,11 @@
LocalPeerBean
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235807260
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -121,6 +126,18 @@
*/
private
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696198#comment-16696198
]
Hudson commented on ZOOKEEPER-3152:
---
SUCCESS: Integrated in Jenkins build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3152.
-
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 669
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/669
Merged to master branch. Thanks @ivmaykov !
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-3152:
---
Assignee: Ilya Maykov
> Port ZK netty stack to netty 4
>
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/669
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/689
@lvfangmin Any more concerns?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated ZOOKEEPER-3197:
---
Description:
A security scan flagged the use of a hard-coded secret
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/294
retest this please
---
Hi Michael!
Thanks for the great help to get 3.5 out of the door. We're getting closer
with each commit.
You asked a lot of questions in your email, which I'm trying to answer, but
I believe the best approach is to deal with one problem at a time.
Especially in email communication is not ideal
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colm O hEigeartaigh updated ZOOKEEPER-3197:
---
Description:
A security scan flagged the use of a hard-coded secret
Colm O hEigeartaigh created ZOOKEEPER-3197:
--
Summary: Improve documentation in ZooKeeperServer.superSecret
Key: ZOOKEEPER-3197
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3197
GitHub user coheigea opened a pull request:
https://github.com/apache/zookeeper/pull/716
Enable secure processing and disallow DTDs in the SAXParserFactory
It's good security practice to set the secure processing feature on
SAXParserFactory and to disallow Doctypes if they aren't
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235712847
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -121,6 +126,18 @@
*/
private
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235713462
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -108,7 +109,11 @@
LocalPeerBean
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
This PR now has the extraneous changes removed and is green in CI. Please
re-review at your convenience.
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/715
Rollup of blocker/critical fixes for 3.5 (to trigger CI)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper rollup-3.5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695827#comment-16695827
]
Michael K. Edwards commented on ZOOKEEPER-2916:
---
The root cause is hidden inside
I think it's mostly a problem in CI, where other processes on the same
machine may compete for the port range, producing spurious Jenkins
failures. The only failures I'm seeing locally are unrelated SSL
issues.
On Thu, Nov 22, 2018 at 3:45 AM Enrico Olivelli wrote:
>
> Il giorno gio 22 nov 2018
Il giorno gio 22 nov 2018 alle ore 12:44 Michael K. Edwards
ha scritto:
>
> I'm glad to be able to help.
>
> It appears as though some of the "flaky tests" result from another
> process stealing a server port between the time that it is assigned
> (in org.apache.zookeeper.PortAssignment.unique())
I'm glad to be able to help.
It appears as though some of the "flaky tests" result from another
process stealing a server port between the time that it is assigned
(in org.apache.zookeeper.PortAssignment.unique()) and the time that it
is bound. This happened, for example, in
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
After groveling through
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2708/consoleText,
I think this may be a contributing factor to flaky tests:
```
[exec]
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/707
Thanks maoling; I'm familiar with the procedure, just hadn't gotten around
to juggling branches.
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/707
@mkedwards
make sure the code in your origin branch-3.5 is what you want for
`ZOOKEEPER-2778 `
then `git push origin branch-3.5 -f` will be ok
---
Thank you very much Michael
I am following and reviewing your patches
Enrico
Il giorno gio 22 nov 2018 alle ore 10:14 Michael K. Edwards
ha scritto:
>
> Hmm. Jira's a bit of a boneyard, isn't it? And timeouts in flaky
> tests are a problem.
>
> I scrubbed through the open bugs and picked the
Hmm. Jira's a bit of a boneyard, isn't it? And timeouts in flaky
tests are a problem.
I scrubbed through the open bugs and picked the ones that looked to me
like they might deserve attention for 3.5.5 or soon thereafter.
They're all on my watchlist:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695632#comment-16695632
]
Daniel Peon commented on ZOOKEEPER-1814:
Hi Michael,
I'm afraid of that the patch is not
50 matches
Mail list logo
