Thank you very much Michael I am following and reviewing your patches
Enrico Il giorno gio 22 nov 2018 alle ore 10:14 Michael K. Edwards <m.k.edwa...@gmail.com> ha scritto: > > Hmm. Jira's a bit of a boneyard, isn't it? And timeouts in flaky > tests are a problem. > > I scrubbed through the open bugs and picked the ones that looked to me > like they might deserve attention for 3.5.5 or soon thereafter. > They're all on my watchlist: > https://issues.apache.org/jira/issues/?filter=-1&jql=watcher%20%3D%20mkedwards%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20created%20ASC > (I'm not counting the Ant->Maven transition in that, which I don't > know much about.) > > I'm trying out some more verbose logging for the junit tests, to try > to understand test flakiness. But the Jenkins pre-commit pipeline > appears to be down? > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/ > On Wed, Nov 21, 2018 at 2:29 PM Michael K. Edwards > <m.k.edwa...@gmail.com> wrote: > > > > Looks like we're really close. Can I help? > > > > I think this is the list of release blockers: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZooKeeper%20and%20resolution%20%3D%20Unresolved%20and%20fixVersion%20%3D%203.5.5%20AND%20priority%20in%20(blocker%2C%20critical)%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC > > > > I currently see 7 issues in that search, of which 4 are aspects of the > > ongoing switch from ant to maven. Setting that aside for the moment, > > there are 3 critical bugs: > > > > ZOOKEEPER-2778 Potential server deadlock between follower sync with > > leader and follower receiving external connection requests. > > > > ZOOKEEPER-1636 c-client crash when zoo_amulti failed > > > > ZOOKEEPER-1818 Fix don't care for trunk > > > > I put them in that order because that's the order in which I've > > stacked the fixes in > > https://github.com/mkedwards/zookeeper/tree/branch-3.5. Then on top > > of that, I've updated the versions of the external library > > dependencies I think it's important to update: Jetty, Jackson, and > > BouncyCastle. The result seems to be a green build in Jenkins: > > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2705/ > > > > Are these fixes in principle landable on the 3.5 branch, or do they > > have to go to master first? Does master need help to build green > > before these can land there? Are there other bugs that are similarly > > critical to fix, and not tagged for 3.5.5 in Jira? Is there other > > testing that I can help with? Are more hands needed on the Maven > > work? > > > > Thanks for all the work that goes into keeping Zookeeper healthy and > > advancing; it's a critical infrastructure component in several systems > > I help develop and operate, and I like being able to rely on it. > > > > Cheers, > > - Michael
