[GitHub] [zookeeper] eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911#discussion_r275141412 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911#discussion_r275141402 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911#discussion_r275141455 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911#discussion_r275141538 ## File path:

[jira] [Commented] (ZOOKEEPER-3365) Use Concurrent HashMap in NettyServerCnxnFactory

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817175#comment-16817175 ] David Mollitor commented on ZOOKEEPER-3365: --- I provided two different PRs with two

[GitHub] [zookeeper] BELUGABEHR commented on issue #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

BELUGABEHR commented on issue #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911#issuecomment-482916373 Related to PR #912 This is an automated message

[GitHub] [zookeeper] BELUGABEHR commented on issue #912: Zookeeper 3365 counter

BELUGABEHR commented on issue #912: Zookeeper 3365 counter URL: https://github.com/apache/zookeeper/pull/912#issuecomment-482916361 Related to PR #911 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] BELUGABEHR opened a new pull request #912: Zookeeper 3365 counter

BELUGABEHR opened a new pull request #912: Zookeeper 3365 counter URL: https://github.com/apache/zookeeper/pull/912 This PR includes improvements related with the Java 8 concurrent package to provide better locking control and less code.

[jira] [Updated] (ZOOKEEPER-3365) Use Concurrent HashMap in NettyServerCnxnFactory

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3365: -- Labels: pull-request-available (was: ) > Use Concurrent HashMap in

[GitHub] [zookeeper] BELUGABEHR opened a new pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory

BELUGABEHR opened a new pull request #911: ZOOKEEPER-3365: Use Concurrent HashMap in NettyServerCnxnFactory URL: https://github.com/apache/zookeeper/pull/911 This PR includes improvements related with the Java 8 concurrent package to provide better locking control and less code.

[jira] [Updated] (ZOOKEEPER-3365) Use Concurrent HashMap in NettyServerCnxnFactory

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated ZOOKEEPER-3365: -- Summary: Use Concurrent HashMap in NettyServerCnxnFactory (was: Use New

[jira] [Created] (ZOOKEEPER-3365) Use New Concurrent HashMap in NettyServerCnxnFactory

David Mollitor created ZOOKEEPER-3365: - Summary: Use New Concurrent HashMap in NettyServerCnxnFactory Key: ZOOKEEPER-3365 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3365 Project:

[GitHub] [zookeeper] eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

eolivelli commented on issue #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality URL: https://github.com/apache/zookeeper/pull/910#issuecomment-482889341 @anmolnar this is a trivial patch, but it is needed for dropping ANT precommit

[jira] [Updated] (ZOOKEEPER-3364) Compile with strict options in order to check code quality

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3364: -- Labels: pull-request-available (was: ) > Compile with strict options in order to

[GitHub] [zookeeper] eolivelli opened a new pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality

eolivelli opened a new pull request #910: ZOOKEEPER-3364 Compile with strict options in order to check code quality URL: https://github.com/apache/zookeeper/pull/910 - Add extra compiler arguments in order to achieve better code quality. - Fix some minor issues reported by javac -

[jira] [Created] (ZOOKEEPER-3364) Compile with strict options in order to check code quality

Enrico Olivelli created ZOOKEEPER-3364: -- Summary: Compile with strict options in order to check code quality Key: ZOOKEEPER-3364 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3364 Project:

ZooKeeper_branch35_jdk8 - Build # 1375 - Failure

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1375/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.31 KB...] [junit] Tests run: 1, Failures:

[GitHub] [zookeeper] anmolnar closed pull request #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha

anmolnar closed pull request #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/908 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] anmolnar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha

anmolnar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/908#issuecomment-482828993 Committed to 3.5 branch. Thanks @nkalmar !

[GitHub] [zookeeper] anmolnar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha

anmolnar commented on issue #908: ZOOKEEPER-3351 - 3.5 - Fix findBugs and rat check, add filename to sha URL: https://github.com/apache/zookeeper/pull/908#issuecomment-482826360 retest ant build This is an automated message

[GitHub] [zookeeper] BELUGABEHR commented on issue #876: ZOOKEEPER-3020: Review of SyncRequestProcessor

BELUGABEHR commented on issue #876: ZOOKEEPER-3020: Review of SyncRequestProcessor URL: https://github.com/apache/zookeeper/pull/876#issuecomment-482818309 @anmolnar Any additional ideas for improvements? This is an

[GitHub] [zookeeper] BELUGABEHR commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java

BELUGABEHR commented on issue #880: ZOOKEEPER-3340: Improve Queue Usage in QuorumCnxManager.java URL: https://github.com/apache/zookeeper/pull/880#issuecomment-482817330 @lvfangmin Thank you for the review. So, this proposed PR should not be viewed simply as 'ArrayBlockingQueue' v.s.

Build failed in Jenkins: ZooKeeper-trunk-owasp #331

See Changes: [andor] ZOOKEEPER-3324: Add read/write metrics for top level znodes [andor] ZOOKEEPER-3143: Pluggable metrics system for ZooKeeper - Data Collection [andor] ZOOKEEPER-3348: Make TxnLog and

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#discussion_r275110980 ## File path: .travis.yml ## @@ -8,7 +8,12 @@ cache: directories: - "$HOME/.m2" -script:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#discussion_r275110966 ## File path: zookeeper-client/zookeeper-client-c/pom.xml ## @@ -55,6 +55,8 @@

[GitHub] [zookeeper] eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on a change in pull request #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#discussion_r275110959 ## File path: zookeeper-assembly/src/main/assembly/source-package.xml ## @@ -112,6 +112,8 @@

[GitHub] [zookeeper] eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file

eolivelli commented on issue #909: ZOOKEEPER-3362 Create a simple checkstyle file URL: https://github.com/apache/zookeeper/pull/909#issuecomment-482791957 @nkalmar @anmolnar this is good to go now This is an automated

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816873#comment-16816873 ] Enrico Olivelli commented on ZOOKEEPER-3351: This is the issue about

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816871#comment-16816871 ] Enrico Olivelli commented on ZOOKEEPER-3351: [~Tison] I have created the umbrella issue,

[jira] [Created] (ZOOKEEPER-3363) Drop ant basedbuild umbrella issue

Enrico Olivelli created ZOOKEEPER-3363: -- Summary: Drop ant basedbuild umbrella issue Key: ZOOKEEPER-3363 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3363 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816853#comment-16816853 ] TisonKun commented on ZOOKEEPER-3351: - [~eolivelli] is there an umbrella issue about drop ANT? >

Re: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3

+1, no bindingLook at my previous jepsen, benchmark and zkCli test, 3.5.5 works well. - Original Message - From: Andor Molnar To: DevZooKeeper Subject: Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3 Date: 2019-04-12 19:58 Hi team, Just to wrap up the votes so far: We got +1 from

Re: ZK Smoke Screen Test

Good job,Thanks for this:https://github.com/BELUGABEHR/zk-smoketest#running-under-dockerYou can give a PR to phunt's repo,let more people benefit from it.Look at ZOOKEEPER-3264 which is aimed to implement a better benchmark tool for zookeeper internal.Stay tuned! :D - Original Message