Re: No tag for 3.6.0?

2020-04-28 Thread Christopher
FWIW, I did end up figuring this out eventually. According to the git docs, "By default, only tags on fetched branches are imported" Because of ZooKeeper's practice of cherry-picking and releasing from a local release branch, the tags are not tags of commits which exist in one of the fetched

Re: 3.5.8 release

2020-04-28 Thread Andor Molnar
Thanks Mate, I’ve just created PR for the backport. PTAL. Andor > On 2020. Apr 28., at 15:16, Enrico Olivelli wrote: > > Il Mar 28 Apr 2020, 14:38 Mate Szalay-Beko > ha scritto: > >> Hello Guys, >> >> I am collecting what we might miss for the 3.5.8 release. >> >> I want to finish a few

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Andor Molnar
https://github.com/apache/zookeeper/pull/1340 > On 2020. Apr 28., at 15:04, Andor Molnar wrote: > > I verified the patch, it works perfectly. > > Steps: > - build ZK from source with openjdk 13.0.2 > - run server with Oracle 1.8.0_201 > - connect zkcli with both java versions > - run some

Re: 3.5.8 release

2020-04-28 Thread Enrico Olivelli
Il Mar 28 Apr 2020, 14:38 Mate Szalay-Beko ha scritto: > Hello Guys, > > I am collecting what we might miss for the 3.5.8 release. > > I want to finish a few things in the following days: > - ZOOKEEPER-3727: Fix 3.5 source tarball to represent the git repository > - ZOOKEEPER-3810: a bugfix that

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Andor Molnar
I verified the patch, it works perfectly. Steps: - build ZK from source with openjdk 13.0.2 - run server with Oracle 1.8.0_201 - connect zkcli with both java versions - run some smoke tests It worked perfectly with master and failed with 3.5.7 with the “NoSuchMethodError” as mentioned in the

Re: 3.5.8 release

2020-04-28 Thread Mate Szalay-Beko
Hello Guys, I am collecting what we might miss for the 3.5.8 release. I want to finish a few things in the following days: - ZOOKEEPER-3727: Fix 3.5 source tarball to represent the git repository - ZOOKEEPER-3810: a bugfix that I want to backport from 3.6, PR ready - a few small document fixes

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Andor Molnar
Great. I’ll take care of that. > On 2020. Apr 28., at 13:08, Enrico Olivelli wrote: > > Il Mar 28 Apr 2020, 10:48 Andor Molnar ha scritto: > >> Really? >> That patch is a general solution and actually looks really promising to >> me. I’ll check. >> > > I forgot that in that patch option 2

[jira] [Created] (ZOOKEEPER-3811) cleaning up the code,A static field should be directly referred by its class name

2020-04-28 Thread xavierzw (Jira)
xavierzw created ZOOKEEPER-3811: --- Summary: cleaning up the code,A static field should be directly referred by its class name Key: ZOOKEEPER-3811 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3811

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Enrico Olivelli
Il Mar 28 Apr 2020, 10:48 Andor Molnar ha scritto: > Really? > That patch is a general solution and actually looks really promising to > me. I’ll check. > I forgot that in that patch option 2 is already implemented https://github.com/apache/zookeeper/pull/1269 We could port it to 3.6 branch and

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Andor Molnar
Really? That patch is a general solution and actually looks really promising to me. I’ll check. Thanks Chris. Andor > On 2020. Apr 28., at 9:34, Enrico Olivelli wrote: > > Il Mar 28 Apr 2020, 02:47 Christopher ha scritto: > >> Option 2 was implemented by me already as part of my pull

[jira] [Created] (ZOOKEEPER-3810) Backporting ZOOKEEPER-2307 to branch 3.5

2020-04-28 Thread Mate Szalay-Beko (Jira)
Mate Szalay-Beko created ZOOKEEPER-3810: --- Summary: Backporting ZOOKEEPER-2307 to branch 3.5 Key: ZOOKEEPER-3810 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3810 Project: ZooKeeper

Re: Handle Java 9/11 additions of covariant return types to java.nio.ByteBuffer methods

2020-04-28 Thread Enrico Olivelli
Il Mar 28 Apr 2020, 02:47 Christopher ha scritto: > Option 2 was implemented by me already as part of my pull request for > https://issues.apache.org/jira/browse/ZOOKEEPER-3739 > This change was applied to 3.6.1 and 3.7.0. > This is not the problem but the problem with ByteBuffer. Enrico >