[jira] [Commented] (ZOOKEEPER-2125) SSL on Netty client-server communication

2015-03-09 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353382#comment-14353382 ] Rakesh R commented on ZOOKEEPER-2125: - [~hdeng] btw I've noticed the

[jira] [Commented] (ZOOKEEPER-2125) SSL on Netty client-server communication

2015-03-09 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353361#comment-14353361 ] Rakesh R commented on ZOOKEEPER-2125: - +1 latest patch looks good to me >

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-09 Thread Rakesh R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31277/#review75737 --- Ship it! Ship It! - Rakesh R On March 7, 2015, 4:02 p.m

[jira] [Commented] (ZOOKEEPER-2134) AsyncHammerTest.testHammer fails intermittently

2015-03-09 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1435#comment-1435 ] Rakesh R commented on ZOOKEEPER-2134: - Thanks [~michim] for the patch and [~h

[jira] [Commented] (ZOOKEEPER-2134) AsyncHammerTest.testHammer fails intermittently

2015-03-09 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352825#comment-14352825 ] Rakesh R commented on ZOOKEEPER-2134: - Thanks [~michim] for the patch. In my

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-08 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352527#comment-14352527 ] Rakesh R commented on ZOOKEEPER-1907: - Thanks [~hdeng],[~rgs],[~michim] for

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-06 Thread Rakesh R
> On March 7, 2015, 5:24 a.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java, line > > 493 > > <https://reviews.apache.org/r/31277/diff/14/?file=888101#file888101line493> > > > > Can we extract this to a metho

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-06 Thread Rakesh R
/FinalRequestProcessor.java <https://reviews.apache.org/r/31277/#comment122819> Can we extract this to a method to avoid duplication - Rakesh R On March 7, 2015, 1:04 a.m., Hongchao Deng wrote: > > --- > This is an automatically generated e

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-06 Thread Rakesh R
> On March 6, 2015, 8:39 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/common/X509Error.java, line 21 > > <https://reviews.apache.org/r/31277/diff/11/?file=886450#file886450line21> > > > > I prefer to use X509Exception instead of X509E

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-06 Thread Rakesh R
tps://reviews.apache.org/r/31277/#comment122717> Netty usage is pluggable. SSL feature will be enabled when user user plugged-in zookeeper.serverCnxnFactory, zookeeper.clientCnxnSocket as Netty. isn't it? Its good to capture in the document, whats your opinion? - Rakesh R

Re: Review Request 31277: ZOOKEEPER-2125: SSL on Netty client-server communication

2015-03-06 Thread Rakesh R
lease add the same logic of #closeSession() in FinalRequestProcessor as well. Refer: FinalRequestProcessor#processRequest() if (request.type == OpCode.closeSession) { - Rakesh R On March 6, 2015, 12:17 a.m., Hongchao Deng wrote: > > -

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349942#comment-14349942 ] Rakesh R commented on ZOOKEEPER-1907: - [~michim] could you have a look at

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349938#comment-14349938 ] Rakesh R commented on ZOOKEEPER-1907: - Thanks a lot [~hdeng] for shaping

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-05 Thread Rakesh R
> On March 2, 2015, 5:35 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 688 > > <https://reviews.apache.org/r/20071/diff/7/?file=882155#file882155line688> > > > > Adding some comments here would be

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-05 Thread Rakesh R
- Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review74757 --- On March 5, 2015, 6:55 p.m., Rakesh R wrote

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349281#comment-14349281 ] Rakesh R commented on ZOOKEEPER-1907: - Attached new patch addressing the comm

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-03-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Attachment: ZOOKEEPER-1907.patch > Improve Thread handl

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-05 Thread Rakesh R
n just leave "if (firstProcessor == null) {" unchanged. This is > the original behavior. Modified as state!=State.RUNNING - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/200

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-05 Thread Rakesh R
l too. added comments - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review74761 --- On March 5

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-05 Thread Rakesh R
/CommitProcessorTest.java 1664445 ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1664445 ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1664445 Diff: https://reviews.apache.org/r/20071/diff/ Testing --- yet to be inlcuded Thanks, Rakesh R

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-02 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343427#comment-14343427 ] Rakesh R commented on ZOOKEEPER-1907: - I've updated the RB, could you ha

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-03-02 Thread Rakesh R
/CommitProcessorTest.java 1661461 ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1661461 ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1661461 Diff: https://reviews.apache.org/r/20071/diff/ Testing --- yet to be inlcuded Thanks, Rakesh R

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-03-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342334#comment-14342334 ] Rakesh R commented on ZOOKEEPER-1907: - It seems test case failure is unrelate

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-03-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342324#comment-14342324 ] Rakesh R commented on ZOOKEEPER-1952: - Committed to trunk :

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-26 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339747#comment-14339747 ] Rakesh R commented on ZOOKEEPER-1952: - Thanks [~haridsv], [~nijel] for

[jira] [Resolved] (ZOOKEEPER-2119) Netty client docs

2015-02-24 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R resolved ZOOKEEPER-2119. - Resolution: Fixed > Netty client docs > - > > Ke

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-24 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335152#comment-14335152 ] Rakesh R commented on ZOOKEEPER-2119: - Attached committed patch so that will

[jira] [Updated] (ZOOKEEPER-2119) Netty client docs

2015-02-24 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2119: Attachment: ZOOKEEPER-2119.patch > Netty client d

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-24 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335145#comment-14335145 ] Rakesh R commented on ZOOKEEPER-2119: - Thanks [~hdeng] for the patch and [

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-24 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334746#comment-14334746 ] Rakesh R commented on ZOOKEEPER-2119: - OK. I will commit this [ZK-2119 p

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332274#comment-14332274 ] Rakesh R commented on ZOOKEEPER-2119: - Thanks [~hdeng] for the patch. bq.

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332093#comment-14332093 ] Rakesh R commented on ZOOKEEPER-2119: - Hi [~fpj], [~hdeng], I was about to co

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-02-22 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Attachment: ZOOKEEPER-1907.patch > Improve Thread handl

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-19 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328567#comment-14328567 ] Rakesh R commented on ZOOKEEPER-1952: - +1 looks good to me. Test failures

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-02-19 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328534#comment-14328534 ] Rakesh R commented on ZOOKEEPER-1907: - [~hdeng] Thats really good catch.

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-19 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328518#comment-14328518 ] Rakesh R commented on ZOOKEEPER-1952: - bq.Could you give trigger another b

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-19 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328513#comment-14328513 ] Rakesh R commented on ZOOKEEPER-2119: - The patch has addressed [~fpj]'s

[jira] [Updated] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-19 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1952: Attachment: ZOOKEEPER-1952-5.patch > Default log directory and file name can be chan

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-02-18 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Attachment: ZOOKEEPER-1907.patch Attaching the latest patch to the jira (the same patch is

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-18 Thread Rakesh R
enerated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review73016 ------- On Feb. 19, 2015, 3:23 a.m., Rakesh R wrote: > > --- > This i

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-18 Thread Rakesh R
/CommitProcessorTest.java 1660779 ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1660779 ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1660779 Diff: https://reviews.apache.org/r/20071/diff/ Testing --- yet to be inlcuded Thanks, Rakesh R

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-18 Thread Rakesh R
required, removed. > On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 147 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845237#file845237line147> > > > > Why int

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-18 Thread Rakesh R
visit: https://reviews.apache.org/r/20071/#review70766 ------- On Feb. 19, 2015, 3:23 a.m., Rakesh R wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20071/ > ---

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

2015-02-17 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325425#comment-14325425 ] Rakesh R commented on ZOOKEEPER-2094: - Yesterday I have added few more re

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-17 Thread Rakesh R
he.org/r/20071/diff/4-5/?file=845243#file845243line190> > > > > Why interrupt? OK. I will remove it - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review71262

[jira] [Commented] (ZOOKEEPER-2119) Netty client docs

2015-02-17 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325413#comment-14325413 ] Rakesh R commented on ZOOKEEPER-2119: - +1 looks good to me. > Netty clie

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

2015-02-16 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323734#comment-14323734 ] Rakesh R commented on ZOOKEEPER-2094: - bq. Do you mean Netty client?

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

2015-02-16 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323678#comment-14323678 ] Rakesh R commented on ZOOKEEPER-2094: - Adding one more point to the above.

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

2015-02-16 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323672#comment-14323672 ] Rakesh R commented on ZOOKEEPER-2094: - Thanks [~iandi]. I have added few re

Re: Review Request 30753: ZOOKEEPER-2094: SSL feature on Netty

2015-02-16 Thread Rakesh R
mplementation it can return null. I suggest #createTrustManager can throw exception if not found any match instead of return null. whats your opinion? - Rakesh R On Feb. 7, 2015, 12:40 a.m., Hongchao Deng wrote: > > --- &

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-16 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322532#comment-14322532 ] Rakesh R commented on ZOOKEEPER-1952: - [PreCommit build-2519|h

[jira] [Updated] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-12 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1952: Attachment: ZOOKEEPER-1952-4.patch Reattaching the previous patch to get the QA report

[jira] [Updated] (ZOOKEEPER-1766) Consistent log severity level guards and statements

2015-02-12 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1766: Assignee: Jackie Chang > Consistent log severity level guards and stateme

[jira] [Commented] (ZOOKEEPER-2094) SSL feature on Netty

2015-02-10 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314615#comment-14314615 ] Rakesh R commented on ZOOKEEPER-2094: - Nice work [~iandi] and [~hdeng]. I

[jira] [Commented] (ZOOKEEPER-1952) Default log directory and file name can be changed

2015-02-10 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314604#comment-14314604 ] Rakesh R commented on ZOOKEEPER-1952: - Thanks [~haridsv] for fixing the re

[jira] [Commented] (ZOOKEEPER-1949) recipes jar not included in the distribution package

2015-02-10 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314557#comment-14314557 ] Rakesh R commented on ZOOKEEPER-1949: - [~michim] Could you please push thi

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-10 Thread Rakesh R
mind. If not, will continue this fashion. ok? - Rakesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review71269 -------

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-10 Thread Rakesh R
wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java, > > line 135 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845252#file845252line135> > > > > Same.. it's always false. sure, will change this log

ZooKeeper Trunk Solaris build is failing consistently

2015-02-09 Thread Rakesh R
Hi, CAUSE : https://builds.apache.org/job/ZooKeeper-trunk-solaris/936/ trunk] $ /export/home/hudson/hudson-slave/tools/hudson.tasks.Ant_AntInstallation/ant-1.8.2/bin/ant "-DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME} -Djava5.home=${JAVA5_HOME}" -DBUILD_TARGETS

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308687#comment-14308687 ] Rakesh R commented on ZOOKEEPER-1366: - Thank you [~hdeng], all others for qui

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-05 Thread Rakesh R
){ return; } super.shutdown(); // ... } - Rakesh R On Feb. 5, 2015, 6:32 p.m., Rakesh R wrote: > > --- > This is an automatically generated e-mail. To reply,

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307758#comment-14307758 ] Rakesh R commented on ZOOKEEPER-1366: - +1 latest patch looks good t

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-05 Thread Rakesh R
/test/org/apache/zookeeper/test/ClientBase.java 1657623 ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1657623 Diff: https://reviews.apache.org/r/20071/diff/ Testing --- yet to be inlcuded Thanks, Rakesh R

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-05 Thread Rakesh R
tps://reviews.apache.org/r/20071/#review70766 ------- On Feb. 3, 2015, 8:35 a.m., Rakesh R wrote: > > --- > This is an automatically generated e-mail.

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-02-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307691#comment-14307691 ] Rakesh R commented on ZOOKEEPER-1907: - Thanks [~hdeng]. Attached patch addres

[jira] [Updated] (ZOOKEEPER-2029) Leader.LearnerCnxAcceptor should rethrow exception after logging

2015-02-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2029: Assignee: Rakesh R > Leader.LearnerCnxAcceptor should rethrow exception after logg

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-02-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Attachment: ZOOKEEPER-1907.patch > Improve Thread handl

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-02-04 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306564#comment-14306564 ] Rakesh R commented on ZOOKEEPER-1907: - bq. Before calling zks#shutdown() wil

[jira] [Commented] (ZOOKEEPER-1983) Append to zookeeper.out (not overwrite) to support logrotation

2015-02-04 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305005#comment-14305005 ] Rakesh R commented on ZOOKEEPER-1983: - ok. I got your point. It looks simple,

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-02-04 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304984#comment-14304984 ] Rakesh R commented on ZOOKEEPER-1907: - Thanks [~hdeng] for the comments. b

RE: ZooKeeper-trunk-solaris - Build # 931 - Still Failing

2015-02-04 Thread Rakesh R
Hi, Jenkins failing always, complaining " Error: JAVA_HOME is not defined correctly." Could someone tell me the way to set this. Should raise any INFRA task to fix this? Thanks & Regards, Rakesh -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 04

Re: Review Request 30573: ZOOKEEPER-1366: Zookeeper should be tolerant of clock adjustments

2015-02-04 Thread Rakesh R
pwriter.print(new Date(time)); 2) ServerBean#getLastResponseTime() new Date(stats.getLastResponseTime()).toString(); src/java/test/org/apache/zookeeper/common/TimeTest.java <https://reviews.apache.org/r/30573/#comment116400> I didn't understand this test case. For

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-02-03 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Attachment: ZOOKEEPER-1907.patch Attaching latest patch(same is uploaded to review board

[jira] [Updated] (ZOOKEEPER-1907) Improve Thread handling

2015-02-03 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1907: Fix Version/s: 3.6.0 > Improve Thread handl

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-03 Thread Rakesh R
in listener between run() and shutdown()? Maybe some > > comments? > > Rakesh R wrote: > yes. I missed that part. How about making listener as 'volatile' ? > > Hongchao Deng wrote: > It's a problem called time-to-check-time-to-use. > > Rakesh R

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-02-03 Thread Rakesh R
/test/org/apache/zookeeper/test/ClientBase.java 1656643 ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 1656643 Diff: https://reviews.apache.org/r/20071/diff/ Testing --- yet to be inlcuded Thanks, Rakesh R

[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for "./zkCli.sh cmd arg"

2015-02-02 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302780#comment-14302780 ] Rakesh R commented on ZOOKEEPER-2074: - +1 lgtm > Incorrect exit co

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-02 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302775#comment-14302775 ] Rakesh R commented on ZOOKEEPER-1366: - +1 pushing to 3.5 branch. I'm

[jira] [Commented] (ZOOKEEPER-2074) Incorrect exit codes for "./zkCli.sh cmd arg"

2015-02-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300914#comment-14300914 ] Rakesh R commented on ZOOKEEPER-2074: - Thanks [~surendrasingh] for the patch.

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300877#comment-14300877 ] Rakesh R commented on ZOOKEEPER-1366: - Thanks again [~tdunning] for the reply

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300879#comment-14300879 ] Rakesh R commented on ZOOKEEPER-1366: - Thanks again [~tdunning] for the reply

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-02-01 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300878#comment-14300878 ] Rakesh R commented on ZOOKEEPER-1366: - Thanks again [~tdunning] for the reply

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2015-01-30 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299708#comment-14299708 ] Rakesh R commented on ZOOKEEPER-1366: - Thanks [~tdunning] for the patch, have

[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-30 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299707#comment-14299707 ] Rakesh R commented on ZOOKEEPER-2111: - Committed to trunk : http://svn.apache

[jira] [Updated] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-30 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2111: Attachment: ZOOKEEPER-2111.patch > Not isAlive states should be synchronized in ClientC

[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-30 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299667#comment-14299667 ] Rakesh R commented on ZOOKEEPER-2111: - Thank you [~hdeng] for the patch.

[jira] [Updated] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-30 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2111: Fix Version/s: 3.6.0 3.5.1 > Not isAlive states should be synchronized

[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-29 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298129#comment-14298129 ] Rakesh R commented on ZOOKEEPER-2111: - +1 lgtm > Not isAlive states sh

[jira] [Updated] (ZOOKEEPER-2110) Typo fixes in the ZK documentation

2015-01-29 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2110: Fix Version/s: (was: 4.0.0) 3.6.0 > Typo fixes in the ZK documentat

[jira] [Updated] (ZOOKEEPER-2072) Netty Server Should Configure Child Channel Pipeline By Specifying ChannelPipelineFactory

2015-01-29 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2072: Fix Version/s: (was: 4.0.0) 3.6.0 > Netty Server Should Configure Ch

[jira] [Commented] (ZOOKEEPER-2072) Netty Server Should Configure Child Channel Pipeline By Specifying ChannelPipelineFactory

2015-01-29 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298112#comment-14298112 ] Rakesh R commented on ZOOKEEPER-2072: - Thanks [~hdeng] for the fix Committe

[jira] [Commented] (ZOOKEEPER-2072) Netty Server Should Configure Child Channel Pipeline By Specifying ChannelPipelineFactory

2015-01-29 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296549#comment-14296549 ] Rakesh R commented on ZOOKEEPER-2072: - {

[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294773#comment-14294773 ] Rakesh R commented on ZOOKEEPER-2111: - Before ZOOKEEPER-2069, it

[jira] [Commented] (ZOOKEEPER-2111) Not isAlive states should be synchronized in ClientCnxn

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294749#comment-14294749 ] Rakesh R commented on ZOOKEEPER-2111: - Thanks [~hdeng] for reporting thi

[jira] [Updated] (ZOOKEEPER-2110) Typo fixes in the ZK documentation

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2110: Attachment: ZOOKEEPER-2110_br3_5.patch > Typo fixes in the ZK documentat

[jira] [Commented] (ZOOKEEPER-2110) Typo fixes in the ZK documentation

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293780#comment-14293780 ] Rakesh R commented on ZOOKEEPER-2110: - Thanks Jeffrey for the patch. Will as

[jira] [Updated] (ZOOKEEPER-2110) Typo fixes in the ZK documentation

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2110: Summary: Typo fixes in the ZK documentation (was: Tyop fixes in the ZK documentation) > T

[jira] [Commented] (ZOOKEEPER-2037) ZooKeeper methods to wait on client connection (re)establishment.

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293364#comment-14293364 ] Rakesh R commented on ZOOKEEPER-2037: - [~hdeng] anything specific to be don

Re: Review Request 25968: ZOOKEEPER-2019

2015-01-27 Thread Rakesh R
test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java <https://reviews.apache.org/r/25968/#comment114587> please remove 'limits' variable, its unused - Rakesh R On Sept. 24, 2014, 4:22 a.m., Hongchao Deng wrote: > > ---

[jira] [Updated] (ZOOKEEPER-2072) Netty Server Should Configure Child Channel Pipeline By Specifying ChannelPipelineFactory

2015-01-27 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-2072: Fix Version/s: 3.5.1 > Netty Server Should Configure Child Channel Pipeline By Specify

<    5   6   7   8   9   10   11   12   13   14   >