[
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323672#comment-14323672
]
Rakesh R commented on ZOOKEEPER-2094:
-------------------------------------
Thanks [~iandi]. I have added few review comments in [Review
Board|https://reviews.apache.org/r/30753/diff/#], please have a look.
I have one general suggestion, the patch looks very big. I understand this is
required to test the complete feature, but there could be chances of missing
the focus of the reviewer. Can we think of splitting into smaller sub-tasks.
This would be helpful to the reviewers and push one by one. What others opinion?
Subtasks would be like,
# Document SSL feature on Netty
# Provide implementation of X509 AuthenticationProvider
# Modify ZooKeeper NettyServer to support SSL
# Modify ZooKeeper client cnxn to support SSL
# Modify ZooKeeperServerMain to support SSL
# Modify FourLetterWord to support SSL
Also, feel free to modify the subject line if requires.
> SSL feature on Netty
> --------------------
>
> Key: ZOOKEEPER-2094
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: server
> Affects Versions: 3.4.6, 3.5.0
> Reporter: Ian Dimayuga
> Assignee: Ian Dimayuga
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2094-git-apply.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch,
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks,
> testTrustStore.jks, testUntrustedKeyStore.jks
>
>
> Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider
> to perform authentication.
> Review board:
> https://reviews.apache.org/r/30753/diff/#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
