Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/123#discussion_r92309054
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/123#discussion_r92309025
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92274850
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296453
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297258
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296064
--- Diff:
src/java/test/org/apache/zookeeper/server/MockNettyServerCnxn.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92283709
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92266304
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297567
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297538
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296352
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92282690
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297351
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92297692
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92269582
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92274772
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92264074
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92269683
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92271380
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92298117
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -694,7 +690,7 @@ public void sendResponse(ReplyHeader h, Record r,
String
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92266393
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92268597
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/99#discussion_r92296029
--- Diff:
src/java/test/org/apache/zookeeper/server/ServerCxnExceptionsTest.java ---
@@ -0,0 +1,170 @@
+/**
+ * Licensed to the Apache Software
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/99
I like this patch, but I think the whole reflection/mock thing is kind of
reinventing a fault injection inside the test classes. If so, why not use a
production ready framework as Byteman? I
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/123
Add orthogonal fault injection mechanism/framework
Add Byteman (http://byteman.jboss.org/) as a dependency to ZooKeeper
project to enable the dynamic injection of failures.
You can merge this
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/122#discussion_r92209798
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -39,32 +39,10 @@
import org.apache.zookeeper.client.ZKClientConfig;
import
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r89287398
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -144,4 +144,10 @@
+
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/73
In my team's projects at GH I am able to close/reopen the PRs too (i.e.,
not only the PR creators). I guess you have to contact INFRA or Patrick to give
committers the auth to do this
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
**Very cool!** :smiley: Excuse me, totally forgot that Curator has been
using Github + Apache integration well before. Please, if you have some spare
cycles, it would be really cool if you could
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/73
@fpj Hey, Flavio, This looks like a non valid PR. Should we close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
@Randgalt Oh, we are putting the finishing touches in the
JIRA-Github-Apache integration & workflow, so any of the scripts that hold
things together missed this one. We are still debugging
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87466839
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary
getWatchesSummary
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/82
@skamille @Randgalt Wasn't this issue resolved? We can close this PR it by
now, right? :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/103
MINOR: add option to inform JIRA_PASSWORD at CLI prompt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper zk-merge-branch
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/87
Hi @fpj, could we have this PR merged? :)
Thanks!
PS: It is target at branch-3.4, but would be cool if we could also apply it
to branch-3.5 and master.
---
If your project is
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/84#discussion_r87057041
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/84#discussion_r87052291
--- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java ---
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87027302
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87028116
--- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java ---
@@ -1293,13 +1293,12 @@ public synchronized WatchesSummary
getWatchesSummary
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87038798
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -141,109 +141,128 @@ public String genCsharpWriteWrapper(String fname,
String tag
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87027160
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
---
@@ -344,9 +345,10 @@ public boolean containsQuorum(Set
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r87026194
--- Diff: src/java/main/org/apache/zookeeper/version/util/VerGen.java ---
@@ -50,10 +50,8 @@ public static void generateFile(File outputDir, Version
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/98#discussion_r86502042
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/98#discussion_r86415195
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/85
ZOOKEEPER-2597: Add script to merge PR from Apache git repo to Github
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/77
ZOOKEEPER-2280: NettyServerCnxnFactory doesn't honor maxClientCnxns pâ¦
â¦aram
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eri
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/46
ZOOKEEPER-2280: NettyServerCnxnFactory doesn't honor maxClientCnxns pâ¦
â¦aram
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eri
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/45
ZOOKEEPER-2238 Support limiting the maximum number of connections/cliâ¦
ents to a zookeeper server.
You can merge this pull request into a Git repository by running:
$ git pull https
301 - 350 of 350 matches
Mail list logo
