Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/528
I'd like to see this brought back. Not cool to drop autoconf when the
CMake setup can't build shared libraries. From
`zookeeper-client/zookeeper-client-c/README`:
```
Current
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
Btw. I think it's perfectly fine to choose option 2.
I was able to build ZooKeeper C client and run the tests on Ubuntu 18.04
with CMake.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
@phunt I ran a few cycles with the curl commit that you linked and here're
my results:
- there's no such thing with autotools that "check for a macro existence
and use it if present",
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
I had no luck with verifying a specific macro existence for some reason.
I'm not sure if there's a way at all. Maybe I should check how other projects
are dealing with similar problems.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
Hm. iiuc the m4 checks are during configure script creation itself, so
perhaps that's not the best idea either. :-(
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
Perhaps we could do this? -- check if the cppunit macro is defined, if not
then check for pkg-config, if not then error out (or whatever we do today). otw
use the first macro/approach available.
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
Hm. It's not very clear that
> ./configure: line 5034: PKG_PROG_PKG_CONFIG: command not found
means that pkg-config needs to be installed. Esp given we've never needed
it - it's a
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
@phunt have you installed `pkg-config`?
Because your Ubuntu image doesn't include it.
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
I'm afraid it still doesn't work for me. This is ubuntu 14.04 - the docker
image I pointed to previously.
# ./configure
checking for doxygen... no
checking for perl...
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
@phunt I ended up defining a custom macro to support static linking. Now
the script works with older versions of `pkg-config` too.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
Yeah, I see what the problem is: `pkg-config` package has to be installed,
but there's another problem with the version that is shipped with 14.04: it
doesn't have `PKG_CHECK_MODULES_STATIC`
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
ps. you can try using my repos, makes it easy to try out various envs:
https://hub.docker.com/r/phunt/
See the readme on how to run - I typically map my zk source directory into
the
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/528
Seems like it breaks ubuntu 14.04 (not sure what else, that's what I
tried). This is working fine w/o the patch:
./configure
checking for doxygen... no
checking for perl...
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
@phunt @afine @hanm You guys might want to take a quick look at this in
@rgs1 absence. It's kind of an infrastructural change only and would be useful
in the long term.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
Using pkg-config in the latest patch.
I also removed unused method `print_completion_queue()`, because it doesn't
compile under Ubuntu 18.04
@rgs1 Would you care to take a look?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/528
Raised the question on libreoffice mailing list and from libcppunit-1.14.0
the recommended way to configure build flags is using `pkg-config`.
I'm working on a patch to address this and will
16 matches
Mail list logo
