[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r140815418 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,50 +40,110 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user skamille commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r136637514 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,50 +40,110 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132592200 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132588619 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132579217 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132576447 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034244 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034154 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034008 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132027605 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132006551 --- Diff: src/java/test/org/apache/zookeeper/test/PersistentWatcherTest.java --- @@ -0,0 +1,228 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r131271126 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21; +

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132023758 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132025725 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132024228 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter, boolean

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132010827 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r94030738 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -729,7 +729,7 @@ Persistent recursive watches are set

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93960121 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93960053 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93893162 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93889832 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,43 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93889759 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887170 --- Diff: src/java/test/org/apache/zookeeper/test/PersistentWatcherTest.java --- @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887652 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887190 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,43 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887080 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887048 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886810 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,19 @@ synchronized void dumpWatches(PrintWriter pwriter,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886806 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886802 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886789 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886801 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886805 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -522,6 +566,15 @@ protected boolean removeWatches(Map pathVsWatcher,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886777 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886566 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886519 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886440 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886426 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93885429 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93885330 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883095 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883225 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,19 @@ synchronized void dumpWatches(PrintWriter pwriter,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883345 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883250 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883319 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883200 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883280 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883126 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -522,6 +566,15 @@ protected boolean removeWatches(Map pathVsWatcher,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93883352 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/136 [ZOOKEEPER-1416] Persistent Recursive Watch Here is a completed implementation for a persistent, recursive watch addition for ZK. These watches are set via a new method, `addPersistentWatch()`