[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160245528 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent()

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160243418 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent()

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160244385 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent()

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160244035 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent()

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160243609 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -307,4 +315,104 @@ public void testReloadSnapshotWithMissingParent()

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2018-01-08 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/439#discussion_r160244289 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -38,10 +40,16 @@ import org.slf4j.LoggerFactory; import

[GitHub] zookeeper pull request #439: ZOOKEEPER-1621: Delete and skip txn log with in...

2017-12-29 Thread abhishekrai
GitHub user abhishekrai opened a pull request: https://github.com/apache/zookeeper/pull/439 ZOOKEEPER-1621: Delete and skip txn log with incomplete header Based on the patch by Michi Mutsuzaki. When Zookeeper server encounters a txn log with incomplete header, the old