Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/548
---
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r203817750
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -61,10 +61,16 @@ static public String getClientConfigStr(String
con
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r203816489
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -857,15 +869,15 @@ public void run() {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201923508
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -61,10 +61,16 @@ static public String getClientConfigStr(String
configDa
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201901490
--- Diff:
src/java/test/org/apache/zookeeper/server/util/ConfigUtilsTest.java ---
@@ -29,4 +30,21 @@ public void testSplitServerConfig() throws
ConfigExc
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201923793
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -226,17 +230,25 @@ static public InitialMessage parse(Long
protoc
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201926608
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -857,15 +869,15 @@ public void run() {
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r200064561
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -60,4 +60,25 @@ static public String getClientConfigStr(String
configDat
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198228442
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198228805
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -225,17 +229,25 @@ static public InitialMessage parse(Long
prot
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198229351
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
---
@@ -58,10 +58,10 @@ public void tearDown() throws Exceptio
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r198227173
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197976612
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org
Github user mjeelanimsft commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197950541
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff --
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197933819
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff --
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197781125
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org.apa
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197780621
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org.apa
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197779656
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197633793
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int
p
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197633896
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff --
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r197633888
--- Diff: src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
---
@@ -60,4 +60,25 @@ static public String getClientConfigStr(String
configDat
GitHub user mjeelanimsft opened a pull request:
https://github.com/apache/zookeeper/pull/548
[ZOOKEEPER-3057] Fix IPv6 literal usage
This patch contains fixes for IPv6 literal usage and corresponding unit
test changes.
As per discussion in ZOOKEEPER-3057 - The issue/proble
22 matches
Mail list logo
