[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/628 ---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-06 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r239578960 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,514 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
Github user enixon closed the pull request at: https://github.com/apache/zookeeper/pull/628 ---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
GitHub user enixon reopened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
Github user enixon closed the pull request at: https://github.com/apache/zookeeper/pull/628 ---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
GitHub user enixon reopened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231364697 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml --- @@ -111,7 +111,41 @@ the ZooKeeper service.

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231364616 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,514 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r231359694 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,18 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r230965607 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml --- @@ -111,7 +111,41 @@ the ZooKeeper service.

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r230965386 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,514 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r230964928 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,18 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-10-09 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r223889253 --- Diff: src/java/test/org/apache/zookeeper/server/util/PortForwarder.java --- @@ -29,62 +26,15 @@ import java.net.Socket; import

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-10-09 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r223888479 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221416362 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java --- @@ -196,6 +224,10 @@ protected long getLastQueued() { return

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221338505 --- Diff: docs/zookeeperAdmin.html --- @@ -1126,6 +1126,14 @@ Minimum Configuration zookeeper.serverCnxnFactory,

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221393478 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -764,6 +764,16 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221415847 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221416332 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -232,8 +236,8 @@ protected void sockConnect(Socket sock, InetSocketAddress

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221415836 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -84,8 +84,12 @@ public Socket getSocket() { protected

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-28 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r221389580 --- Diff: src/java/test/org/apache/zookeeper/server/util/PortForwarder.java --- @@ -29,62 +26,15 @@ import java.net.Socket; import

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-26 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r220768593 --- Diff: src/java/test/org/apache/zookeeper/test/ObserverMasterTest.java --- @@ -0,0 +1,764 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-26 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r220765363 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java --- @@ -196,6 +224,10 @@ protected long getLastQueued() { return

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219023394 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1170,6 +1194,16 @@ synchronized public long

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219581743 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,513 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219585427 --- Diff: src/java/test/org/apache/zookeeper/test/ObserverMasterTest.java --- @@ -0,0 +1,764 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219583415 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -1920,7 +1937,75 @@ private void updateRemotePeerMXBeans(Map

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219582907 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/ObserverMaster.java --- @@ -0,0 +1,513 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219312586 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java --- @@ -113,13 +116,17 @@ public void commit(long zxid) {

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219583775 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/DelayRequestProcessor.java --- @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219023427 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1170,6 +1194,16 @@ synchronized public long

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219312930 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -1465,4 +1508,107 @@ private boolean isRunning() { private

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-21 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219313594 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java --- @@ -246,12 +250,12 @@ protected void connectToLeader(InetSocketAddress

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-19 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219036460 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java --- @@ -196,6 +224,10 @@ protected long getLastQueued() { return

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-19 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r219034842 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/DelayRequestProcessor.java --- @@ -0,0 +1,77 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-15 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/628#discussion_r217894081 --- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java --- @@ -75,4 +76,29 @@ public void failed(Throwable e, FrameworkMethod method) {

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-14 Thread enixon
GitHub user enixon opened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements