[CANCELLED] Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-04 Thread Enrico Olivelli
I am cancelling this vote. Stay tuned for rc2 Enrico Il Lun 3 Feb 2020, 23:38 Patrick Hunt ha scritto: > On Mon, Feb 3, 2020 at 2:27 PM Enrico Olivelli > wrote: > > > Il Lun 3 Feb 2020, 21:22 Patrick Hunt ha scritto: > > > > > Enrico, while what you are saying is true, and sounds reasonable

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Patrick Hunt
On Mon, Feb 3, 2020 at 2:27 PM Enrico Olivelli wrote: > Il Lun 3 Feb 2020, 21:22 Patrick Hunt ha scritto: > > > Enrico, while what you are saying is true, and sounds reasonable wrt this > > release, keep in mind that often for our users ZK is not an end in and of > > itself - it's combined with

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Jordan Zimmerman
> We can include Jordan's patch and Mate's fix for tests as well. Woot! > On Feb 3, 2020, at 5:26 PM, Enrico Olivelli wrote: > > Il Lun 3 Feb 2020, 21:22 Patrick Hunt ha scritto: > >> Enrico, while what you are saying is true, and sounds reasonable wrt this >> release, keep in mind that

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Enrico Olivelli
Il Lun 3 Feb 2020, 21:22 Patrick Hunt ha scritto: > Enrico, while what you are saying is true, and sounds reasonable wrt this > release, keep in mind that often for our users ZK is not an end in and of > itself - it's combined with other capabilities/components. As such those > components may

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Patrick Hunt
Enrico, while what you are saying is true, and sounds reasonable wrt this release, keep in mind that often for our users ZK is not an end in and of itself - it's combined with other capabilities/components. As such those components may use related functionality which is impacted - providing

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Enrico Olivelli
Patrick We are not affected by that issue https://nvd.nist.gov/vuln/detail/CVE-2019-20445 It is about HTTP. As Netty is a core dependency and in my experience sometimes it introduces regressions I feel it is safer to not upgrade for 3.6.0. We can upgrade it on master branch. Enrico Il Lun 3 Feb

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Patrick Hunt
FYI owasp jenkins job is failing due to netty CVE: https://issues.apache.org/jira/browse/ZOOKEEPER-3716 Patrick On Mon, Feb 3, 2020 at 8:12 AM Enrico Olivelli wrote: > Il Lun 3 Feb 2020, 16:23 Norbert Kalmar ha > scritto: > > > Máté's patch fixed it for me. I don't know if this is a blocker

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Enrico Olivelli
Il Lun 3 Feb 2020, 16:23 Norbert Kalmar ha scritto: > Máté's patch fixed it for me. I don't know if this is a blocker for 3.6.0 > rc1 I don't think it is a blocker. It is not a regression Enrico , but since 3.5.7 is not even branched yet, I'll wait for this patch to > make it there. > >

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Norbert Kalmar
Máté's patch fixed it for me. I don't know if this is a blocker for 3.6.0 rc1, but since 3.5.7 is not even branched yet, I'll wait for this patch to make it there. Thanks Máté, good catch! Regards, Norbert On Mon, Feb 3, 2020 at 2:02 PM Szalay-Bekő Máté wrote: > I created

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Szalay-Bekő Máté
I created https://issues.apache.org/jira/browse/ZOOKEEPER-3715 and started to work on it On Mon, Feb 3, 2020 at 1:12 PM Szalay-Bekő Máté wrote: > (FYI: I tried a few more versions, the problem seems to appear between > OpenJDK 8.232 and 8.242. And there are a lot of kerberos related changes >

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Szalay-Bekő Máté
(FYI: I tried a few more versions, the problem seems to appear between OpenJDK 8.232 and 8.242. And there are a lot of kerberos related changes after 8.232: see https://hg.openjdk.java.net/jdk8u/jdk8u/jdk ) On Mon, Feb 3, 2020 at 12:54 PM Norbert Kalmar wrote: > I tested with zulu 1.8.212 on

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Norbert Kalmar
I tested with zulu 1.8.212 on the linux machine, and with zulu 1.8.0_163 on MacOS (whoops). I use sdkman on both machine. I upgraded to the newest 1.8 which is _242, at least with sdkman. And sadly, the mentioned tests also fail for me after the upgrade. So, something in the tests that the new

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Szalay-Bekő Máté
- I compiled and run all the unit tests using Ubuntu 18.04 (incl. the C client), using OpenJDK 1.8.212 - I also built and unit tested the python client - I did some manual tests for the multi-address feature with multiple virtual networks (using https://github.com/symat/zookeeper-docker-test)

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-03 Thread Norbert Kalmar
+1 (non-binding) - unit tests pass - built and started ZK + run few commands from source tarball - checked bin tarball, license files, run ZK + few commands - signature OK. Tested on MacOS with openJDK 1.8, no problems I also run the tests on a Linux machine, found the problem why SSL tests

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-02 Thread Jordan Zimmerman
No big issues with Curator that I could find +1 (non binding) -Jordan > On Feb 1, 2020, at 10:02 AM, Enrico Olivelli wrote: > > This is the second release candidate for Apache ZooKeeper 3.6.0. > > It is a major release and it introduces a lot of new features, most notably: > - Built-in data

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-02 Thread Patrick Hunt
+1 xsums/sig verified, rat ran clean, I ran various release tests and they are passing for me. Patrick On Sat, Feb 1, 2020 at 7:30 AM Jordan Zimmerman wrote: > Maybe we can get 3.6.1 quickly after then? > > > On Feb 1, 2020, at 10:02 AM, Enrico Olivelli > wrote: > > > > This is the second

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-01 Thread Jordan Zimmerman
Maybe we can get 3.6.1 quickly after then? > On Feb 1, 2020, at 10:02 AM, Enrico Olivelli wrote: > > This is the second release candidate for Apache ZooKeeper 3.6.0. > > It is a major release and it introduces a lot of new features, most notably: > - Built-in data consistency check inside

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-01 Thread Enrico Olivelli
Jordan, I am sorry, I have approved that change but we need another binding +1. For who doesn't know that patch is about releasing to Maven central a 'tests jar' in order to ease tests of downstream applications. I am sorry but this weekend I had time to package this new rc and I wanted to move

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-01 Thread Jordan Zimmerman
Any chance of getting https://github.com/apache/zookeeper/pull/1229 into 3.6.0? -JZ > On Feb 1, 2020, at 10:02 AM, Enrico Olivelli wrote: > > This is the second release candidate for Apache ZooKeeper 3.6.0. > > It is a major release and it

[VOTE] Apache ZooKeeper release 3.6.0 candidate 1

2020-02-01 Thread Enrico Olivelli
This is the second release candidate for Apache ZooKeeper 3.6.0. It is a major release and it introduces a lot of new features, most notably: - Built-in data consistency check inside ZooKeeper - Allow Followers to host Observers - Authentication enforcement - Pluggable metrics system for