Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

Thank you guys I have found another problem about fatjar. There is a problem with apache rat check This is the patch. We are excluding one file from fatjar at the root pom, but it looks like maven is going to execute rat even in fatjar module and this makes the build fail. I should also note that

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

sg. Merged onto both. Thanks all! Patrick On Sat, Apr 18, 2020 at 10:08 AM Enrico Olivelli wrote: > Patrick, > Yes only to be merged to branch3.6 and release-3.6.1 > > Thanks > Enrico > > Il Sab 18 Apr 2020, 18:25 Christopher ha scritto: > > > 3.6.1 and the 3.6 branch. PR #1314 has been

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

Patrick, Yes only to be merged to branch3.6 and release-3.6.1 Thanks Enrico Il Sab 18 Apr 2020, 18:25 Christopher ha scritto: > 3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same > issues and more for master/3.7 > > On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote: > > > I

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same issues and more for master/3.7 On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote: > I can take a look. Does this need to go into just 3.6.1 or other branches > as well? The JIRA says just 3.6.1,is that right? > > Patrick > >

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

I can take a look. Does this need to go into just 3.6.1 or other branches as well? The JIRA says just 3.6.1,is that right? Patrick On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli wrote: > PR is finally ready > https://github.com/apache/zookeeper/pull/1323 > > Looking for some committer to help

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

PR is finally ready https://github.com/apache/zookeeper/pull/1323 Looking for some committer to help me merge that patch Enrico Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Thank you Christopher > > We are iterating over #1323. > I think we can

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

Thank you Christopher We are iterating over #1323. I think we can finish the work today Enrico Il giorno sab 18 apr 2020 alle ore 09:39 Christopher ha scritto: > +1 to that approach. I reviewed and made a suggestion on the PR at > https://github.com/apache/zookeeper/pull/1323 > > On Sat, Apr

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

+1 to that approach. I reviewed and made a suggestion on the PR at https://github.com/apache/zookeeper/pull/1323 On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli wrote: > > This is my patch. > Basically it adds back the fatjar module to the full-build profile > this way we have only one profile

Re: Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

This is my patch. Basically it adds back the fatjar module to the full-build profile this way we have only one profile that actually does the "full build" = all maven modules I feel this is a very clear way for users, mvn clean package -Pfull-build this builds the whole repository Enrico Il

Branch-36 is broken - fatjar - WAS Re: [VOTE] Apache ZooKeeper release 3.6.1 candidate 0

Hi, Branch-3.6 is broken due to the fatjat stuff [eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar [INFO] Scanning for projects... [ERROR] [ERROR] Project 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is duplicated in the reactor @ [ERROR] Project