Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-11-06 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Nov. 6, 2016, 7:02 a.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-11-04 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Nov. 4, 2016, 4:48 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-11-04 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Nov. 4, 2016, 4:32 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-11-03 Thread Michael Han
> On Sept. 27, 2016, 6:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/KeeperException.java, line 317 > > > > > > Do we need @Deprecated constant value? Since we are in 3.5 branch, I > > feel its

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-31 Thread Rakesh R
> On Oct. 13, 2016, 9:57 p.m., Abraham Fine wrote: > > src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml, line 1134 > > > > > > is there a way for us to sanity check this (make sure that their > >

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-31 Thread Rakesh R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review154255 --- Ship it! Ship It! - Rakesh R On Oct. 31, 2016, 4:31 a.m.,

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-31 Thread Rakesh R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review154254 --- src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-30 Thread Rakesh R
> On Sept. 27, 2016, 6:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/KeeperException.java, line 317 > > > > > > Do we need @Deprecated constant value? Since we are in 3.5 branch, I > > feel its

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-30 Thread Rakesh R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review154230 --- src/java/main/org/apache/zookeeper/ZooKeeper.java (line 224)

RE: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-17 Thread Kanniappan, Mohanarangan (Nokia - IN/Bangalore)
Anyone can guide me to unsubscribe ? -Original Message- From: Michael Han [mailto:nore...@reviews.apache.org] On Behalf Of Michael Han Sent: Tuesday, October 18, 2016 10:46 AM To: Raul Gutierrez Segales ; Patrick Hunt ; f...@apache.org; Alexander

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-17 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Oct. 18, 2016, 5:15 a.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-13 Thread Michael Han
> On Oct. 13, 2016, 9:57 p.m., Abraham Fine wrote: > > Thanks for the review Abe. I'll post updated patch after consolidating feedback from Flavio regarding my last patch update. > On Oct. 13, 2016, 9:57 p.m., Abraham Fine wrote: > > src/java/main/org/apache/zookeeper/server/DataTree.java,

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-13 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review152577 --- src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-11 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Oct. 11, 2016, 10:33 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-11 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review152214 --- src/java/main/org/apache/zookeeper/ZooKeeper.java (line 224)

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-11 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Oct. 11, 2016, 9:32 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-10 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Oct. 10, 2016, 9:41 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-03 Thread Michael Han
> On Oct. 2, 2016, 2:57 p.m., fpj wrote: > > It is taking shape, thanks for the updates, Michael. I've left some more > > comments when you have a minute. Thanks a lot for your timely review feedback, Flavio. I've attached updated patch in both JIRA and review board. More comments below. >

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-03 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Oct. 3, 2016, 11:52 p.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-10-02 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review151129 --- It is taking shape, thanks for the updates, Michael. I've left

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-28 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Sept. 29, 2016, 1:41 a.m.) Review request for zookeeper, fpj, Patrick

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-28 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Sept. 28, 2016, 11:39 p.m.) Review request for zookeeper, fpj,

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-27 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Sept. 27, 2016, 10:39 p.m.) Review request for zookeeper, fpj,

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-27 Thread Michael Han
> On Sept. 27, 2016, 6:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/KeeperException.java, line 317 > > > > > > Do we need @Deprecated constant value? Since we are in 3.5 branch, I > > feel its

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-27 Thread Rakesh R
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review150538 --- src/java/main/org/apache/zookeeper/KeeperException.java (line

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-26 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Sept. 26, 2016, 10:48 p.m.) Review request for zookeeper, fpj,

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-24 Thread Michael Han
> On Sept. 24, 2016, 3:02 p.m., fpj wrote: > > src/c/tests/TestReconfigServer.cc, line 78 > > > > > > Is this saying that we don't need to test ACLs with reconfig for the C > > client? Yes - These changes are

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-24 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review150301 --- Looks pretty good, Michael. I have left a few comments and

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-20 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/#review149706 --- src/java/main/org/apache/zookeeper/ZooKeeperAdmin.java (line

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-09-01 Thread Michael Han
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51546/ --- (Updated Sept. 1, 2016, 4:24 p.m.) Review request for zookeeper, fpj, Patrick