---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated March 5, 2015, 6:55 p.m.)
Review request for zookeeper, michim, Raul
On March 2, 2015, 5:35 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 688
https://reviews.apache.org/r/20071/diff/7/?file=882155#file882155line688
Adding some comments here would be helpful too.
added comments
- Rakesh
- Rakesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
---
On March 5, 2015, 6:55 p.m., Rakesh R wrote:
On March 2, 2015, 5:35 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 688
https://reviews.apache.org/r/20071/diff/7/?file=882155#file882155line688
Adding some comments here would be helpful too.
Rakesh R wrote:
added
On March 2, 2015, 5:30 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 690
https://reviews.apache.org/r/20071/diff/6-7/?file=868720#file868720line690
state != State.Running.
Or we can just leave if (firstProcessor == null) {
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated March 2, 2015, 5:26 p.m.)
Review request for zookeeper, michim, Raul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74757
---
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review74761
---
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review73016
---
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
On Feb. 3, 2015, 4:52 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java,
line 26
https://reviews.apache.org/r/20071/diff/4/?file=845242#file845242line26
This will notify the server that some critical thread has stopped. It
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated Feb. 19, 2015, 3:23 a.m.)
Review request for zookeeper, michim, Raul
On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java, line
155
https://reviews.apache.org/r/20071/diff/4-5/?file=845238#file845238line155
Why interrupt()?
its not required, removed.
On Feb. 5, 2015, 6:50 p.m.,
On Feb. 18, 2015, 9:54 p.m., Hongchao Deng wrote:
./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java,
line 66
https://reviews.apache.org/r/20071/diff/5/?file=850859#file850859line66
Can we change the name to
testZKSListener since it's a test local
On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
147
https://reviews.apache.org/r/20071/diff/4-5/?file=845237#file845237line147
Why interrupt() here?
Add comments please.
Rakesh R wrote:
On Feb. 5, 2015, 6:58 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
115
https://reviews.apache.org/r/20071/diff/5/?file=850832#file850832line115
And we don't need listener now... Seems like we need to refactor a lot..
On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
147
https://reviews.apache.org/r/20071/diff/4-5/?file=845237#file845237line147
Why interrupt() here?
Add comments please.
When we catch and swallow
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71377
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated Feb. 5, 2015, 6:32 p.m.)
Review request for zookeeper, michim, Raul
On Feb. 3, 2015, 4:52 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java,
line 47
https://reviews.apache.org/r/20071/diff/4/?file=845240#file845240line47
Do you think handleException() and notifyStopping are duplicate? Can we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71262
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review71269
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated Feb. 3, 2015, 8:35 a.m.)
Review request for zookeeper, michim, Raul
On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
159
https://reviews.apache.org/r/20071/diff/3/?file=834241#file834241line159
Is there any race in listener between run() and shutdown()? Maybe some
On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
159
https://reviews.apache.org/r/20071/diff/3/?file=834241#file834241line159
Is there any race in listener between run() and shutdown()? Maybe some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated Jan. 26, 2015, 2:12 p.m.)
Review request for zookeeper, michim, Raul
On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
159
https://reviews.apache.org/r/20071/diff/3/?file=834241#file834241line159
Is there any race in listener between run() and shutdown()? Maybe some
On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
159
https://reviews.apache.org/r/20071/diff/3/?file=834241#file834241line159
Is there any race in listener between run() and shutdown()? Maybe some
On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line
159
https://reviews.apache.org/r/20071/diff/3/?file=834241#file834241line159
Is there any race in listener between run() and shutdown()? Maybe some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---
On April 8, 2014, 6:52 p.m., Raul Gutierrez Segales wrote:
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 1062
https://reviews.apache.org/r/20071/diff/1/?file=550386#file550386line1062
I think we can do more here.. i.e.: actually find out what thread is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review48178
---
Ship it!
Ship It!
- Raul Gutierrez Segales
On May 28, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated May 28, 2014, 12:26 p.m.)
Review request for zookeeper, michim, Raul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---
(Updated May 23, 2014, 11:21 a.m.)
Review request for zookeeper, michim, Raul
33 matches
Mail list logo
