Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-07-07 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/ --- (Updated July 7, 2014, 5:03 p.m.) Review request for zookeeper, fpj, michim,

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-30 Thread Raul Gutierrez Segales
On June 29, 2014, 11:04 a.m., fpj wrote: src/c/include/zookeeper.h, line 124 https://reviews.apache.org/r/23081/diff/3/?file=619678#file619678line124 As I understand it, this code indicates that a write operation was tried when connected to a read-only server. If this is right,

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-30 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/ --- (Updated June 30, 2014, 8 p.m.) Review request for zookeeper, fpj, michim,

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-29 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/#review46948 --- Ship it! Just a few minor comments, otherwise it looks good.

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-27 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/#review46875 --- It looks good to me, I just have a few minor comments, and I need

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-27 Thread Raul Gutierrez Segales
On June 27, 2014, 5:37 p.m., fpj wrote: src/c/README, line 90 https://reviews.apache.org/r/23081/diff/1/?file=618570#file618570line90 This is minor, but does the option really have to be at the end? I'd say that either anywhere or before the host:port pair, no? oh sure. didn't

Re: Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-27 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/ --- (Updated June 27, 2014, 6:45 p.m.) Review request for zookeeper, fpj, michim,

Review Request 23081: ZOOKEEPER-827. enable r/o mode in C client library

2014-06-26 Thread Raul Gutierrez Segales
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23081/ --- Review request for zookeeper, fpj, michim, Patrick Hunt, Rakesh R, and Thawan