---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 17, 2014, 11:30 p.m.)
Review request for zookeeper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 13, 2014, 11:05 p.m.)
Review request for zookeeper.
On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 108
https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line108
bootstrap.setOption(connectTimeoutMillis,
System.getProperty(connectTimeoutMillis));
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 12, 2014, 7:16 p.m.)
Review request for zookeeper.
Repository:
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 1472
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line1472
I'm now confused by this change. Are you getting rid of enableWrite?
saslCompleted is fairly different
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134
It sounds like making pendingQueue and outgoingQueue are optimizations
that are independent from this
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134
It sounds like making pendingQueue and outgoingQueue are optimizations
that are independent from this
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134
It sounds like making pendingQueue and outgoingQueue are optimizations
that are independent from this
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134
It sounds like making pendingQueue and outgoingQueue are optimizations
that are independent from this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review64767
---
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review64803
---
A few more comments, Hongchao. Thanks for the changes so far.
On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 99
https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line99
Could you tell me when this situation can come? Is this added for safer
side?
I will
On Dec. 11, 2014, 10:53 p.m., fpj wrote:
build.xml, line 42
https://reviews.apache.org/r/27244/diff/28/?file=789546#file789546line42
Is this accidental? There is an issue open to change it to 1.7. If it
is necessary, we can make this change here, but otherwise leave it for the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review64807
---
A few more, I'm not sorry for sending them separately.
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 134
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line134
It sounds like making pendingQueue and outgoingQueue are optimizations
that are independent from this
On Dec. 11, 2014, 11:16 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxn.java, line 1472
https://reviews.apache.org/r/27244/diff/28/?file=789547#file789547line1472
I'm now confused by this change. Are you getting rid of enableWrite?
saslCompleted is fairly different
On Dec. 11, 2014, 10:53 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 70
https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line70
I see, the previous sasl changes are necessary here so that we can
proceed only if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 12, 2014, 12:14 a.m.)
Review request for zookeeper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 5, 2014, 10:35 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 6, 2014, 2:11 a.m.)
Review request for zookeeper.
Repository:
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 66
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line66
Is the reason to have workSemaphore to block in doTransport when there
isn't anything in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 3, 2014, 9:50 p.m.)
Review request for zookeeper.
Repository:
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 66
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line66
Is the reason to have workSemaphore to block in doTransport when there
isn't anything in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 3, 2014, 10:20 p.m.)
Review request for zookeeper.
Repository:
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 188
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line188
Could you elaborate on what you're trying to do with this NIOLock? I'm
not sure what you mean
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 188
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line188
Could you elaborate on what you're trying to do with this NIOLock? I'm
not sure what you mean
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review63604
---
Looks better, Hongchao, thanks. I have a few more comments below,
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 66
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line66
Is the reason to have workSemaphore to block in doTransport when there
isn't anything in the
On Dec. 2, 2014, 11:43 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 188
https://reviews.apache.org/r/27244/diff/22/?file=774526#file774526line188
Could you elaborate on what you're trying to do with this NIOLock? I'm
not sure what you mean
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Dec. 3, 2014, 1:52 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review62842
---
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 24, 2014, 7:01 p.m.)
Review request for zookeeper.
Repository:
On Nov. 24, 2014, 6:53 p.m., Raul Gutierrez Segales wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java, line 179
https://reviews.apache.org/r/27244/diff/20/?file=758279#file758279line179
By extraplation I meant that this:
```
LOG.debug(deferring
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 22, 2014, 5:46 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review62605
---
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java
On Nov. 21, 2014, 7:46 p.m., Raul Gutierrez Segales wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java, line 179
https://reviews.apache.org/r/27244/diff/20/?file=758279#file758279line179
nit:
* extrapolation reads better than concatenation
*
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 11, 2014, 8:54 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 10, 2014, 3:28 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 5, 2014, 5:28 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 5, 2014, 6:02 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 5, 2014, 6:03 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 5, 2014, 2:31 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 5, 2014, 4:17 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 3, 2014, 9:35 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 3, 2014, 10:12 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 4, 2014, 3:57 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 2, 2014, 8:22 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 2, 2014, 8:27 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/#review59363
---
First batch of comments. The overall structure looks good, but I
On Nov. 1, 2014, 12:14 p.m., fpj wrote:
src/java/main/org/apache/zookeeper/ClientCnxnSocket.java, line 154
https://reviews.apache.org/r/27244/diff/5/?file=745331#file745331line154
... already started sending Also, the comment is overflowing, so
moving it to the top sounds
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 1, 2014, 10:41 p.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Nov. 2, 2014, 3:28 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Oct. 31, 2014, 10:57 p.m.)
Review request for zookeeper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Oct. 30, 2014, 10:53 p.m.)
Review request for zookeeper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Oct. 31, 2014, 2:09 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
(Updated Oct. 31, 2014, 2:13 a.m.)
Review request for zookeeper.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27244/
---
Review request for zookeeper.
Repository: zookeeper-git
Description
---
57 matches
Mail list logo
