[jira] [Commented] (ZOOKEEPER-2444) Fix NULL handling for getlogin() call
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321882#comment-15321882 ] Michael Han commented on ZOOKEEPER-2444: [~vespian] Thanks for reporting the issue. The fix should be submitted as a patch instead of pull request, and you can find the guidelines of how to submit a patch here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute > Fix NULL handling for getlogin() call > - > > Key: ZOOKEEPER-2444 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2444 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.4.8 >Reporter: Pawel Rozlach > > https://github.com/apache/zookeeper/pull/70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321770#comment-15321770 ] Michael Han commented on ZOOKEEPER-2080: I'd like to take a stab here and assign this issue to myself. Ok with you [~rgs]? > ReconfigRecoveryTest fails intermittently > - > > Key: ZOOKEEPER-2080 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Ted Yu >Assignee: Raul Gutierrez Segales > Attachments: jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, > repro-20150816.log > > > I got the following test failure on MacBook with trunk code: > {code} > Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec > FAILED > waiting for server 2 being up > junit.framework.AssertionFailedError: waiting for server 2 being up > at > org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529) > at > org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Synchronous version of ZooKeeper::sync() API
Thanks for the detailed explanation, Flavio. Makes sense to me. On Wed, Jun 8, 2016 at 2:38 AM, Flavio Junqueirawrote: > Our intention with sync at the time was to have an operation that in > combination with a read gives us linearizable semantics. As it is discussed > in the jira, if there is out-of-band communication, then a client can get a > stale result for a read. The sync op was made async *only* because we > wanted to have the operation open or ongoing while issuing the read. If the > sync is synchronous, then it will have returned by the time you submit the > read. Making the sync call asynchronous clearly doesn't prevent zookeeper > from processing the sync before the read, but it has the advantage of not > blocking the read which is the operation you're really interested in. Also, > even if you're using the sync api for the core operations, you can still > call sync asynchronously and it will have the same effect. > > I don't see a strong reason for adding a synchronous sync, and we should > really encourage the use of asynchronous sync and not have a synchronous > version of sync, but let me know if I'm missing something important. > > -Flavio > > > > On 07 Jun 2016, at 23:49, Marshall McMullen > wrote: > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-1167 > > > > On Tue, Jun 7, 2016 at 4:46 PM, Michael Han wrote: > > > >> Hi devs, > >> > >> Currently ZooKeeper::sync() API only has an asynchronous version: > >> > >> public void sync(String > >> < > >> > http://docs.oracle.com/javase/6/docs/api/java/lang/String.html?is-external=true > >>> > >> path, > >> AsyncCallback.VoidCallback > >> < > >> > https://zookeeper.apache.org/doc/r3.5.1-alpha/api/org/apache/zookeeper/AsyncCallback.VoidCallback.html > >>> > >> cb, > >> Object > >> < > >> > http://docs.oracle.com/javase/6/docs/api/java/lang/Object.html?is-external=true > >>> > >> ctx) > >> > >> Asynchronous sync. Flushes channel between process and leader. > >> > >> Given that all other existing APIs have both sync and async version, > should > >> we also have a synchronous version of the "sync()" API? > >> > >> -- > >> Cheers > >> Michael. > >> > > -- Cheers Michael.
ZooKeeper_branch34 - Build # 1545 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34/1545/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 219978 lines...] [junit] 2016-06-09 00:20:28,811 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-09 00:20:28,811 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-09 00:20:28,811 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-06-09 00:20:28,811 [myid:] - INFO [main:ZooKeeperServer@469] - shutting down [junit] 2016-06-09 00:20:28,812 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-06-09 00:20:28,812 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-06-09 00:20:28,812 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2016-06-09 00:20:28,812 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-06-09 00:20:28,813 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2016-06-09 00:20:28,813 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-06-09 00:20:28,814 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-09 00:20:28,814 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-09 00:20:28,816 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-06-09 00:20:28,816 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2016-06-09 00:20:28,817 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-06-09 00:20:28,817 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2016-06-09 00:20:28,818 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build/test/tmp/test5108602832802523581.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/branch-3.4/build/test/tmp/test5108602832802523581.junit.dir/version-2 [junit] 2016-06-09 00:20:28,823 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-09 00:20:28,824 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:54919 [junit] 2016-06-09 00:20:28,824 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:54919 [junit] 2016-06-09 00:20:28,825 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-06-09 00:20:28,825 [myid:] - INFO [Thread-5:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:54919 (no session established for client) [junit] 2016-06-09 00:20:28,826 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-09 00:20:28,828 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-06-09 00:20:28,828 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-06-09 00:20:28,828 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-06-09 00:20:28,828 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-09 00:20:28,829 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 31173 [junit] 2016-06-09 00:20:28,829 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-06-09 00:20:28,829 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-06-09 00:20:28,829 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-06-09 00:20:28,892 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x15532881ae7 closed [junit] 2016-06-09 00:20:28,892 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-09 00:20:28,893 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x15532881ae7 [junit] 2016-06-09 00:20:28,893 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit]
ZooKeeper_branch34_jdk8 - Build # 595 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/595/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 229425 lines...] [junit] 2016-06-08 23:03:02,612 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-06-08 23:03:02,612 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-08 23:03:02,613 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-08 23:03:02,613 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-06-08 23:03:02,614 [myid:] - INFO [main:ZooKeeperServer@469] - shutting down [junit] 2016-06-08 23:03:02,614 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-06-08 23:03:02,614 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-06-08 23:03:02,614 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2016-06-08 23:03:02,614 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-06-08 23:03:02,615 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2016-06-08 23:03:02,615 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-06-08 23:03:02,616 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-08 23:03:02,616 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-08 23:03:02,617 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-06-08 23:03:02,618 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2016-06-08 23:03:02,618 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-06-08 23:03:02,618 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2016-06-08 23:03:02,618 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test4711996276091598485.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test4711996276091598485.junit.dir/version-2 [junit] 2016-06-08 23:03:02,622 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-08 23:03:02,622 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:43070 [junit] 2016-06-08 23:03:02,623 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:43070 [junit] 2016-06-08 23:03:02,623 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-06-08 23:03:02,623 [myid:] - INFO [Thread-4:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:43070 (no session established for client) [junit] 2016-06-08 23:03:02,624 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-08 23:03:02,626 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-06-08 23:03:02,626 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-06-08 23:03:02,626 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-06-08 23:03:02,626 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-08 23:03:02,627 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 5726 [junit] 2016-06-08 23:03:02,627 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-06-08 23:03:02,627 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-06-08 23:03:02,627 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-06-08 23:03:02,698 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x155324135c8 closed [junit] 2016-06-08 23:03:02,699 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-08 23:03:02,698 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x155324135c8 [junit] 2016-06-08 23:03:02,699 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-1485) client xid overflow is not handled
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321602#comment-15321602 ] Marshall McMullen commented on ZOOKEEPER-1485: -- Assigning this to [~makuchta] as he's been working this issue for us. > client xid overflow is not handled > -- > > Key: ZOOKEEPER-1485 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1485 > Project: ZooKeeper > Issue Type: Bug > Components: c client, java client >Affects Versions: 3.4.3, 3.3.5 >Reporter: Michi Mutsuzaki >Assignee: Martin Kuchta > > Both Java and C clients use signed 32-bit int as XIDs. XIDs are assumed to be > non-negative, and zookeeper uses some negative values as special XIDs (e.g. > -2 for ping, -4 for auth). However, neither Java nor C client ensures the > XIDs it generates are non-negative, and the server doesn't reject negative > XIDs. > Pat had some suggestions on how to fix this: > - (bin-compat) Expire the session when the client sends a negative XID. > - (bin-incompat) In addition to expiring the session, use 64-bit int for XID > so that overflow will practically never happen. > --Michi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-1485) client xid overflow is not handled
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-1485: - Assignee: Martin Kuchta (was: Bruce Gao) > client xid overflow is not handled > -- > > Key: ZOOKEEPER-1485 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1485 > Project: ZooKeeper > Issue Type: Bug > Components: c client, java client >Affects Versions: 3.4.3, 3.3.5 >Reporter: Michi Mutsuzaki >Assignee: Martin Kuchta > > Both Java and C clients use signed 32-bit int as XIDs. XIDs are assumed to be > non-negative, and zookeeper uses some negative values as special XIDs (e.g. > -2 for ping, -4 for auth). However, neither Java nor C client ensures the > XIDs it generates are non-negative, and the server doesn't reject negative > XIDs. > Pat had some suggestions on how to fix this: > - (bin-compat) Expire the session when the client sends a negative XID. > - (bin-incompat) In addition to expiring the session, use 64-bit int for XID > so that overflow will practically never happen. > --Michi -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Unable to contribute on JIRA
Confirming that everything seems to be working now. Thanks for the help, Patrick. > On June 8, 2016 at 4:34 PM Marshall McMullen> wrote: > > Yep, it works now. I was able to assign the Jira to Martin without > problems now. Again, thanks. > > On Wed, Jun 8, 2016 at 4:33 PM, Marshall McMullen > wrote: > > > > Thank you very much for the assistance Patric. > > > > On Wed, Jun 8, 2016 at 4:32 PM, Patrick Hunt > mailto:ph...@apache.org > wrote: > > > > > > > I've added Martin as a contributor, give it another try. > > > > > > Patrick > > > > > > On Wed, Jun 8, 2016 at 3:21 PM, Marshall McMullen < > > > marshall.mcmul...@gmail.com > > > mailto:marshall.mcmul...@gmail.com > wrote: > > > > > > > That makes sense. I would appreciate if a committer can > > > change Martin's > > > > role to be contributer. Otherwise we'll reach out to the > > > Infra team to get > > > > some assistance on that. > > > > > > > > Thanks! > > > > > > > > On Wed, Jun 8, 2016 at 4:04 PM, Michael Han > > > wrote: > > > > > > > > > I think someone (a committer probably only) just needs > > > make Martin as a > > > > > 'contributor' role. > > > > > > > > > > The best way to contact Apache Infra is through their > > > Hipchat channel > > > > > http://www.apache.org/dev/infra-contact > > > > > > > > > > On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < > > > > > marshall.mcmul...@gmail.com > > > mailto:marshall.mcmul...@gmail.com > wrote: > > > > > > > > > > > Should Martin contact the "Apache Infrastructure Team" > > > regarding this? > > > > If > > > > > > so, how does he do that? > > > > > > > > > > > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < > > > > > > marshall.mcmul...@gmail.com > > > mailto:marshall.mcmul...@gmail.com > wrote: > > > > > > > > > > > > > I tried to assign this Jira to him and got an error > > > message back: > > > > > > > > > > > > > > User 'makuchta' cannot be assigned issues. > > > > > > > > > > > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Han > > > > > > > wrote: > > > > > > > > > > > > > >> Martin, > > > > > > >> > > > > > > >> I had met similar issue earlier, here is an email > > > sent earlier to > > > > dev > > > > > > >> list: > > > > > > >> > > > > > > >> >> > > > > > > >> FYI, I met an issue today that I can't attach files > > > to a JIRA issue > > > > > with > > > > > > >> the role of 'contributor'. Contacted Apache > > > Infrastructure team and > > > > > > >> confirmed that: > > > > > > >> > > > > > > >> - For a given JIRA issue, only *reporter*, or > > > *assignee*, or > > > > > *committer* > > > > > > >> can attach file. > > > > > > >> - A contributor can only attach files to issues > > > that's assigned > > > > and/or > > > > > > >> reporting to the contributor. > > > > > > >> - A workaround for a contributor to attach files to > > > any issue is to > > > > > > first > > > > > > >> change assignee to the contributor, then attach > > > files, then change > > > > the > > > > > > >> assignee back. > > > > > > >> >> > > > > > > >> > > > > > > >> I think someone just need to assign ZOOKEEPER-2355 > > > to you since you > > > > > are > > > > > > >> working on it. > > > > > > >> > > > > > > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta < > > > > > mar...@martinkuchta.com mailto:mar...@martinkuchta.com > > > > > > > >> wrote: > > > > > > >> > > > > > > >> > Hi, > > > > > > >> > > > > > > > >> > Does anyone know if I need to do anything special > > > to have the > > > > > ability > > > > > > to > > > > > > >> > submit attachments and be assigned issues on JIRA? > > > I was recently > > > > > > >> trying to > > > > > > >> > submit a patch for ZOOKEEPER-2355 and realized the > > > option was > > > > > missing > > > > > > >> for > > > > > > >> > me. It's not present on any other ZooKeeper JIRAs >
Re: Unable to contribute on JIRA
Yep, it works now. I was able to assign the Jira to Martin without problems now. Again, thanks. On Wed, Jun 8, 2016 at 4:33 PM, Marshall McMullen < marshall.mcmul...@gmail.com> wrote: > Thank you very much for the assistance Patric. > > On Wed, Jun 8, 2016 at 4:32 PM, Patrick Huntwrote: > >> I've added Martin as a contributor, give it another try. >> >> Patrick >> >> On Wed, Jun 8, 2016 at 3:21 PM, Marshall McMullen < >> marshall.mcmul...@gmail.com> wrote: >> >> > That makes sense. I would appreciate if a committer can change Martin's >> > role to be contributer. Otherwise we'll reach out to the Infra team to >> get >> > some assistance on that. >> > >> > Thanks! >> > >> > On Wed, Jun 8, 2016 at 4:04 PM, Michael Han wrote: >> > >> > > I think someone (a committer probably only) just needs make Martin as >> a >> > > 'contributor' role. >> > > >> > > The best way to contact Apache Infra is through their Hipchat channel >> > > http://www.apache.org/dev/infra-contact >> > > >> > > On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < >> > > marshall.mcmul...@gmail.com> wrote: >> > > >> > > > Should Martin contact the "Apache Infrastructure Team" regarding >> this? >> > If >> > > > so, how does he do that? >> > > > >> > > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < >> > > > marshall.mcmul...@gmail.com> wrote: >> > > > >> > > > > I tried to assign this Jira to him and got an error message back: >> > > > > >> > > > > User 'makuchta' cannot be assigned issues. >> > > > > >> > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Han >> > wrote: >> > > > > >> > > > >> Martin, >> > > > >> >> > > > >> I had met similar issue earlier, here is an email sent earlier to >> > dev >> > > > >> list: >> > > > >> >> > > > >> >> >> > > > >> FYI, I met an issue today that I can't attach files to a JIRA >> issue >> > > with >> > > > >> the role of 'contributor'. Contacted Apache Infrastructure team >> and >> > > > >> confirmed that: >> > > > >> >> > > > >> - For a given JIRA issue, only *reporter*, or *assignee*, or >> > > *committer* >> > > > >> can attach file. >> > > > >> - A contributor can only attach files to issues that's assigned >> > and/or >> > > > >> reporting to the contributor. >> > > > >> - A workaround for a contributor to attach files to any issue is >> to >> > > > first >> > > > >> change assignee to the contributor, then attach files, then >> change >> > the >> > > > >> assignee back. >> > > > >> >> >> > > > >> >> > > > >> I think someone just need to assign ZOOKEEPER-2355 to you since >> you >> > > are >> > > > >> working on it. >> > > > >> >> > > > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta < >> > > mar...@martinkuchta.com> >> > > > >> wrote: >> > > > >> >> > > > >> > Hi, >> > > > >> > >> > > > >> > Does anyone know if I need to do anything special to have the >> > > ability >> > > > to >> > > > >> > submit attachments and be assigned issues on JIRA? I was >> recently >> > > > >> trying to >> > > > >> > submit a patch for ZOOKEEPER-2355 and realized the option was >> > > missing >> > > > >> for >> > > > >> > me. It's not present on any other ZooKeeper JIRAs that I can >> see, >> > > > >> although >> > > > >> > I can see it on JIRAs from other Apache projects. >> > > > >> > >> > > > >> > I was working with Marshall McMullen to get the patch >> submitted, >> > and >> > > > our >> > > > >> > first thought was that the issue might need to be assigned to >> me, >> > > but >> > > > >> even >> > > > >> > though he was able to reassign the issue, I was not a valid >> user >> > to >> > > > >> assign >> > > > >> > it to. >> > > > >> > >> > > > >> > My account username is makuchta. I created it almost two weeks >> ago >> > > if >> > > > >> > that's of any relevance. >> > > > >> > >> > > > >> > >> > > > >> > Thanks, >> > > > >> > >> > > > >> > Martin >> > > > >> >> > > > >> >> > > > >> >> > > > >> >> > > > >> -- >> > > > >> Cheers >> > > > >> Michael. >> > > > >> >> > > > > >> > > > > >> > > > >> > > >> > > >> > > >> > > -- >> > > Cheers >> > > Michael. >> > > >> > >> > >
[jira] [Updated] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-2355: - Assignee: Martin Kuchta (was: Marshall McMullen) > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Martin Kuchta >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Unable to contribute on JIRA
Thank you very much for the assistance Patric. On Wed, Jun 8, 2016 at 4:32 PM, Patrick Huntwrote: > I've added Martin as a contributor, give it another try. > > Patrick > > On Wed, Jun 8, 2016 at 3:21 PM, Marshall McMullen < > marshall.mcmul...@gmail.com> wrote: > > > That makes sense. I would appreciate if a committer can change Martin's > > role to be contributer. Otherwise we'll reach out to the Infra team to > get > > some assistance on that. > > > > Thanks! > > > > On Wed, Jun 8, 2016 at 4:04 PM, Michael Han wrote: > > > > > I think someone (a committer probably only) just needs make Martin as a > > > 'contributor' role. > > > > > > The best way to contact Apache Infra is through their Hipchat channel > > > http://www.apache.org/dev/infra-contact > > > > > > On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < > > > marshall.mcmul...@gmail.com> wrote: > > > > > > > Should Martin contact the "Apache Infrastructure Team" regarding > this? > > If > > > > so, how does he do that? > > > > > > > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < > > > > marshall.mcmul...@gmail.com> wrote: > > > > > > > > > I tried to assign this Jira to him and got an error message back: > > > > > > > > > > User 'makuchta' cannot be assigned issues. > > > > > > > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Han > > wrote: > > > > > > > > > >> Martin, > > > > >> > > > > >> I had met similar issue earlier, here is an email sent earlier to > > dev > > > > >> list: > > > > >> > > > > >> >> > > > > >> FYI, I met an issue today that I can't attach files to a JIRA > issue > > > with > > > > >> the role of 'contributor'. Contacted Apache Infrastructure team > and > > > > >> confirmed that: > > > > >> > > > > >> - For a given JIRA issue, only *reporter*, or *assignee*, or > > > *committer* > > > > >> can attach file. > > > > >> - A contributor can only attach files to issues that's assigned > > and/or > > > > >> reporting to the contributor. > > > > >> - A workaround for a contributor to attach files to any issue is > to > > > > first > > > > >> change assignee to the contributor, then attach files, then change > > the > > > > >> assignee back. > > > > >> >> > > > > >> > > > > >> I think someone just need to assign ZOOKEEPER-2355 to you since > you > > > are > > > > >> working on it. > > > > >> > > > > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta < > > > mar...@martinkuchta.com> > > > > >> wrote: > > > > >> > > > > >> > Hi, > > > > >> > > > > > >> > Does anyone know if I need to do anything special to have the > > > ability > > > > to > > > > >> > submit attachments and be assigned issues on JIRA? I was > recently > > > > >> trying to > > > > >> > submit a patch for ZOOKEEPER-2355 and realized the option was > > > missing > > > > >> for > > > > >> > me. It's not present on any other ZooKeeper JIRAs that I can > see, > > > > >> although > > > > >> > I can see it on JIRAs from other Apache projects. > > > > >> > > > > > >> > I was working with Marshall McMullen to get the patch submitted, > > and > > > > our > > > > >> > first thought was that the issue might need to be assigned to > me, > > > but > > > > >> even > > > > >> > though he was able to reassign the issue, I was not a valid user > > to > > > > >> assign > > > > >> > it to. > > > > >> > > > > > >> > My account username is makuchta. I created it almost two weeks > ago > > > if > > > > >> > that's of any relevance. > > > > >> > > > > > >> > > > > > >> > Thanks, > > > > >> > > > > > >> > Martin > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> -- > > > > >> Cheers > > > > >> Michael. > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Cheers > > > Michael. > > > > > >
Re: Unable to contribute on JIRA
I've added Martin as a contributor, give it another try. Patrick On Wed, Jun 8, 2016 at 3:21 PM, Marshall McMullen < marshall.mcmul...@gmail.com> wrote: > That makes sense. I would appreciate if a committer can change Martin's > role to be contributer. Otherwise we'll reach out to the Infra team to get > some assistance on that. > > Thanks! > > On Wed, Jun 8, 2016 at 4:04 PM, Michael Hanwrote: > > > I think someone (a committer probably only) just needs make Martin as a > > 'contributor' role. > > > > The best way to contact Apache Infra is through their Hipchat channel > > http://www.apache.org/dev/infra-contact > > > > On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < > > marshall.mcmul...@gmail.com> wrote: > > > > > Should Martin contact the "Apache Infrastructure Team" regarding this? > If > > > so, how does he do that? > > > > > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < > > > marshall.mcmul...@gmail.com> wrote: > > > > > > > I tried to assign this Jira to him and got an error message back: > > > > > > > > User 'makuchta' cannot be assigned issues. > > > > > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Han > wrote: > > > > > > > >> Martin, > > > >> > > > >> I had met similar issue earlier, here is an email sent earlier to > dev > > > >> list: > > > >> > > > >> >> > > > >> FYI, I met an issue today that I can't attach files to a JIRA issue > > with > > > >> the role of 'contributor'. Contacted Apache Infrastructure team and > > > >> confirmed that: > > > >> > > > >> - For a given JIRA issue, only *reporter*, or *assignee*, or > > *committer* > > > >> can attach file. > > > >> - A contributor can only attach files to issues that's assigned > and/or > > > >> reporting to the contributor. > > > >> - A workaround for a contributor to attach files to any issue is to > > > first > > > >> change assignee to the contributor, then attach files, then change > the > > > >> assignee back. > > > >> >> > > > >> > > > >> I think someone just need to assign ZOOKEEPER-2355 to you since you > > are > > > >> working on it. > > > >> > > > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta < > > mar...@martinkuchta.com> > > > >> wrote: > > > >> > > > >> > Hi, > > > >> > > > > >> > Does anyone know if I need to do anything special to have the > > ability > > > to > > > >> > submit attachments and be assigned issues on JIRA? I was recently > > > >> trying to > > > >> > submit a patch for ZOOKEEPER-2355 and realized the option was > > missing > > > >> for > > > >> > me. It's not present on any other ZooKeeper JIRAs that I can see, > > > >> although > > > >> > I can see it on JIRAs from other Apache projects. > > > >> > > > > >> > I was working with Marshall McMullen to get the patch submitted, > and > > > our > > > >> > first thought was that the issue might need to be assigned to me, > > but > > > >> even > > > >> > though he was able to reassign the issue, I was not a valid user > to > > > >> assign > > > >> > it to. > > > >> > > > > >> > My account username is makuchta. I created it almost two weeks ago > > if > > > >> > that's of any relevance. > > > >> > > > > >> > > > > >> > Thanks, > > > >> > > > > >> > Martin > > > >> > > > >> > > > >> > > > >> > > > >> -- > > > >> Cheers > > > >> Michael. > > > >> > > > > > > > > > > > > > > > > > > > -- > > Cheers > > Michael. > > >
Re: Unable to contribute on JIRA
That makes sense. I would appreciate if a committer can change Martin's role to be contributer. Otherwise we'll reach out to the Infra team to get some assistance on that. Thanks! On Wed, Jun 8, 2016 at 4:04 PM, Michael Hanwrote: > I think someone (a committer probably only) just needs make Martin as a > 'contributor' role. > > The best way to contact Apache Infra is through their Hipchat channel > http://www.apache.org/dev/infra-contact > > On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < > marshall.mcmul...@gmail.com> wrote: > > > Should Martin contact the "Apache Infrastructure Team" regarding this? If > > so, how does he do that? > > > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < > > marshall.mcmul...@gmail.com> wrote: > > > > > I tried to assign this Jira to him and got an error message back: > > > > > > User 'makuchta' cannot be assigned issues. > > > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Han wrote: > > > > > >> Martin, > > >> > > >> I had met similar issue earlier, here is an email sent earlier to dev > > >> list: > > >> > > >> >> > > >> FYI, I met an issue today that I can't attach files to a JIRA issue > with > > >> the role of 'contributor'. Contacted Apache Infrastructure team and > > >> confirmed that: > > >> > > >> - For a given JIRA issue, only *reporter*, or *assignee*, or > *committer* > > >> can attach file. > > >> - A contributor can only attach files to issues that's assigned and/or > > >> reporting to the contributor. > > >> - A workaround for a contributor to attach files to any issue is to > > first > > >> change assignee to the contributor, then attach files, then change the > > >> assignee back. > > >> >> > > >> > > >> I think someone just need to assign ZOOKEEPER-2355 to you since you > are > > >> working on it. > > >> > > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta < > mar...@martinkuchta.com> > > >> wrote: > > >> > > >> > Hi, > > >> > > > >> > Does anyone know if I need to do anything special to have the > ability > > to > > >> > submit attachments and be assigned issues on JIRA? I was recently > > >> trying to > > >> > submit a patch for ZOOKEEPER-2355 and realized the option was > missing > > >> for > > >> > me. It's not present on any other ZooKeeper JIRAs that I can see, > > >> although > > >> > I can see it on JIRAs from other Apache projects. > > >> > > > >> > I was working with Marshall McMullen to get the patch submitted, and > > our > > >> > first thought was that the issue might need to be assigned to me, > but > > >> even > > >> > though he was able to reassign the issue, I was not a valid user to > > >> assign > > >> > it to. > > >> > > > >> > My account username is makuchta. I created it almost two weeks ago > if > > >> > that's of any relevance. > > >> > > > >> > > > >> > Thanks, > > >> > > > >> > Martin > > >> > > >> > > >> > > >> > > >> -- > > >> Cheers > > >> Michael. > > >> > > > > > > > > > > > > -- > Cheers > Michael. >
Re: Unable to contribute on JIRA
I think someone (a committer probably only) just needs make Martin as a 'contributor' role. The best way to contact Apache Infra is through their Hipchat channel http://www.apache.org/dev/infra-contact On Wed, Jun 8, 2016 at 3:01 PM, Marshall McMullen < marshall.mcmul...@gmail.com> wrote: > Should Martin contact the "Apache Infrastructure Team" regarding this? If > so, how does he do that? > > On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < > marshall.mcmul...@gmail.com> wrote: > > > I tried to assign this Jira to him and got an error message back: > > > > User 'makuchta' cannot be assigned issues. > > > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Hanwrote: > > > >> Martin, > >> > >> I had met similar issue earlier, here is an email sent earlier to dev > >> list: > >> > >> >> > >> FYI, I met an issue today that I can't attach files to a JIRA issue with > >> the role of 'contributor'. Contacted Apache Infrastructure team and > >> confirmed that: > >> > >> - For a given JIRA issue, only *reporter*, or *assignee*, or *committer* > >> can attach file. > >> - A contributor can only attach files to issues that's assigned and/or > >> reporting to the contributor. > >> - A workaround for a contributor to attach files to any issue is to > first > >> change assignee to the contributor, then attach files, then change the > >> assignee back. > >> >> > >> > >> I think someone just need to assign ZOOKEEPER-2355 to you since you are > >> working on it. > >> > >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta > >> wrote: > >> > >> > Hi, > >> > > >> > Does anyone know if I need to do anything special to have the ability > to > >> > submit attachments and be assigned issues on JIRA? I was recently > >> trying to > >> > submit a patch for ZOOKEEPER-2355 and realized the option was missing > >> for > >> > me. It's not present on any other ZooKeeper JIRAs that I can see, > >> although > >> > I can see it on JIRAs from other Apache projects. > >> > > >> > I was working with Marshall McMullen to get the patch submitted, and > our > >> > first thought was that the issue might need to be assigned to me, but > >> even > >> > though he was able to reassign the issue, I was not a valid user to > >> assign > >> > it to. > >> > > >> > My account username is makuchta. I created it almost two weeks ago if > >> > that's of any relevance. > >> > > >> > > >> > Thanks, > >> > > >> > Martin > >> > >> > >> > >> > >> -- > >> Cheers > >> Michael. > >> > > > > > -- Cheers Michael.
Re: Unable to contribute on JIRA
Should Martin contact the "Apache Infrastructure Team" regarding this? If so, how does he do that? On Wed, Jun 8, 2016 at 4:00 PM, Marshall McMullen < marshall.mcmul...@gmail.com> wrote: > I tried to assign this Jira to him and got an error message back: > > User 'makuchta' cannot be assigned issues. > > On Wed, Jun 8, 2016 at 3:58 PM, Michael Hanwrote: > >> Martin, >> >> I had met similar issue earlier, here is an email sent earlier to dev >> list: >> >> >> >> FYI, I met an issue today that I can't attach files to a JIRA issue with >> the role of 'contributor'. Contacted Apache Infrastructure team and >> confirmed that: >> >> - For a given JIRA issue, only *reporter*, or *assignee*, or *committer* >> can attach file. >> - A contributor can only attach files to issues that's assigned and/or >> reporting to the contributor. >> - A workaround for a contributor to attach files to any issue is to first >> change assignee to the contributor, then attach files, then change the >> assignee back. >> >> >> >> I think someone just need to assign ZOOKEEPER-2355 to you since you are >> working on it. >> >> On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta >> wrote: >> >> > Hi, >> > >> > Does anyone know if I need to do anything special to have the ability to >> > submit attachments and be assigned issues on JIRA? I was recently >> trying to >> > submit a patch for ZOOKEEPER-2355 and realized the option was missing >> for >> > me. It's not present on any other ZooKeeper JIRAs that I can see, >> although >> > I can see it on JIRAs from other Apache projects. >> > >> > I was working with Marshall McMullen to get the patch submitted, and our >> > first thought was that the issue might need to be assigned to me, but >> even >> > though he was able to reassign the issue, I was not a valid user to >> assign >> > it to. >> > >> > My account username is makuchta. I created it almost two weeks ago if >> > that's of any relevance. >> > >> > >> > Thanks, >> > >> > Martin >> >> >> >> >> -- >> Cheers >> Michael. >> > >
Re: Unable to contribute on JIRA
I tried to assign this Jira to him and got an error message back: User 'makuchta' cannot be assigned issues. On Wed, Jun 8, 2016 at 3:58 PM, Michael Hanwrote: > Martin, > > I had met similar issue earlier, here is an email sent earlier to dev list: > > >> > FYI, I met an issue today that I can't attach files to a JIRA issue with > the role of 'contributor'. Contacted Apache Infrastructure team and > confirmed that: > > - For a given JIRA issue, only *reporter*, or *assignee*, or *committer* > can attach file. > - A contributor can only attach files to issues that's assigned and/or > reporting to the contributor. > - A workaround for a contributor to attach files to any issue is to first > change assignee to the contributor, then attach files, then change the > assignee back. > >> > > I think someone just need to assign ZOOKEEPER-2355 to you since you are > working on it. > > On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchta > wrote: > > > Hi, > > > > Does anyone know if I need to do anything special to have the ability to > > submit attachments and be assigned issues on JIRA? I was recently trying > to > > submit a patch for ZOOKEEPER-2355 and realized the option was missing for > > me. It's not present on any other ZooKeeper JIRAs that I can see, > although > > I can see it on JIRAs from other Apache projects. > > > > I was working with Marshall McMullen to get the patch submitted, and our > > first thought was that the issue might need to be assigned to me, but > even > > though he was able to reassign the issue, I was not a valid user to > assign > > it to. > > > > My account username is makuchta. I created it almost two weeks ago if > > that's of any relevance. > > > > > > Thanks, > > > > Martin > > > > > -- > Cheers > Michael. >
Re: Unable to contribute on JIRA
Martin, I had met similar issue earlier, here is an email sent earlier to dev list: >> FYI, I met an issue today that I can't attach files to a JIRA issue with the role of 'contributor'. Contacted Apache Infrastructure team and confirmed that: - For a given JIRA issue, only *reporter*, or *assignee*, or *committer* can attach file. - A contributor can only attach files to issues that's assigned and/or reporting to the contributor. - A workaround for a contributor to attach files to any issue is to first change assignee to the contributor, then attach files, then change the assignee back. >> I think someone just need to assign ZOOKEEPER-2355 to you since you are working on it. On Wed, Jun 8, 2016 at 2:34 PM, Martin Kuchtawrote: > Hi, > > Does anyone know if I need to do anything special to have the ability to > submit attachments and be assigned issues on JIRA? I was recently trying to > submit a patch for ZOOKEEPER-2355 and realized the option was missing for > me. It's not present on any other ZooKeeper JIRAs that I can see, although > I can see it on JIRAs from other Apache projects. > > I was working with Marshall McMullen to get the patch submitted, and our > first thought was that the issue might need to be assigned to me, but even > though he was able to reassign the issue, I was not a valid user to assign > it to. > > My account username is makuchta. I created it almost two weeks ago if > that's of any relevance. > > > Thanks, > > Martin -- Cheers Michael.
[jira] [Commented] (ZOOKEEPER-2137) Make testPortChange() less flaky
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321499#comment-15321499 ] Hadoop QA commented on ZOOKEEPER-2137: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12809039/ZOOKEEPER-2137.patch against trunk revision 1747408. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//console This message is automatically generated. > Make testPortChange() less flaky > > > Key: ZOOKEEPER-2137 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Hongchao Deng >Assignee: Michael Han > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch, > ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch > > > The cause of flaky failure of testPortChange() is a race in sync(). > I figured out it could take some time to fix sync(). Meanwhile, we can make > testPortChange() less flaky by doing reconfig on the leader. We can change > this back in the fix of ZOOKEEPER-2136. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Success: ZOOKEEPER-2137 PreCommit Build #3186
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 385616 lines...] [exec] http://issues.apache.org/jira/secure/attachment/12809039/ZOOKEEPER-2137.patch [exec] against trunk revision 1747408. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 7 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3186//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 0182a31e5149ee850c3a84b2da525d9d87057b42 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 19 minutes 38 seconds Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2137 Email was triggered for: Success Sending email for trigger: Success Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## All tests passed
Unable to contribute on JIRA
Hi, Does anyone know if I need to do anything special to have the ability to submit attachments and be assigned issues on JIRA? I was recently trying to submit a patch for ZOOKEEPER-2355 and realized the option was missing for me. It's not present on any other ZooKeeper JIRAs that I can see, although I can see it on JIRAs from other Apache projects. I was working with Marshall McMullen to get the patch submitted, and our first thought was that the issue might need to be assigned to me, but even though he was able to reassign the issue, I was not a valid user to assign it to. My account username is makuchta. I created it almost two weeks ago if that's of any relevance. Thanks, Martin
[jira] [Updated] (ZOOKEEPER-2137) Make testPortChange() less flaky
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han updated ZOOKEEPER-2137: --- Attachment: ZOOKEEPER-2137.patch Rework patch based on feedback from Alex and Raul: separate creation of znode for reader / writer zookeeper handles using a dedicated function. > Make testPortChange() less flaky > > > Key: ZOOKEEPER-2137 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Hongchao Deng >Assignee: Michael Han > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch, > ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch > > > The cause of flaky failure of testPortChange() is a race in sync(). > I figured out it could take some time to fix sync(). Meanwhile, we can make > testPortChange() less flaky by doing reconfig on the leader. We can change > this back in the fix of ZOOKEEPER-2136. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321459#comment-15321459 ] Martin Kuchta commented on ZOOKEEPER-2355: -- A search for the new test failures shows them as known flaky tests (ZOOKEEPER-1806, ZOOKEEPER-1807, ZOOKEEPER-2137), and they seem far removed from anything this patch touches. I haven't seen them at all locally. > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321410#comment-15321410 ] Marshall McMullen edited comment on ZOOKEEPER-2355 at 6/8/16 8:43 PM: -- [~makuchta] - I'll leave you to investigate the failure reported above. was (Author: marshall): @makuchta - I'll leave you to investigate the failure reported above. > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321410#comment-15321410 ] Marshall McMullen commented on ZOOKEEPER-2355: -- @makuchta - I'll leave you to investigate the failure reported above. > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321401#comment-15321401 ] Hadoop QA commented on ZOOKEEPER-2355: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12809019/ZOOKEEPER-2355-03.patch against trunk revision 1747408. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//console This message is automatically generated. > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2355 PreCommit Build #3185
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 385354 lines...] [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3185//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] a5e650badc0afcb836a98a658c94dd0934940cd9 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1605: exec returned: 1 Total time: 8 minutes 45 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Compressed 552.76 KB of artifacts by 40.5% relative to #3177 Recording test results Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 [description-setter] Description set: ZOOKEEPER-2355 Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 Setting LATEST1_7_HOME=/home/jenkins/jenkins-slave/tools/hudson.model.JDK/latest1.7 ### ## FAILED TESTS (if any) ## 3 tests failed. FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig Error Message: waiting for server 2 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 2 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig Error Message: waiting for server 2 being up Stack Trace: junit.framework.AssertionFailedError: waiting for server 2 being up at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:217) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) FAILED: org.apache.zookeeper.test.ReconfigTest.testPortChange Error Message: expected:but was: Stack Trace: junit.framework.AssertionFailedError: expected: but was: at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:150) at
ZooKeeper-trunk-openjdk7 - Build # 1052 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1052/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 384554 lines...] [junit] 2016-06-08 20:36:28,017 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree] [junit] 2016-06-08 20:36:28,017 [myid:] - INFO [main:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11222] [junit] 2016-06-08 20:36:28,017 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-06-08 20:36:28,017 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-08 20:36:28,019 [myid:] - INFO [main:ClientBase@460] - STARTING server [junit] 2016-06-08 20:36:28,019 [myid:] - INFO [main:ClientBase@380] - CREATING server instance 127.0.0.1:11222 [junit] 2016-06-08 20:36:28,019 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 1 selector thread(s), 8 worker threads, and 64 kB direct buffers. [junit] 2016-06-08 20:36:28,020 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-06-08 20:36:28,020 [myid:] - INFO [main:ClientBase@355] - STARTING server instance 127.0.0.1:11222 [junit] 2016-06-08 20:36:28,020 [myid:] - INFO [main:ZooKeeperServer@858] - minSessionTimeout set to 6000 [junit] 2016-06-08 20:36:28,021 [myid:] - INFO [main:ZooKeeperServer@867] - maxSessionTimeout set to 6 [junit] 2016-06-08 20:36:28,021 [myid:] - INFO [main:ZooKeeperServer@156] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test1210820030522791759.junit.dir/version-2 snapdir /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test1210820030522791759.junit.dir/version-2 [junit] 2016-06-08 20:36:28,022 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test1210820030522791759.junit.dir/version-2/snapshot.b [junit] 2016-06-08 20:36:28,024 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-openjdk7/trunk/build/test/tmp/test1210820030522791759.junit.dir/version-2/snapshot.b [junit] 2016-06-08 20:36:28,026 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-06-08 20:36:28,026 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:41027 [junit] 2016-06-08 20:36:28,027 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:41027 [junit] 2016-06-08 20:36:28,027 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-06-08 20:36:28,028 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:41027 (no session established for client) [junit] 2016-06-08 20:36:28,028 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-08 20:36:28,030 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-06-08 20:36:28,030 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-06-08 20:36:28,030 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-06-08 20:36:28,030 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-06-08 20:36:28,031 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 15741 [junit] 2016-06-08 20:36:28,031 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 23 [junit] 2016-06-08 20:36:28,031 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-06-08 20:36:28,031 [myid:] - INFO [main:ClientBase@537] - tearDown starting [junit] 2016-06-08 20:36:28,100 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x18520b7 closed [junit] 2016-06-08 20:36:28,100 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x18520b7 [junit] 2016-06-08 20:36:28,100 [myid:] - INFO [main:ClientBase@507] - STOPPING server [junit] 2016-06-08 20:36:28,101 [myid:] - INFO
[jira] [Updated] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen updated ZOOKEEPER-2355: - Attachment: ZOOKEEPER-2355-03.patch Updated patch with Martin's proposed solution. > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch, > ZOOKEEPER-2355-03.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marshall McMullen reassigned ZOOKEEPER-2355: Assignee: Marshall McMullen (was: Arshad Mohammad) > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Marshall McMullen >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321334#comment-15321334 ] Martin Kuchta commented on ZOOKEEPER-2355: -- I've been playing with some variations on the proposed fix and trying to reason about what's actually going wrong. When syncing with the leader, of the three leader responses (DIFF, SNAP, TRUNC), I think there's only an issue with setting the last processed ZXID the way it's currently done in the DIFF case. In the SNAP and TRUNC cases, we've already deserialized the snapshot or truncated the log by the time setLastProcessedZxid is called. In the DIFF case, the reason it's incorrect is because we're setting the last processed ZXID as if we've already committed all the transactions we're about to receive, so a failure before that actually happens leaves us in an inconsistent state. The logic in the patch of moving the call to setLastProcessedZxid to when the follower receives UPTODATE or NEWLEADER makes sense to me, but this isn't consistent with the behavior expected by some of the other unit tests. I don't think setLastProcessedZxid needs to be explicitly called at all when the follower receives a DIFF message because we will update the last processed ZXID as we commit transactions received from the leader anyway. I do think it needs to be preserved as-is for SNAP and TRUNC to keep the currently expected behavior. Whether there are other problematic scenarios associated with how SNAP and TRUNC are processed can be investigated separately since there may still be cases where the last processed ZXID and the actual transaction log state are out of sync. I'm submitting a modified version of the patch provided by [~arshad.mohammad]. The patch includes his original unit test which still fails against trunk and passes with the patch, but the changes to Learner.java are the slightly different ones that I'm proposing. (I do have two unit tests failing locally that are also failing against trunk, so I think it's an unrelated issue with my environment that I'll need to look into when I get time. If that turns out to not be the case based on the Jenkins build, I'll investigate.) > Ephemeral node is never deleted if follower fails while reading the proposal > packet > --- > > Key: ZOOKEEPER-2355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2355 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Reporter: Arshad Mohammad >Assignee: Arshad Mohammad >Priority: Critical > Fix For: 3.4.9 > > Attachments: ZOOKEEPER-2355-01.patch, ZOOKEEPER-2355-02.patch > > > ZooKeeper ephemeral node is never deleted if follower fail while reading the > proposal packet > The scenario is as follows: > # Configure three node ZooKeeper cluster, lets say nodes are A, B and C, > start all, assume A is leader, B and C are follower > # Connect to any of the server and create ephemeral node /e1 > # Close the session, ephemeral node /e1 will go for deletion > # While receiving delete proposal make Follower B to fail with > {{SocketTimeoutException}}. This we need to do to reproduce the scenario > otherwise in production environment it happens because of network fault. > # Remove the fault, just check that faulted Follower is now connected with > quorum > # Connect to any of the server, create the same ephemeral node /e1, created > is success. > # Close the session, ephemeral node /e1 will go for deletion > # {color:red}/e1 is not deleted from the faulted Follower B, It should have > been deleted as it was again created with another session{color} > # {color:green}/e1 is deleted from Leader A and other Follower C{color} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_solaris - Build # 127 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_solaris/127/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 350348 lines...] [junit] 2016-06-08 19:11:58,679 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-08 19:11:58,679 [myid:] - INFO [main:ClientBase@460] - STARTING server [junit] 2016-06-08 19:11:58,680 [myid:] - INFO [main:ClientBase@380] - CREATING server instance 127.0.0.1:11222 [junit] 2016-06-08 19:11:58,680 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2016-06-08 19:11:58,681 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-06-08 19:11:58,682 [myid:] - INFO [main:ClientBase@355] - STARTING server instance 127.0.0.1:11222 [junit] 2016-06-08 19:11:58,682 [myid:] - INFO [main:ZooKeeperServer@858] - minSessionTimeout set to 6000 [junit] 2016-06-08 19:11:58,683 [myid:] - INFO [main:ZooKeeperServer@867] - maxSessionTimeout set to 6 [junit] 2016-06-08 19:11:58,683 [myid:] - INFO [main:ZooKeeperServer@156] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8766170667986612101.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8766170667986612101.junit.dir/version-2 [junit] 2016-06-08 19:11:58,684 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8766170667986612101.junit.dir/version-2/snapshot.b [junit] 2016-06-08 19:11:58,687 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8766170667986612101.junit.dir/version-2/snapshot.b [junit] 2016-06-08 19:11:58,689 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-06-08 19:11:58,690 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:47183 [junit] 2016-06-08 19:11:58,690 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:47183 [junit] 2016-06-08 19:11:58,691 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-06-08 19:11:58,691 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:47183 (no session established for client) [junit] 2016-06-08 19:11:58,691 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-08 19:11:58,693 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-06-08 19:11:58,693 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-06-08 19:11:58,693 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-06-08 19:11:58,693 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-06-08 19:11:58,694 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17736 [junit] 2016-06-08 19:11:58,694 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2016-06-08 19:11:58,694 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-06-08 19:11:58,694 [myid:] - INFO [main:ClientBase@537] - tearDown starting [junit] 2016-06-08 19:11:58,772 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x121ae6a9081 closed [junit] 2016-06-08 19:11:58,772 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x121ae6a9081 [junit] 2016-06-08 19:11:58,772 [myid:] - INFO [main:ClientBase@507] - STOPPING server [junit] 2016-06-08 19:11:58,773 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 19:11:58,773 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 19:11:58,773 [myid:] - INFO
ZooKeeper-trunk-solaris - Build # 1188 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1188/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 347456 lines...] [junit] 2016-06-08 17:17:33,582 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-08 17:17:33,583 [myid:] - INFO [main:ClientBase@460] - STARTING server [junit] 2016-06-08 17:17:33,584 [myid:] - INFO [main:ClientBase@380] - CREATING server instance 127.0.0.1:11222 [junit] 2016-06-08 17:17:33,584 [myid:] - INFO [main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2016-06-08 17:17:33,585 [myid:] - INFO [main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222 [junit] 2016-06-08 17:17:33,585 [myid:] - INFO [main:ClientBase@355] - STARTING server instance 127.0.0.1:11222 [junit] 2016-06-08 17:17:33,586 [myid:] - INFO [main:ZooKeeperServer@858] - minSessionTimeout set to 6000 [junit] 2016-06-08 17:17:33,586 [myid:] - INFO [main:ZooKeeperServer@867] - maxSessionTimeout set to 6 [junit] 2016-06-08 17:17:33,586 [myid:] - INFO [main:ZooKeeperServer@156] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5745037607644678587.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5745037607644678587.junit.dir/version-2 [junit] 2016-06-08 17:17:33,587 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5745037607644678587.junit.dir/version-2/snapshot.b [junit] 2016-06-08 17:17:33,589 [myid:] - INFO [main:FileTxnSnapLog@298] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5745037607644678587.junit.dir/version-2/snapshot.b [junit] 2016-06-08 17:17:33,591 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222 [junit] 2016-06-08 17:17:33,591 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:33299 [junit] 2016-06-08 17:17:33,592 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from /127.0.0.1:33299 [junit] 2016-06-08 17:17:33,592 [myid:] - INFO [NIOWorkerThread-1:StatCommand@49] - Stat command output [junit] 2016-06-08 17:17:33,593 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:33299 (no session established for client) [junit] 2016-06-08 17:17:33,593 [myid:] - INFO [main:JMXEnv@228] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-08 17:17:33,594 [myid:] - INFO [main:JMXEnv@245] - expect:InMemoryDataTree [junit] 2016-06-08 17:17:33,595 [myid:] - INFO [main:JMXEnv@249] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree [junit] 2016-06-08 17:17:33,595 [myid:] - INFO [main:JMXEnv@245] - expect:StandaloneServer_port [junit] 2016-06-08 17:17:33,595 [myid:] - INFO [main:JMXEnv@249] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11222 [junit] 2016-06-08 17:17:33,595 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17715 [junit] 2016-06-08 17:17:33,596 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24 [junit] 2016-06-08 17:17:33,596 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testQuota [junit] 2016-06-08 17:17:33,596 [myid:] - INFO [main:ClientBase@537] - tearDown starting [junit] 2016-06-08 17:17:33,672 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x121ae01cb51 closed [junit] 2016-06-08 17:17:33,672 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x121ae01cb51 [junit] 2016-06-08 17:17:33,672 [myid:] - INFO [main:ClientBase@507] - STOPPING server [junit] 2016-06-08 17:17:33,673 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2016-06-08 17:17:33,673 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 17:17:33,673 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] -
[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320859#comment-15320859 ] Hudson commented on ZOOKEEPER-2442: --- FAILURE: Integrated in ZooKeeper-trunk #2953 (See [https://builds.apache.org/job/ZooKeeper-trunk/2953/]) ZOOKEEPER-2442: Socket leak in QuorumCnxManager connectOne (Michael Han via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1747408]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > Socket leak in QuorumCnxManager connectOne > -- > > Key: ZOOKEEPER-2442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2442 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.5.1 >Reporter: Michael Han >Assignee: Michael Han > Attachments: ZOOKEEPER-2442.patch > > > The function connectOne() in QuorumCnxManager.java sometimes fails to release > a socket allocated by Socket(): > {code} > try { > if (LOG.isDebugEnabled()) { > LOG.debug("Opening channel to server " + sid); > } > Socket sock = new Socket(); > setSockOpts(sock); > sock.connect(self.getView().get(sid).electionAddr, cnxTO); > if (LOG.isDebugEnabled()) { > LOG.debug("Connected to server " + sid); > } > initiateConnection(sock, sid); > } catch (UnresolvedAddressException e) { > // Sun doesn't include the address that causes this > // exception to be thrown, also UAE cannot be wrapped cleanly > // so we log the exception in order to capture this critical > // detail. > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, e); > throw e; > } catch (IOException e) { > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, > e); > } > {code} > Another place in Listener.run() where the client socket is not explicitly > closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper-trunk - Build # 2953 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk/2953/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 380185 lines...] [junit] 2016-06-08 16:23:33,163 [myid:] - INFO [/127.0.0.1:11365:QuorumCnxManager$Listener@661] - Leaving listener [junit] 2016-06-08 16:23:33,163 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5,name2=Leader] [junit] 2016-06-08 16:23:33,162 [myid:] - WARN [LearnerHandler-/127.0.0.1:54604:LearnerHandler@903] - Ignoring unexpected exception [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1219) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:340) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:338) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2016-06-08 16:23:33,164 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled) [junit] 2016-06-08 16:23:33,163 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):QuorumPeer@1127] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1124) [junit] 2016-06-08 16:23:33,164 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):Leader@613] - Shutting down [junit] 2016-06-08 16:23:33,164 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):QuorumPeer@1158] - PeerState set to LOOKING [junit] 2016-06-08 16:23:33,164 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):QuorumPeer@1140] - QuorumPeer main thread exited [junit] 2016-06-08 16:23:33,164 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5] [junit] 2016-06-08 16:23:33,164 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled) to exit thread [junit] 2016-06-08 16:23:33,165 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5] [junit] 2016-06-08 16:23:33,165 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1] [junit] 2016-06-08 16:23:33,165 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2] [junit] 2016-06-08 16:23:33,165 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:11363)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3] [junit] 2016-06-08 16:23:33,165 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11351 [junit] 2016-06-08 16:23:33,166 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11351 is no longer accepting client connections [junit] 2016-06-08 16:23:33,166 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11354 [junit] 2016-06-08 16:23:33,166 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11354 is no longer accepting client connections [junit] 2016-06-08 16:23:33,167 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11357 [junit] 2016-06-08 16:23:33,167 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11357 is no longer accepting client connections [junit] 2016-06-08 16:23:33,167 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11360 [junit] 2016-06-08 16:23:33,167 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11360 is no longer accepting client connections [junit] 2016-06-08 16:23:33,168 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 11363 [junit] 2016-06-08 16:23:33,168 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:11363 is no longer accepting client connections [junit] 2016-06-08 16:23:33,169 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320828#comment-15320828 ] Michael Han commented on ZOOKEEPER-2442: Thanks [~rgs] for the code review and commit! > Socket leak in QuorumCnxManager connectOne > -- > > Key: ZOOKEEPER-2442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2442 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.5.1 >Reporter: Michael Han >Assignee: Michael Han > Attachments: ZOOKEEPER-2442.patch > > > The function connectOne() in QuorumCnxManager.java sometimes fails to release > a socket allocated by Socket(): > {code} > try { > if (LOG.isDebugEnabled()) { > LOG.debug("Opening channel to server " + sid); > } > Socket sock = new Socket(); > setSockOpts(sock); > sock.connect(self.getView().get(sid).electionAddr, cnxTO); > if (LOG.isDebugEnabled()) { > LOG.debug("Connected to server " + sid); > } > initiateConnection(sock, sid); > } catch (UnresolvedAddressException e) { > // Sun doesn't include the address that causes this > // exception to be thrown, also UAE cannot be wrapped cleanly > // so we log the exception in order to capture this critical > // detail. > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, e); > throw e; > } catch (IOException e) { > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, > e); > } > {code} > Another place in Listener.run() where the client socket is not explicitly > closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2137) Make testPortChange() less flaky
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320779#comment-15320779 ] Michael Han commented on ZOOKEEPER-2137: Yup I think you are right [~rgs], I could see one case where an existing writer node created by a different call of testNormalOperation (where the zk handles were shared between calls) can throw the exception that skip reader node creation - which might be the cause of the failure in previous pre-commit tests. > Make testPortChange() less flaky > > > Key: ZOOKEEPER-2137 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Hongchao Deng >Assignee: Michael Han > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch, > ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch > > > The cause of flaky failure of testPortChange() is a race in sync(). > I figured out it could take some time to fix sync(). Meanwhile, we can make > testPortChange() less flaky by doing reconfig on the leader. We can change > this back in the fix of ZOOKEEPER-2136. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320773#comment-15320773 ] Raul Gutierrez Segales commented on ZOOKEEPER-2442: --- Merged to trunk: https://github.com/apache/zookeeper/commit/3c37184e83a3e68b73544cebccf9388eea26f523 Waiting on [~cnauroth] for merging to the 3.5 branch. > Socket leak in QuorumCnxManager connectOne > -- > > Key: ZOOKEEPER-2442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2442 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.5.1 >Reporter: Michael Han >Assignee: Michael Han > Attachments: ZOOKEEPER-2442.patch > > > The function connectOne() in QuorumCnxManager.java sometimes fails to release > a socket allocated by Socket(): > {code} > try { > if (LOG.isDebugEnabled()) { > LOG.debug("Opening channel to server " + sid); > } > Socket sock = new Socket(); > setSockOpts(sock); > sock.connect(self.getView().get(sid).electionAddr, cnxTO); > if (LOG.isDebugEnabled()) { > LOG.debug("Connected to server " + sid); > } > initiateConnection(sock, sid); > } catch (UnresolvedAddressException e) { > // Sun doesn't include the address that causes this > // exception to be thrown, also UAE cannot be wrapped cleanly > // so we log the exception in order to capture this critical > // detail. > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, e); > throw e; > } catch (IOException e) { > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, > e); > } > {code} > Another place in Listener.run() where the client socket is not explicitly > closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320766#comment-15320766 ] Raul Gutierrez Segales commented on ZOOKEEPER-2442: --- Oh, forgot to mention, a super small nit for next time. In: {code} -if (LOG.isDebugEnabled()) { -LOG.debug("Opening channel to server " + sid); -} +LOG.debug("Opening channel to server " + sid); {code} I think for LOG statements using {} (extrapolation) instead of + (concatenation) reads nicer (specially for statements with multiple vars in them. > Socket leak in QuorumCnxManager connectOne > -- > > Key: ZOOKEEPER-2442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2442 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.5.1 >Reporter: Michael Han >Assignee: Michael Han > Attachments: ZOOKEEPER-2442.patch > > > The function connectOne() in QuorumCnxManager.java sometimes fails to release > a socket allocated by Socket(): > {code} > try { > if (LOG.isDebugEnabled()) { > LOG.debug("Opening channel to server " + sid); > } > Socket sock = new Socket(); > setSockOpts(sock); > sock.connect(self.getView().get(sid).electionAddr, cnxTO); > if (LOG.isDebugEnabled()) { > LOG.debug("Connected to server " + sid); > } > initiateConnection(sock, sid); > } catch (UnresolvedAddressException e) { > // Sun doesn't include the address that causes this > // exception to be thrown, also UAE cannot be wrapped cleanly > // so we log the exception in order to capture this critical > // detail. > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, e); > throw e; > } catch (IOException e) { > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, > e); > } > {code} > Another place in Listener.run() where the client socket is not explicitly > closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2442) Socket leak in QuorumCnxManager connectOne
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320763#comment-15320763 ] Raul Gutierrez Segales commented on ZOOKEEPER-2442: --- lgtm, +1 - thanks [~hanm]! Presumably we want this for trunk and 3.5.x, right? I'll merge to trunk first. cc: [~cnauroth] who is getting the next 3.5.x release ready. > Socket leak in QuorumCnxManager connectOne > -- > > Key: ZOOKEEPER-2442 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2442 > Project: ZooKeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.5.1 >Reporter: Michael Han >Assignee: Michael Han > Attachments: ZOOKEEPER-2442.patch > > > The function connectOne() in QuorumCnxManager.java sometimes fails to release > a socket allocated by Socket(): > {code} > try { > if (LOG.isDebugEnabled()) { > LOG.debug("Opening channel to server " + sid); > } > Socket sock = new Socket(); > setSockOpts(sock); > sock.connect(self.getView().get(sid).electionAddr, cnxTO); > if (LOG.isDebugEnabled()) { > LOG.debug("Connected to server " + sid); > } > initiateConnection(sock, sid); > } catch (UnresolvedAddressException e) { > // Sun doesn't include the address that causes this > // exception to be thrown, also UAE cannot be wrapped cleanly > // so we log the exception in order to capture this critical > // detail. > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, e); > throw e; > } catch (IOException e) { > LOG.warn("Cannot open channel to " + sid > + " at election address " + electionAddr, > e); > } > {code} > Another place in Listener.run() where the client socket is not explicitly > closed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Zookeeper 3.4.8 is bundled with old version of Netty:jar
On 7 June 2016 at 18:48, Patrick Huntwrote: > There is a jira for this already. Someone want to drive this one? > > https://issues.apache.org/jira/browse/ZOOKEEPER-2399 So are we good in the 3.4 branch after: https://github.com/apache/zookeeper/commit/f0a49567d545bd6584cb8ece2d491dc6c65174f8 or would we still need to backup netty 4.x support to that branch (eventually)? -rgs > > > Patrick > > On Mon, Jun 6, 2016 at 1:51 PM, Michael Han wrote: > > > FYI branch 3.4 was recently patched with Netty 3.10 to address some of > the > > security concerns as described in ZOOKEEPER-2423: Upgrade Netty version > due > > to security vulnerability. > > > > > > > https://github.com/apache/zookeeper/commit/f0a49567d545bd6584cb8ece2d491dc6c65174f8 > > > > > > > > > > On Mon, Jun 6, 2016 at 1:38 PM, Hegde, Pallavi > > wrote: > > > > > Hello, > > > We are currently facing some security issues with Zookeeper version > 3.4.7 > > > & 3.4.8, since its bundled with very old version of Netty:jar, version > > > 3.7.0. > > > Could you address this issue in future Zookeeper releases by packaging > it > > > with Netty.jar-4.0.27, or higher version of Netty:jar? I am sure this > > will > > > help many other issues including security violations. > > > > > > Thanks > > > Pallavi > > > > > > > > > > > > -- > > Cheers > > Michael. > > >
[jira] [Commented] (ZOOKEEPER-2137) Make testPortChange() less flaky
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320742#comment-15320742 ] Raul Gutierrez Segales commented on ZOOKEEPER-2137: --- In: {code} public static void testNormalOperation(ZooKeeper writer, ZooKeeper reader) try{ writer.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT); + reader.create("/dummy", "dummy".getBytes(), + ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT); } catch (KeeperException.NodeExistsException e) { } {code} don't you want *each* create() call to be independently wrapped within a try/catch NodeExistsException to ensure both writer and reader have an updated view of the world? > Make testPortChange() less flaky > > > Key: ZOOKEEPER-2137 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Hongchao Deng >Assignee: Michael Han > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch, > ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch > > > The cause of flaky failure of testPortChange() is a race in sync(). > I figured out it could take some time to fix sync(). Meanwhile, we can make > testPortChange() less flaky by doing reconfig on the leader. We can change > this back in the fix of ZOOKEEPER-2136. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch34_openjdk7 - Build # 1102 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1102/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 219726 lines...] [junit] 2016-06-08 15:23:16,648 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-06-08 15:23:16,648 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-08 15:23:16,648 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-08 15:23:16,649 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - NIOServerCnxn factory exited run method [junit] 2016-06-08 15:23:16,649 [myid:] - INFO [main:ZooKeeperServer@469] - shutting down [junit] 2016-06-08 15:23:16,649 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2016-06-08 15:23:16,649 [myid:] - INFO [main:PrepRequestProcessor@765] - Shutting down [junit] 2016-06-08 15:23:16,650 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2016-06-08 15:23:16,650 [myid:] - INFO [ProcessThread(sid:0 cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2016-06-08 15:23:16,650 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2016-06-08 15:23:16,650 [myid:] - INFO [main:FinalRequestProcessor@402] - shutdown of request processor complete [junit] 2016-06-08 15:23:16,651 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-08 15:23:16,652 [myid:] - INFO [main:JMXEnv@146] - ensureOnly:[] [junit] 2016-06-08 15:23:16,653 [myid:] - INFO [main:ClientBase@443] - STARTING server [junit] 2016-06-08 15:23:16,654 [myid:] - INFO [main:ClientBase@364] - CREATING server instance 127.0.0.1:11221 [junit] 2016-06-08 15:23:16,654 [myid:] - INFO [main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2016-06-08 15:23:16,654 [myid:] - INFO [main:ClientBase@339] - STARTING server instance 127.0.0.1:11221 [junit] 2016-06-08 15:23:16,655 [myid:] - INFO [main:ZooKeeperServer@170] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test2048004010189009638.junit.dir/version-2 snapdir /x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/branch-3.4/build/test/tmp/test2048004010189009638.junit.dir/version-2 [junit] 2016-06-08 15:23:16,660 [myid:] - INFO [main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221 [junit] 2016-06-08 15:23:16,660 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - Accepted socket connection from /127.0.0.1:51244 [junit] 2016-06-08 15:23:16,661 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing stat command from /127.0.0.1:51244 [junit] 2016-06-08 15:23:16,661 [myid:] - INFO [Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output [junit] 2016-06-08 15:23:16,662 [myid:] - INFO [Thread-4:NIOServerCnxn@1008] - Closed socket connection for client /127.0.0.1:51244 (no session established for client) [junit] 2016-06-08 15:23:16,662 [myid:] - INFO [main:JMXEnv@229] - ensureParent:[InMemoryDataTree, StandaloneServer_port] [junit] 2016-06-08 15:23:16,664 [myid:] - INFO [main:JMXEnv@246] - expect:InMemoryDataTree [junit] 2016-06-08 15:23:16,665 [myid:] - INFO [main:JMXEnv@250] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree [junit] 2016-06-08 15:23:16,665 [myid:] - INFO [main:JMXEnv@246] - expect:StandaloneServer_port [junit] 2016-06-08 15:23:16,665 [myid:] - INFO [main:JMXEnv@250] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port11221 [junit] 2016-06-08 15:23:16,666 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 26415 [junit] 2016-06-08 15:23:16,666 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20 [junit] 2016-06-08 15:23:16,666 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota [junit] 2016-06-08 15:23:16,666 [myid:] - INFO [main:ClientBase@520] - tearDown starting [junit] 2016-06-08 15:23:16,735 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x155309c47d7 closed [junit] 2016-06-08 15:23:16,735 [myid:] - INFO [main:ClientBase@490] - STOPPING server [junit] 2016-06-08 15:23:16,735 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for session: 0x155309c47d7 [junit] 2016-06-08 15:23:16,736 [myid:] - INFO
[jira] [Commented] (ZOOKEEPER-2445) Add a new node to cluster, error config file but sucessed
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320645#comment-15320645 ] Alexander Shraer commented on ZOOKEEPER-2445: - First if you're interested in adding/removing nodes, consider using 3.5 release and the reconfiguration API. https://zookeeper.apache.org/doc/trunk/zookeeperReconfig.html > the server does not match with the serverid which server ? the new one ? I don't really understand what you mean here. Could you paste here the configuration file of the new server, and its myid. But essentially, the server is only supposed to make sure that myid appears in the configuration file (when booting), not much more than that. What check would you expect ? > Add a new node to cluster, error config file but sucessed > - > > Key: ZOOKEEPER-2445 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2445 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.6 > Environment: Centos 6.5 JDK7 >Reporter: Ahaha >Priority: Critical > Original Estimate: 24h > Remaining Estimate: 24h > > I want to add a new node to a test cluster with three node. So I tried with > the folling steps: 1. I copied one foller zookeeper directory, and edit > clientPort, dataDir , logDir, myid file, and then add a new record > server.newId=hostname:newPort:newEPort into zoo.cfg, for test I keep the > leader configuration there and remove the other two configuration, I tested > ,this failed. So I open the zoo.cfg , copied the lead configuration line just > edit the serverId, and this should be a wrong configuration file as the > server does not match with the serverid. But strangely , it successed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_jdk8 - Build # 112 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/112/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 372328 lines...] [junit] 2016-06-08 11:56:10,408 [myid:] - WARN [LearnerHandler-/127.0.0.1:57666:LearnerHandler@903] - Ignoring unexpected exception [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1220) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:335) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:339) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2016-06-08 11:56:10,408 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2016-06-08 11:56:10,409 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:/127.0.0.1:19442:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2016-06-08 11:56:10,409 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 11:56:10,409 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 11:56:10,411 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5,name2=Leader] [junit] 2016-06-08 11:56:10,411 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):QuorumPeer@1127] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1124) [junit] 2016-06-08 11:56:10,411 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):Leader@613] - Shutting down [junit] 2016-06-08 11:56:10,412 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):QuorumPeer@1158] - PeerState set to LOOKING [junit] 2016-06-08 11:56:10,412 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):QuorumPeer@1140] - QuorumPeer main thread exited [junit] 2016-06-08 11:56:10,411 [myid:] - INFO [/127.0.0.1:19444:QuorumCnxManager$Listener@659] - Leaving listener [junit] 2016-06-08 11:56:10,412 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5] [junit] 2016-06-08 11:56:10,412 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5] [junit] 2016-06-08 11:56:10,413 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled) [junit] 2016-06-08 11:56:10,413 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1] [junit] 2016-06-08 11:56:10,413 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled) to exit thread [junit] 2016-06-08 11:56:10,413 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2] [junit] 2016-06-08 11:56:10,413 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:19442)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3] [junit] 2016-06-08 11:56:10,414 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 19430 [junit] 2016-06-08 11:56:10,414 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:19430 is no longer accepting client connections [junit] 2016-06-08 11:56:10,414 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 19433 [junit] 2016-06-08 11:56:10,414 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:19433 is no longer accepting client connections [junit] 2016-06-08 11:56:10,415 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 19436 [junit]
ZooKeeper-trunk-jdk8 - Build # 627 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/627/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 368255 lines...] [junit] 2016-06-08 11:50:23,515 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:24828)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5] [junit] 2016-06-08 11:50:23,516 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:24828)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1] [junit] 2016-06-08 11:50:23,516 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:24828)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2] [junit] 2016-06-08 11:50:23,516 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:24828)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3] [junit] 2016-06-08 11:50:23,516 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24816 [junit] 2016-06-08 11:50:23,517 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:24816 is no longer accepting client connections [junit] 2016-06-08 11:50:23,517 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24819 [junit] 2016-06-08 11:50:23,517 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:24819 is no longer accepting client connections [junit] 2016-06-08 11:50:23,517 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24822 [junit] 2016-06-08 11:50:23,518 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:24822 is no longer accepting client connections [junit] 2016-06-08 11:50:23,518 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24825 [junit] 2016-06-08 11:50:23,518 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:24825 is no longer accepting client connections [junit] 2016-06-08 11:50:23,518 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 24828 [junit] 2016-06-08 11:50:23,518 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:24828 is no longer accepting client connections [junit] 2016-06-08 11:50:23,522 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testRemoveOneAsynchronous [junit] 2016-06-08 11:50:23,522 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testRemoveOneAsynchronous [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 120.282 sec, Thread: 6, Class: org.apache.zookeeper.test.ReconfigTest [junit] 2016-06-08 11:50:23,631 [myid:127.0.0.1:24725] - INFO [main-SendThread(127.0.0.1:24725):ClientCnxn$SendThread@1113] - Opening socket connection to server 127.0.0.1/127.0.0.1:24725. Will not attempt to authenticate using SASL (unknown error) [junit] 2016-06-08 11:50:23,631 [myid:127.0.0.1:24725] - WARN [main-SendThread(127.0.0.1:24725):ClientCnxn$SendThread@1235] - Session 0x101be286590 for server 127.0.0.1/127.0.0.1:24725, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:712) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214) [junit] 2016-06-08 11:50:23,638 [myid:] - INFO [ProcessThread(sid:0 cport:22074)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x101be293d7d [junit] 2016-06-08 11:50:23,639 [myid:] - INFO [SyncThread:0:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port22074,name1=Connections,name2=127.0.0.1,name3=0x101be293d7d] [junit] 2016-06-08 11:50:23,639 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x101be293d7d [junit] 2016-06-08 11:50:23,639 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x101be293d7d closed [junit] 2016-06-08 11:50:23,641 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 16661 [junit] 2016-06-08 11:50:23,641 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 51 [junit] 2016-06-08 11:50:23,641 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testWatcherAutoResetWithLocal [junit] 2016-06-08 11:50:23,641 [myid:] - INFO [main:ClientBase@537] - tearDown starting [junit] 2016-06-08 11:50:23,641 [myid:] - INFO [main:ClientBase@507] - STOPPING server
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320352#comment-15320352 ] Sergio Fernández commented on ZOOKEEPER-2446: - Right, then this duplicates ZOOKEEPER-2373. I reported it because I didn't see any current snapshot pushed to https://repository.apache.org/content/groups/snapshots/org/apache/zookeeper/zookeeper/ with that issue fixed. > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Fernández resolved ZOOKEEPER-2446. - Resolution: Duplicate > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320349#comment-15320349 ] Flavio Junqueira commented on ZOOKEEPER-2446: - Ah, I see. I thought we had solved it in ZOOKEEPER-2373, is it where we broke it? > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320335#comment-15320335 ] Sergio Fernández commented on ZOOKEEPER-2446: - Well, license header would be something else. What I'm reporting here is the lack of license field in the {{pom.xml}}: https://maven.apache.org/pom.html#Licenses That field is used in Maven to declare the license of the artifact. As I said, it's weird, because it is already in the custom template: https://github.com/apache/zookeeper/blob/trunk/src/pom.template#L35 So I guess the actual source of the issue is that the custom template is not being used by the {{ivi:makepom}} Ant tasks. > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320330#comment-15320330 ] Flavio Junqueira commented on ZOOKEEPER-2446: - Thanks [~wikier] for reporting this issue. I wonder if we need a license header since it is a generated file. We can definitely update the fields you're suggesting, do you want to take a crack at it? > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320326#comment-15320326 ] Sergio Fernández commented on ZOOKEEPER-2446: - Definitely that template is not being used... the generated {{pom.xml}} files also miss some other fields, such as {{}} or {{}}. > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320324#comment-15320324 ] Sergio Fernández commented on ZOOKEEPER-2446: - It's weird... because I took a look and the {{ivi:makepom}} tasks uses a template file with the {{}} hardcoded there: https://github.com/apache/zookeeper/blob/trunk/src/pom.template#L35 > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_openjdk7 - Build # 110 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/110/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 391959 lines...] [junit] 2016-06-08 10:05:12,799 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:27521)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.4] [junit] 2016-06-08 10:05:12,800 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27509 [junit] 2016-06-08 10:05:12,800 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27509 is no longer accepting client connections [junit] 2016-06-08 10:05:12,800 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27512 [junit] 2016-06-08 10:05:12,801 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27512 is no longer accepting client connections [junit] 2016-06-08 10:05:12,801 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27515 [junit] 2016-06-08 10:05:12,801 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27515 is no longer accepting client connections [junit] 2016-06-08 10:05:12,801 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27518 [junit] 2016-06-08 10:05:12,801 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27518 is no longer accepting client connections [junit] 2016-06-08 10:05:12,802 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 27521 [junit] 2016-06-08 10:05:12,802 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27521 is no longer accepting client connections [junit] 2016-06-08 10:05:12,803 [myid:] - INFO [main:ZKTestCase$1@65] - SUCCEEDED testRemoveOneAsynchronous [junit] 2016-06-08 10:05:12,803 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testRemoveOneAsynchronous [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 126.971 sec, Thread: 7, Class: org.apache.zookeeper.test.ReconfigTest [junit] 2016-06-08 10:05:34,094 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 29316 [junit] 2016-06-08 10:05:34,095 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55 [junit] 2016-06-08 10:05:34,095 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD testManyChildWatchersAutoReset [junit] 2016-06-08 10:05:34,095 [myid:] - INFO [main:ClientBase@537] - tearDown starting [junit] 2016-06-08 10:05:34,095 [myid:] - INFO [ProcessThread(sid:0 cport:16611)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x10088a9476e [junit] 2016-06-08 10:05:34,103 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x10088a9476e [junit] 2016-06-08 10:05:34,103 [myid:] - INFO [NIOWorkerThread-24:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x10088a9476e] [junit] 2016-06-08 10:05:34,103 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x10088a9476e closed [junit] 2016-06-08 10:05:34,104 [myid:] - INFO [NIOWorkerThread-24:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:52372 which had sessionid 0x10088a9476e [junit] 2016-06-08 10:05:34,105 [myid:] - INFO [ProcessThread(sid:0 cport:16611)::PrepRequestProcessor@647] - Processed session termination for sessionid: 0x10088a9476e0001 [junit] 2016-06-08 10:05:34,111 [myid:] - INFO [main:ZooKeeper@1313] - Session: 0x10088a9476e0001 closed [junit] 2016-06-08 10:05:34,111 [myid:] - INFO [main:ClientBase@507] - STOPPING server [junit] 2016-06-08 10:05:34,111 [myid:] - INFO [NIOWorkerThread-25:MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16611,name1=Connections,name2=127.0.0.1,name3=0x10088a9476e0001] [junit] 2016-06-08 10:05:34,112 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2016-06-08 10:05:34,111 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for session: 0x10088a9476e0001 [junit] 2016-06-08 10:05:34,112 [myid:] - INFO [NIOWorkerThread-25:NIOServerCnxn@607] - Closed socket connection for client /127.0.0.1:52407 which had sessionid 0x10088a9476e0001 [junit] 2016-06-08 10:05:34,114 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:16611:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2016-06-08 10:05:34,115 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 10:05:34,115 [myid:] -
[jira] [Updated] (ZOOKEEPER-2446) License missing in the pom.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Fernández updated ZOOKEEPER-2446: Labels: maven (was: ) > License missing in the pom.xml > -- > > Key: ZOOKEEPER-2446 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.8 >Reporter: Sergio Fernández >Priority: Critical > Labels: maven > > Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized > the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} > branch, e.g., > https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ZOOKEEPER-2446) License missing in the pom.xml
Sergio Fernández created ZOOKEEPER-2446: --- Summary: License missing in the pom.xml Key: ZOOKEEPER-2446 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2446 Project: ZooKeeper Issue Type: Bug Components: build Affects Versions: 3.4.8 Reporter: Sergio Fernández Priority: Critical Assembling a {{NOTICE}} file in a project that uses Zookeeper I've realized the {{pom.xml}} does not declare the license, at least in the whole {{3.4.x}} branch, e.g., https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Synchronous version of ZooKeeper::sync() API
Our intention with sync at the time was to have an operation that in combination with a read gives us linearizable semantics. As it is discussed in the jira, if there is out-of-band communication, then a client can get a stale result for a read. The sync op was made async *only* because we wanted to have the operation open or ongoing while issuing the read. If the sync is synchronous, then it will have returned by the time you submit the read. Making the sync call asynchronous clearly doesn't prevent zookeeper from processing the sync before the read, but it has the advantage of not blocking the read which is the operation you're really interested in. Also, even if you're using the sync api for the core operations, you can still call sync asynchronously and it will have the same effect. I don't see a strong reason for adding a synchronous sync, and we should really encourage the use of asynchronous sync and not have a synchronous version of sync, but let me know if I'm missing something important. -Flavio > On 07 Jun 2016, at 23:49, Marshall McMullen> wrote: > > https://issues.apache.org/jira/browse/ZOOKEEPER-1167 > > On Tue, Jun 7, 2016 at 4:46 PM, Michael Han wrote: > >> Hi devs, >> >> Currently ZooKeeper::sync() API only has an asynchronous version: >> >> public void sync(String >> < >> http://docs.oracle.com/javase/6/docs/api/java/lang/String.html?is-external=true >>> >> path, >> AsyncCallback.VoidCallback >> < >> https://zookeeper.apache.org/doc/r3.5.1-alpha/api/org/apache/zookeeper/AsyncCallback.VoidCallback.html >>> >> cb, >> Object >> < >> http://docs.oracle.com/javase/6/docs/api/java/lang/Object.html?is-external=true >>> >> ctx) >> >> Asynchronous sync. Flushes channel between process and leader. >> >> Given that all other existing APIs have both sync and async version, should >> we also have a synchronous version of the "sync()" API? >> >> -- >> Cheers >> Michael. >>
[jira] [Created] (ZOOKEEPER-2445) Add a new node to cluster, error config file but sucessed
Ahaha created ZOOKEEPER-2445: Summary: Add a new node to cluster, error config file but sucessed Key: ZOOKEEPER-2445 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2445 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.6 Environment: Centos 6.5 JDK7 Reporter: Ahaha Priority: Critical I want to add a new node to a test cluster with three node. So I tried with the folling steps: 1. I copied one foller zookeeper directory, and edit clientPort, dataDir , logDir, myid file, and then add a new record server.newId=hostname:newPort:newEPort into zoo.cfg, for test I keep the leader configuration there and remove the other two configuration, I tested ,this failed. So I open the zoo.cfg , copied the lead configuration line just edit the serverId, and this should be a wrong configuration file as the server does not match with the serverid. But strangely , it successed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
ZooKeeper_branch35_jdk7 - Build # 544 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/544/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 370878 lines...] [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2016-06-08 08:44:26,706 [myid:] - WARN [LearnerHandler-/127.0.0.1:52838:LearnerHandler@903] - Ignoring unexpected exception [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1219) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:340) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:338) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2016-06-08 08:44:26,708 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2016-06-08 08:44:26,709 [myid:] - INFO [/127.0.0.1:22137:QuorumCnxManager$Listener@659] - Leaving listener [junit] 2016-06-08 08:44:26,709 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5,name2=Leader] [junit] 2016-06-08 08:44:26,710 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):QuorumPeer@1127] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1124) [junit] 2016-06-08 08:44:26,710 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled) [junit] 2016-06-08 08:44:26,711 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled) to exit thread [junit] 2016-06-08 08:44:26,710 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):Leader@613] - Shutting down [junit] 2016-06-08 08:44:26,711 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):QuorumPeer@1158] - PeerState set to LOOKING [junit] 2016-06-08 08:44:26,711 [myid:] - WARN [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):QuorumPeer@1140] - QuorumPeer main thread exited [junit] 2016-06-08 08:44:26,711 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5] [junit] 2016-06-08 08:44:26,712 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.5] [junit] 2016-06-08 08:44:26,712 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.1] [junit] 2016-06-08 08:44:26,712 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.2] [junit] 2016-06-08 08:44:26,712 [myid:] - INFO [QuorumPeer[myid=5](plain=/127.0.0.1:22135)(secure=disabled):MBeanRegistry@128] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id5,name1=replica.3] [junit] 2016-06-08 08:44:26,712 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 22123 [junit] 2016-06-08 08:44:26,713 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:22123 is no longer accepting client connections [junit] 2016-06-08 08:44:26,713 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 22126 [junit] 2016-06-08 08:44:26,713 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:22126 is no longer accepting client connections [junit] 2016-06-08 08:44:26,713 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 22129 [junit] 2016-06-08 08:44:26,714 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:22129 is no longer accepting client connections [junit] 2016-06-08 08:44:26,714 [myid:] - INFO [main:FourLetterWordMain@85] - connecting to 127.0.0.1 22132 [junit] 2016-06-08 08:44:26,714 [myid:] - INFO [main:QuorumUtil@243] -
[jira] [Updated] (ZOOKEEPER-1045) Quorum Peer mutual authentication
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1045: Fix Version/s: 3.5.3 3.4.9 > Quorum Peer mutual authentication > - > > Key: ZOOKEEPER-1045 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Eugene Koontz >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.9, 3.5.3 > > Attachments: 0001-ZOOKEEPER-1045-br-3-4.patch, > 1045_failing_phunt.tar.gz, ZK-1045-test-case-failure-logs.zip, > ZOOKEEPER-1045-00.patch, ZOOKEEPER-1045-Rolling Upgrade Design Proposal.pdf, > ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch, > ZOOKEEPER-1045-br-3-4.patch, ZOOKEEPER-1045-br-3-4.patch > > > ZOOKEEPER-938 addresses mutual authentication between clients and servers. > This bug, on the other hand, is for authentication among quorum peers. > Hopefully much of the work done on SASL integration with Zookeeper for > ZOOKEEPER-938 can be used as a foundation for this enhancement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2137) Make testPortChange() less flaky
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320055#comment-15320055 ] Michael Han commented on ZOOKEEPER-2137: Thanks for the tip, the failure is not from testPortChange but from ReconfigFailureCasesTest.testObserverToParticipantConversionFails which uses testNormalOperation, and it looks like caused by what you said. Will check it out later. > Make testPortChange() less flaky > > > Key: ZOOKEEPER-2137 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2137 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Hongchao Deng >Assignee: Michael Han > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2137-cb.patch, ZOOKEEPER-2137.patch, > ZOOKEEPER-2137.patch, ZOOKEEPER-2137.patch > > > The cause of flaky failure of testPortChange() is a race in sync(). > I figured out it could take some time to fix sync(). Meanwhile, we can make > testPortChange() less flaky by doing reconfig on the leader. We can change > this back in the fix of ZOOKEEPER-2136. -- This message was sent by Atlassian JIRA (v6.3.4#6332)