Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205527457
--- Diff: src/java/test/org/apache/zookeeper/test/TxnLogSizeLimitTest.java
---
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205526853
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205526028
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -127,14 +127,11 @@
Long logSize =
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205525593
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -109,7 +109,7 @@
*
* The feature is disabled
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/119
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/578
committed to 3.6/3.5. thanks @lvfangmin !
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3097.
Resolution: Fixed
Fix Version/s: 3.5.5
Issue resolved by pull request 578
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/578
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/119
committed to 3.6/3.5. thanks @arshadmohammad !
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-3094:
---
Fix Version/s: 3.4.14
> Make BufferSizeTest reliable
>
>
>
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/577
committed to 3.4, 3.5, 3.6. thanks @mjeelanimsft !
---
Github user mjeelanimsft commented on the issue:
https://github.com/apache/zookeeper/pull/577
Thanks for accepting and merging @hanm !
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/560
+1 i approve. thanx for handling the commit @hanm !
---
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/565
+1 let's make this happen
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/555#discussion_r205669958
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid,
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2004/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 78.39 MB...]
[exec] +1
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/584
i'm not sure this is an issue. there is a single thread
(FileRequestProcessor) that does all the mutations, so i don't think there is a
race here. there might be a race in other places, but we need
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666190
--- Diff: src/c/tests/TestClient.cc ---
@@ -325,7 +326,17 @@ class Zookeeper_simpleSystem : public
CPPUNIT_NS::TestFixture
CPPUNIT_ASSERT(zk
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666180
--- Diff: src/c/src/zookeeper.c ---
@@ -842,11 +842,16 @@ static int resolve_hosts(const zhandle_t *zh, const
char *hosts_in, addrvec_t *a
}
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2003/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 79.45 MB...]
[exec] +1
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/548
+1 i'll kick jenkins
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/584
This is good enough to make the ephemerals thread safe in DataTree, if it's
being called in multiple thread, the code you touched here may add ephemerals
which is just removed in killSession.
See https://builds.apache.org/job/ZooKeeper-trunk/120/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 142.77 KB...]
[junit] Running
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559123#comment-16559123
]
yang hao commented on ZOOKEEPER-3105:
-
[~maoling]
do you test it on python3?
in my test,
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667305
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,20 @@
/** Maximum time we allow for elapsed
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667420
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/567#discussion_r205667343
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -102,6 +102,21 @@
/** Maximum time we allow for elapsed
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar i think fixing whitespace is good if it is in proximity of the
code you are changing, which i think is the case in this diff.
the logic looks good to me! thanx @lvfangmin !
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/573
i'll kick it again and see if it works.
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666254
--- Diff: src/c/tests/zkServer.sh ---
@@ -77,7 +77,7 @@ fi
if [ "x${base_dir}" == "x" ]
then
-zk_base="../../"
+zk_base="../../../"
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/579#discussion_r205666234
--- Diff: src/c/tests/zkServer.sh ---
@@ -77,7 +77,7 @@ fi
if [ "x${base_dir}" == "x" ]
then
-zk_base="../../"
+zk_base="../../../"
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/566
i agree with @maoling, logging it with every warning seems overkill. the
rest of the change looks great though. are you ok with removing the extra words
in the log message?
---
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/563#discussion_r205668951
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -1128,9 +1128,9 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205332227
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
---
@@ -19,6 +19,8 @@
import
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205340493
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205331145
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -72,7 +72,7 @@
static final File BASETEST =
new
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205340787
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205331482
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumBase.java ---
@@ -53,32 +53,32 @@
protected int port3;
protected int port4;
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205339992
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/544
committed to 3.4, thanks @lujiefsi !
Please close this pull request.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-3009:
---
Fix Version/s: 3.4.14
> Potential NPE in NIOServerCnxnFactory
>
Github user lujiefsi closed the pull request at:
https://github.com/apache/zookeeper/pull/544
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2002/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.93 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558929#comment-16558929
]
Kevin Lu commented on ZOOKEEPER-3036:
-
[~o...@coralogix.com] did you get this resolved? We ran
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205636796
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java ---
@@ -101,33 +100,44 @@ public boolean isGlobalSession(long
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205629046
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java ---
@@ -85,31 +85,43 @@ public boolean isGlobalSession(long sessionId)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205636550
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
@@ -47,21 +47,20 @@
long createSession(int sessionTimeout);
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r205630231
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +275,11 @@ public synchronized boolean addSession(long id, int
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559223#comment-16559223
]
Hudson commented on ZOOKEEPER-2251:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #122 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559222#comment-16559222
]
Hudson commented on ZOOKEEPER-3097:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #122 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559224#comment-16559224
]
Hudson commented on ZOOKEEPER-3094:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #122 (See
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/585
wow! what's going on with this patch? it's huge?
---
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/577
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3094.
Resolution: Fixed
Fix Version/s: 3.5.5
Issue resolved by pull request 577
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205663822
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558498#comment-16558498
]
maoling commented on ZOOKEEPER-3105:
[~lordofkey]
It's a zkpython snippet which cannot reproduce
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559204#comment-16559204
]
maoling commented on ZOOKEEPER-3105:
[~lordofkey]
sorry I test it with python2.will test with
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205662651
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
factory)
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/560#discussion_r205659448
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -399,8 +399,30 @@ public void save(DataTree dataTree,
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/1/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by user phunt
[EnvInject] - Loading node environment
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205663866
--- Diff:
src/java/test/org/apache/zookeeper/server/persistence/UtilTest.java ---
@@ -0,0 +1,91 @@
+/**
--- End diff --
did you mean for
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1058/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.39 KB...]
[junit] Running
yang hao created ZOOKEEPER-3105:
---
Summary: Character coding problem occur when create a node using
python3
Key: ZOOKEEPER-3105
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3105
Project:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558353#comment-16558353
]
Edward Ribeiro commented on ZOOKEEPER-3105:
---
Could you please post a code snippet that
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm ? @breed ? @phunt ?
---
GitHub user lordofkey opened a pull request:
https://github.com/apache/zookeeper/pull/585
Zookeeper 3105:Character coding problem occur when create a node using
python3
when creating a node using python3, InvalidACLException occurs all the
time. it`s caused by imcompatible way of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558447#comment-16558447
]
yang hao commented on ZOOKEEPER-3105:
-
{code:java}
import zookeeper
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/583
@nkalmar I can remove the white space in this diff, it do looks much
cleaner after we remove the space though.
Do you know how often we need to ask people to format their code (remove
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/583
@lvfangmin discard your vim,embrace IEDA(smirk)
---
69 matches
Mail list logo
