Github user gmcdonald commented on the issue:
https://github.com/apache/zookeeper/pull/588
trigger jenkins with a comment ?
---
Github user gmcdonald commented on the issue:
https://github.com/apache/zookeeper/pull/588
take 2, trigger PR to Jenkins
---
Github user tamaashu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207521296
--- Diff:
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java ---
@@ -39,27 +44,44 @@ public void testMultipleServersChrootPath(){
ping
Il giorno mar 24 lug 2018 alle ore 13:03 Enrico Olivelli <
eolive...@gmail.com> ha scritto:
> Hi,
> I have started drafting an API for the new Metrics system.
>
> The idea is to design a common API to be implemented by a "Metrics
> Provider".
>
> This way we will instrument ZooKeeper code
Recently I've learned *zookeeper* standalone server souce code, now I know
each request will process by *PrepRequestProcessor* ->
*SyncRequestProcessor* -> *FinalRequestProcessor*, I found that
*PrepRequestProcessor* will create a *changeRecord* and put it into
*outstandingChanges* and
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207535136
--- Diff:
src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java ---
@@ -39,27 +44,44 @@ public void testMultipleServersChrootPath(){
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207597400
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
startForwarding(LearnerHandler
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207596633
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
startForwarding(LearnerHandler
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207597633
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
@@ -86,6 +86,7 @@
QuorumCnxManager manager;
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/586#discussion_r207599621
--- Diff: src/contrib/zkpython/src/c/zookeeper.c ---
@@ -387,8 +387,8 @@ int parse_acls(struct ACL_vector *acls, PyObject
*pyacls)
PyObject *perms
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/583
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/447
@hanm is the new change looks good to you?
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/588
@gmcdonald what does "take 2, trigger PR to Jenkins" mean? Used to trigger
PR to Jenkins? Any action item I need to take of?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reassigned ZOOKEEPER-1177:
-
Assignee: Fangmin Lv (was: Thawan Kooburat)
Take over this Jira, have implemented
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207613222
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207604144
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/588#discussion_r207605164
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1165,6 +1165,58 @@ synchronized public long
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Reed resolved ZOOKEEPER-3104.
--
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 583
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611316
--- Diff: src/java/main/org/apache/zookeeper/metrics/Counter.java ---
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611064
--- Diff: src/java/main/org/apache/zookeeper/metrics/Gauge.java ---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/582#discussion_r207611617
--- Diff: src/java/main/org/apache/zookeeper/metrics/MetricsContext.java ---
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568533#comment-16568533
]
Hudson commented on ZOOKEEPER-3104:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #133 (See
Github user jtuple commented on the issue:
https://github.com/apache/zookeeper/pull/580
I'm happy to add tests for `AvgMinMaxCounter` and `SimpleCounter`, will go
ahead and update this PR today to include that for completeness. Since it's
easy change to make while we discuss any
Github user jtuple commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/580#discussion_r207633573
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -271,7 +271,7 @@ private boolean checkFourLetterWord(final Channel
24 matches
Mail list logo
