[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217741801 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217739881 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) { //

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217743312 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt = null;

Success: ZOOKEEPER- PreCommit Build #2171

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2171/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.35 MB...] [exec] +1

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-14 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/622 Okay to enable by default on 3.6 ---

[jira] [Commented] (ZOOKEEPER-3148) Fix Kerberos tests on branch 3.4 and JDK11

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614997#comment-16614997 ] Hadoop QA commented on ZOOKEEPER-3148: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #2172

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2172/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.41 MB...] [exec] +1

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217763082 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java --- @@ -83,7 +83,7 @@ public QuorumMaj(Properties props) throws

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217770370 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217769719 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/622 @anmolnar @eolivelli thanks for review. About the switch, I think we can enable it by default, I'll make that change. But I think it's better to keep the switch, it's easier to turn off if

[GitHub] zookeeper pull request #626: ZOOKEEPER-3148 Add Kerberos tests for modern JD...

2018-09-14 Thread eolivelli
GitHub user eolivelli opened a pull request: https://github.com/apache/zookeeper/pull/626 ZOOKEEPER-3148 Add Kerberos tests for modern JDKs - This change is only for 3.4 branch, which MUST be compatible with JDK6 - Add Kerby and upgrade commons-io to 2.6, as needed by Kerby

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/622 Why be afraid enabling it right on? Jira is scoped for 3.6, but I think it should go into 3.5 too like the others. ---

Re: Java version (Oracle - OpenJDK) support

2018-09-14 Thread Enrico Olivelli
Here we are, this is my proposal for restoring tests on branch 3.4 on JDK 11 https://github.com/apache/zookeeper/pull/626 this is the JIRA case https://issues.apache.org/jira/browse/ZOOKEEPER-3148 I tried to change as less as possible. I will be happy to follow committers opinions Enrico Il

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217773472 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[jira] [Created] (ZOOKEEPER-3148) Fix Kerberos tests on branch 3.4 and JDK11

2018-09-14 Thread Enrico Olivelli (JIRA)
Enrico Olivelli created ZOOKEEPER-3148: -- Summary: Fix Kerberos tests on branch 3.4 and JDK11 Key: ZOOKEEPER-3148 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3148 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3148) Fix Kerberos tests on branch 3.4 and JDK11

2018-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3148: -- Labels: pull-request-available (was: ) > Fix Kerberos tests on branch 3.4 and

Re: Java version (Oracle - OpenJDK) support

2018-09-14 Thread Andor Molnar
> On 2018. Sep 13., at 19:29, Patrick Hunt wrote: > > On Thu, Sep 13, 2018 at 1:52 AM Andor Molnar > wrote: > >> Hi team, >> >> Let me quickly summarise what we’re trying to resolve on this thread. >> >> Problem #1: due to Oracle licensing changes people are

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/184 @anmolnar @breed @hanm please take a look at #627. That's my stack of patches that we've added on top of this PR and have been testing internally at Facebook. We think the two PRs should land

[jira] [Created] (ZOOKEEPER-3149) Unreachable node can prevent remaining nodes from gaining quorum

2018-09-14 Thread Andrew January (JIRA)
Andrew January created ZOOKEEPER-3149: - Summary: Unreachable node can prevent remaining nodes from gaining quorum Key: ZOOKEEPER-3149 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3149

[GitHub] zookeeper issue #567: ZOOKEEPER-3071: Add a config parameter to control tran...

2018-09-14 Thread suyogmapara
Github user suyogmapara commented on the issue: https://github.com/apache/zookeeper/pull/567 @anmolnar thank you, I will surely update the docs with some more details. I am currently waiting to see if there is anything else I need to address in the next iteration. ---

[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615274#comment-16615274 ] Hadoop QA commented on ZOOKEEPER-3142: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2174

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2174/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.15 MB...] [exec]

Success: ZOOKEEPER- PreCommit Build #2177

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2177/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.75 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615345#comment-16615345 ] Hadoop QA commented on ZOOKEEPER-3142: -- +1 overall. GitHub Pull Request Build +1

Re: ZooKeeper 3.5 blocker issues

2018-09-14 Thread Fangmin Lv
Oh, sorry for the confusion, I should provide more context. Leader will use on disk txn sync with followers to if the peer zxid is not in it's in memory commit logs, the code is here: Leader on disk txn sync

[jira] [Commented] (ZOOKEEPER-3145) Potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615117#comment-16615117 ] Hadoop QA commented on ZOOKEEPER-3145: -- -1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #619: ZOOKEEPER-3142: Extend SnapshotFormatter to dump data ...

2018-09-14 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/619 In this case the failed check is findbugs: "IS | Inconsistent synchronization of org.apache.zookeeper.server.DataNode.data; locked 89% of time" I'm going to resubmit and see if it

[jira] [Updated] (ZOOKEEPER-3149) Unreachable node can prevent remaining nodes from gaining quorum

2018-09-14 Thread Andrew January (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew January updated ZOOKEEPER-3149: -- Description: Steps to reproduce: # Have a 3 node cluster set up, with node 2 as

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread enixon
Github user enixon commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217812851 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/624 The newly added server.id is supposed to one of the static config, right? If I read the patch correctly, seems it will be treated as dynamic config, and the server.id in dynamic config won't be

Failed: ZOOKEEPER- PreCommit Build #2173

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2173/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 83.61 MB...] [exec]

ZooKeeper-trunk-windows-cmake - Build # 2935 - Still Failing

2018-09-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2935/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.71 KB...] [ivy:retrieve] confs: [javacc]

[GitHub] zookeeper pull request #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-09-14 Thread ivmaykov
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/627 ZOOKEEPER-236: SSL Support for Atomic Broadcast protocol [part 2] # Overview These are fixes and improvements to #184 that we've coded up at Facebook while testing that PR internally. This

Failed: ZOOKEEPER- PreCommit Build #2176

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2176/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.60 KB...] [exec]

[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615320#comment-16615320 ] Hadoop QA commented on ZOOKEEPER-3142: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2175

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2175/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.02 MB...] [exec]

[jira] [Updated] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3140: -- Labels: pull-request-available (was: ) > Allow Followers to host Observers >

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-09-14 Thread enixon
GitHub user enixon opened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements

[jira] [Commented] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615455#comment-16615455 ] Hadoop QA commented on ZOOKEEPER-3140: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2178

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2178/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.17 MB...] [exec] +1

[GitHub] zookeeper issue #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/184 For context on the second pull request, testing at Facebook revealed a bug in the existent form of 184. From #627 notes: > Fixed networking issues/bugs in UnifiedServerSocket > -

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/627 Jenkins build failed with compiling errors. To debug: * Click the [Details](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2179/) link. * Navigate to Build Artifacts >

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/627 I also checked out this pull request locally, ended up with same error. ---

[GitHub] zookeeper pull request #580: ZOOKEEPER-3098: Add additional server metrics

2018-09-14 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/580#discussion_r217864986 --- Diff: src/java/test/org/apache/zookeeper/server/ServerMetricsTest.java --- @@ -0,0 +1,91 @@ +package org.apache.zookeeper.server; --- End diff

[GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/580 Thanks for rebase, @jtuple. Latest build failed, but those are flaky tests. Kicking Jenkins again to get a green build. @anmolnar Could you please also sign this off? I believe you raised a

[jira] [Commented] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615533#comment-16615533 ] Hadoop QA commented on ZOOKEEPER-3140: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2185

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2185/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.67 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2184

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2184/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.89 MB...] [exec]

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/625 @hanm no problem, I will rebase to master and try to pass jenkins automatic build today. ---

[jira] [Commented] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615542#comment-16615542 ] Hudson commented on ZOOKEEPER-3142: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #192 (See

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217873955 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo...

2018-09-14 Thread breed
Github user breed commented on the issue: https://github.com/apache/zookeeper/pull/624 thanks for remembering to update the doc @maoling ! ---

[GitHub] zookeeper pull request #624: ZOOKEEPER-3108:use a new property server.id in ...

2018-09-14 Thread breed
Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/624#discussion_r217873847 --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -265,18 +266,25 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/627 Not sure how to debug the jenkins build failure, since I don't do this regularly. Any help is appreciated. ---

[jira] [Resolved] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3137. Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 615

[GitHub] zookeeper pull request #615: ZOOKEEPER-3137: add a utility to truncate logs ...

2018-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/615 ---

[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615502#comment-16615502 ] Michael Han commented on ZOOKEEPER-3141: Thanks [~lvfangmin], appreciate your help on fixing

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/627 Removed guava dependency and fixed remaining build breaks (hopefully all of them). ---

[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615520#comment-16615520 ] Hadoop QA commented on ZOOKEEPER-236: - -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2182

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2182/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.67 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #2183

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2183/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.95 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-3098) Add additional server metrics

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615528#comment-16615528 ] Hadoop QA commented on ZOOKEEPER-3098: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2179

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2179/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 6.69 KB...] [exec] Pull

Success: ZOOKEEPER- PreCommit Build #2180

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2180/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84.63 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3145) Potential watch missing issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615479#comment-16615479 ] Hadoop QA commented on ZOOKEEPER-3145: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/625 @roodkcab Could you please update the target branch of your pull request from `3.5.4` to `master`? `3.5.4` is a released branch and is considered read only. ---

ZooKeeper-trunk-windows-cmake - Build # 2937 - Still Failing

2018-09-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2937/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 10.62 KB...] [ivy:retrieve] confs: [javacc]

[jira] [Commented] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

2018-09-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615566#comment-16615566 ] Benjamin Reed commented on ZOOKEEPER-3108: -- the reason we kept myid out of the config is so

[GitHub] zookeeper issue #627: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-09-14 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/627 Here are the changes compared to #184 only. Should make it easier to review: https://github.com/apache/zookeeper/compare/pull/184/head...ivmaykov:fb-tls ---

[GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/580 From the conversation so far, it looks like we have reached a consensus regarding the directions of this patch and future metrics related patch. For this specific patch, it looks good to me, and I

ZooKeeper-trunk-windows-cmake - Build # 2936 - Still Failing

2018-09-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2936/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.73 KB...] [ivy:retrieve] confs: [javacc]

[GitHub] zookeeper issue #580: ZOOKEEPER-3098: Add additional server metrics

2018-09-14 Thread jtuple
Github user jtuple commented on the issue: https://github.com/apache/zookeeper/pull/580 Rebased to resolve merge conflict. ---

[jira] [Assigned] (ZOOKEEPER-3140) Allow Followers to host Observers

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-3140: -- Assignee: Brian Nixon > Allow Followers to host Observers >

[jira] [Resolved] (ZOOKEEPER-3142) Extend SnapshotFormatter to dump data in json format

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3142. Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 619

[GitHub] zookeeper pull request #619: ZOOKEEPER-3142: Extend SnapshotFormatter to dum...

2018-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/619 ---

[GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo...

2018-09-14 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/624 @Thanks all for reviewing,I will deal with this suggestions ASAP. ---

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread enixon
Github user enixon commented on the issue: https://github.com/apache/zookeeper/pull/625 I don't have the expertise to review this thoroughly but it's pretty cool to get SSL support on C as well. ---

[jira] [Resolved] (ZOOKEEPER-3144) Potential ephemeral nodes inconsistent due to global session inconsistent with fuzzy snapshot

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3144. Resolution: Fixed Issue resolved by pull request 621

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/625 I don't have a local environment to test C client at the moment, but from Jenkins, this pull request does not build: [exec] [exec]

[jira] [Commented] (ZOOKEEPER-3098) Add additional server metrics

2018-09-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615497#comment-16615497 ] Hadoop QA commented on ZOOKEEPER-3098: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #2181

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2181/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.29 MB...] [exec] +1

[GitHub] zookeeper pull request #621: [ZOOKEEPER-3144] Fix potential ephemeral nodes ...

2018-09-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/621 ---

[GitHub] zookeeper issue #622: [ZOOKEEPER-3145] Fix potential watch missing issue due...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/622 Rebase to resolve conflict with latest code. Btw, internally we still disable the CloseSessionTxn by default, since we have too many ensembles, and we want to slowly rollout this

[jira] [Commented] (ZOOKEEPER-3137) add a utility to truncate logs to a zxid

2018-09-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615482#comment-16615482 ] Hudson commented on ZOOKEEPER-3137: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #191 (See

[jira] [Commented] (ZOOKEEPER-3144) Potential ephemeral nodes inconsistent due to global session inconsistent with fuzzy snapshot

2018-09-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615483#comment-16615483 ] Hudson commented on ZOOKEEPER-3144: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #191 (See

[jira] [Assigned] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reassigned ZOOKEEPER-2122: -- Assignee: shuoshi (was: Ashish Amarnath) > Impplement SSL support in the

[jira] [Commented] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky

2018-09-14 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615496#comment-16615496 ] Fangmin Lv commented on ZOOKEEPER-3141: --- [~hanm] where can I found the nightly build result, I

[jira] [Comment Edited] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky

2018-09-14 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615502#comment-16615502 ] Michael Han edited comment on ZOOKEEPER-3141 at 9/14/18 11:23 PM: --

Failed: ZOOKEEPER- PreCommit Build #2186

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2186/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.39 MB...] [exec]

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/625 ![image](https://user-images.githubusercontent.com/1700820/45547330-04600c80-b853-11e8-8440-622f8e7043c1.png)

ZooKeeper_branch35_jdk8 - Build # 1118 - Still Failing

2018-09-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1118/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.85 KB...] [junit] Tests run: 1, Failures:

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689355 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte

Failed: ZOOKEEPER- PreCommit Build #2170

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2170/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.04 MB...] [exec]

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689225 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689682 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper pull request #625: Ssl client

2018-09-14 Thread roodkcab
GitHub user roodkcab opened a pull request: https://github.com/apache/zookeeper/pull/625 Ssl client ZOOKEEPER-2122: add openssl to zookeeper c client to support ssl You can merge this pull request into a Git repository by running: $ git pull

Failed: ZOOKEEPER- PreCommit Build #2169

2018-09-14 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2169/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 48.23 KB...] Auto-merging

[jira] [Updated] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library

2018-09-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2122: -- Labels: build pull-request-available security (was: build security) > Impplement

[GitHub] zookeeper issue #625: Ssl client

2018-09-14 Thread roodkcab
Github user roodkcab commented on the issue: https://github.com/apache/zookeeper/pull/625 I added openssl to zookeeper's c client, it's more like a wrapper to the plain socket, I changed the file descriptor from a socket_t to zsock_t in _zhandle, it contains ssl context and a struct

  1   2   >