[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2572/ ---

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2574/ ---

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2571/ ---

Failed: ZOOKEEPER- PreCommit Build #2574

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2574/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 83.68 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2572

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2572/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.91 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2576

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2576/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.27 MB...] [exec]

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2576/ ---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230523204 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230539129 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230522968 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230523105 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230539608 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2573/ ---

Failed: ZOOKEEPER- PreCommit Build #2573

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2573/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.68 MB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2575/ ---

Failed: ZOOKEEPER- PreCommit Build #2575

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2575/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.07 MB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2571

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2571/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.44 MB...] [exec]

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230538126 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,191 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #673: [ZOOKEEPER-3177] Refactor request throttle logi...

2018-11-02 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/673#discussion_r230276535 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java --- @@ -68,8 +68,39 @@ private volatile boolean stale =

[jira] [Updated] (ZOOKEEPER-3169) Reduce session revalidation time after zxid roll over

2018-11-02 Thread JIRA
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 田毅群 updated ZOOKEEPER-3169: --- Attachment: session revalidation.docx > Reduce session revalidation time after zxid roll over >

[jira] [Commented] (ZOOKEEPER-3169) Reduce session revalidation time after zxid roll over

2018-11-02 Thread JIRA
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673049#comment-16673049 ] 田毅群 commented on ZOOKEEPER-3169: Hi, could you please help to view the plan in file   "session

ZooKeeper_branch35_jdk8 - Build # 1177 - Still Failing

2018-11-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1177/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108.46 KB...] [junit] Running

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230455088 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230454818 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2569/ ---

Failed: ZOOKEEPER- PreCommit Build #2569

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2569/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.04 KB...] [exec]

Failed: ZOOKEEPER- PreCommit Build #2568

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2568/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 37.92 KB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2568/ ---

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151424 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230421726 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151441 In zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java: In

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230421926 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,27 +229,47 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/680 @eolivelli switched to lambdas, kept the finalizer in for now but added a TODO to remove it. ---

[GitHub] zookeeper pull request #685: [ZOOKEEPER-3104] Fix potential data inconsisten...

2018-11-02 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/685 [ZOOKEEPER-3104] Fix potential data inconsistency due to NEWLEADER packet being sent too early during SNAP sync Port this fix from master to 3.5. You can merge this pull request into a Git

Re: ZooKeeper 3.5 blocker issues

2018-11-02 Thread Fangmin Lv
Andor, Here is the PR to port ZK-3104 from master to 3.4: https://github.com/apache/zookeeper/pull/685. Fangmin On Fri, Nov 2, 2018 at 11:46 AM Fangmin Lv wrote: > Hi Andor, > > Is anyone working on ZK-2778? I can pick it up if there is no one working > on it yet. > > I'll open a 3.5 PR for

Success: ZOOKEEPER- PreCommit Build #2570

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2570/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.28 MB...] [exec]

[GitHub] zookeeper issue #685: [ZOOKEEPER-3104] Fix potential data inconsistency due ...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/685 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2570/ ---

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230419175 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

Failed: ZOOKEEPER- PreCommit Build #2563

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2563/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.92 MB...] [exec]

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230418985 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151383 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230423126 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -254,23 +282,54 @@ public static X509KeyManager

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151817 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In

Failed: ZOOKEEPER- PreCommit Build #2564

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2564/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.22 MB...] [exec]

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/679 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2564/ ---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/678 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2563/ ---

Failed: ZOOKEEPER- PreCommit Build #2565

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2565/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.80 MB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2565/ ---

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230418497 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #:

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151782 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In

Failed: ZOOKEEPER- PreCommit Build #2566

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2566/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 85.92 MB...] [exec]

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/680 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2566/ ---

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/681 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2567/ ---

Failed: ZOOKEEPER- PreCommit Build #2567

2018-11-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2567/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 86.11 MB...] [exec]

Re: ZOOKEEPER-3183

2018-11-02 Thread Fangmin Lv
Great, thanks! On Fri, Nov 2, 2018 at 12:01 PM Tumati Venky wrote: > Sure Fangmin.I will send PR in a day. > > Thanks, > Tumati > > On Sat, Nov 3, 2018 at 12:08 AM Fangmin Lv wrote: > >> Thanks Tumati for providing the improvement, please open a pull request >> and I'll review it. >> >> Best,

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230465652 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230467749 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

Re: ZooKeeper 3.5 blocker issues

2018-11-02 Thread Fangmin Lv
Hi Andor, Is anyone working on ZK-2778? I can pick it up if there is no one working on it yet. I'll open a 3.5 PR for ZK-3104 today. Fangmin On Fri, Oct 26, 2018 at 3:33 AM Andor Molnar wrote: > Hi folks, > > You’ve probably realised lots of update emails coming from Jira. Please be > aware

Re: ZOOKEEPER-3183

2018-11-02 Thread Tumati Venky
Sure Fangmin.I will send PR in a day. Thanks, Tumati On Sat, Nov 3, 2018 at 12:08 AM Fangmin Lv wrote: > Thanks Tumati for providing the improvement, please open a pull request > and I'll review it. > > Best, > Fangmin > > On Thu, Nov 1, 2018 at 3:22 PM Andor Molnár wrote: > >> Hi Tumati! >>

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230463665 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230463114 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230461099 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r230463216 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,180 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230468188 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

Re: ZOOKEEPER-3183

2018-11-02 Thread Fangmin Lv
Thanks Tumati for providing the improvement, please open a pull request and I'll review it. Best, Fangmin On Thu, Nov 1, 2018 at 3:22 PM Andor Molnár wrote: > Hi Tumati! > > > Of course. Your contribution is much appreciated. > > Would you please open a github pull request, when you're ready