Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/703
@anmolnar following are my understanding about the acceptedEpoch,
currentEpoch and electionEpoch:
* acceptedEpoch : the previous epoch we accepted so far, usually is the
epoch is the
Github user TyqITstudent commented on the issue:
https://github.com/apache/zookeeper/pull/720
> It seems you are not renaming classes/fields in every point of code
Ok, thanks for your remind.
---
Github user TyqITstudent commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/720#discussion_r236065557
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ---
@@ -616,6 +616,14 @@ private void processEvent(Object event) {
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1206/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 66.03 KB...]
[junit] Running
Michael K. Edwards created ZOOKEEPER-3200:
-
Summary: Flaky test:
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testInconsistentDueToNewLeaderOrder
Key: ZOOKEEPER-3200
URL:
GitHub user mkedwards reopened a pull request:
https://github.com/apache/zookeeper/pull/721
ZOOKEEPER-3046: wait for clients to reconnect after restarting server
You can merge this pull request into a Git repository by running:
$ git pull
Github user lavacat commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/721#discussion_r236095252
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
@@ -221,6 +228,7 @@ public void
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3203:
--
Summary: Tracking and exposing the non voting followers in ZK (was: Track
the number of
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
retest this please
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698341#comment-16698341
]
Michael K. Edwards commented on ZOOKEEPER-3046:
---
Still seeing test failures; basically
Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/721#discussion_r236097804
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
@@ -221,6 +228,7 @@ public void
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3203:
--
Labels: pull-request-available (was: )
> Tracking and exposing the non voting
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/722
[ZOOKEEPER-3203] Tracking the number of non voting followers in ZK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/689#discussion_r236098818
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
@@ -102,12 +103,13 @@ public void
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698526#comment-16698526
]
Michael K. Edwards commented on ZOOKEEPER-3201:
---
What seems to be happening here is
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
Except, er, that seems to make the tests fail. ð Investigating.
---
Michael K. Edwards created ZOOKEEPER-3201:
-
Summary: Flaky test:
org.apache.zookeeper.server.ZxidRolloverTest.testRolloverThenLeaderRestart
Key: ZOOKEEPER-3201
URL:
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
Fixed that (and tested it locally before pushing this time).
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698341#comment-16698341
]
Michael K. Edwards edited comment on ZOOKEEPER-3046 at 11/25/18 10:21 PM:
Github user mkedwards closed the pull request at:
https://github.com/apache/zookeeper/pull/721
---
Fangmin Lv created ZOOKEEPER-3203:
-
Summary: Track the number of non voting followers in ZK
Key: ZOOKEEPER-3203
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3203
Project: ZooKeeper
Michael K. Edwards created ZOOKEEPER-3202:
-
Summary: Flaky test:
org.apache.zookeeper.test.ClientSSLTest.testClientServerSSL
Key: ZOOKEEPER-3202
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3202
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/721
ZOOKEEPER-3046: wait for clients to reconnect after restarting server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mkedwards/zookeeper
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/689#discussion_r236102347
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
@@ -102,12 +103,13 @@ public void addDeadWatcher(int
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3202:
--
Labels: pull-request-available (was: )
> Flaky test:
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/689#discussion_r236098795
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
@@ -161,10 +163,10 @@ public void doWork() throws
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/723
ZOOKEEPER-3202: Add timing margin to improve reliability of
testClientServerSSL()
Allowing just 5 seconds for 3 quorum peers to start and elect a leader is a
bit tight, at least when running
Github user mkedwards commented on the issue:
https://github.com/apache/zookeeper/pull/721
I think so too! Done ð
---
GitHub user mkedwards opened a pull request:
https://github.com/apache/zookeeper/pull/724
ZOOKEEPER-2488: Synchronized access to shuttingDownLE in QuorumPeer
I think this can be reviewed separately from the (functionally somewhat
related) changes in #707.
You can merge this pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2488:
--
Labels: pull-request-available (was: )
> Unsynchronized access to shuttingDownLE
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698585#comment-16698585
]
Michael K. Edwards commented on ZOOKEEPER-2488:
---
I pulled that fix out as a separate PR
31 matches
Mail list logo
