[jira] [Updated] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-3233: Description: Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads

Build failed in Jenkins: ZooKeeper-trunk-owasp #224

2019-01-03 Thread Apache Jenkins Server
See Changes: [andor] ZOOKEEPER-3228: [TLS] Fix key usage extension in test certs [fangmin] ZOOKEEPER-3205: Add test cases for jute [andor] ZOOKEEPER-3226: MAVEN MIGRATION - - add profile for C build

Re: Jira - GitHub linkage broken?

2019-01-03 Thread Andor Molnar
I opened Infra ticket: https://issues.apache.org/jira/browse/INFRA-17532 Andor > On 2019. Jan 2., at 15:41, Enrico Olivelli wrote: > > Il giorno mer 2 gen 2019 alle ore 15:28 Enrico Olivelli > mailto:eolive...@gmail.com>> ha scritto: >>

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox
anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451120479 retest this please This is an automated message

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446 one more test, found a bug :) This is an automated message

[GitHub] Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446 one more test, found a bug :) This is an automated message from the

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108055 Please ignore this comment, checking JIRA integration. This

[jira] [Updated] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3217: -- Labels: pull-request-available (was: ) > owasp job flagging slf4j on trunk >

[jira] [Updated] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3229: -- Labels: pull-request-available (was: ) > [TLS] add AES-256 ciphers to default

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451121539 retest this please This is an automated message from the Apache Git

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451125713 retest this please This is an automated message from the Apache Git

[jira] [Resolved] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3233. - Resolution: Fixed Issue resolved by pull request 750

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox
ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451128577 retest this please This is an automated message from the Apache

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java ## @@ -212,7 +212,8

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963240 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ## @@ -18,6 +18,7 @@

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963646 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java ## @@

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244962944 ## File path: excludeFindBugsFilter.xml ## @@ -0,0 +1,14 @@ + + + Review comment: Naming is a little bit

[GitHub] anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

2019-01-03 Thread GitBox
anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list URL: https://github.com/apache/zookeeper/pull/744#issuecomment-451113306 @ivmaykov `QuorumSSLTest.testProtocolVersion` is failing, because TLSv1.1 participant is able to join TLSv1.2-only

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox
anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451117487 retest this please This is an automated message

[jira] [Updated] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3222: -- Labels: pull-request-available (was: ) > Flaky: multiple intermittent segfaults

[jira] [Commented] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732957#comment-16732957 ] Hudson commented on ZOOKEEPER-3233: --- SUCCESS: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733808#comment-16733808 ] Hudson commented on ZOOKEEPER-3217: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #335 (See

[jira] [Commented] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733807#comment-16733807 ] Hudson commented on ZOOKEEPER-3222: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #335 (See

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-03 Thread Brian Nixon (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733820#comment-16733820 ] Brian Nixon commented on ZOOKEEPER-3232: seems reasonable to me > make the log of

[GitHub] enixon commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox
enixon commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret URL: https://github.com/apache/zookeeper/pull/752#issuecomment-451351904 I like it :) This is an automated message from

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-03 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-451193461 @anmolnar - should be up to date now. This is an automated message from the

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244994756 ## File path: excludeFindBugsFilter.xml ## @@ -0,0 +1,14 @@ + + + Review comment: @anmolnar this name is

[jira] [Commented] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733041#comment-16733041 ] Hudson commented on ZOOKEEPER-3233: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #332 (See

[jira] [Resolved] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3222. - Resolution: Fixed Fix Version/s: (was: 3.4.14) Issue resolved by pull

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451167996 retest this please This is an automated message from the Apache Git

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox
anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451167753 Committed to master and 3.5 branches. Thanks @lvfangmin !

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox
ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451177021 retest this please This is an automated message from the Apache

[GitHub] asfgit closed pull request #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
asfgit closed pull request #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Updated] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3197: -- Labels: pull-request-available (was: ) > Improve documentation in

[GitHub] coheigea opened a new pull request #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox
coheigea opened a new pull request #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret URL: https://github.com/apache/zookeeper/pull/752 This is an automated message from the Apache Git Service. To

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r245008359 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ## @@ -18,6 +18,7 @@

[GitHub] asfgit closed pull request #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox
asfgit closed pull request #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-03 Thread GitBox
anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-451174697 @arankin-irl Please rebase on top of current master. @ivmaykov @hanm Would you please take a quick a look at this patch? I'd like to get your

Re: Re: ZooKeeper 3.5 blocker issues

2019-01-03 Thread Norbert Kalmar
Hi everyone, Happy New Year! My patches were merged today, so maven build should be working on master branch. There is still one Pr open about findbugs - https://github.com/apache/zookeeper/pull/742 (Thanks Enrico!) Annotations has been introduced instead of central xml, it's quite a change, but

[GitHub] eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#issuecomment-451139535 @anmolnar the change around `// TTL.toEphemeralOwner(ttl);` was because that method for spotbugs won't have any side effects, but indeed it

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244995163 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java ## @@ -18,6 +18,7 @@

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451145230 retest this please This is an automated message from the Apache Git

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox
anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451154938 retest this please This is an automated message

Jenkins issues

2019-01-03 Thread Andor Molnar
Hi team, I’m not sure, but it looks like we cannot run 2 concurrent PreCommit jobs on a single Jenkins slave, because both of them get killed soon after the second starts. Additionally all of the recent builds running on H19 for some reason. I opened an INFRA ticket to track and get help:

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244996468 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java ## @@

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r245004005 ## File path: excludeFindBugsFilter.xml ## @@ -0,0 +1,14 @@ + + + Review comment: Leave it, I'm fine with

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox
ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451166896 retest this please This is an automated message from the Apache

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox
anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451178971 Committed to 3.4, 3.5 and master branches. Thanks @eolivelli ! This

[jira] [Resolved] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3217. - Resolution: Fixed Issue resolved by pull request 736

[GitHub] anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation

2019-01-03 Thread GitBox
anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation URL: https://github.com/apache/zookeeper/pull/710#issuecomment-451179479 retest this please This is an automated message from the

[GitHub] dineshappavoo commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox
dineshappavoo commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret URL: https://github.com/apache/zookeeper/pull/752#issuecomment-451256979 LGTM  This is an automated message from

Re: Maven migration and CI

2019-01-03 Thread Ted Dunning
Wow. This has been a long time coming! Great news. On Thu, Jan 3, 2019 at 1:34 PM Enrico Olivelli wrote: > Hi Zookeepers > Now that we have Maven it is time to set up new CI jobs and compare the > results with the Ant based build. > > My proposal is to set up a few jobs and see the results.

Jenkins build is back to normal : ZooKeeper-trunk-owasp #225

2019-01-03 Thread Apache Jenkins Server
See

ZooKeeper-trunk - Build # 333 - Failure

2019-01-03 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/333/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.41 KB...] at

Re: Re: ZooKeeper 3.5 blocker issues

2019-01-03 Thread Enrico Olivelli
Il gio 3 gen 2019, 16:49 Norbert Kalmar ha scritto: > Hi everyone, Happy New Year! > > My patches were merged today, so maven build should be working on master > branch. > There is still one Pr open about findbugs - > https://github.com/apache/zookeeper/pull/742 (Thanks Enrico!) > Annotations

Maven migration and CI

2019-01-03 Thread Enrico Olivelli
Hi Zookeepers Now that we have Maven it is time to set up new CI jobs and compare the results with the Ant based build. My proposal is to set up a few jobs and see the results. When Norbert finishes the migration and we are happy we will drop Ant CI. I would start with a daily job for master

Re: Jenkins issues

2019-01-03 Thread Enrico Olivelli
Your ticket has been closed. I think our script won't kill other executions but I need to check. Btw. We can configure the job in order to run at most one execution at a time. Zookeeper test suite is pretty heavy (it does a lot of fsyncs for instance) and we are running test concurrently, so at

[jira] [Commented] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733546#comment-16733546 ] Hudson commented on ZOOKEEPER-3217: --- FAILURE: Integrated in Jenkins build

[jira] [Commented] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733545#comment-16733545 ] Hudson commented on ZOOKEEPER-3222: --- FAILURE: Integrated in Jenkins build

ZooKeeper-trunk-windows-cmake - Build # 3090 - Failure

2019-01-03 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/3090/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 11.21 KB...] [move] Moving 1 file to

ZooKeeper-trunk - Build # 334 - Still Failing

2019-01-03 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/334/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.21 KB...] at