date:20131212

On Dec. 11, 2013, 8:06 p.m., German Blanco wrote:
./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 387
https://reviews.apache.org/r/15753/diff/1/?file=389468#file389468line387

Please remove spaces in this line.

I do not understand because I didn't modify the file QuorumPeer.java. Actually
there is no modification information on the patch that I uploaded. Is it
something that I'm missing or missunderstanding?

On Dec. 11, 2013, 8:06 p.m., Daniel Peon wrote:
In general review indentation (spaces instead of tabs), remove trailing
spaces.
Also, there is no test case included. If the test was in a new file, check
that you have done svn add before generating the patch.

I think something wrong happened with the patch generation. Although the .patch
file does not contain some of the lines that you could find in the diff
command, they are changes that I did before in the code.

I just generated a new patch from the LATEST version. Additionally I performed
the svn add operation before generating the patch also.

Please review it if you can just and let's see if I did it right.

- Daniel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/#review30222
---

On Dec. 12, 2013, 8:30 a.m., Daniel Peon wrote:

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 8:30 a.m.)

Review request for zookeeper, German Blanco and fpj.

Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814

Repository: zookeeper

Description
---

See Zookeeper-1814.

Diffs
-

./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368
./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
1550368
./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
1550368

./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java
PRE-CREATION

Diff: https://reviews.apache.org/r/15753/diff/

Testing
---

New test case checking that the parameter maxNotificationInterval can be
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager
class in order to avoid any answer to Fast Leader Election. Thus, FLE is
forced to retry increasing exponentially the notifications interval. This
interval is measured and the test case stops when 3 consecutive measures are
equal. The test case will be OK if the measure is the configured in the cfg
file.

File Attachments

ZOOKEEPER-1814.patch

https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch

Thanks,

Daniel Peon

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 8:30 a.m.)

Review request for zookeeper, German Blanco and fpj.

Changes
---

I created a new patch from the latest revision (1550368). It seems that the
previous one didn't match to the changes that I made (it appeared some modified
files that I didn't modified actually). Additionally I performed the 'svn add'
operation on the test file. It should appear a new file
(src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java).

Thanks and regards.

Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814

Repository: zookeeper

Description
---

See Zookeeper-1814.

Diffs (updated)
-

Diff: https://reviews.apache.org/r/15753/diff/

Testing
---

New test case checking that the parameter maxNotificationInterval can be
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to
retry increasing exponentially the notifications interval. This interval is
measured and the test case stops when 3 consecutive measures are equal. The
test case will be OK if the measure is the configured in the cfg file.

File Attachments

ZOOKEEPER-1814.patch

https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch

Thanks,

Daniel Peon

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 8:38 a.m.)


Review request for zookeeper, German Blanco and fpj.


Changes
---

Spaces and tabs corrected.


Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814


Repository: zookeeper


Description
---

See Zookeeper-1814.


Diffs (updated)
-

  ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 
  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1550368 
  ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
1550368 
  ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/15753/diff/


Testing
---

New test case checking that the parameter maxNotificationInterval can be 
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class 
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to 
retry increasing exponentially the notifications interval. This interval is 
measured and the test case stops when 3 consecutive measures are equal. The 
test case will be OK if the measure is the configured in the cfg file.


File Attachments


ZOOKEEPER-1814.patch
  
https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch


Thanks,

Daniel Peon

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/#review30248
---



File Attachment: ZOOKEEPER-1814.patch - ZOOKEEPER-1814.patch
https://reviews.apache.org//r/15753/#fcomment5
It seems to be a wrong patch. I've added a new version.

- Daniel Peon


On Dec. 12, 2013, 8:38 a.m., Daniel Peon wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15753/
 ---
 
 (Updated Dec. 12, 2013, 8:38 a.m.)
 
 
 Review request for zookeeper, German Blanco and fpj.
 
 
 Bugs: ZOOKEEPER-1814
 https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 See Zookeeper-1814.
 
 
 Diffs
 -
 
   ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 
   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
 1550368 
   ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
 1550368 
   
 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/15753/diff/
 
 
 Testing
 ---
 
 New test case checking that the parameter maxNotificationInterval can be 
 configurable.
 
 The test case overwrites the receiveConnection method in QuorumCnxManager 
 class in order to avoid any answer to Fast Leader Election. Thus, FLE is 
 forced to retry increasing exponentially the notifications interval. This 
 interval is measured and the test case stops when 3 consecutive measures are 
 equal. The test case will be OK if the measure is the configured in the cfg 
 file.
 
 
 File Attachments
 
 
 ZOOKEEPER-1814.patch
   
 https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch
 
 
 Thanks,
 
 Daniel Peon

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 8:42 a.m.)


Review request for zookeeper, German Blanco and fpj.


Changes
---

Spaces and tabs corrected (it was still a missing space)


Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814


Repository: zookeeper


Description
---

See Zookeeper-1814.


Diffs (updated)
-

  ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 
  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1550368 
  ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
1550368 
  ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/15753/diff/


Testing
---

New test case checking that the parameter maxNotificationInterval can be 
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class 
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to 
retry increasing exponentially the notifications interval. This interval is 
measured and the test case stops when 3 consecutive measures are equal. The 
test case will be OK if the measure is the configured in the cfg file.


File Attachments


ZOOKEEPER-1814.patch
  
https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch


Thanks,

Daniel Peon

Re: Review Request 16202: Log all exceptions not caught by ZK threads

2013-12-12 Thread Rakesh R


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16202/
---

(Updated Dec. 12, 2013, 8:49 a.m.)


Review request for zookeeper, Benjamin Reed, fpj, Mahadev Konar, Patrick Hunt, 
and Raul Gutierrez Segales.


Changes
---

Just updated JIRA id in header.


Bugs: ZOOKEEPER-602
https://issues.apache.org/jira/browse/ZOOKEEPER-602


Repository: zookeeper


Description
---

Improve exception handling - log all exceptions not caught by ZK threads. Will 
be helpful in debugging and gives the reason for thread exits.


Diffs
-

  ./src/java/main/org/apache/zookeeper/ClientCnxn.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/WorkerService.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java 
PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java PRE-CREATION 
  
./src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.java 
1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1544413 
  
./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
 1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 
1544413 
  
./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
 1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 
1544413 
  ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1544413 
  
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
 1544413 
  ./src/java/test/config/findbugsExcludeFile.xml 1544413 
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/16202/diff/


Testing
---

Includes basic test case


Thanks,

Rakesh R

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Peon updated ZOOKEEPER-1814:
---

Attachment: ZOOKEEPER-1814.patch

New patch created after solving the warning.

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 8:53 a.m.)

Review request for zookeeper, German Blanco and fpj.

Changes
---

In order to avoid a new warning detected during the regression, I upload the
Diff r5.

Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814

Repository: zookeeper

Description
---

See Zookeeper-1814.

Diffs (updated)
-

Diff: https://reviews.apache.org/r/15753/diff/

Testing
---

New test case checking that the parameter maxNotificationInterval can be
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to
retry increasing exponentially the notifications interval. This interval is
measured and the test case stops when 3 consecutive measures are equal. The
test case will be OK if the measure is the configured in the cfg file.

File Attachments

ZOOKEEPER-1814.patch

https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch

Thanks,

Daniel Peon

ZooKeeper-trunk-solaris - Build # 758 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/758/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 209487 lines...]
[junit] 2013-12-12 09:01:30,711 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2013-12-12 09:01:30,712 [myid:] - INFO  [main:ZooKeeperServer@428] 
- shutting down
[junit] 2013-12-12 09:01:30,712 [myid:] - INFO  
[main:SessionTrackerImpl@183] - Shutting down
[junit] 2013-12-12 09:01:30,712 [myid:] - INFO  
[main:PrepRequestProcessor@972] - Shutting down
[junit] 2013-12-12 09:01:30,713 [myid:] - INFO  
[main:SyncRequestProcessor@190] - Shutting down
[junit] 2013-12-12 09:01:30,713 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2013-12-12 09:01:30,713 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited!
[junit] 2013-12-12 09:01:30,713 [myid:] - INFO  
[main:FinalRequestProcessor@442] - shutdown of request processor complete
[junit] 2013-12-12 09:01:30,714 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-12-12 09:01:30,714 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-12-12 09:01:30,715 [myid:] - INFO  [main:ClientBase@414] - 
STARTING server
[junit] 2013-12-12 09:01:30,715 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8407264545862758254.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8407264545862758254.junit.dir/version-2
[junit] 2013-12-12 09:01:30,716 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2013-12-12 09:01:30,716 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-12-12 09:01:30,717 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8407264545862758254.junit.dir/version-2/snapshot.b
[junit] 2013-12-12 09:01:30,720 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test8407264545862758254.junit.dir/version-2/snapshot.b
[junit] 2013-12-12 09:01:30,722 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-12-12 09:01:30,722 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:42922
[junit] 2013-12-12 09:01:30,723 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:42922
[junit] 2013-12-12 09:01:30,724 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2013-12-12 09:01:30,724 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:42922 (no session established for client)
[junit] 2013-12-12 09:01:30,724 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-12-12 09:01:30,726 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-12-12 09:01:30,726 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-12-12 09:01:30,726 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-12-12 09:01:30,727 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-12-12 09:01:30,727 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-12-12 09:01:30,727 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-12-12 09:01:30,800 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down
[junit] 2013-12-12 09:01:30,800 [myid:] - INFO  [main:ZooKeeper@777] - 
Session: 0x142e60a1786 closed
[junit] 2013-12-12 09:01:30,801 [myid:] - INFO  [main:ClientBase@421] - 
STOPPING server
[junit] 2013-12-12 09:01:30,801 [myid:] - INFO

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846190#comment-13846190
]

Hadoop QA commented on ZOOKEEPER-1814:
--

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12618381/ZOOKEEPER-1814.patch
against trunk revision 1550213.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//console

This message is automatically generated.

Reduction of waiting time during Fast Leader Election
-

Key: ZOOKEEPER-1814
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
Fix For: 3.5.0

Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

Original Estimate: 24h
Remaining Estimate: 24h

FastLeader election takes long time because of the exponential backoff.
Currently the time is 60 seconds.
It would be interesting to give the possibility to configure this parameter,
like for example for a Server shutdown.
Otherwise, it sometimes takes so long and it has been detected a test failure
when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
This test case waits until 30 seconds and this is smaller than the 60 seconds
where the leader election can be waiting for at the moment of shutting down.
Considering the failure during the test case, this issue was considered a
possible bug.

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Success: ZOOKEEPER-1814 PreCommit Build #1827

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 264680 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618381/ZOOKEEPER-1814.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1827//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] ace884b5501bf25c2a26855a4f7bd0063d9c8503 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 33 minutes 51 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1814
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-3.4-WinVS2008_java - Build # 376 - Still Failing

See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/376/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 214413 lines...]
[junit] 2013-12-12 10:08:58,413 [myid:] - INFO  [main:ClientBase@421] - 
STOPPING server
[junit] 2013-12-12 10:08:58,413 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1007] - Closed socket 
connection for client /127.0.0.1:57814 which had sessionid 0x142e647caf1
[junit] 2013-12-12 10:08:58,503 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - 
NIOServerCnxn factory exited run method
[junit] 2013-12-12 10:08:58,413 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down
[junit] 2013-12-12 10:08:58,504 [myid:] - INFO  [main:ZooKeeperServer@441] 
- shutting down
[junit] 2013-12-12 10:08:58,504 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 2013-12-12 10:08:58,504 [myid:] - INFO  
[main:PrepRequestProcessor@761] - Shutting down
[junit] 2013-12-12 10:08:58,603 [myid:] - INFO  
[main:SyncRequestProcessor@209] - Shutting down
[junit] 2013-12-12 10:08:58,603 [myid:] - INFO  [ProcessThread(sid:0 
cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2013-12-12 10:08:58,603 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited!
[junit] 2013-12-12 10:08:58,603 [myid:] - INFO  
[main:FinalRequestProcessor@415] - shutdown of request processor complete
[junit] 2013-12-12 10:08:58,604 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-12-12 10:08:59,695 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[]
[junit] 2013-12-12 10:08:59,698 [myid:] - INFO  [main:ZKTestCase$1@65] - 
FAILED testQuota
[junit] junit.framework.AssertionFailedError: expected:0 but was:1
[junit] at junit.framework.Assert.fail(Assert.java:47)
[junit] at junit.framework.Assert.failNotEquals(Assert.java:283)
[junit] at junit.framework.Assert.assertEquals(Assert.java:64)
[junit] at junit.framework.Assert.assertEquals(Assert.java:195)
[junit] at junit.framework.Assert.assertEquals(Assert.java:201)
[junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
[junit] at 
org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417)
[junit] at 
org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80)
[junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[junit] at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[junit] at java.lang.reflect.Method.invoke(Method.java:597)
[junit] at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
[junit] at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
[junit] at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
[junit] at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
[junit] at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[junit] at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
[junit] at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
[junit] at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
[junit] at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
[junit] at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
[junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
[junit] at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
[junit] at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
[junit] at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
[junit] at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
[junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
[junit] at 
junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)
[junit] 2013-12-12 10:08:59,710 [myid:] - INFO

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Peon updated ZOOKEEPER-1814:
---

Attachment: ZOOKEEPER-1814.patch

Uploaded new patch with correct test case indentation and CountDownLatch wait 
for the test case instead of sleep.

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, 
 ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Status of 3.4.6

2013-12-12 Thread FPJ

There are two issues blocking 3.4.6 now:

 

-  I don't understand why the 3.4 windows build in failing on
Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing to
have a look, I would appreciate some help.

-  ZK-1430 needs to get in and I'd like to understand what needs to
be done for ZK-1402.

 

Thanks,

-Flavio

Success: ZOOKEEPER-1814 PreCommit Build #1828

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 266601 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618428/ZOOKEEPER-1814.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 642498e67d50c752f8b87a127c73a930a85aa3c4 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 33 minutes 4 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1814
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

2013-12-12 Thread JIRA


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846436#comment-13846436
 ] 

Germán Blanco commented on ZOOKEEPER-1814:
--

Sorry I didn't catch this before, but if you need to update the patch again, 
perhaps it would make sense to set a smaller maxFleNotificationInterval time in 
the test (say 200 milliseconds instead of 5000), so that the test is faster and 
it doesn't add time to the already very long ZooKeeper regression.

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, 
 ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846438#comment-13846438
]

Hadoop QA commented on ZOOKEEPER-1814:
--

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12618428/ZOOKEEPER-1814.patch
against trunk revision 1550213.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1828//console

This message is automatically generated.

Reduction of waiting time during Fast Leader Election
-

Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch,
ZOOKEEPER-1814.patch

Original Estimate: 24h
Remaining Estimate: 24h

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846442#comment-13846442
]

Daniel Peon commented on ZOOKEEPER-1814:

That's right, I should have thought about that before. Right now the test case
is introducing around 20 seconds to the execution and it is not necessary. I'm
going to change it and upload the new patch.

Reduction of waiting time during Fast Leader Election
-

Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch,
ZOOKEEPER-1814.patch

Original Estimate: 24h
Remaining Estimate: 24h

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 5:07 p.m.)

Review request for zookeeper, German Blanco and fpj.

Changes
---

Uploaded the patch with recommended changes. Additionally the notifications
interval for leader election was reduced during the test case.

Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814

Repository: zookeeper

Description
---

See Zookeeper-1814.

Diffs (updated)
-

Diff: https://reviews.apache.org/r/15753/diff/

Testing
---

New test case checking that the parameter maxNotificationInterval can be
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to
retry increasing exponentially the notifications interval. This interval is
measured and the test case stops when 3 consecutive measures are equal. The
test case will be OK if the measure is the configured in the cfg file.

File Attachments

ZOOKEEPER-1814.patch

https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch

Thanks,

Daniel Peon

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Peon updated ZOOKEEPER-1814:
---

Attachment: ZOOKEEPER-1814.patch

In the test case, maxFleNotificationInterval parameter has been reduced.

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, 
 ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/
---

(Updated Dec. 12, 2013, 5:12 p.m.)


Review request for zookeeper, German Blanco and fpj.


Changes
---

Updated because a wrong indentation in one of the lines.


Bugs: ZOOKEEPER-1814
https://issues.apache.org/jira/browse/ZOOKEEPER-1814


Repository: zookeeper


Description
---

See Zookeeper-1814.


Diffs (updated)
-

  ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 
  ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
1550368 
  ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
1550368 
  ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/15753/diff/


Testing
---

New test case checking that the parameter maxNotificationInterval can be 
configurable.

The test case overwrites the receiveConnection method in QuorumCnxManager class 
in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to 
retry increasing exponentially the notifications interval. This interval is 
measured and the test case stops when 3 consecutive measures are equal. The 
test case will be OK if the measure is the configured in the cfg file.


File Attachments


ZOOKEEPER-1814.patch
  
https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch


Thanks,

Daniel Peon

[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Peon updated ZOOKEEPER-1814:
---

Attachment: ZOOKEEPER-1814.patch

Updated with the right indentation in one line in the test case.

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, 
 ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Success: ZOOKEEPER-1814 PreCommit Build #1829

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 270905 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618436/ZOOKEEPER-1814.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 30a8cfea4e54e4ab38cd18362989cf2594d4e43e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 32 minutes 45 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1814
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846489#comment-13846489
]

Hadoop QA commented on ZOOKEEPER-1814:
--

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12618436/ZOOKEEPER-1814.patch
against trunk revision 1550213.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1829//console

This message is automatically generated.

Reduction of waiting time during Fast Leader Election
-

Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch,
ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

Original Estimate: 24h
Remaining Estimate: 24h

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

2013-12-12 Thread Raul Gutierrez Segales (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846493#comment-13846493
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1814:
---

Some nits and simplifications:

{noformat}
+  paraemphasis role=boldNew in 3.3.0:/emphasisMaximum 
notifications
{noformat}

3.3.0 doesn't seem right.

Nit:

{noformat}
- * should not be taken into account in the comparison 
- * (electionEpoch and zxid). 
+ * should not be taken into account in the comparison
+ * (electionEpoch and zxid).
{noformat}

those lines didn't really change, you just introduced a trailing space.

Instead of:

{noformat}
+if (System.getProperty(zookeeper.maxFleNotificationInterval) != 
null){
+maxNotificationInterval = 
Integer.parseInt(System.getProperty(zookeeper.maxFleNotificationInterval));
+} else {
+maxNotificationInterval = 6;
+}
{noformat}

you can just have:

{noformat}
maxNotificationInterval = 
Integer.getInteger(zookeeper.maxFleNotificationInterval, 6);
{noformat}

Nit: for all the LOG.info/LOG.debug statements, I think it's cleaner to use 
string extrapolation as opposed to concatenating strings. i.e.: instead of:

{noformat}
LOG.info(Two equal notification intervals measured [ + counter +  of 
++ numEqualIntervalsNeeded + ]);
{noformat}

just:

{noformat}
LOG.info(Two equal notification intervals measured [{} of {}], counter, 
numEqualIntervalsNeeded);
{noformat}

Instead of:

{noformat}
+maxFleNotificationInterval = 
Integer.parseInt(System.getProperty(zookeeper.maxFleNotificationInterval));
{noformat}

just:

{noformat}
+maxFleNotificationInterval = 
Integer.getInteger(zookeeper.maxFleNotificationInterval);
{noformat}

you probably want to make zookeeper.maxFleNotificationInterval a public 
constant somewhere. 

Instead of:

{noformat}
+if (thread.isAlive()) {
+Assert.fail(Should not be alive);
+}
{noformat}

maybe just:

{noformat}
+  Assert.assertFalse(Should not be alive, thread.isAlive());
{noformat}

 Reduction of waiting time during Fast Leader Election
 -

 Key: ZOOKEEPER-1814
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, 
 ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 FastLeader election takes long time because of the exponential backoff. 
 Currently the time is 60 seconds.
 It would be interesting to give the possibility to configure this parameter, 
 like for example for a Server shutdown.
 Otherwise, it sometimes takes so long and it has been detected a test failure 
 when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
 This test case waits until 30 seconds and this is smaller than the 60 seconds 
 where the leader election can be waiting for at the moment of shutting down.
 Considering the failure during the test case, this issue was considered a 
 possible bug.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)

2013-12-12 Thread Raul Gutierrez Segales


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15753/#review30267
---



./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
https://reviews.apache.org/r/15753/#comment57933

(commented on the JIRA but commenting here as well to make it easier to 
fix/follow-up).

This can just be:

maxNotificationInterval = 
Integer.getInteger(zookeeper.maxFleNotificationInterval, 6);



./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java
https://reviews.apache.org/r/15753/#comment57934

Nit: for all the LOG.info/LOG.debug statements, I think it's cleaner to use 
string extrapolation as opposed to concatenating strings. i.e.: instead of:

LOG.info(Two equal notification intervals measured [ + counter +  of 
++ numEqualIntervalsNeeded + ]);

just:

LOG.info(Two equal notification intervals measured [{} of {}], counter, 
numEqualIntervalsNeeded);





./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java
https://reviews.apache.org/r/15753/#comment57935

maxFleNotificationInterval = 
Integer.getInteger(zookeeper.maxFleNotificationInterval);

you probably want to make zookeeper.maxFleNotificationInterval a public 
constant somewhere. 



./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java
https://reviews.apache.org/r/15753/#comment57936

simpler: Assert.assertFalse(Should not be alive, thread.isAlive());


- Raul Gutierrez Segales


On Dec. 12, 2013, 5:12 p.m., Daniel Peon wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/15753/
 ---
 
 (Updated Dec. 12, 2013, 5:12 p.m.)
 
 
 Review request for zookeeper, German Blanco and fpj.
 
 
 Bugs: ZOOKEEPER-1814
 https://issues.apache.org/jira/browse/ZOOKEEPER-1814
 
 
 Repository: zookeeper
 
 
 Description
 ---
 
 See Zookeeper-1814.
 
 
 Diffs
 -
 
   ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 
   ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 
 1550368 
   ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 
 1550368 
   
 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/15753/diff/
 
 
 Testing
 ---
 
 New test case checking that the parameter maxNotificationInterval can be 
 configurable.
 
 The test case overwrites the receiveConnection method in QuorumCnxManager 
 class in order to avoid any answer to Fast Leader Election. Thus, FLE is 
 forced to retry increasing exponentially the notifications interval. This 
 interval is measured and the test case stops when 3 consecutive measures are 
 equal. The test case will be OK if the measure is the configured in the cfg 
 file.
 
 
 File Attachments
 
 
 ZOOKEEPER-1814.patch
   
 https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch
 
 
 Thanks,
 
 Daniel Peon

Success: ZOOKEEPER-1814 PreCommit Build #1830

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 296032 lines...]
 [exec] BUILD SUCCESSFUL
 [exec] Total time: 0 seconds
 [exec] 
 [exec] 
 [exec] 
 [exec] 
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618438/ZOOKEEPER-1814.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] dba5c9c20a6f81fdf01a4a97236118a1d3509a8e logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 34 minutes 33 seconds
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1814
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846507#comment-13846507
]

Hadoop QA commented on ZOOKEEPER-1814:
--

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12618438/ZOOKEEPER-1814.patch
against trunk revision 1550213.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1830//console

This message is automatically generated.

Reduction of waiting time during Fast Leader Election
-

Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch,
ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch

Original Estimate: 24h
Remaining Estimate: 24h

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1382) Zookeeper server holds onto dead/expired session ids in the watch data structures

2013-12-12 Thread JIRA


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846547#comment-13846547
 ] 

Germán Blanco commented on ZOOKEEPER-1382:
--

Thank you [~fournc]!

 Zookeeper server holds onto dead/expired session ids in the watch data 
 structures
 -

 Key: ZOOKEEPER-1382
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1382
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.5
Reporter: Neha Narkhede
Assignee: Germán Blanco
Priority: Critical
 Fix For: 3.4.6, 3.5.0

 Attachments: ZOOKEEPER-1382-branch-3.4.patch, 
 ZOOKEEPER-1382-branch-3.4.patch, ZOOKEEPER-1382-branch-3.4.patch, 
 ZOOKEEPER-1382-branch-3.4.patch, ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, 
 ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, ZOOKEEPER-1382.patch, 
 ZOOKEEPER-1382_3.3.4.patch


 I've observed that zookeeper server holds onto expired session ids in the 
 watcher data structures. The result is the wchp command reports session ids 
 that cannot be found through cons/dump and those expired session ids sit 
 there maybe until the server is restarted. Here are snippets from the client 
 and the server logs that lead to this state, for one particular session id 
 0x134485fd7bcb26f -
 There are 4 servers in the zookeeper cluster - 223, 224, 225 (leader), 226 
 and I'm using ZkClient to connect to the cluster
 From the application log -
 application.log.2012-01-26-325.gz:2012/01/26 04:56:36.177 INFO [ClientCnxn] 
 [main-SendThread(223.prod:12913)] [application Session establishment complete 
 on server 223.prod/172.17.135.38:12913, sessionid = 0x134485fd7bcb26f, 
 negotiated timeout = 6000
 application.log.2012-01-27.gz:2012/01/27 09:52:37.714 INFO [ClientCnxn] 
 [main-SendThread(223.prod:12913)] [application] Client session timed out, 
 have not heard from server in 9827ms for sessionid 0x134485fd7bcb26f, closing 
 socket connection and attempting reconnect
 application.log.2012-01-27.gz:2012/01/27 09:52:38.191 INFO [ClientCnxn] 
 [main-SendThread(226.prod:12913)] [application] Unable to reconnect to 
 ZooKeeper service, session 0x134485fd7bcb26f has expired, closing socket 
 connection
 On the leader zk, 225 -
 zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
 [SessionTracker:ZooKeeperServer@314] - Expiring session 0x134485fd7bcb26f, 
 timeout of 6000ms exceeded
 zookeeper.log.2012-01-27-leader-225.gz:2012-01-27 09:52:34,010 - INFO  
 [ProcessThread:-1:PrepRequestProcessor@391] - Processed session termination 
 for sessionid: 0x134485fd7bcb26f
 On the server, the client was initially connected to, 223 -
 zookeeper.log.2012-01-26-223.gz:2012-01-26 04:56:36,173 - INFO  
 [CommitProcessor:1:NIOServerCnxn@1580] - Established session 
 0x134485fd7bcb26f with negotiated timeout 6000 for client /172.17.136.82:45020
 zookeeper.log.2012-01-27-223.gz:2012-01-27 09:52:34,018 - INFO  
 [CommitProcessor:1:NIOServerCnxn@1435] - Closed socket connection for client 
 /172.17.136.82:45020 which had sessionid 0x134485fd7bcb26f
 Here are the log snippets from 226, which is the server, the client 
 reconnected to, before getting session expired event -
 2012-01-27 09:52:38,190 - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@770] - Client 
 attempting to renew session 0x134485fd7bcb26f at /172.17.136.82:49367
 2012-01-27 09:52:38,191 - INFO  
 [QuorumPeer:/0.0.0.0:12913:NIOServerCnxn@1573] - Invalid session 
 0x134485fd7bcb26f for client /172.17.136.82:49367, probably expired
 2012-01-27 09:52:38,191 - INFO  
 [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:12913:NIOServerCnxn@1435] - Closed 
 socket connection for client /172.17.136.82:49367 which had sessionid 
 0x134485fd7bcb26f
 wchp output from 226, taken on 01/30 -
 nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
 *226.*wchp* | wc -l
 3
 wchp output from 223, taken on 01/30 -
 nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
 *223.*wchp* | wc -l
 0
 cons output from 223 and 226, taken on 01/30 -
 nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
 *226.*cons* | wc -l
 0
 nnarkhed-ld:zk-cons-wchp-2012013000 nnarkhed$ grep 0x134485fd7bcb26f 
 *223.*cons* | wc -l
 0
 So, what seems to have happened is that the client was able to re-register 
 the watches on the new server (226), after it got disconnected from 223, 
 inspite of having an expired session id. 
 In NIOServerCnxn, I saw that after suspecting that a session is expired, a 
 server removes the cnxn and its watches from its internal data structures. 
 But before that it allows more requests to be processed even if the session 
 is expired -
 // Now that the session is ready we can start

Re: Status of 3.4.6

2013-12-12 Thread German Blanco

Hello Flavio,

this looks great now, only one small problem and the deployment to go!
Congratulations!

I have taken a look at the windows build in Jenkins, and I am going to make
a wild guess at what it might be happening, I hope it is worth anything.
In many of the errors, the assertion in JMXEnv.java:115 is failing.
The call is from ClientBase.java:197. I see something strange there, it
seems that the procedure might close the client in one of the conditions
(line 193) and still then check that it is there in line 197. So if closing
is fast enough, the checking fails. Could that be it?

Regards,

German.


On Thu, Dec 12, 2013 at 5:24 PM, FPJ fpjunque...@yahoo.com wrote:

 There are two issues blocking 3.4.6 now:



 -  I don't understand why the 3.4 windows build in failing on
 Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing to
 have a look, I would appreciate some help.

 -  ZK-1430 needs to get in and I'd like to understand what needs to
 be done for ZK-1402.



 Thanks,

 -Flavio

Re: Status of 3.4.6

2013-12-12 Thread German Blanco

... there is a similar situation in JMXEnv.java:138. It seems that
ensureOnly gets call before the previously invoked shutdown has completed.
The problem here is that one needs the Jenkins build in order to test what
is really happening :-(


On Thu, Dec 12, 2013 at 7:57 PM, German Blanco 
german.blanco.bla...@gmail.com wrote:

 Hello Flavio,

 this looks great now, only one small problem and the deployment to go!
 Congratulations!

 I have taken a look at the windows build in Jenkins, and I am going to
 make a wild guess at what it might be happening, I hope it is worth
 anything.
 In many of the errors, the assertion in JMXEnv.java:115 is failing.
 The call is from ClientBase.java:197. I see something strange there, it
 seems that the procedure might close the client in one of the conditions
 (line 193) and still then check that it is there in line 197. So if closing
 is fast enough, the checking fails. Could that be it?

 Regards,

 German.


 On Thu, Dec 12, 2013 at 5:24 PM, FPJ fpjunque...@yahoo.com wrote:

 There are two issues blocking 3.4.6 now:



 -  I don't understand why the 3.4 windows build in failing on
 Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing
 to
 have a look, I would appreciate some help.

 -  ZK-1430 needs to get in and I'd like to understand what needs
 to
 be done for ZK-1402.



 Thanks,

 -Flavio

[jira] [Created] (ZOOKEEPER-1835) dynamic configuration file renaming fails on Windows

2013-12-12 Thread Bruno Freudensprung (JIRA)

Bruno Freudensprung created ZOOKEEPER-1835:
--

 Summary: dynamic configuration file renaming fails on Windows
 Key: ZOOKEEPER-1835
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1835
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.0
 Environment: Windows 7 64-bit, Oracle Java  1.6.0_32-b05
Reporter: Bruno Freudensprung


On Windows, reconfig fails to rename the tmp dynamic config file to the real 
dynamic config filename.
Javadoc of java.io.File.renameTo says the behavior is highly plateform 
dependent, so I guess this should not be a big surprise.
The problem occurs in 
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java that 
could be modified like this:
+ curFile.delete();
if (!tmpFile.renameTo(curFile)) {
+ configFile.delete();
if (!tmpFile.renameTo(configFile)) {
As suggested by Alex in https://issues.apache.org/jira/browse/ZOOKEEPER-1691 
(btw there is more information about my test scenario over there) it is a bit 
scary to delete the current configuration file.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

2013-12-12 Thread Bruno Freudensprung (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846741#comment-13846741
 ] 

Bruno Freudensprung commented on ZOOKEEPER-1691:


Hi Alex,

Thanks for your answer. I feel sorry having done a pointless test and I hope 
the following one will be more interesting. 
As suggested, here is the JIRA about the renaming:
https://issues.apache.org/jira/browse/ZOOKEEPER-1835

Bruno.

 Add a flag to disable standalone mode
 -

 Key: ZOOKEEPER-1691
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691
 Project: ZooKeeper
  Issue Type: Improvement
  Components: quorum
Reporter: Michi Mutsuzaki
Assignee: Helen Hastings
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, 
 ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, 
 ZOOKEEPER-1691.patch, test scenario.txt


 Currently you cannot use dynamic reconfiguration to bootstrap zookeeper 
 cluster because the server goes into standalone mode when there is only one 
 server in the cluster.
 --Michi



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Status of 3.4.6

2013-12-12 Thread Flavio Junqueira

Good points. I'm not sure if the client being being closed is what is causing 
the test failure, but it is not a bad guess. I think we need to execute 
ensureAll only in the case we add the client. The observation about ensureOnly 
seems right to me.

We will need to get those in to get Jenkins to run. Do you want to create a 
subtask of ZK-1833 and propose these changes in a patch? If you propose a 
patch, we can give it a try and see.

There are other failures unrelated to this, though. Example:

[junit] 2013-12-12 08:55:48,245 [myid:] - INFO  [main:ZKTestCase$1@65] - FAILED 
testStartupFailureCreate
[junit] org.junit.internal.runners.model.MultipleFailureException
[junit] at 
org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23)
[junit] at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42)
[junit] at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
[junit] at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
[junit] at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
[junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
[junit] at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
[junit] at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
[junit] at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
[junit] at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
[junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
[junit] at 
junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
[junit] at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)

On Dec 12, 2013, at 7:07 PM, German Blanco german.blanco.bla...@gmail.com 
wrote:

 ... there is a similar situation in JMXEnv.java:138. It seems that
 ensureOnly gets call before the previously invoked shutdown has completed.
 The problem here is that one needs the Jenkins build in order to test what
 is really happening :-(
 
 
 On Thu, Dec 12, 2013 at 7:57 PM, German Blanco 
 german.blanco.bla...@gmail.com wrote:
 
 Hello Flavio,
 
 this looks great now, only one small problem and the deployment to go!
 Congratulations!
 
 I have taken a look at the windows build in Jenkins, and I am going to
 make a wild guess at what it might be happening, I hope it is worth
 anything.
 In many of the errors, the assertion in JMXEnv.java:115 is failing.
 The call is from ClientBase.java:197. I see something strange there, it
 seems that the procedure might close the client in one of the conditions
 (line 193) and still then check that it is there in line 197. So if closing
 is fast enough, the checking fails. Could that be it?
 
 Regards,
 
 German.
 
 
 On Thu, Dec 12, 2013 at 5:24 PM, FPJ fpjunque...@yahoo.com wrote:
 
 There are two issues blocking 3.4.6 now:
 
 
 
 -  I don't understand why the 3.4 windows build in failing on
 Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing
 to
 have a look, I would appreciate some help.
 
 -  ZK-1430 needs to get in and I'd like to understand what needs
 to
 be done for ZK-1402.
 
 
 
 Thanks,
 
 -Flavio

[jira] [Assigned] (ZOOKEEPER-1833) fix 3.4 windows build


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki reassigned ZOOKEEPER-1833:
--

Assignee: Michi Mutsuzaki  (was: some one)

 fix 3.4 windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 [junit] 2013-12-06 10:07:55,361 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBehindLeader
 [junit] 2013-12-06 10:10:57,439 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLateLogs
 [junit] 2013-12-06

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

2013-12-12 Thread Bruno Freudensprung (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846779#comment-13846779
 ] 

Bruno Freudensprung commented on ZOOKEEPER-1691:


Here is my next test. Reconfig has been successful although I am still unsure 
about correct start conditions (should zoo.cfg files have 
standaloneEnabled=false or standaloneEnabled=true?). I assume false in this 
test (well.. I couldn't make it work with false anyway, I guess it is the 
situation described here https://issues.apache.org/jira/browse/ZOOKEEPER-1726)

== Server 1 zoo.cfg:
standaloneEnabled=false
dynamicConfigFile=path to/confdyn1/zoo.cfg.dynamic

== Server 1 zoo.cfg.dynamic:
server.1=localhost:2888:3888:participant;localhost:2181

Now say I want to add server 2 to the server 1 cluster.

== Server 2 zoo.cfg:
standaloneEnabled=false
dynamicConfigFile=path to/confdyn2/zoo.cfg.dynamic

== Server 2 zoo.cfg.dynamic (it is aware of the server 1, as mentioned in the 
Dynamic Reconfiguration - User Manual
that I should have read more carefully yesterday):
server.1=localhost:2888:3888:participant;localhost:2181
server.2=localhost:2889:3889:participant;localhost:2182

Start server 1 = OK
Start server 2 = OK but something rather strange happens, server 2  
zoo.cfg.dynamic now becomes (server.2 line disappears, although server 2 myid 
file contains 2):

server.1=localhost:2888:3888:participant;localhost:2181
version=1

== connect client 1 to server 1 and ask for the config:
[zk: localhost:2181(CONNECTED) 0] config
server.1=localhost:2888:3888:participant;localhost:2181
version=1
[zk: localhost:2181(CONNECTED) 1]

== connect client 2 to server 2 and ask for the config:
[zk: localhost:2182(CONNECTED) 1] config
server.1=localhost:2888:3888:participant;localhost:2181
version=1
[zk: localhost:2182(CONNECTED) 2]

== use client 1 to issue a reconfig command on server 1:
[zk: localhost:2181(CONNECTED) 1] reconfig -add 
server.2=localhost:2889:3889:participant;localhost:2182
Committed new configuration:
server.1=localhost:2888:3888:participant;localhost:2181
server.2=localhost:2889:3889:participant;localhost:2182
version=10003
[zk: localhost:2181(CONNECTED) 2]

== display config from client 2 connected to server 2:
[zk: localhost:2182(CONNECTED) 2] config
server.1=localhost:2888:3888:participant;localhost:2181
server.2=localhost:2889:3889:participant;localhost:2182
version=10003
[zk: localhost:2182(CONNECTED) 3]

Looks fine!! Nodes created from client 1 are visible to client 2 and vice-versa.
Still, I can see strange stack traces in both server consoles.

Server 1:
2013-12-12 22:31:40,888 [myid:1] - WARN  [ProcessThread(sid:1 
cport:-1)::QuorumCnxManager@390] - Cannot open channel to 2 at election address 
localhost/127.0.0.1:3889
java.net.ConnectException: Connection refused: connect
at java.net.PlainSocketImpl.socketConnect(Native Method)
at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:351)
at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:213)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:200)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
at java.net.Socket.connect(Socket.java:529)
at 
org.apache.zookeeper.server.quorum.QuorumCnxManager.connectOne(QuorumCnxManager.java:375)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.connectNewPeers(QuorumPeer.java:1252)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.setLastSeenQuorumVerifier(QuorumPeer.java:1272)
at org.apache.zookeeper.server.quorum.Leader.propose(Leader.java:1071)
at 
org.apache.zookeeper.server.quorum.ProposalRequestProcessor.processRequest(ProposalRequestProcessor.java:78)
at 
org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:864)
at 
org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:144)
2013-12-12 22:31:41,919 [myid:1] - WARN  
[LearnerHandler-/127.0.0.1:52301:QuorumPeer@1259] - Restarting Leader Election
2013-12-12 22:31:41,920 [myid:1] - INFO  
[localhost/127.0.0.1:3888:QuorumCnxManager$Listener@571] - Leaving listener
2013-12-12 22:31:41,920 [myid:1] - INFO  
[QuorumPeerListener:QuorumCnxManager$Listener@544] - My election bind port: 
localhost/127.0.0.1:3888
2013-12-12 22:31:44,438 [myid:1] - INFO  
[WorkerReceiver[myid=1]:FastLeaderElection$Messenger$WorkerReceiver@410] - 
WorkerReceiver is down
2013-12-12 22:31:44,439 [myid:1] - INFO  
[WorkerSender[myid=1]:FastLeaderElection$Messenger$WorkerSender@442] - 
WorkerSender is down

Server 2:
2013-12-12 22:31:41,894 [myid:2] - WARN  
[QuorumPeer[myid=2]/127.0.0.1:2182:QuorumCnxManager@390] - Cannot open channel 
to 2 at election address localhost/127.0.0.1:3889
java.net.ConnectException: Connection refused: connect
at java.net.PlainSocketImpl.socketConnect(Native

Re: Status of 3.4.6

2013-12-12 Thread Michi Mutsuzaki

I'm running the build on my local windows box right now. I am seeing some
test failures, although the number of failures is much less. I'll
update the jira
when I finish running the test.

Also, I just noticed that ZooKeeper-trunk-WinVS2008_java has been timing out.
I didn't know ZooKeeper-trunk-WinVS2008 doesn't run ant test, and I somehow
assumed the gray status means the build is disabled. I increased the timeout
from 2 hours to 4 hours and restart the test. I'm pretty sure it'll
fail, but at least
we'll know that it's not just 3.4 branch that's broken.


On Thu, Dec 12, 2013 at 1:27 PM, Flavio Junqueira fpjunque...@yahoo.com wrote:
 Good points. I'm not sure if the client being being closed is what is causing 
 the test failure, but it is not a bad guess. I think we need to execute 
 ensureAll only in the case we add the client. The observation about 
 ensureOnly seems right to me.

 We will need to get those in to get Jenkins to run. Do you want to create a 
 subtask of ZK-1833 and propose these changes in a patch? If you propose a 
 patch, we can give it a try and see.

 There are other failures unrelated to this, though. Example:

 [junit] 2013-12-12 08:55:48,245 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] org.junit.internal.runners.model.MultipleFailureException
 [junit] at 
 org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23)
 [junit] at 
 org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42)
 [junit] at 
 org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
 [junit] at 
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
 [junit] at 
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
 [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
 [junit] at 
 org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
 [junit] at 
 org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
 [junit] at 
 org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
 [junit] at 
 org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
 [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
 [junit] at 
 junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)

 On Dec 12, 2013, at 7:07 PM, German Blanco german.blanco.bla...@gmail.com 
 wrote:

 ... there is a similar situation in JMXEnv.java:138. It seems that
 ensureOnly gets call before the previously invoked shutdown has completed.
 The problem here is that one needs the Jenkins build in order to test what
 is really happening :-(


 On Thu, Dec 12, 2013 at 7:57 PM, German Blanco 
 german.blanco.bla...@gmail.com wrote:

 Hello Flavio,

 this looks great now, only one small problem and the deployment to go!
 Congratulations!

 I have taken a look at the windows build in Jenkins, and I am going to
 make a wild guess at what it might be happening, I hope it is worth
 anything.
 In many of the errors, the assertion in JMXEnv.java:115 is failing.
 The call is from ClientBase.java:197. I see something strange there, it
 seems that the procedure might close the client in one of the conditions
 (line 193) and still then check that it is there in line 197. So if closing
 is fast enough, the checking fails. Could that be it?

 Regards,

 German.


 On Thu, Dec 12, 2013 at 5:24 PM, FPJ fpjunque...@yahoo.com wrote:

 There are two issues blocking 3.4.6 now:



 -  I don't understand why the 3.4 windows build in failing on
 Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing
 to
 have a look, I would appreciate some help.

 -  ZK-1430 needs to get in and I'd like to understand what needs
 to
 be done for ZK-1402.



 Thanks,

 -Flavio

[jira] [Commented] (ZOOKEEPER-1833) fix 3.4 windows build


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846892#comment-13846892
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1833:


The following tests failed on my local windows box:

- org.apache.zookeeper.test.FLETest
Testcase: testLE took 7.8 sec
FAILED
Leader hasn't joined: 5
junit.framework.AssertionFailedError: Leader hasn't joined: 5
at org.apache.zookeeper.test.FLETest.testLE(FLETest.java:313)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

- org.apache.zookeeper.test.ClientPortBindTest
java.net.SocketException: Address family not supported by protocol family: bind
at sun.nio.ch.Net.bind(Native Method)
at 
sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:126)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:59)
at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:52)
at 
org.apache.zookeeper.server.NIOServerCnxnFactory.configure(NIOServerCnxnFactory.java:95)
at 
org.apache.zookeeper.server.ServerCnxnFactory.createFactory(ServerCnxnFactory.java:126)
at 
org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress(ClientPortBindTest.java:84)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

- org.apache.zookeeper.test.NioNettySuiteHammerTest
- org.apache.zookeeper.test.NioNettySuiteTest
- org.apache.zookeeper.test.SaslAuthFailNotifyTest
Timeout.

 fix 3.4 windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED

[jira] [Commented] (ZOOKEEPER-1833) fix 3.4 windows build


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846906#comment-13846906
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1833:


ClientPortBindTest error seems to be a known issue. NIO in java6 doesn't work 
with IPv6 on windows.

 fix 3.4 windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 [junit] 2013-12-06 10:07:55,361 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBehindLeader
 [junit]

ZooKeeper-trunk-WinVS2008_java - Build # 622 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008_java/622/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 271774 lines...]
[junit] 2013-12-13 00:00:43,718 [myid:] - INFO  [main:ZooKeeperServer@149] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test5100204417961579608.junit.dir\version-2
 snapdir 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test5100204417961579608.junit.dir\version-2
[junit] 2013-12-13 00:00:43,729 [myid:] - INFO  
[main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 1 selector thread(s), 4 worker threads, and 64 
kB direct buffers.
[junit] 2013-12-13 00:00:43,730 [myid:] - INFO  
[main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-12-13 00:00:43,733 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test5100204417961579608.junit.dir\version-2\snapshot.b
[junit] 2013-12-13 00:00:43,815 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62339
[junit] 2013-12-13 00:00:43,815 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@882] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2013-12-13 00:00:43,831 [myid:] - WARN  
[NIOWorkerThread-1:NIOServerCnxn@372] - Exception causing close of session 0x0: 
ZooKeeperServer not running
[junit] 2013-12-13 00:00:43,831 [myid:] - INFO  [main:FileTxnSnapLog@297] - 
Snapshotting: 0xb to 
f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008_java\trunk\build\test\tmp\test5100204417961579608.junit.dir\version-2\snapshot.b
[junit] 2013-12-13 00:00:43,930 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:62339 (no session established for client)
[junit] 2013-12-13 00:00:43,931 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1124] - Unable to read 
additional data from server sessionid 0x142e9414c4d, likely server has 
closed socket, closing socket connection and attempting reconnect
[junit] 2013-12-13 00:00:43,932 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2013-12-13 00:00:43,933 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62344
[junit] 2013-12-13 00:00:43,934 [myid:] - INFO  
[NIOWorkerThread-2:NIOServerCnxn@835] - Processing stat command from 
/127.0.0.1:62344
[junit] 2013-12-13 00:00:43,934 [myid:] - INFO  
[NIOWorkerThread-2:NIOServerCnxn$StatCommand@684] - Stat command output
[junit] 2013-12-13 00:00:44,032 [myid:] - INFO  
[NIOWorkerThread-2:NIOServerCnxn@1006] - Closed socket connection for client 
/127.0.0.1:62344 (no session established for client)
[junit] 2013-12-13 00:00:44,032 [myid:] - INFO  [main:JMXEnv@133] - 
ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] 2013-12-13 00:00:44,034 [myid:] - INFO  [main:JMXEnv@105] - 
expect:InMemoryDataTree
[junit] 2013-12-13 00:00:44,034 [myid:] - INFO  [main:JMXEnv@108] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] 2013-12-13 00:00:44,132 [myid:] - INFO  [main:JMXEnv@105] - 
expect:StandaloneServer_port
[junit] 2013-12-13 00:00:44,132 [myid:] - INFO  [main:JMXEnv@108] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-12-13 00:00:44,132 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota
[junit] 2013-12-13 00:00:44,132 [myid:] - INFO  [main:ClientBase@451] - 
tearDown starting
[junit] 2013-12-13 00:00:45,000 [myid:] - INFO  
[SessionTracker:SessionTrackerImpl@134] - SessionTrackerImpl exited loop!
[junit] 2013-12-13 00:00:45,638 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1008] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11221. Will not attempt to 
authenticate using SASL (java.lang.SecurityException: Unable to locate a login 
configuration)
[junit] 2013-12-13 00:00:45,639 [myid:] - INFO  
[main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@882] - Socket 
connection established to 127.0.0.1/127.0.0.1:11221, initiating session
[junit] 2013-12-13 00:00:45,639 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted

[jira] [Updated] (ZOOKEEPER-1833) fix windows build


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-1833:
---

Summary: fix windows build  (was: fix 3.4 windows build)

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 [junit] 2013-12-06 10:07:55,361 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBehindLeader
 [junit] 2013-12-06 10:10:57,439 [myid:] - INFO  [main:ZKTestCase$1@65] -

[jira] [Updated] (ZOOKEEPER-1833) fix 3.4 windows build


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michi Mutsuzaki updated ZOOKEEPER-1833:
---

Attachment: ZOOKEEPER-1833.patch

 fix 3.4 windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testSessionMoved
 [junit] 2013-12-06 10:04:50,542 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testMultiToFollower
 [junit] 2013-12-06 10:07:55,361 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBehindLeader
 [junit] 2013-12-06 10:10:57,439 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED

Re: Status of 3.4.6

2013-12-12 Thread Michi Mutsuzaki

I uploaded a patch that fixes ClientPortBindTest.

https://issues.apache.org/jira/browse/ZOOKEEPER-1833

On Thu, Dec 12, 2013 at 2:14 PM, Michi Mutsuzaki mi...@cs.stanford.edu wrote:
 I'm running the build on my local windows box right now. I am seeing some
 test failures, although the number of failures is much less. I'll
 update the jira
 when I finish running the test.

 Also, I just noticed that ZooKeeper-trunk-WinVS2008_java has been timing out.
 I didn't know ZooKeeper-trunk-WinVS2008 doesn't run ant test, and I somehow
 assumed the gray status means the build is disabled. I increased the timeout
 from 2 hours to 4 hours and restart the test. I'm pretty sure it'll
 fail, but at least
 we'll know that it's not just 3.4 branch that's broken.


 On Thu, Dec 12, 2013 at 1:27 PM, Flavio Junqueira fpjunque...@yahoo.com 
 wrote:
 Good points. I'm not sure if the client being being closed is what is 
 causing the test failure, but it is not a bad guess. I think we need to 
 execute ensureAll only in the case we add the client. The observation about 
 ensureOnly seems right to me.

 We will need to get those in to get Jenkins to run. Do you want to create a 
 subtask of ZK-1833 and propose these changes in a patch? If you propose a 
 patch, we can give it a try and see.

 There are other failures unrelated to this, though. Example:

 [junit] 2013-12-12 08:55:48,245 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] org.junit.internal.runners.model.MultipleFailureException
 [junit] at 
 org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23)
 [junit] at 
 org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42)
 [junit] at 
 org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
 [junit] at 
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
 [junit] at 
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
 [junit] at 
 org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
 [junit] at 
 org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
 [junit] at 
 org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
 [junit] at 
 org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
 [junit] at 
 org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
 [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
 [junit] at 
 junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
 [junit] at 
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)

 On Dec 12, 2013, at 7:07 PM, German Blanco german.blanco.bla...@gmail.com 
 wrote:

 ... there is a similar situation in JMXEnv.java:138. It seems that
 ensureOnly gets call before the previously invoked shutdown has completed.
 The problem here is that one needs the Jenkins build in order to test what
 is really happening :-(


 On Thu, Dec 12, 2013 at 7:57 PM, German Blanco 
 german.blanco.bla...@gmail.com wrote:

 Hello Flavio,

 this looks great now, only one small problem and the deployment to go!
 Congratulations!

 I have taken a look at the windows build in Jenkins, and I am going to
 make a wild guess at what it might be happening, I hope it is worth
 anything.
 In many of the errors, the assertion in JMXEnv.java:115 is failing.
 The call is from ClientBase.java:197. I see something strange there, it
 seems that the procedure might close the client in one of the conditions
 (line 193) and still then check that it is there in line 197. So if closing
 is fast enough, the checking fails. Could that be it?

 Regards,

 German.


 On Thu, Dec 12, 2013 at 5:24 PM, FPJ fpjunque...@yahoo.com wrote:

 There are two issues blocking 3.4.6 now:



 -  I don't understand why the 3.4 windows build in failing on
 Jenkins. Tests seem to pass fine on Windows for me. If anyone is willing
 to
 have a look, I would appreciate some help.

 -  ZK-1430 needs to get in and I'd like to understand what needs
 to
 be done for ZK-1402.



 Thanks,

 -Flavio

[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode

2013-12-12 Thread Alexander Shraer (JIRA)

[
https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846973#comment-13846973
]

Alexander Shraer commented on ZOOKEEPER-1691:
-

Hi Bruno,

standaloneEnabled=false seems correct. Otherwise you would not be able to
connect the servers since each of them would form a separate standalone
ensemble. The fact that server 2's line disappears initially from its own
config is expected - once it syncs with the leader it adopts the current config
in which its not yet a member. the initial config you start it with is invalid
and only used to bootstrap server 2. Its sort of a hack, I agree, but we need
to tell it which ports to listen to initially, etc.

The error messages may indicate a bug or two. The second one from server 2
means that its trying to initiate a connection to itself, which I don't think
should happen. The fix for this seems easy. I'm not sure about the reason for
server 1's error message. In any case, would be great if you open a JIRA for
this, you can assign it to me.

Thanks,
Alex

Add a flag to disable standalone mode
-

Key: ZOOKEEPER-1691
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Reporter: Michi Mutsuzaki
Assignee: Helen Hastings
Fix For: 3.5.0

Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch,
ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch,
ZOOKEEPER-1691.patch, test scenario.txt

Currently you cannot use dynamic reconfiguration to bootstrap zookeeper
cluster because the server goes into standalone mode when there is only one
server in the cluster.
--Michi

--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Failed: ZOOKEEPER-1833 PreCommit Build #1831

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 303597 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618502/ZOOKEEPER-1833.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 14f2df57a452ee2b366501b0562fcd8dfed734b7 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 32 minutes 37 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1833
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1833) fix windows build


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846983#comment-13846983
 ] 

Hadoop QA commented on ZOOKEEPER-1833:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12618502/ZOOKEEPER-1833.patch
  against trunk revision 1550213.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1831//console

This message is automatically generated.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED

[jira] [Commented] (ZOOKEEPER-1833) fix windows build


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846990#comment-13846990
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1833:


{quote}
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

This patch only modifies build.xml. I manually ran ClientPortBindTest on a 
windows box and verified that this patch fixes the test.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testFourLetterWords
 [junit] 2013-12-06 09:14:03,770 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testLE
 [junit] 2013-12-06 09:46:30,002 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHierarchicalQuorum
 [junit] 2013-12-06 09:50:26,912 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHammerBasic
 [junit] 2013-12-06 09:51:07,604 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testQuotaWithQuorum
 [junit] 2013-12-06 09:52:41,515 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testNull
 [junit] 2013-12-06 09:53:22,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testDeleteWithChildren
 [junit] 2013-12-06 09:56:49,061 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:58:27,705 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testGetView
 [junit] 2013-12-06 09:59:07,856 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testViewContains
 [junit] 2013-12-06 10:01:31,418

Failed: ZOOKEEPER-1833 PreCommit Build #1832

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 288913 lines...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12618502/ZOOKEEPER-1833.patch
 [exec]   against trunk revision 1550213.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.9) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5f02f4ed82fe4076e0af670e970d789eb7ee99b8 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623:
 exec returned: 1

Total time: 34 minutes 26 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Description set: ZOOKEEPER-1833
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-1833) fix windows build


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846993#comment-13846993
 ] 

Hadoop QA commented on ZOOKEEPER-1833:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12618502/ZOOKEEPER-1833.patch
  against trunk revision 1550213.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1832//console

This message is automatically generated.

 fix windows build
 -

 Key: ZOOKEEPER-1833
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
 Fix For: 3.4.6

 Attachments: ZOOKEEPER-1833.patch


 A bunch of 3.4 tests are failing on windows.
 {noformat}
 [junit] 2013-12-06 08:40:59,692 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testEarlyLeaderAbandonment
 [junit] 2013-12-06 08:41:10,472 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testHighestZxidJoinLate
 [junit] 2013-12-06 08:45:31,085 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testUpdatingEpoch
 [junit] 2013-12-06 08:55:34,630 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testObserversHammer
 [junit] 2013-12-06 08:55:59,889 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncExistsFailure_NoNode
 [junit] 2013-12-06 08:56:00,571 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetACL
 [junit] 2013-12-06 08:56:02,626 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenEmpty
 [junit] 2013-12-06 08:56:03,491 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenSingle
 [junit] 2013-12-06 08:56:11,276 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenTwo
 [junit] 2013-12-06 08:56:13,878 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildrenFailure_NoNode
 [junit] 2013-12-06 08:56:16,294 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Empty
 [junit] 2013-12-06 08:56:18,622 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Single
 [junit] 2013-12-06 08:56:21,224 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Two
 [junit] 2013-12-06 08:56:23,738 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetChildren2Failure_NoNode
 [junit] 2013-12-06 08:56:26,058 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetData
 [junit] 2013-12-06 08:56:28,482 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testAsyncGetDataFailure_NoNode
 [junit] 2013-12-06 08:57:35,527 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureCreate
 [junit] 2013-12-06 08:57:38,645 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSet
 [junit] 2013-12-06 08:57:41,261 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testStartupFailureSnapshot
 [junit] 2013-12-06 08:59:22,222 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientWithWatcherObj
 [junit] 2013-12-06 09:00:05,592 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientCleanup
 [junit] 2013-12-06 09:01:24,113 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testBindByAddress
 [junit] 2013-12-06 09:02:14,123 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testClientwithoutWatcherObj
 [junit] 2013-12-06 09:05:56,461 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testZeroWeightQuorum
 [junit] 2013-12-06 09:08:18,747 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED testResyncByDiffAfterFollowerCrashes
 [junit] 2013-12-06 09:09:42,271 [myid:] - INFO  [main:ZKTestCase$1@65] - 
 FAILED

[jira] [Created] (ZOOKEEPER-1836) addrvec_next() fails to set next parameter if addrvec_hasnext() returns false

2013-12-12 Thread Dutch T. Meyer (JIRA)

Dutch T. Meyer created ZOOKEEPER-1836:
-

 Summary: addrvec_next() fails to set next parameter if 
addrvec_hasnext() returns false
 Key: ZOOKEEPER-1836
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1836
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Reporter: Dutch T. Meyer
Priority: Trivial


There is a relatively innocuous but useless pointer assignment in
addrvec_next():

195 void addrvec_next(addrvec_t *avec, struct sockaddr_storage *next)

203 if (!addrvec_hasnext(avec))
204 {
205 next = NULL;
206 return;

That assignment on (205) has no point, as next is a local variable lost upon 
function return.  Likely this should be a memset to zero out the actual 
parameter.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (ZOOKEEPER-1576) Zookeeper cluster - failed to connect to cluster if one of the provided IPs causes java.net.UnknownHostException

2013-12-12 Thread Benjamin Jaton (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Jaton updated ZOOKEEPER-1576:
--

Attachment: ZOOKEEPER-1576-3.4.patch

Patch for 3.4

 Zookeeper cluster - failed to connect to cluster if one of the provided IPs 
 causes java.net.UnknownHostException
 

 Key: ZOOKEEPER-1576
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1576
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.0
 Environment: Three 3.4.3 zookeeper servers in cluster, linux.
Reporter: Tally Tsabary
Assignee: Edward Ribeiro
 Fix For: 3.5.0

 Attachments: ZOOKEEPER-1576-3.4.patch, ZOOKEEPER-1576.3.patch, 
 ZOOKEEPER-1576.4.patch, ZOOKEEPER-1576.5.patch


 Using a cluster of three 3.4.3 zookeeper servers.
 All the servers are up, but on the client machine, the firewall is blocking 
 one of the  servers.
 The following exception is happening, and the client is not connected to any 
 of the other cluster members.
 The exception:Nov 02, 2012 9:54:32 PM 
 com.netflix.curator.framework.imps.CuratorFrameworkImpl logError
 SEVERE: Background exception was not retry-able or retry gave up
 java.net.UnknownHostException: scnrmq003.myworkday.com
 at java.net.Inet4AddressImpl.lookupAllHostAddr(Native Method)
 at java.net.InetAddress$1.lookupAllHostAddr(Unknown Source)
 at java.net.InetAddress.getAddressesFromNameService(Unknown Source)
 at java.net.InetAddress.getAllByName0(Unknown Source)
 at java.net.InetAddress.getAllByName(Unknown Source)
 at java.net.InetAddress.getAllByName(Unknown Source)
 at 
 org.apache.zookeeper.client.StaticHostProvider.init(StaticHostProvider.java:60)
 at org.apache.zookeeper.ZooKeeper.init(ZooKeeper.java:440)
 at org.apache.zookeeper.ZooKeeper.init(ZooKeeper.java:375)
 The code at the 
 org.apache.zookeeper.client.StaticHostProvider.init(StaticHostProvider.java:60)
  is :
 public StaticHostProvider(CollectionInetSocketAddress serverAddresses) 
 throws UnknownHostException {
 for (InetSocketAddress address : serverAddresses) {
 InetAddress resolvedAddresses[] = InetAddress.getAllByName(address
 .getHostName());
 for (InetAddress resolvedAddress : resolvedAddresses) { 
 this.serverAddresses.add(new InetSocketAddress(resolvedAddress 
 .getHostAddress(), address.getPort())); }
 }
 ..
 The for-loop is not trying to resolve the rest of the servers on the list if 
 there is an UnknownHostException at the 
 InetAddress.getAllByName(address.getHostName()); 
 and it fails the client connection creation.
 I was expecting the connection will be created for the other members of the 
 cluster. 
 Also, InetAddress is a blocking command, and if it takes very long time,  
 (longer than the defined timeout) - that also should allow us to continue to 
 try and connect to the other servers on the list.
 Assuming this will be fixed, and we will get connection to the current 
 available servers, I think the zookeeper should continue to retry to connect 
 to the not-connected server of the cluster, so it will be able to use it 
 later when it is back.
 If one of the servers on the list is not available during the connection 
 creation, then it should be retried every x time despite the fact that we 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (ZOOKEEPER-1836) addrvec_next() fails to set next parameter if addrvec_hasnext() returns false

2013-12-12 Thread Marshall McMullen (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847116#comment-13847116
 ] 

Marshall McMullen commented on ZOOKEEPER-1836:
--

Yes, that was what I intended for this to do. Nice catch. 

Would be great if you could submit a patch. If you can't I'll look at this 
later this week.

 addrvec_next() fails to set next parameter if addrvec_hasnext() returns false
 -

 Key: ZOOKEEPER-1836
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1836
 Project: ZooKeeper
  Issue Type: Bug
  Components: c client
Reporter: Dutch T. Meyer
Priority: Trivial

 There is a relatively innocuous but useless pointer assignment in
 addrvec_next():
 195   void addrvec_next(addrvec_t *avec, struct sockaddr_storage *next)
 
 203   if (!addrvec_hasnext(avec))
 204   {
 205   next = NULL;
 206   return;
 That assignment on (205) has no point, as next is a local variable lost upon 
 function return.  Likely this should be a memset to zero out the actual 
 parameter.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

ZooKeeper_branch33_solaris - Build # 735 - Failure

See https://builds.apache.org/job/ZooKeeper_branch33_solaris/735/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 103129 lines...]
[junit] 2013-12-13 07:07:26,925 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test8868562298213392774.junit.dir/version-2/snapshot.0
[junit] 2013-12-13 07:07:26,929 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-12-13 07:07:26,931 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-12-13 07:07:26,933 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:51073
[junit] 2013-12-13 07:07:26,933 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:51073
[junit] 2013-12-13 07:07:26,934 - INFO  
[Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-12-13 07:07:26,935 - INFO  [Thread-4:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:51073 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-12-13 07:07:26,937 - INFO  [main:ClientBase@408] - STOPPING 
server
[junit] 2013-12-13 07:07:26,939 - INFO  
[SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited!
[junit] 2013-12-13 07:07:26,939 - INFO  
[ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop!
[junit] 2013-12-13 07:07:26,939 - INFO  [main:FinalRequestProcessor@370] - 
shutdown of request processor complete
[junit] 2013-12-13 07:07:26,941 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] ensureOnly:[]
[junit] 2013-12-13 07:07:26,943 - INFO  [main:ClientBase@401] - STARTING 
server
[junit] 2013-12-13 07:07:26,944 - INFO  [main:ZooKeeperServer@154] - 
Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test8868562298213392774.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test8868562298213392774.junit.dir/version-2
[junit] 2013-12-13 07:07:26,945 - INFO  [main:NIOServerCnxn$Factory@143] - 
binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2013-12-13 07:07:26,947 - INFO  [main:FileSnap@82] - Reading 
snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test8868562298213392774.junit.dir/version-2/snapshot.b
[junit] 2013-12-13 07:07:26,950 - INFO  [main:FileTxnSnapLog@256] - 
Snapshotting: b
[junit] 2013-12-13 07:07:26,952 - INFO  [main:FourLetterWordMain@43] - 
connecting to 127.0.0.1 11221
[junit] 2013-12-13 07:07:26,953 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - 
Accepted socket connection from /127.0.0.1:51075
[junit] 2013-12-13 07:07:26,954 - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing 
stat command from /127.0.0.1:51075
[junit] 2013-12-13 07:07:26,955 - INFO  
[Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output
[junit] 2013-12-13 07:07:26,956 - INFO  [Thread-5:NIOServerCnxn@1435] - 
Closed socket connection for client /127.0.0.1:51075 (no session established 
for client)
[junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port]
[junit] expect:InMemoryDataTree
[junit] found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree
[junit] expect:StandaloneServer_port
[junit] found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port-1
[junit] 2013-12-13 07:07:26,959 - INFO  [main:ClientBase@431] - tearDown 
starting
[junit] 2013-12-13 07:07:26,960 - INFO  [main:ClientBase@443] - fdcount 
after test is: 41
[junit] 2013-12-13 07:07:27,007 - INFO  
[SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop!
[junit] 2013-12-13 07:07:27,007 - INFO  
[SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop!
[junit] 2013-12-13 07:07:27,028 - INFO  [main:ZooKeeper@544] - Session: 
0x142eac80692 closed
[junit] 2013-12-13 07:07:27,028 - INFO  [main:ClientBase@408] - STOPPING 
server
[junit] 2013-12-13 07:07:27,028 - INFO

Re: Status of 3.4.6

2013-12-12 Thread German Blanco

I have also seen this failure in the logs:

junit.framework.AssertionFailedError: QP failed to shutdown in 30
seconds: QuorumPeer[myid=0]/127.0.0.1:11251
at org.apache.zookeeper.test.QuorumBase.shutdown(QuorumBase.java:393)
at 
org.apache.zookeeper.server.quorum.QuorumPeerTestBase$TestQPMain.shutdown(QuorumPeerTestBase.java:52)
at 
org.apache.zookeeper.server.quorum.QuorumPeerTestBase$MainThread.shutdown(QuorumPeerTestBase.java:152)
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testNextConfigUnreachable(ReconfigRecoveryTest.java:268)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Would it perhaps help to get ZOOKEEPER-1814 in as well and reduce the FLE
max notification interval for this test?


On Fri, Dec 13, 2013 at 1:21 AM, Michi Mutsuzaki mi...@cs.stanford.eduwrote:

 I uploaded a patch that fixes ClientPortBindTest.

 https://issues.apache.org/jira/browse/ZOOKEEPER-1833

 On Thu, Dec 12, 2013 at 2:14 PM, Michi Mutsuzaki mi...@cs.stanford.edu
 wrote:
  I'm running the build on my local windows box right now. I am seeing some
  test failures, although the number of failures is much less. I'll
  update the jira
  when I finish running the test.
 
  Also, I just noticed that ZooKeeper-trunk-WinVS2008_java has been timing
 out.
  I didn't know ZooKeeper-trunk-WinVS2008 doesn't run ant test, and I
 somehow
  assumed the gray status means the build is disabled. I increased the
 timeout
  from 2 hours to 4 hours and restart the test. I'm pretty sure it'll
  fail, but at least
  we'll know that it's not just 3.4 branch that's broken.
 
 
  On Thu, Dec 12, 2013 at 1:27 PM, Flavio Junqueira fpjunque...@yahoo.com
 wrote:
  Good points. I'm not sure if the client being being closed is what is
 causing the test failure, but it is not a bad guess. I think we need to
 execute ensureAll only in the case we add the client. The observation about
 ensureOnly seems right to me.
 
  We will need to get those in to get Jenkins to run. Do you want to
 create a subtask of ZK-1833 and propose these changes in a patch? If you
 propose a patch, we can give it a try and see.
 
  There are other failures unrelated to this, though. Example:
 
  [junit] 2013-12-12 08:55:48,245 [myid:] - INFO  [main:ZKTestCase$1@65]
 - FAILED testStartupFailureCreate
  [junit] org.junit.internal.runners.model.MultipleFailureException
  [junit] at
 org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23)
  [junit] at
 org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42)
  [junit] at
 org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48)
  [junit] at
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
  [junit] at
 org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
  [junit] at
 org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
  [junit] at
 org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
  [junit] at
 org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
  [junit] at
 org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
  [junit] at
 org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
  [junit] at
 org.junit.runners.ParentRunner.run(ParentRunner.java:236)
  [junit] at
 junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39)
  [junit] at
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518)
  [junit] at
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052)
  [junit] at
 org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906)
 
  On Dec 12, 2013, at 7:07 PM, German Blanco 
 german.blanco.bla...@gmail.com wrote:
 
  ... there is a similar situation in JMXEnv.java:138. It seems that
  ensureOnly gets call before the previously invoked shutdown has
 completed.
  The problem here is that one needs the Jenkins build in order to test
 what
  is really happening :-(
 
 
  On Thu, Dec 12, 2013 at 7:57 PM, German Blanco 
  german.blanco.bla...@gmail.com wrote:
 
  Hello Flavio,
 
  this looks great now, only one small problem and the deployment to go!
  Congratulations!
 
  I have taken a look at the windows build in Jenkins, and I am going to
  make a wild guess at what it might be happening, I hope it is worth
  anything.
  In many of the errors, the assertion in JMXEnv.java:115 is failing.
  The call is from ClientBase.java:197. I see something strange there,
 it
  seems that the procedure might close the client in one of the
 conditions
  (line 193) and still then check that it is there in line 197. So if
 closing
  is fast enough, the checking fails. Could that be it?
 
  Regards,
 
  German.
 
 
  On Thu,

Jenkins build is back to normal : bookkeeper-trunk #471