date:20190103

[jira] [Commented] (ZOOKEEPER-3232) make the log of notification about LE more readable

2019-01-03 Thread Brian Nixon (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733820#comment-16733820
 ] 

Brian Nixon commented on ZOOKEEPER-3232:


seems reasonable to me

> make the log of notification about LE more readable
> ---
>
> Key: ZOOKEEPER-3232
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3232
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: leaderElection
>Reporter: maoling
>Assignee: maoling
>Priority: Minor
>
> the log of notification about LE is very important to help us to see the 
> process of LE:e.g.
> {code:java}
> 2019-01-01 16:29:27,494 [myid:2] - INFO 
> [WorkerReceiver[myid=2]:FastLeaderElection@595] - Notification: 1 (message 
> format version), 3 (n.leader), 0x60b3dc215 (n.zxid), 0x3 (n.round), FOLLOWING 
> (n.state), 1 (n.sid), 0x7 (n.peerEpoch) LOOKING (my state){code}
> the current log have some problems:
> 1:don't use the placeholder(other:+),don't in the style of k:v（antiman）
> 2.the properties in the logs are very messed(no group by,no order), not easy 
> to read.
> 3.the value about version is HEX which don't have the 0x prefix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] enixon commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox

enixon commented on issue #752: ZOOKEEPER-3197 - Improve documentation in 
ZooKeeperServer.superSecret
URL: https://github.com/apache/zookeeper/pull/752#issuecomment-451351904
 
 
   I like it :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733807#comment-16733807
 ] 

Hudson commented on ZOOKEEPER-3222:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #335 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/335/])
ZOOKEEPER-3222: Flaky: multiple intermittent segfaults in C++ tests (andor: rev 
f644f3d63e3d1efd3a977b2f4621734dfe617f31)
* (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc


> Flaky: multiple intermittent segfaults in C++ tests
> ---
>
> Key: ZOOKEEPER-3222
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3222
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There're multiple places in C++ tests where zookeeper client handle 
> (zkhandle_t) doesn't get closed correctly causing intermittent segmentations 
> faults.
> e.g. In multi threaded tests IO thread remains open in these client which 
> could when trying to log something in a log file which is already closed by 
> the test.
> Another catch is when the test is trying to validate an already closed 
> client: the client struct cannot be accessed after the memory has been freed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733808#comment-16733808
 ] 

Hudson commented on ZOOKEEPER-3217:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #335 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/335/])
ZOOKEEPER-3217: owasp job flagging slf4j on trunk (andor: rev 
4a8fda7031d68236441b13bd878936b2607c5244)
* (add) owaspSuppressions.xml
* (edit) build.xml


> owasp job flagging slf4j on trunk
> -
>
> Key: ZOOKEEPER-3217
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3217
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Patrick Hunt
>Assignee: Enrico Olivelli
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-owasp/204/artifact/build/test/owasp/dependency-check-vulnerability.html
> https://nvd.nist.gov/vuln/detail/CVE-2018-8088
> We don't use EventData but should consider upgrading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 334 - Still Failing

2019-01-03 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk/334/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 9.21 KB...]
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://gitbox.apache.org/repos/asf/zookeeper.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to access 
'https://gitbox.apache.org/repos/asf/zookeeper.git/': Failed to connect to 
gitbox.apache.org port 443: Connection timed out

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H4
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:955)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor1100.invoke(Unknown 
Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy114.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED

Jenkins build is back to normal : ZooKeeper-trunk-owasp #225

2019-01-03 Thread Apache Jenkins Server

See

Re: Maven migration and CI

2019-01-03 Thread Ted Dunning

Wow.

This has been a long time coming!

Great news.



On Thu, Jan 3, 2019 at 1:34 PM Enrico Olivelli  wrote:

> Hi Zookeepers
> Now that we have Maven it is time to set up new CI jobs and compare the
> results with the Ant based build.
>
> My proposal is to set up a few jobs and see the results. When Norbert
> finishes the migration and we are happy we will drop Ant CI.
>
> I would start with a daily job for master which runs all of the test suites
> + rat + spotbugs.
>
> As a second step I would introduce a new precommit job which builds the
> patch using Maven, so in github we will have two 'status lines'
>
> Then I would add code coverage reports, OWASP
>
> The final step will be to introduce Jenkins DSL based configuration for CI,
> this way committers will have full control on CI, reviews of the
> configuration changes will be possible...(we could use Jenkinsfile approach
> if you prefer)
>
> I am able to work on ASF CI so if you allow me I will start with some
> prototype
>
> Enrico
>
> --
>
>
> -- Enrico Olivelli
>

ZooKeeper-trunk - Build # 333 - Failure

2019-01-03 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk/333/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 9.41 KB...]
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://gitbox.apache.org/repos/asf/zookeeper.git 
+refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: unable to access 
'https://gitbox.apache.org/repos/asf/zookeeper.git/': Failed to connect to 
gitbox.apache.org port 443: Connection timed out

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2038)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1757)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:438)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H4
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
at 
hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)
at hudson.remoting.Channel.call(Channel.java:955)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
at sun.reflect.GeneratedMethodAccessor1100.invoke(Unknown 
Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
at com.sun.proxy.$Proxy114.execute(Unknown Source)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:886)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1810)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED

Re: Jenkins issues

2019-01-03 Thread Enrico Olivelli

Your ticket has been closed.
I think our script won't kill other executions but I need to check.
Btw. We can configure the job in order to run at most one execution at a
time. Zookeeper test suite is pretty heavy (it does a lot of fsyncs for
instance) and we are running test concurrently, so at least putting a limit
to the job seems reasonable to me


Enrico

Il gio 3 gen 2019, 13:35 Andor Molnar  ha scritto:

> Hi team,
>
> I’m not sure, but it looks like we cannot run 2 concurrent PreCommit jobs
> on a single Jenkins slave, because both of them get killed soon after the
> second starts. Additionally all of the recent builds running on H19 for
> some reason. I opened an INFRA ticket to track and get help:
>
> https://issues.apache.org/jira/browse/INFRA-17533 <
> https://issues.apache.org/jira/browse/INFRA-17533>
>
> Regards,
> Andor
>
>
> --


-- Enrico Olivelli

[jira] [Commented] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733546#comment-16733546
 ] 

Hudson commented on ZOOKEEPER-3217:
---

FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #172 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/172/])
ZOOKEEPER-3217: owasp job flagging slf4j on trunk (andor: rev 
4a8fda7031d68236441b13bd878936b2607c5244)
* (edit) build.xml
* (add) owaspSuppressions.xml


> owasp job flagging slf4j on trunk
> -
>
> Key: ZOOKEEPER-3217
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3217
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Patrick Hunt
>Assignee: Enrico Olivelli
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-owasp/204/artifact/build/test/owasp/dependency-check-vulnerability.html
> https://nvd.nist.gov/vuln/detail/CVE-2018-8088
> We don't use EventData but should consider upgrading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733545#comment-16733545
 ] 

Hudson commented on ZOOKEEPER-3222:
---

FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #172 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/172/])
ZOOKEEPER-3222: Flaky: multiple intermittent segfaults in C++ tests (andor: rev 
f644f3d63e3d1efd3a977b2f4621734dfe617f31)
* (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc


> Flaky: multiple intermittent segfaults in C++ tests
> ---
>
> Key: ZOOKEEPER-3222
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3222
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There're multiple places in C++ tests where zookeeper client handle 
> (zkhandle_t) doesn't get closed correctly causing intermittent segmentations 
> faults.
> e.g. In multi threaded tests IO thread remains open in these client which 
> could when trying to log something in a log file which is already closed by 
> the test.
> Another catch is when the test is trying to validate an already closed 
> client: the client struct cannot be accessed after the memory has been freed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Maven migration and CI

2019-01-03 Thread Enrico Olivelli

Hi Zookeepers
Now that we have Maven it is time to set up new CI jobs and compare the
results with the Ant based build.

My proposal is to set up a few jobs and see the results. When Norbert
finishes the migration and we are happy we will drop Ant CI.

I would start with a daily job for master which runs all of the test suites
+ rat + spotbugs.

As a second step I would introduce a new precommit job which builds the
patch using Maven, so in github we will have two 'status lines'

Then I would add code coverage reports, OWASP

The final step will be to introduce Jenkins DSL based configuration for CI,
this way committers will have full control on CI, reviews of the
configuration changes will be possible...(we could use Jenkinsfile approach
if you prefer)

I am able to work on ASF CI so if you allow me I will start with some
prototype

Enrico

-- 


-- Enrico Olivelli

Re: Re: ZooKeeper 3.5 blocker issues

2019-01-03 Thread Enrico Olivelli

Il gio 3 gen 2019, 16:49 Norbert Kalmar  ha
scritto:

> Hi everyone, Happy New Year!
>
> My patches were merged today, so maven build should be working on master
> branch.
> There is still one Pr open about findbugs -
> https://github.com/apache/zookeeper/pull/742 (Thanks Enrico!)
> Annotations has been introduced instead of central xml, it's quite a
> change, but I agree it's better this way. Still, it's kind of a bigger
> change, so please have a look, and +1 or -1 if you like the new spotbugs
> annotations update.
> +1 from me! :)
>
> I will start to work on creating the assembly (ZOOKEEPER-3028), hopefully I
> will have the PR tomorrow.
>

We should change the release procedure as well, the best would be to use
maven release plugin, I may add that it is better for the release procedure
to run on docker so that we have a reproducible build environment.
We have already most of this stuff already in Bookkeeper project (thanks to
Sijie Guo), there is almost nothing special about about Bookkeeper.

https://bookkeeper.apache.org/community/release_guide/#prepare-release-branch

>
> If these two remaining tickets are done, CI integration can be started
> (ZOOKEEPER-3224), and various processes (release, pre-commit) can be tested
> with maven.
>

I will start a new email thread about this


Thank you Norbert!

Enrico


> Hopefully we will see maven running on Apache builds this month!
>
> Regards,
> Norbert
>
> On Fri, Dec 21, 2018 at 7:20 AM Enrico Olivelli 
> wrote:
>
> > Il ven 21 dic 2018, 04:24 毛蛤丝  ha scritto:
> >
> > > @Norbert @Enrico
> > > About the checkstyle
> > > Since there were so many,many checkstyle violations in the zk code base
> > > so the CI with checkstyle should ingore the existing codes, only act
> upon
> > > the new codes(new PR)
> > > After that, we can clean up the violations in the code base one module
> by
> > > another,one package by another
> > > if we have the time(but i think we don't[smirk])
> > >
> >
> > Yes it is a task for 3.6.0. Not worth 3.5.
> > We can engage new contributors for this task. It is easy and it does not
> > require knowledge of ZK internals
> >
> > Enrico
> >
> >
> > - 原始邮件 -
> > > 发件人：Enrico Olivelli 
> > > 收件人：DevZooKeeper 
> > > 主题：Re: ZooKeeper 3.5 blocker issues
> > > 日期：2018年12月20日 17点10分
> > >
> > >
> > > Great
> > > Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar
> > >  ha scritto:
> > > >
> > > > Subtasks:
> > > > Findbugs, checkstyle -
> > > https://issues.apache.org/jira/browse/ZOOKEEPER-3223
> > > We don't have checksyle. In my experience introducing checkstyle break
> > > every pending patch.
> > > I would like to narrow down this issue to "Spotbugs" and pick in up
> > > > CI integration -
> https://issues.apache.org/jira/browse/ZOOKEEPER-3224
> > > I would like to pick this up
> > > Enrico
> > > > Code coverage - https://issues.apache.org/jira/browse/ZOOKEEPER-3225
> > - I
> > > > laready started this one and some of it is committed with the patch,
> > so I
> > > > will continue to work on it.
> > > > Recipes and contrib -
> > > https://issues.apache.org/jira/browse/ZOOKEEPER-3171
> > > > - Already on it, recipes is done, PR soon available.
> > > > Assembly - https://issues.apache.org/jira/browse/ZOOKEEPER-3029
> > > >
> > > > This are the tasks left I can think of. If anything is missing, feel
> > free
> > > > to create a jira, or let me know.
> > > > The ones I'm already working on - 3225, 3171 - I made a comment,
> Those
> > > > should be ready this week.
> > > >
> > > > Thanks,
> > > > Norbert
> > > >
> > > >
> > > > On Thu, Dec 20, 2018 at 9:07 AM Enrico Olivelli  >
> > > wrote:
> > > >
> > > > > Great.
> > > > > Can you create JIRA tickets for remaining subtask? So that I can
> pick
> > > them
> > > > > up?
> > > > > I volounter for spotbugs and for CI integration, but let's see the
> > list
> > > > > Enrico
> > > > >
> > > > > Il gio 20 dic 2018, 07:21 Andor Molnar  ha
> > scritto:
> > > > >
> > > > > > Ok. Looks like ant still works properly, so let’s commit this
> patch
> > > and
> > > > > > you guys can collaborate to polish the Maven build.
> > > > > >
> > > > > > For now, it’s master-only.
> > > > > >
> > > > > > Thanks,
> > > > > > Andor
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On 2018. Dec 19., at 16:44, Norbert Kalmar
> > > > > 
> > > > > > wrote:
> > > > > > >
> > > > > > > Thank you Enrico, I agree, that we could commit this patch at
> > it's
> > > > > > current
> > > > > > > state, it fulfills the original jira anyways.
> > > > > > >
> > > > > > > I'll see what's wrong with the java tests, but honestly, it
> looks
> > > like
> > > > > > > they're just flaky... runs well on local builds with 8 thread.
> > > > > > >
> > > > > > > Regards,
> > > > > > > Norbert
> > > > > > >
> > > > > > > On Wed, Dec 19, 2018 at 2:50 PM Tamas Penzes
> > > > >  > > > > > >
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Hi All,
> > > > > > >>
> > > > > > >> For assembly task I would promote the way how HBase works.
> > >

[GitHub] dineshappavoo commented on issue #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox

dineshappavoo commented on issue #752: ZOOKEEPER-3197 - Improve documentation 
in ZooKeeperServer.superSecret
URL: https://github.com/apache/zookeeper/pull/752#issuecomment-451256979
 
 
   LGTM  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

ZooKeeper-trunk-windows-cmake - Build # 3090 - Failure

2019-01-03 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/3090/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 11.21 KB...]
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\javacc\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\src\main\java\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:
[javac] Compiling 39 source files to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\build\classes
[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 1.8
[javac] 1 warning

compile_jute_uptodate:

compile_jute:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\target\main\java
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c\generated
 [java] ../../../src/main/resources/zookeeper.jute Parsed Successfully
 [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed 
Successfully
[touch] Creating 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-jute\target\main\java\.generated

BUILD SUCCESSFUL
Total time: 13 seconds
[ZooKeeper-trunk-windows-cmake] $ cmd /c call 
F:\jenkins\jenkins-slave\temp\jenkins5308759478494435391.bat

f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake>cd 
zookeeper-client/zookeeper-client-c 

f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c>cmake
 . 
-- Building for: Visual Studio 14 2015
-- The C compiler identification is unknown
-- The CXX compiler identification is unknown
CMake Error at CMakeLists.txt:19 (project):
  No CMAKE_C_COMPILER could be found.



CMake Error at CMakeLists.txt:19 (project):
  No CMAKE_CXX_COMPILER could be found.



-- Configuring incomplete, errors occurred!
See also 
"F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/zookeeper-client/zookeeper-client-c/CMakeFiles/CMakeOutput.log".
See also 
"F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/zookeeper-client/zookeeper-client-c/CMakeFiles/CMakeError.log".

f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c>cmake
 --build . 
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: ALL_BUILD.vcxproj

f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\zookeeper-client\zookeeper-client-c>exit
 1 
Build step 'Execute Windows batch command' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-03 Thread GitBox

arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#issuecomment-451193461
 
 
   @anmolnar - should be up to date now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Re: ZooKeeper 3.5 blocker issues

2019-01-03 Thread Norbert Kalmar

Hi everyone, Happy New Year!

My patches were merged today, so maven build should be working on master
branch.
There is still one Pr open about findbugs -
https://github.com/apache/zookeeper/pull/742 (Thanks Enrico!)
Annotations has been introduced instead of central xml, it's quite a
change, but I agree it's better this way. Still, it's kind of a bigger
change, so please have a look, and +1 or -1 if you like the new spotbugs
annotations update.
+1 from me! :)

I will start to work on creating the assembly (ZOOKEEPER-3028), hopefully I
will have the PR tomorrow.

If these two remaining tickets are done, CI integration can be started
(ZOOKEEPER-3224), and various processes (release, pre-commit) can be tested
with maven.

Hopefully we will see maven running on Apache builds this month!

Regards,
Norbert

On Fri, Dec 21, 2018 at 7:20 AM Enrico Olivelli  wrote:

> Il ven 21 dic 2018, 04:24 毛蛤丝  ha scritto:
>
> > @Norbert @Enrico
> > About the checkstyle
> > Since there were so many,many checkstyle violations in the zk code base
> > so the CI with checkstyle should ingore the existing codes, only act upon
> > the new codes(new PR)
> > After that, we can clean up the violations in the code base one module by
> > another,one package by another
> > if we have the time(but i think we don't[smirk])
> >
>
> Yes it is a task for 3.6.0. Not worth 3.5.
> We can engage new contributors for this task. It is easy and it does not
> require knowledge of ZK internals
>
> Enrico
>
>
> - 原始邮件 -
> > 发件人：Enrico Olivelli 
> > 收件人：DevZooKeeper 
> > 主题：Re: ZooKeeper 3.5 blocker issues
> > 日期：2018年12月20日 17点10分
> >
> >
> > Great
> > Il giorno gio 20 dic 2018 alle ore 10:07 Norbert Kalmar
> >  ha scritto:
> > >
> > > Subtasks:
> > > Findbugs, checkstyle -
> > https://issues.apache.org/jira/browse/ZOOKEEPER-3223
> > We don't have checksyle. In my experience introducing checkstyle break
> > every pending patch.
> > I would like to narrow down this issue to "Spotbugs" and pick in up
> > > CI integration - https://issues.apache.org/jira/browse/ZOOKEEPER-3224
> > I would like to pick this up
> > Enrico
> > > Code coverage - https://issues.apache.org/jira/browse/ZOOKEEPER-3225
> - I
> > > laready started this one and some of it is committed with the patch,
> so I
> > > will continue to work on it.
> > > Recipes and contrib -
> > https://issues.apache.org/jira/browse/ZOOKEEPER-3171
> > > - Already on it, recipes is done, PR soon available.
> > > Assembly - https://issues.apache.org/jira/browse/ZOOKEEPER-3029
> > >
> > > This are the tasks left I can think of. If anything is missing, feel
> free
> > > to create a jira, or let me know.
> > > The ones I'm already working on - 3225, 3171 - I made a comment, Those
> > > should be ready this week.
> > >
> > > Thanks,
> > > Norbert
> > >
> > >
> > > On Thu, Dec 20, 2018 at 9:07 AM Enrico Olivelli 
> > wrote:
> > >
> > > > Great.
> > > > Can you create JIRA tickets for remaining subtask? So that I can pick
> > them
> > > > up?
> > > > I volounter for spotbugs and for CI integration, but let's see the
> list
> > > > Enrico
> > > >
> > > > Il gio 20 dic 2018, 07:21 Andor Molnar  ha
> scritto:
> > > >
> > > > > Ok. Looks like ant still works properly, so let’s commit this patch
> > and
> > > > > you guys can collaborate to polish the Maven build.
> > > > >
> > > > > For now, it’s master-only.
> > > > >
> > > > > Thanks,
> > > > > Andor
> > > > >
> > > > >
> > > > >
> > > > > > On 2018. Dec 19., at 16:44, Norbert Kalmar
> > > > 
> > > > > wrote:
> > > > > >
> > > > > > Thank you Enrico, I agree, that we could commit this patch at
> it's
> > > > > current
> > > > > > state, it fulfills the original jira anyways.
> > > > > >
> > > > > > I'll see what's wrong with the java tests, but honestly, it looks
> > like
> > > > > > they're just flaky... runs well on local builds with 8 thread.
> > > > > >
> > > > > > Regards,
> > > > > > Norbert
> > > > > >
> > > > > > On Wed, Dec 19, 2018 at 2:50 PM Tamas Penzes
> > > >  > > > > >
> > > > > > wrote:
> > > > > >
> > > > > >> Hi All,
> > > > > >>
> > > > > >> For assembly task I would promote the way how HBase works.
> > > > > >> They create a pure source and a bin tarball separately. Please
> > see how
> > > > > they
> > > > > >> create a release here:
> > > > > >>
> > https://github.com/apache/hbase/blob/master/dev-support/make_rc.sh
> > > > > >> We could probably use the well known "copy+paste technology" to
> > have
> > > > it
> > > > > >> within ZooKeeper the same way. ;-)
> > > > > >>
> > > > > >> Regards, Tamaas
> > > > > >>
> > > > > >> On Wed, Dec 19, 2018 at 2:28 PM Enrico Olivelli <
> > eolive...@gmail.com>
> > > > > >> wrote:
> > > > > >>
> > > > > >>> Great work Norbert
> > > > > >>> I you want I can help,especially for rat, findbugs (need to
> > switch to
> > > > > >>> spotbugs anyway) and OWASP stuff (recently I started using
> Maven
> > > > > >>> Plugin in other projects)
> > > > > >>> But I am not sure how can I help you concretely if we do

[GitHub] anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable client-initiated renegotiation

2019-01-03 Thread GitBox

anmolnar commented on issue #710: ZOOKEEPER-3195: TLS - disable 
client-initiated renegotiation
URL: https://github.com/apache/zookeeper/pull/710#issuecomment-451179479
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451178971
 
 
   Committed to 3.4, 3.5 and master branches. Thanks @eolivelli !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread Andor Molnar (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3217.
-
Resolution: Fixed

Issue resolved by pull request 736
[https://github.com/apache/zookeeper/pull/736]

> owasp job flagging slf4j on trunk
> -
>
> Key: ZOOKEEPER-3217
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3217
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Patrick Hunt
>Assignee: Enrico Olivelli
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.4.14, 3.5.5
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-owasp/204/artifact/build/test/owasp/dependency-check-vulnerability.html
> https://nvd.nist.gov/vuln/detail/CVE-2018-8088
> We don't use EventData but should consider upgrading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] asfgit closed pull request #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

asfgit closed pull request #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build.xml b/build.xml
index 58685327f8..423c108362 100644
--- a/build.xml
+++ b/build.xml
@@ -1705,6 +1705,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
   reportoutputdirectory="${owasp.out.dir}"
   reportformat="ALL"
   failBuildOnCVSS="0">
+
 
 
 
diff --git a/owaspSuppressions.xml b/owaspSuppressions.xml
new file mode 100644
index 00..0165b9ada1
--- /dev/null
+++ b/owaspSuppressions.xml
@@ -0,0 +1,25 @@
+
+
+
+
+https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.2.xsd;>
+   
+  
+  CVE-2018-8088
+   
+


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox

ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to 
network
URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451177021
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-03 Thread GitBox

anmolnar commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#issuecomment-451174697
 
 
   @arankin-irl Please rebase on top of current master.
   @ivmaykov @hanm Would you please take a quick a look at this patch? I'd like 
to get your support to confidently merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451167996
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread Andor Molnar (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3222.
-
   Resolution: Fixed
Fix Version/s: (was: 3.4.14)

Issue resolved by pull request 740
[https://github.com/apache/zookeeper/pull/740]

> Flaky: multiple intermittent segfaults in C++ tests
> ---
>
> Key: ZOOKEEPER-3222
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3222
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> There're multiple places in C++ tests where zookeeper client handle 
> (zkhandle_t) doesn't get closed correctly causing intermittent segmentations 
> faults.
> e.g. In multi threaded tests IO thread remains open in these client which 
> could when trying to log something in a log file which is already closed by 
> the test.
> Another catch is when the test is trying to validate an already closed 
> client: the client struct cannot be accessed after the memory has been freed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent 
segfaults in C++ tests
URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451167753
 
 
   Committed to master and 3.5 branches. Thanks @lvfangmin !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit closed pull request #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox

asfgit closed pull request #740: ZOOKEEPER-3222. Flaky: multiple intermittent 
segfaults in C++ tests
URL: https://github.com/apache/zookeeper/pull/740
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/zookeeper-client/zookeeper-client-c/tests/TestClient.cc 
b/zookeeper-client/zookeeper-client-c/tests/TestClient.cc
index 008bfdbf83..2006c45878 100644
--- a/zookeeper-client/zookeeper-client-c/tests/TestClient.cc
+++ b/zookeeper-client/zookeeper-client-c/tests/TestClient.cc
@@ -669,15 +669,6 @@ class Zookeeper_simpleSystem : public 
CPPUNIT_NS::TestFixture
 CPPUNIT_ASSERT(count == 1);
 count  = 0;
 CPPUNIT_ASSERT_EQUAL((int) ZOK, zookeeper_close(zk_auth));
-
-// [ZOOKEEPER-800] zoo_add_auth should return ZINVALIDSTATE if
-// the connection is closed. 
-zhandle_t *zk2 = zookeeper_init(hostPorts, NULL, 1, 0, NULL, 0);
-sleep(1);
-CPPUNIT_ASSERT_EQUAL((int) ZOK, zookeeper_close(zk2));
-CPPUNIT_ASSERT_EQUAL(0, zoo_state(zk2)); // 0 ==> ZOO_CLOSED_STATE
-rc = zoo_add_auth(zk2, "digest", "pat:passwd", 10, voidCompletion, 
(void*)ZOK);
-CPPUNIT_ASSERT_EQUAL((int) ZINVALIDSTATE, rc);
 
 struct sockaddr addr;
 socklen_t addr_len = sizeof(addr);
@@ -1351,9 +1342,9 @@ class Zookeeper_simpleSystem : public 
CPPUNIT_NS::TestFixture
   int blen = sizeof(buf);  
   int rc;
   watchctx_t ctx;
-   zhandle_t *zk;
+  zhandle_t *zk;
 
-   /* setup path */
+  /* setup path */
   zk = createClient();
   CPPUNIT_ASSERT(zk);
 
@@ -1409,6 +1400,8 @@ class Zookeeper_simpleSystem : public 
CPPUNIT_NS::TestFixture
watcher_rw, NULL, 0);
   CPPUNIT_ASSERT_EQUAL((int)ZCONNECTIONLOSS, rc);
 
+  zookeeper_close(zk);
+
   /* bring the server back */
   startServer();
   zk = createClient();


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox

ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to 
network
URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451166896
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent 
segfaults in C++ tests
URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451154938
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r245008359
 
 

 ##
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##
 @@ -18,6 +18,7 @@
 
 package org.apache.zookeeper;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 Review comment:
   I'm willing to accept it, but it makes the patch slightly bigger and I feel 
like we need some additional support from the community in this case. At least 
one more approval from a committer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r245004005
 
 

 ##
 File path: excludeFindBugsFilter.xml
 ##
 @@ -0,0 +1,14 @@
+
+
+
 
 Review comment:
   Leave it, I'm fine with that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733041#comment-16733041
 ] 

Hudson commented on ZOOKEEPER-3233:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #332 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/332/])
ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (andor: rev 
50aeb922a48ed07e48719f4def331b6ed4fcb4fb)
* (edit) zookeeper-server/src/test/resources/test-github-pr.sh


> Run github pre-commit hook tests on 4 threads
> -
>
> Key: ZOOKEEPER-3233
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3233
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.6.0
>
>
> Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads only 
> (currently 8) in order to enhance flaky test stability.
> Test output can also be turned off, because test results are collected from 
> xml files at end of the process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451145230
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244996468
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java
 ##
 @@ -180,7 +180,7 @@ public static void setPreallocSize(long size) {
  * @param serverStats used to update fsyncThresholdExceedCount
  */
 @Override
-public void setServerStats(ServerStats serverStats) {
+public synchronized void setServerStats(ServerStats serverStats) {
 
 Review comment:
   This is spotbugs error:
   `[ERROR] Inconsistent synchronization of 
org.apache.zookeeper.server.persistence.FileTxnLog.serverStats; locked 66% of 
time [org.apache.zookeeper.server.persistence.FileTxnLog, 
org.apache.zookeeper.server.persistence.FileTxnLog, 
org.apache.zookeeper.server.persistence.FileTxnLog] Unsynchronized access at 
FileTxnLog.java:[line 184]Synchronized access at FileTxnLog.java:[line 
381]Synchronized access at FileTxnLog.java:[line 382] IS2_INCONSISTENT_SYNC
   `
   
   I think this change is safe


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

eolivelli commented on issue #742: ZOOKEEPER-3223: Configure Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#issuecomment-451139535
 
 
   @anmolnar the change around
   `// TTL.toEphemeralOwner(ttl);`
   was because that method for spotbugs won't have any side effects, but indeed 
it is a false positive, so I am reverting it and adding a suppression


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244995163
 
 

 ##
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##
 @@ -18,6 +18,7 @@
 
 package org.apache.zookeeper;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 Review comment:
   @anmolnar personally I like to use annotation because when you read the java 
file you see the problems.
   And I am usually using the configuration file for coarse grained  control, 
like when there is some kind of check you don't want to consider at all or in 
many files


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

eolivelli commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244994756
 
 

 ##
 File path: excludeFindBugsFilter.xml
 ##
 @@ -0,0 +1,14 @@
+
+
+
 
 Review comment:
   @anmolnar  this name is very common, as many project migrated from findbugs.
   I can change, no problem. But I don't feel strong about it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3197:
--
Labels: pull-request-available  (was: )

> Improve documentation in ZooKeeperServer.superSecret
> 
>
> Key: ZOOKEEPER-3197
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3197
> Project: ZooKeeper
>  Issue Type: Task
>Reporter: Colm O hEigeartaigh
>Priority: Trivial
>  Labels: pull-request-available
>
> A security scan flagged the use of a hard-coded secret 
> (ZooKeeperServer.superSecret) in conjunction with a java Random instance to 
> generate a password:
> byte[] generatePasswd(long id)
> {         Random r = new Random(id ^ superSecret);         byte p[] = 
> new byte[16];         r.nextBytes(p);         return p;     }
> superSecret has the following javadoc:
>  /**
>     * This is the secret that we use to generate passwords, for the moment it
>     * is more of a sanity check.
>     */
> It is unclear from this comment and looking at the code why it is not a 
> security risk. It would be good to update the javadoc along the lines of 
> "Using a hard-coded secret with Random to generate a password is not a 
> security risk because the resulting passwords are used for X, Y, Z and not 
> for authentication etc" or something would be very helpful for anyone else 
> looking at the code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] coheigea opened a new pull request #752: ZOOKEEPER-3197 - Improve documentation in ZooKeeperServer.superSecret

2019-01-03 Thread GitBox

coheigea opened a new pull request #752: ZOOKEEPER-3197 - Improve documentation 
in ZooKeeperServer.superSecret
URL: https://github.com/apache/zookeeper/pull/752
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins issues

2019-01-03 Thread Andor Molnar

Hi team,

I’m not sure, but it looks like we cannot run 2 concurrent PreCommit jobs on a 
single Jenkins slave, because both of them get killed soon after the second 
starts. Additionally all of the recent builds running on H19 for some reason. I 
opened an INFRA ticket to track and get help:

https://issues.apache.org/jira/browse/INFRA-17533 


Regards,
Andor

[GitHub] ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to network

2019-01-03 Thread GitBox

ArtemChernatsky commented on issue #730: Zookeeper-3188: Improve resilience to 
network
URL: https://github.com/apache/zookeeper/pull/730#issuecomment-451128577
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451125713
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732957#comment-16732957
 ] 

Hudson commented on ZOOKEEPER-3233:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #170 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/170/])
ZOOKEEPER-3233: Run github pre-commit hook tests on 4 threads (andor: rev 
50aeb922a48ed07e48719f4def331b6ed4fcb4fb)
* (edit) zookeeper-server/src/test/resources/test-github-pr.sh


> Run github pre-commit hook tests on 4 threads
> -
>
> Key: ZOOKEEPER-3233
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3233
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.6.0
>
>
> Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads only 
> (currently 8) in order to enhance flaky test stability.
> Test output can also be turned off, because test results are collected from 
> xml files at end of the process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

anmolnar commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451121539
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent 
segfaults in C++ tests
URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451120479
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread GitBox

anmolnar commented on issue #740: ZOOKEEPER-3222. Flaky: multiple intermittent 
segfaults in C++ tests
URL: https://github.com/apache/zookeeper/pull/740#issuecomment-451117487
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3222) Flaky: multiple intermittent segfaults in C++ tests

2019-01-03 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3222:
--
Labels: pull-request-available  (was: )

> Flaky: multiple intermittent segfaults in C++ tests
> ---
>
> Key: ZOOKEEPER-3222
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3222
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
>
> There're multiple places in C++ tests where zookeeper client handle 
> (zkhandle_t) doesn't get closed correctly causing intermittent segmentations 
> faults.
> e.g. In multi threaded tests IO thread remains open in these client which 
> could when trying to log something in a log file which is already closed by 
> the test.
> Another catch is when the test is trying to validate an already closed 
> client: the client struct cannot be accessed after the memory has been freed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3229) [TLS] add AES-256 ciphers to default cipher list

2019-01-03 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3229:
--
Labels: pull-request-available  (was: )

> [TLS] add AES-256 ciphers to default cipher list
> 
>
> Key: ZOOKEEPER-3229
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3229
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Assignee: Ilya Maykov
>Priority: Minor
>  Labels: pull-request-available
>
> Let's add AES-256 ciphers to the default cipher suite list, so clients that 
> prefer using 256-bit symmetric keys can connect by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to default cipher list

2019-01-03 Thread GitBox

anmolnar commented on issue #744: ZOOKEEPER-3229: [TLS] add AES-256 ciphers to 
default cipher list
URL: https://github.com/apache/zookeeper/pull/744#issuecomment-451113306
 
 
   @ivmaykov `QuorumSSLTest.testProtocolVersion` is failing, because TLSv1.1 
participant is able to join TLSv1.2-only quorum. Not sure how is it related to 
this change, but could you please take a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ZOOKEEPER-3217) owasp job flagging slf4j on trunk

2019-01-03 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3217:
--
Labels: pull-request-available  (was: )

> owasp job flagging slf4j on trunk
> -
>
> Key: ZOOKEEPER-3217
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3217
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Patrick Hunt
>Assignee: Enrico Olivelli
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk-owasp/204/artifact/build/test/owasp/dependency-check-vulnerability.html
> https://nvd.nist.gov/vuln/detail/CVE-2018-8088
> We don't use EventData but should consider upgrading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963646
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java
 ##
 @@ -180,7 +180,7 @@ public static void setPreallocSize(long size) {
  * @param serverStats used to update fsyncThresholdExceedCount
  */
 @Override
-public void setServerStats(ServerStats serverStats) {
+public synchronized void setServerStats(ServerStats serverStats) {
 
 Review comment:
   I'm not sure if we need to synchronize here, but it shouldn't be part of 
this patch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244962944
 
 

 ##
 File path: excludeFindBugsFilter.xml
 ##
 @@ -0,0 +1,14 @@
+
+
+
 
 Review comment:
   Naming is a little bit confusing I think. Given that this is a config file 
of `spotBugs`, shouldn't we call it `spotBugsFilter.xml` instead?
   Though the XML tag name has remained "FindBugs", so I'm not sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
 ##
 @@ -212,7 +212,8 @@ public static void validateServerId(long serverId) {
  */
 public static void validateTTL(CreateMode mode, long ttl) {
 if (mode.isTTL()) {
-TTL.toEphemeralOwner(ttl);
+// nothing to do in 3.5 was:
+// TTL.toEphemeralOwner(ttl);
 
 Review comment:
   @eolivelli How is this code change related to this patch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs

2019-01-03 Thread GitBox

anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure 
Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963240
 
 

 ##
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##
 @@ -18,6 +18,7 @@
 
 package org.apache.zookeeper;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 Review comment:
   Do we have to migrate to this annotation-based approach of defining filters?
   Can't we just re-use the existing findBugs filter file?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging 
slf4j on trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446
 
 
   one more test, found a bug :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

Humbedooh commented on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on 
trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108446
 
 
   one more test, found a bug :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging slf4j on trunk

2019-01-03 Thread GitBox

Humbedooh removed a comment on issue #736: ZOOKEEPER-3217 owasp job flagging 
slf4j on trunk
URL: https://github.com/apache/zookeeper/pull/736#issuecomment-451108055
 
 
   Please ignore this comment, checking JIRA integration.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Jira - GitHub linkage broken?

2019-01-03 Thread Andor Molnar

I opened Infra ticket:

https://issues.apache.org/jira/browse/INFRA-17532 


Andor



> On 2019. Jan 2., at 15:41, Enrico Olivelli  wrote:
> 
> Il giorno mer 2 gen 2019 alle ore 15:28 Enrico Olivelli
> mailto:eolive...@gmail.com>> ha scritto:
>> 
>> Il giorno mer 2 gen 2019 alle ore 15:24 Andor Molnar
>>  ha scritto:
>>> 
>>> Hi team,
>>> 
>>> Looks like the linkage between GitHub and Apache Jira got broken:
>>> https://issues.apache.org/jira/browse/ZOOKEEPER-3217 
>>> 
>>> 
>>> It has an open pull request on Github, but I cannot see it on the Jira as a 
>>> linked page.
>>> https://github.com/apache/zookeeper/pull/736 
>>> 
>>> 
>>> Maybe related to the Gitbox migration?
>> 
>> I didn't notice it. But you are right.
>> We can ask to infra
>> 
>> Please note that currently (now, at the time of writing) ASF Jenkins
>> is in bad status, it seems that every linux node is having trouble,
> 
> Sorry, it is windows to have problems, not linux
> Enrico
> 
>> there is an huge queue. The JIRA problem is unrelated
>> 
>> Enrico
>> 
>>> 
>>> Regards,
>>> Andor

[jira] [Resolved] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Andor Molnar (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3233.
-
Resolution: Fixed

Issue resolved by pull request 750
[https://github.com/apache/zookeeper/pull/750]

> Run github pre-commit hook tests on 4 threads
> -
>
> Key: ZOOKEEPER-3233
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3233
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.6.0
>
>
> Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads only 
> (currently 8) in order to enhance flaky test stability.
> Test output can also be turned off, because test results are collected from 
> xml files at end of the process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3233) Run github pre-commit hook tests on 4 threads

2019-01-03 Thread Andor Molnar (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar updated ZOOKEEPER-3233:

Description: 
Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads only 
(currently 8) in order to enhance flaky test stability.
Test output can also be turned off, because test results are collected from xml 
files at end of the process.

  was:Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads 
only (currently 8) in order to enhance flaky test stability.


> Run github pre-commit hook tests on 4 threads
> -
>
> Key: ZOOKEEPER-3233
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3233
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: tests
>Affects Versions: 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.6.0
>
>
> Adjust GitHub pre-commit hook script to run Java unit tests on 4 threads only 
> (currently 8) in order to enhance flaky test stability.
> Test output can also be turned off, because test results are collected from 
> xml files at end of the process.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: ZooKeeper-trunk-owasp #224

2019-01-03 Thread Apache Jenkins Server

See 


Changes:

[andor] ZOOKEEPER-3228: [TLS] Fix key usage extension in test certs

[fangmin] ZOOKEEPER-3205: Add test cases for jute

[andor] ZOOKEEPER-3226: MAVEN MIGRATION - - add profile for C build

[andor] ZOOKEEPER-3171: MAVEN MIGRATION - - Add recipes and contrib maven build

--
[...truncated 13.47 KB...]
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found org.apache.yetus#audience-annotations;0.5.0 in maven2
[ivy:retrieve]  found io.netty#netty-all;4.1.29.Final in maven2
[ivy:retrieve]  found com.googlecode.json-simple#json-simple;1.1.1 in maven2
[ivy:retrieve] :: resolution report :: resolve 59ms :: artifacts dl 8ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   18  |   0   |   0   |   0   ||   18  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  18 artifacts copied, 0 already retrieved (7954kB/23ms)

ivy-retrieve-clover:

clover.check:

clover.setup:

clover:

ivy-retrieve-javacc:
[mkdir] Created dir: 

[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [javacc]
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 17ms :: artifacts dl 0ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  javacc  |   1   |   0   |   0   |   0   ||   1   |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [javacc]
[ivy:retrieve]  1 artifacts copied, 0 already retrieved (291kB/2ms)

generate_jute_parser:
[mkdir] Created dir: 

[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 

 [move] Moving 1 file to 

   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 

 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:
[javac] Compiling 39 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

compile_jute_uptodate:

compile_jute:
[mkdir] Created dir: 

[mkdir] Created dir: 

 [java] ../../../src/main/resources/zookeeper.jute Parsed Successfully
 [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed 
Successfully
[touch] Creating 


ver-gen:
[javac] Compiling 1 source file to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

git-revision:
[mkdir] Created dir: 


version-info:

process-template:

build-generated:
[javac] Compiling 63 source files to 

[javac] warning: [options]

61 matches

Mail list logo