[jira] [Commented] (ZOOKEEPER-3267) Add watcher metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783990#comment-16783990 ] Hudson commented on ZOOKEEPER-3267: --- SUCCESS: Integrated in Jenkins build

[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed

maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469504060 - > Maybe the flag is not needed and I am fine with it. agree - adding a new field/attributive

[jira] [Commented] (ZOOKEEPER-3267) Add watcher metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783953#comment-16783953 ] Hudson commented on ZOOKEEPER-3267: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #425 (See

[jira] [Updated] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3143: -- Labels: pull-request-available (was: ) > Pluggable metrics system for ZooKeeper -

[GitHub] [zookeeper] eolivelli commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

eolivelli commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/840#discussion_r262282219 ## File path:

[GitHub] [zookeeper] eolivelli commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

eolivelli commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/840#discussion_r262282219 ## File path:

[jira] [Updated] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3143: --- Summary: Pluggable metrics system for ZooKeeper - Data Collection on Server

[jira] [Resolved] (ZOOKEEPER-3267) Add watcher metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3267. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 796

[jira] [Assigned] (ZOOKEEPER-3267) Add watcher metrics

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3267: --- Assignee: Jie Huang > Add watcher metrics > --- > >

[GitHub] [zookeeper] asfgit closed pull request #796: ZOOKEEPER-3267: Add watcher metrics

asfgit closed pull request #796: ZOOKEEPER-3267: Add watcher metrics URL: https://github.com/apache/zookeeper/pull/796 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [zookeeper] eolivelli commented on a change in pull request #840: WIP - Refactor ServerMetrics, make it a single instance

eolivelli commented on a change in pull request #840: WIP - Refactor ServerMetrics, make it a single instance URL: https://github.com/apache/zookeeper/pull/840#discussion_r262282219 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

anmolnar commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#discussion_r262276981 ## File path:

[GitHub] [zookeeper] anmolnar commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

anmolnar commented on a change in pull request #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255 URL: https://github.com/apache/zookeeper/pull/832#discussion_r262276762 ## File path:

[jira] [Commented] (ZOOKEEPER-3264) Add a benchmark tool for zookeeper

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783825#comment-16783825 ] Alexander Shraer commented on ZOOKEEPER-3264: - Also, [~kfirlevari] extended the zookeeper 

[jira] [Commented] (ZOOKEEPER-3264) Add a benchmark tool for zookeeper

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783824#comment-16783824 ] Brian Nixon commented on ZOOKEEPER-3264: I know that [~breed] at one point was thinking of

Re: Question on ZK commit/patch policy.

I like having JIRAs for all changes because it allows one to track all the changes to given components through the JIRA web interface and it forces the contributor to spend some time upfront making sure their change is a single coherent unit. For trivial changes like spelling, whitespace, pruning

[GitHub] [zookeeper] athanatos commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1

athanatos commented on issue #787: ZOOKEEPER-3253: client should not send requests with cxid=-4, -2, or -1 URL: https://github.com/apache/zookeeper/pull/787#issuecomment-469395692 @phunt I pushed a version with that changed. The JenkinsMaven failure doesn't appear related to this patch.

[GitHub] [zookeeper] anmolnar commented on a change in pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol

anmolnar commented on a change in pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol URL: https://github.com/apache/zookeeper/pull/826#discussion_r262198467 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@

[GitHub] [zookeeper] anmolnar commented on a change in pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol

anmolnar commented on a change in pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol URL: https://github.com/apache/zookeeper/pull/826#discussion_r262198571 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md ## @@

[GitHub] [zookeeper] lvfangmin commented on issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO

lvfangmin commented on issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO URL: https://github.com/apache/zookeeper/pull/690#issuecomment-469365172 retest this please This is an automated message from

[GitHub] [zookeeper] eolivelli edited a comment on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed

eolivelli edited a comment on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469237177 @maoling thank you for trying this out. Unfortunately I think we need backward compatibility

[GitHub] [zookeeper] eolivelli commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed

eolivelli commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469237177 @maoling thank you foe trying this out. Unfortunately I think we need backward compatibility tests for

[GitHub] [zookeeper] TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed

TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469211354 Besides, I cannot reproduce ci failure locally and wonder if it is a known issue, since it looks like

[GitHub] [zookeeper] TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed

TisonKun commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-469211007 Thanks for your reviews @maoling @eolivelli . @eolivelli what do you think about @maoling 's analysis

[GitHub] [zookeeper] TyqITstudent commented on issue #688: reduce session revalidation time after zxid roll over

TyqITstudent commented on issue #688: reduce session revalidation time after zxid roll over URL: https://github.com/apache/zookeeper/pull/688#issuecomment-469202545 > looking--(:D)-- Take it easy. This

[jira] [Commented] (ZOOKEEPER-3255) add a banner to make the startup of zk server more cool

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783214#comment-16783214 ] Hudson commented on ZOOKEEPER-3255: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #424 (See

[jira] [Commented] (ZOOKEEPER-3255) add a banner to make the startup of zk server more cool

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783188#comment-16783188 ] Hudson commented on ZOOKEEPER-3255: --- FAILURE: Integrated in Jenkins build