Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/157
@revans2 the change looks good, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/157#discussion_r98734336
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -507,9 +507,12 @@ public synchronized void shutdown
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/157
Had another look at the patch, specifically the changes on Learner. Looks
good to me. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/160
+1, merging to master (the jira mentioned patch to 3.4 and 3.5 will be sent
separately).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/156
Closing pull request now it's merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/92
Hey @shralex, want to close the loop here. Does the latest pull request
look good to you? My stress tests on this branch has been green for past two
weeks.
---
If your project is set up
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/111
Merged to 3.4, 3.5, and master. Thanks for your contribution @abhishekrai !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/110
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/135
@rakeshadr Could you close this PR since it has been merged in? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/110
Merged, thanks for your contribution @ronin13 !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451441
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -434,6 +434,10 @@ public int getQuorumSize(){
//last proposed
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97451281
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long sid
Github user hanm commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584729
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server/quorum
Github user hanm commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20585960
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server/quorum
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/156
ZOOKEEPER-2044:CancelledKeyException in zookeeper 3.4.5.
Patch from Germán Blanco, test case from Flavio.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/156
@rakeshadr thanks for review, patch updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r97921838
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r98244348
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +69,41 @@ public void testOperationsAfterCnxnClose() throws
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/156#discussion_r98120457
--- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java
---
@@ -68,4 +69,38 @@ public void testOperationsAfterCnxnClose() throws
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r102301090
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final Channel
channel
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
Update patch to address review comments from @arshadmohammad and @rakeshadr
* Added a nop command that does nothing but print message back to client
for better user experience.
* Test
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101838431
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +159,50 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101838458
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +159,50 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101838329
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -479,7 +479,7 @@ private boolean checkFourLetterWord(final SelectionKey
k
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
Thanks @arshadmohammad for review. I'll update the patch soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101838868
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101838800
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101839349
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
>> on the surface this pr reminds me of ZOOKEEPER-2184, wondering if some
of the logic can be shared?
I had a chat with @afine offline again about this and I think Abe had a
good
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
Patch updated to address review comments from @arshadmohammad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101877413
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,11 +159,69 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101877565
--- Diff:
src/java/test/org/apache/zookeeper/test/FourLetterWordsWhiteListTest.java ---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101877350
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,11 +159,69 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101793125
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r101793204
--- Diff:
src/java/main/org/apache/zookeeper/server/command/SnapCommand.java ---
@@ -0,0 +1,53 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
@JiangJiafu What I meant is we can solve the problem (sharing code between
this issue and ZOOKEEPER-2181) later, after both issues are merged in. We can
make things progress by doing one step
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r102273810
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final Channel
channel
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r102275734
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -267,10 +267,17 @@ private boolean checkFourLetterWord(final Channel
channel
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102282461
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/168
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/168
The question is why these PRs not get closed automatically. A little bit
investigation indicates a consistent pattern that PRs not closed were most
committed by @rakeshadr :). Rakesh, any idea
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/171
+1. Chat with @afine offline, this is hard to reproduce without introducing
some delays in the process callback.
---
If your project is set up for it, you can reply to this email and have your
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r100893741
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -159,7 +159,7 @@ public QuorumServer(long id, String hostname
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100685238
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -106,6 +106,7 @@ public void shutdown
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/168
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after
we migrating to git - most of the git commits in recent couple of months don't
update
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/169
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after
we migrating to git - most of the git commits in recent couple of months don't
update
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/169
@rakeshadr for branch-3.5 as requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/162
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/168
@rakeshadr for branch-3.4 as requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/161
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/179
ZOOKEEPER-2693: DOS attack on wchp/wchc four letter words (4lw)
This is for master / branch-3.5:
* Introduce a new configuration option that by default turn off 4lw.
* Update docs
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101572026
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1155,6 +1155,30 @@ server.3=zoo3:2888:3888
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101572993
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101572954
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1650,7 +1674,16 @@ server.3=zoo3:2888:3888
while "srvr"
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101579781
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1155,6 +1155,30 @@ server.3=zoo3:2888:3888
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101589125
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static int
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r101588320
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -153,13 +155,33 @@
*/
public final static int
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
Thanks everyone for feedback. Updated pull request to address your review
comments. One change I made on latest update is to introduce an internal Java
system property zookeeper.test.4lw.enabled
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/177
merged, please close this PR @afine .
Side note - the other day was discussing this with @rakeshadr. If we use
the merge script without resolving the JIRA, or the JIRA was already resolved
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/173
Thanks for updates, @JiangJiafu.
Patch looks good, and I agree that this patch is solving a different
problem than ZOOKEEPER-2184. I'll give a few more days in case anyone has
addition
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
@rakeshadr , @arshadmohammad feedback on this patch will be appreciated. It
is a blocker for both ongoing 3.5 and 3.4 releases.
---
If your project is set up for it, you can reply to this email
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/177
+1. Will merge this and the other one shortly. Thanks for spending time
taking care of the tests @afine !
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/137
lgtm, though I don't have a windows box to test changes on lastRevision.bat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/154
ZOOKEEPER-2672: Remove CHANGE.txt.
The CHANGE.txt is already not the source of truth of what's changed after
we migrating to git - most of the git commits in recent couple of months don't
update
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/157
@revans2 No more work is required, the patch is ready, but I am not sure if
this should be included in the upcoming 3.4.10 release. If not we will wait
until 3.4.10 is out to merge this into branch
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96574629
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection
serverAddresses
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96574584
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -87,15 +73,69 @@ public StaticHostProvider(Collection
serverAddresses
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> Do we need a separate issue for the 3.6 change?
No we don't (what @fpj prefers wrapping both PR in one shot under
ZOOKEEPER-2642).
@Randgalt Do you mind update the curr
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
@Randgalt Exactly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/152
>> Do I need to create a new patch file or is that no longer necessary?
No need to create a patch file separately - a pull request is enough.
---
If your project is set up for it, y
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/152
+1, thanks @Randgalt.
@fpj Shall I merge this in (along with
https://github.com/apache/zookeeper/pull/151)?
---
If your project is set up for it, you can reply to this email and have your
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/122
>> Breaking changes should be in a 3.6 version.
Sounds OK to me.
>> We need to either create a new issue or have a different pull request
for 3.5 under this same issu
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96699234
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96702291
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96699514
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/150#discussion_r96699622
--- Diff: src/java/main/org/apache/zookeeper/client/StaticHostProvider.java
---
@@ -57,26 +62,20 @@
public StaticHostProvider(Collection
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r103512572
--- Diff:
src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java ---
@@ -216,6 +216,10 @@ public static boolean isEnabled(String command
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/93#discussion_r85179943
--- Diff: README.txt ---
@@ -35,3 +35,7 @@ dist-maven directory are deployed to the central
repository after the release
is voted on and approved
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/93
4th general comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/85
+1 great job Eddie.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/93#discussion_r85172091
--- Diff: README.txt ---
@@ -35,3 +35,7 @@ dist-maven directory are deployed to the central
repository after the release
is voted on and approved
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/93
ZOOKEEPER-2481: Flaky Test: testZeroWeightQuorum
Don't merge, this is just a test please discard.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/93#discussion_r85179972
--- Diff: README.txt ---
@@ -35,3 +35,7 @@ dist-maven directory are deployed to the central
repository after the release
is voted on and approved
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/93
closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/93
test on closed comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/93#discussion_r85172473
--- Diff: README.txt ---
@@ -35,3 +35,7 @@ dist-maven directory are deployed to the central
repository after the release
is voted on and approved
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/84
(Not particularly related to the logic of this PR) Might be better to do a
git squash to consolidate 16 commits into a single commit to keep the commit
history clean - I've seen most projects operate
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/102#discussion_r86885871
--- Diff: src/java/main/org/apache/jute/compiler/CGenerator.java ---
@@ -61,70 +61,88 @@ void genCode() throws IOException
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/102
ZOOKEEPER-2628: Fix findbug warnings.
This PR fixed 19 find bug warnings except this one, which might require
interface change that potentially could break client side apps.
Malicious code
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/102
Updated PR to address review comments from @eribeiro.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/100
@rgs1 Sure, no need to rush this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/96
Thanks @breed and @rgs1 for your time and review feedback. Pull request,
patch, and review board is now updated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/100
Thanks for the review, @rgs1. Patch and PR is updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/102
Updated PR to address review comments from @breed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/96#discussion_r87543684
--- Diff: src/java/test/org/apache/zookeeper/server/DataTreeTest.java ---
@@ -200,29 +198,34 @@ public void
testSerializeDoesntLockDataNodeWhileWriting
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/100
ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C client.
JIRA: https://issues.apache.org/jira/browse/ZOOKEEPER-2627
* Remove ZRWSERVERFOUND from C client to maintain consistency of error
codes
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/90#discussion_r84585224
--- Diff: src/c/include/zookeeper.h ---
@@ -2000,6 +2001,7 @@ ZOOAPI int zoo_set_acl(zhandle_t *zh, const char
*path, int version,
* \ref zoo_acreate
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/91
Use explicit fine grained locks for synchronizing access to QuorumVerifier
states in QuorumPeer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
1 - 100 of 839 matches
Mail list logo
