[jira] [Created] (ZOOKEEPER-3922) Add support for two server ZooKeeper with hardware oracle

2020-08-27 Thread Benjamin Reed (Jira)
Benjamin Reed created ZOOKEEPER-3922: Summary: Add support for two server ZooKeeper with hardware oracle Key: ZOOKEEPER-3922 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3922 Project:

[jira] [Commented] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

2018-09-14 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615566#comment-16615566 ] Benjamin Reed commented on ZOOKEEPER-3108: -- the reason we kept myid out of the config is so

[jira] [Resolved] (ZOOKEEPER-3104) Potential data inconsistency due to NEWLEADER packet being sent too early during SNAP sync

2018-08-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3104. -- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 583

[jira] [Commented] (ZOOKEEPER-3036) Unexpected exception in zookeeper

2018-07-30 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561968#comment-16561968 ] Benjamin Reed commented on ZOOKEEPER-3036: -- can you give a bit more detail as to what

[jira] [Resolved] (ZOOKEEPER-3095) Connect string fix for non-existent hosts

2018-07-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3095. -- Resolution: Fixed Issue resolved by pull request 579

[jira] [Resolved] (ZOOKEEPER-3072) Race condition in throttling

2018-07-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3072. -- Resolution: Fixed > Race condition in throttling > >

[jira] [Updated] (ZOOKEEPER-3072) Race condition in throttling

2018-07-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-3072: - Fix Version/s: 3.5.4 3.6.0 > Race condition in throttling >

[jira] [Resolved] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message

2018-07-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3061. -- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 555

[jira] [Resolved] (ZOOKEEPER-3073) fix couple of typos

2018-07-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3073. -- Resolution: Fixed > fix couple of typos > --- > >

[jira] [Resolved] (ZOOKEEPER-3078) Remove unused print_completion_queue function

2018-07-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3078. -- Resolution: Fixed > Remove unused print_completion_queue function >

[jira] [Resolved] (ZOOKEEPER-3079) Fix unsafe use of sprintf(3) for creating IP address strings

2018-07-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3079. -- Resolution: Fixed > Fix unsafe use of sprintf(3) for creating IP address strings >

[jira] [Resolved] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

2018-07-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2886. -- Resolution: Fixed > Permanent session moved error in multi-op only connections >

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

2018-06-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508441#comment-16508441 ] Benjamin Reed commented on ZOOKEEPER-3056: -- how are you getting in a state where you have

[jira] [Resolved] (ZOOKEEPER-2772) Delete node command does not honor Acl policy

2017-05-17 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2772. -- Resolution: Not A Bug > Delete node command does not honor Acl policy >

[jira] [Commented] (ZOOKEEPER-2772) Delete node command does not honor Acl policy

2017-05-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009215#comment-16009215 ] Benjamin Reed commented on ZOOKEEPER-2772: -- this appears to be a misunderstanding of what the

[jira] [Commented] (ZOOKEEPER-2748) Admin command to voluntarily drop client connections

2017-04-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964730#comment-15964730 ] Benjamin Reed commented on ZOOKEEPER-2748: -- we do this using the JMX interface. i think that

[jira] [Commented] (ZOOKEEPER-2693) DOS attack on wchp/wchc four letter words (4lw)

2017-03-16 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929091#comment-15929091 ] Benjamin Reed commented on ZOOKEEPER-2693: -- can someone put a good link to the exploit in the

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

2017-02-19 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873747#comment-15873747 ] Benjamin Reed commented on ZOOKEEPER-2184: -- another option would be to have a background

[jira] [Assigned] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

2017-02-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed reassigned ZOOKEEPER-27: -- Assignee: (was: Mahadev konar) Fix Version/s: (was: 3.0.0)

[jira] [Commented] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

2017-02-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854717#comment-15854717 ] Benjamin Reed commented on ZOOKEEPER-27: had the joy of running into this problem today. this

[jira] [Updated] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

2017-02-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-27: --- Description: Moved from SourceForge to Apache.

[jira] [Resolved] (ZOOKEEPER-261) Reinitialized servers should not participate in leader election

2017-01-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-261. - Resolution: Fixed committed to master > Reinitialized servers should not participate

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2016-12-15 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752196#comment-15752196 ] Benjamin Reed commented on ZOOKEEPER-2325: -- [~rgs] can you commit this? we need it to get

[jira] [Created] (ZOOKEEPER-2640) fix test coverage for single threaded C-API

2016-12-04 Thread Benjamin Reed (JIRA)
Benjamin Reed created ZOOKEEPER-2640: Summary: fix test coverage for single threaded C-API Key: ZOOKEEPER-2640 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2640 Project: ZooKeeper

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2016-11-29 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706785#comment-15706785 ] Benjamin Reed commented on ZOOKEEPER-2325: -- hey andrew, i've merged all the patches into a

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-07 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645962#comment-15645962 ] Benjamin Reed commented on ZOOKEEPER-2014: -- shall i commit it or are we waiting on something

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635265#comment-15635265 ] Benjamin Reed commented on ZOOKEEPER-2014: -- ah that makes sense. i didn't dig deep enough :)

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634422#comment-15634422 ] Benjamin Reed commented on ZOOKEEPER-2014: -- just a curious observer: why are we propagating

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632820#comment-15632820 ] Benjamin Reed commented on ZOOKEEPER-2619: -- i would love to see ZOOKEEPER-22 fixed, but i

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632811#comment-15632811 ] Benjamin Reed commented on ZOOKEEPER-2619: -- multi will handle some of the use cases, but a

[jira] [Commented] (ZOOKEEPER-2623) CheckVersion outside of Multi causes NullPointerException

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632776#comment-15632776 ] Benjamin Reed commented on ZOOKEEPER-2623: -- i agree that we should handle this gracefully :)

[jira] [Commented] (ZOOKEEPER-2592) Zookeeper is not recoverable once running system( machine on which zookeeper is running) is out of space

2016-11-03 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632763#comment-15632763 ] Benjamin Reed commented on ZOOKEEPER-2592: -- it sounds like we should close this as a

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

2016-10-27 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612002#comment-15612002 ] Benjamin Reed commented on ZOOKEEPER-761: - not yet, i have a mac and tests don't seem to work

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607124#comment-15607124 ] Benjamin Reed commented on ZOOKEEPER-2597: -- btw thanx for the script edward! even though

[jira] [Resolved] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2597. -- Resolution: Fixed > Add script to merge PR from Apache git repo to Github >

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607121#comment-15607121 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i used the script to commit the pull request. i

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605468#comment-15605468 ] Benjamin Reed commented on ZOOKEEPER-761: - for some reason my comments/changes do not get

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605414#comment-15605414 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i'll commit at end of day unless someone has an

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605408#comment-15605408 ] Benjamin Reed commented on ZOOKEEPER-2597: -- for some reason my comments were not bridged

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

2016-10-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604093#comment-15604093 ] Benjamin Reed commented on ZOOKEEPER-2619: -- thanx diego, you did express well what i was

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

2016-10-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598842#comment-15598842 ] Benjamin Reed commented on ZOOKEEPER-2619: -- i think it's a good idea to document this issue

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

2016-10-18 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586819#comment-15586819 ] Benjamin Reed commented on ZOOKEEPER-761: - this is a pretty good patch to make things start

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567516#comment-15567516 ] Benjamin Reed commented on ZOOKEEPER-2597: -- cool i opened an infra jira to see if they can

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567338#comment-15567338 ] Benjamin Reed commented on ZOOKEEPER-2597: -- are you still working on this edward? do you want

[jira] [Comment Edited] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559081#comment-15559081 ] Benjamin Reed edited comment on ZOOKEEPER-2597 at 10/9/16 2:16 AM: ---

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559081#comment-15559081 ] Benjamin Reed commented on ZOOKEEPER-2597: -- no problem. i made some reviews. (i though that

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558730#comment-15558730 ] Benjamin Reed commented on ZOOKEEPER-2597: -- did you put up the pull request? > Add script to

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-07 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556598#comment-15556598 ] Benjamin Reed commented on ZOOKEEPER-2597: -- great thanx! i have a couple of questions about

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

2016-10-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552617#comment-15552617 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i'm just starting to look at this script. it's

[jira] [Resolved] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

2016-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2600. -- Resolution: Cannot Reproduce > dangling ephemerals on overloaded server with local

[jira] [Commented] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

2016-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518765#comment-15518765 ] Benjamin Reed commented on ZOOKEEPER-2600: -- i investigated this further and it appears that a

[jira] [Created] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

2016-09-22 Thread Benjamin Reed (JIRA)
Benjamin Reed created ZOOKEEPER-2600: Summary: dangling ephemerals on overloaded server with local sessions Key: ZOOKEEPER-2600 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2600 Project:

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

2016-09-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485391#comment-15485391 ] Benjamin Reed commented on ZOOKEEPER-2465: -- the last time a similar issue came up like this

[jira] [Commented] (ZOOKEEPER-2169) Enable creation of nodes with TTLs

2016-09-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469376#comment-15469376 ] Benjamin Reed commented on ZOOKEEPER-2169: -- can't you just do a stat to find this out? >

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

2016-09-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457459#comment-15457459 ] Benjamin Reed commented on ZOOKEEPER-2536: -- BTW i think the patch is not applying because you

[jira] [Commented] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root

2016-09-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457457#comment-15457457 ] Benjamin Reed commented on ZOOKEEPER-2537: -- isn't this the same as ZOOKEEPER-2536? > When

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

2016-09-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457447#comment-15457447 ] Benjamin Reed commented on ZOOKEEPER-2536: -- +1 LGTM > When provide path for "dataDir" with

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

2016-09-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457427#comment-15457427 ] Benjamin Reed commented on ZOOKEEPER-2539: -- +1 looks good, just a formatting nit you need to

[jira] [Commented] (ZOOKEEPER-2169) Enable creation of nodes with TTLs

2016-08-28 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15444326#comment-15444326 ] Benjamin Reed commented on ZOOKEEPER-2169: -- i observed that all the container check tests

[jira] [Commented] (ZOOKEEPER-2169) Enable creation of nodes with TTLs

2016-08-19 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428477#comment-15428477 ] Benjamin Reed commented on ZOOKEEPER-2169: -- this looks pretty cool. it doesn't look like you

[jira] [Updated] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

2016-08-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-2325: - Attachment: zk.patch patch for ZOOKEEPER-2325.001.patch to make sure the initial case

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

2014-04-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968053#comment-13968053 ] Benjamin Reed commented on ZOOKEEPER-1807: -- +1 looks good to me. it would be

[jira] [Commented] (ZOOKEEPER-1699) Leader should timeout and give up leadership when losing quorum of last proposed configuration

2014-04-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13968059#comment-13968059 ] Benjamin Reed commented on ZOOKEEPER-1699: -- you have some tabs that should be

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

2013-11-26 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833545#comment-13833545 ] Benjamin Reed commented on ZOOKEEPER-832: - i think ZOOKEEPER-1794 would mostly

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

2013-11-25 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832373#comment-13832373 ] Benjamin Reed commented on ZOOKEEPER-832: - i think the solution to this is to

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

2013-11-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831147#comment-13831147 ] Benjamin Reed commented on ZOOKEEPER-832: - i can't quite see how any of the

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-11-23 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830747#comment-13830747 ] Benjamin Reed commented on ZOOKEEPER-1742: -- here is the message that failed

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-11-22 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830577#comment-13830577 ] Benjamin Reed commented on ZOOKEEPER-1742: -- it doesn't work on 3.4 either :(

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-11-21 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829739#comment-13829739 ] Benjamin Reed commented on ZOOKEEPER-1742: -- this still fails for me on my

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-11-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819839#comment-13819839 ] Benjamin Reed commented on ZOOKEEPER-1742: -- doing the tests on mac osx is

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-11-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811314#comment-13811314 ] Benjamin Reed commented on ZOOKEEPER-1742: -- i propose that i open up another

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-15 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796361#comment-13796361 ] Benjamin Reed commented on ZOOKEEPER-1783: -- looks great alex! sorry to nit

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-15 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796412#comment-13796412 ] Benjamin Reed commented on ZOOKEEPER-1783: -- +1 looks great thanx for sticking

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793918#comment-13793918 ] Benjamin Reed commented on ZOOKEEPER-1783: -- in Leader.java you create a new

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-10-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793925#comment-13793925 ] Benjamin Reed commented on ZOOKEEPER-1742: -- the --wrap is only used with the

[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos

2013-10-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793927#comment-13793927 ] Benjamin Reed commented on ZOOKEEPER-1742: -- @pat you should split out the

[jira] [Commented] (ZOOKEEPER-1783) Distinguish initial configuration from first established configuration

2013-10-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793513#comment-13793513 ] Benjamin Reed commented on ZOOKEEPER-1783: -- can you describe the problem a

[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible

2013-10-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793517#comment-13793517 ] Benjamin Reed commented on ZOOKEEPER-1499: -- +1 looks good alex! clientPort

[jira] [Commented] (ZOOKEEPER-1652) zookeeper java client does a reverse dns lookup when connecting

2013-10-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793518#comment-13793518 ] Benjamin Reed commented on ZOOKEEPER-1652: -- +1 nice fix zookeeper java

[jira] [Commented] (ZOOKEEPER-1666) Avoid Reverse DNS lookup if the hostname in connection string is literal IP address.

2013-10-12 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793520#comment-13793520 ] Benjamin Reed commented on ZOOKEEPER-1666: -- +1 i think this is a java only

[jira] [Updated] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible

2013-10-08 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1499: - Attachment: ZOOKEEPER-1499.patch isn't the problem that we aren't using the wildcard

[jira] [Commented] (ZOOKEEPER-1774) QuorumPeerMainTest fails consistently with complains about host assertion failure

2013-10-07 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787936#comment-13787936 ] Benjamin Reed commented on ZOOKEEPER-1774: -- it could be dns timeout issues.

[jira] [Commented] (ZOOKEEPER-832) Invalid session id causes infinite loop during automatic reconnect

2013-10-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787921#comment-13787921 ] Benjamin Reed commented on ZOOKEEPER-832: - i think approach 1 might be better.

[jira] [Commented] (ZOOKEEPER-1777) Missing ephemeral nodes in one of the members of the ensemble

2013-10-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787928#comment-13787928 ] Benjamin Reed commented on ZOOKEEPER-1777: -- i'm curious about the goal here.

[jira] [Commented] (ZOOKEEPER-1781) ZooKeeper Server fails if snapCount is set to 1

2013-10-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787929#comment-13787929 ] Benjamin Reed commented on ZOOKEEPER-1781: -- +1 good work! ZooKeeper Server

[jira] [Commented] (ZOOKEEPER-1763) Upgrade the netty version

2013-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777096#comment-13777096 ] Benjamin Reed commented on ZOOKEEPER-1763: -- +1 looks good to me

[jira] [Commented] (ZOOKEEPER-1760) Provide an interface for check version of a node

2013-09-24 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13777132#comment-13777132 ] Benjamin Reed commented on ZOOKEEPER-1760: -- i agree with flavio. you get this

[jira] [Commented] (ZOOKEEPER-1629) testTransactionLogCorruption occasionally fails

2013-06-13 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682645#comment-13682645 ] Benjamin Reed commented on ZOOKEEPER-1629: -- i think alex is right. i think we

[jira] [Commented] (ZOOKEEPER-1697) large snapshots can cause continuous quorum failure

2013-05-02 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647703#comment-13647703 ] Benjamin Reed commented on ZOOKEEPER-1697: -- ZOOKEEPER-1324 is probably one of

[jira] [Commented] (ZOOKEEPER-1629) testTransactionLogCorruption occasionally fails

2013-04-02 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619961#comment-13619961 ] Benjamin Reed commented on ZOOKEEPER-1629: -- ah you are right. it would be

[jira] [Updated] (ZOOKEEPER-1629) testTransactionLogCorruption occasionally fails

2013-04-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-1629: - Summary: testTransactionLogCorruption occasionally fails (was:

[jira] [Commented] (ZOOKEEPER-1629) testTransactionLogCorruption occasionally fails

2013-04-01 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618850#comment-13618850 ] Benjamin Reed commented on ZOOKEEPER-1629: -- can we get a few more comments in

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2013-03-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599688#comment-13599688 ] Benjamin Reed commented on ZOOKEEPER-107: - it passed jenkins right before the

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2013-03-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595583#comment-13595583 ] Benjamin Reed commented on ZOOKEEPER-107: - Committed revision 1453693. great

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2013-03-05 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13594396#comment-13594396 ] Benjamin Reed commented on ZOOKEEPER-107: - +1 awesome work you guys! looks

[jira] [Commented] (ZOOKEEPER-1366) Zookeeper should be tolerant of clock adjustments

2013-02-11 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575664#comment-13575664 ] Benjamin Reed commented on ZOOKEEPER-1366: -- i was just reviewing this issue

[jira] [Commented] (ZOOKEEPER-1643) Windows: fetch_and_add not 64bit-compatible, may not be correct

2013-02-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575593#comment-13575593 ] Benjamin Reed commented on ZOOKEEPER-1643: -- i think it would be great to use

[jira] [Commented] (ZOOKEEPER-1643) Windows: fetch_and_add not 64bit-compatible, may not be correct

2013-02-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575594#comment-13575594 ] Benjamin Reed commented on ZOOKEEPER-1643: -- we should also use

[jira] [Commented] (ZOOKEEPER-1643) Windows: fetch_and_add not 64bit-compatible, may not be correct

2013-02-10 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575628#comment-13575628 ] Benjamin Reed commented on ZOOKEEPER-1643: -- i really think you only need the

[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership

2013-02-06 Thread Benjamin Reed (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572606#comment-13572606 ] Benjamin Reed commented on ZOOKEEPER-107: - great work you guys! can you comment

  1   2   3   >