Re: write performance issue in 3.6.2

2021-05-03 Thread Michael Han
ates on the issue. > > > > > > 1. We've checked the fine grained metrics and found that the > > > CommitProcessor was the bottleneck. The commit_commit_proc_req_queued > and > > > the write_commitproc_time_ms were large. > > > The errors were caused by

Re: write performance issue in 3.6.2

2021-05-03 Thread Michael Han
e know if you or anyone has any questions. > > Thanks, > > Li > > > > On Tue, Apr 20, 2021 at 8:03 PM Michael Han wrote: > > > What is the workload looking like? Is it pure write, or mixed read write? > > > > A couple of ideas to move this forwar

Re: write performance issue in 3.6.2

2021-04-20 Thread Michael Han
What is the workload looking like? Is it pure write, or mixed read write? A couple of ideas to move this forward: * Publish the performance benchmark so the community can help. * Bisect git commit and find the bad commit that caused the regression. * Use the fine grained metrics introduced in 3.6

Re: ConnectionLoss Upon Length Error - Failed to Write > 1 MB

2021-01-08 Thread Michael Han
Server should really check the length of incoming buffer size against the sum of jute.maxbuffer and an extra configurable padding (reserved for packet / requests headers). The default padding value is 1024 bytes and now it's configurable through Java properties. I believe we do use this combined

[jira] [Created] (ZOOKEEPER-3981) Flaky test MultipleAddressTest::testGetValidAddressWithNotValid

2020-10-20 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3981: -- Summary: Flaky test MultipleAddressTest::testGetValidAddressWithNotValid Key: ZOOKEEPER-3981 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3981 Project

[jira] [Created] (ZOOKEEPER-3970) Enable ZooKeeperServerController to expire session

2020-10-14 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3970: -- Summary: Enable ZooKeeperServerController to expire session Key: ZOOKEEPER-3970 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3970 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3967) Jetty License Update

2020-10-12 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3967: -- Summary: Jetty License Update Key: ZOOKEEPER-3967 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3967 Project: ZooKeeper Issue Type: Task

[jira] [Created] (ZOOKEEPER-3966) Model ZooKeeper data tree using RocksDB primitives to enable on disk data tree storage

2020-10-07 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3966: -- Summary: Model ZooKeeper data tree using RocksDB primitives to enable on disk data tree storage Key: ZOOKEEPER-3966 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3966

[jira] [Created] (ZOOKEEPER-3965) Add documentation for RocksDB Snap feature

2020-10-07 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3965: -- Summary: Add documentation for RocksDB Snap feature Key: ZOOKEEPER-3965 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3965 Project: ZooKeeper

[jira] [Created] (ZOOKEEPER-3964) Introduce RocksDB snap and implement change data capture to enable incremental snapshot

2020-10-07 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3964: -- Summary: Introduce RocksDB snap and implement change data capture to enable incremental snapshot Key: ZOOKEEPER-3964 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3964

Re: ApacheCon Bug Bash

2020-10-02 Thread Michael Han
Let's not close these pull requests as invalid as they are with very good intentions. Can someone on this list from MuseDev please work with the contributors so they are aware of our contribution guideline: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute For these pull

Re: [jira] [Commented] (ZOOKEEPER-3945) poker

2020-09-25 Thread Michael Han
Thanks Christopher, just deleted this spam issue. On Thu, Sep 24, 2020 at 11:40 PM Christopher Tubbs (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/ZOOKEEPER-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201944#comment-17201944 > ] > > Christopher

[jira] [Created] (ZOOKEEPER-3948) Introduce a deterministic runtime behavior injection framework for ZooKeeperServer testing

2020-09-25 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3948: -- Summary: Introduce a deterministic runtime behavior injection framework for ZooKeeperServer testing Key: ZOOKEEPER-3948 URL: https://issues.apache.org/jira/browse/ZOOKEEPER

Re: CI build issues

2020-09-15 Thread Michael Han
nk at the end of the way we should have everything in > source control to be perfect. > > We still don’t have Windows build either, but I’m not sure if > Windows-based nodes are available. > > Andor > > > > > On 2020. Sep 13., at 23:02, Michael Han wrote: > >

Re: CI build issues

2020-09-14 Thread Michael Han
nches > > For reference this one is for pre-commit > https://github.com/apache/zookeeper/blob/master/Jenkinsfile-PreCommit > > > > > > > > Patrick > > > > On Sun, Sep 13, 2020 at 2:02 PM Michael Han wrote: > > > > > Folks, >

CI build issues

2020-09-13 Thread Michael Han
Folks, I am seeing some CI build issues. Specifically: * Comment on github PR with "retest maven build" does not trigger a rebuild of JenkinsMaven. This used to work. Is this a known issue? * Tons of pre-merge job links on PRs are broken: they actually link to a deleted ci job I created a few

Re: [VOTE] Apache ZooKeeper 3.6.2 candidate 1

2020-09-04 Thread Michael Han
+1, with two minor issues: There is one unit test deterministically failing for me locally on mac: MultipleAddressesTest.testGetValidAddressWithNotValid Expected exception: java.net.NoRouteToHostException Also missing a couple of items in release notes: ZOOKEEPER-3794, ZOOKEEPER-3797,

Re: [VOTE] Apache ZooKeeper release 3.6.2 candidate 0

2020-09-03 Thread Michael Han
Haven't fully tested the RC but I didn't experience any of the lag through the cli. On Thu, Sep 3, 2020 at 3:15 PM Ted Dunning wrote: > On Thu, Sep 3, 2020 at 1:58 PM Patrick Hunt wrote: > > > On Thu, Sep 3, 2020 at 1:54 PM Ted Dunning > wrote: > > > > > OK. Did it with the correct version

Re: May violate the ZAB agreement -- version 3.6.1

2020-09-01 Thread Michael Han
n a new proposal > is chosen. If a learner needs to know whether a value has been chosen, it > can have a proposer issue a proposal, using the algorithm described above. > “ > > > > Best, > li xun > > > > 2020年8月29日 10:59,Michael Han 写道: > > Hi Xun, >

Re: May violate the ZAB agreement -- version 3.6.1

2020-08-28 Thread Michael Han
Hi Xun, I think this is a bug, your test case is sound to me. Do you mind creating a JIRA for this issue? Followers should not ACK NEWLEADER without ACK every transaction from the DIFF sync. To ACK every transaction, a follower either persists the transaction in log, or takes a snapshot before

Re: Creating a public fork of ZooKeeper

2020-08-16 Thread Michael Han
Have you considered a private fork? That might be a better option here as it provides additional flexibilities on what to develop (e.g. patented or company specific tech), when and what to upstream and so on. The downside of private fork I experienced was losing the incentive to upstream which

Re: ZK Transaction API multi()

2020-07-28 Thread Michael Han
I agree with Ted's comments on the philosophy of scaling and the need to recheck your use case to justify if ZooKeeper is the long term solution or not. That said, I was in a similar position and had gone through similar scaling challenges for ZooKeeper so I could probably provide some

Re: Need Help with Maven Build

2020-05-19 Thread Michael Han
hi jun - which maven version you are using? If it's 3.5.x, try upgrade to 3.6.x. I had the exact same issue a while back and upgrade maven fixed this, so I didn't bother to debug. That said, it's interesting to understand why we failed under specific version of maven / env, so cc dev list where

Re: Cutting 3.6.1 HEADS UP !

2020-04-10 Thread Michael Han
would be good to get ZOOKEEPER-3793 in this release. Without ZOOKEEPER-3793 zk will not throttle requests at all, given RequestThrottler is disabled by default (and requires some understanding to configure it correctly). On Thu, Apr 9, 2020 at 10:04 PM Enrico Olivelli wrote: > Il Ven 10 Apr

[jira] [Created] (ZOOKEEPER-3793) Request throttling is broken when RequestThrottler is disabled or configured incorrectly.

2020-04-10 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3793: -- Summary: Request throttling is broken when RequestThrottler is disabled or configured incorrectly. Key: ZOOKEEPER-3793 URL: https://issues.apache.org/jira/browse/ZOOKEEPER

Re: Implement checksum against malformed packets

2020-04-08 Thread Michael Han
-Solomon in order to avoid retransmission, but I don’t have practical > > experience with that, so might be a crazy idea. :) > > > > Andor > > > > > > > > > On 2020. Apr 8., at 3:17, Michael Han wrote: > > > > > >>> but not bulletproof? > &g

Re: Implement checksum against malformed packets

2020-04-07 Thread Michael Han
>> but not bulletproof? tcp checksum is weak and can't detect all corrupt packet; and bit flip can happen anywhere within the stack, and can be caused by malfunction of ram, or say, cosmic rays. Statistically a corrupt packet survives all layers of check is low, and even a packet is corrupted,

Re: ZooKeeper snapCount Tuning

2020-04-03 Thread Michael Han
The workload is a more deciding factor than hardwares when tuning zookeeper.snapCount and other config parameters, under current ZK implementation. I am afraid there is no universal value that applicable to every case although we can provide recommended settings by benchmarking predictable and

Re: [DISCUSS] Sending 3.4 release line to End-Of-Life status

2020-04-01 Thread Michael Han
+1. For EOL policy statement, just to throw something out here that i can think of: * Define what EOL means (such as: not supported by community dev team anymore, no future 3.4 releases .. still accessible at download page for X years..) and a date of EOL. * Provide guidelines for upgrading

[Job Ad] Twitter is hiring ZooKeepers

2020-03-09 Thread Michael Han
Hi fellow ZooKeeper developers, I have open software engineering positions in my team and would love to hear from anyone who might be interested. The work is around ZooKeeper

Re: [VOTE] Apache ZooKeeper 3.6.0 candidate 4

2020-03-03 Thread Michael Han
+1 - verified checksum/sig. - verified release notes. - verified regenerated documentations. - verified both java and c unit tests pass (ubuntu 18 / java11). - verified with a few jetty admin commands and zk cli commands. On Tue, Mar 3, 2020 at 2:24 AM Flavio Junqueira wrote: > +1 (binding) >

Re: Jepsen.io report

2020-02-17 Thread Michael Han
I believe the original report for ZooKeeper https://aphyr.com/posts/291-call-me-maybe-zookeeper was done by the author of Jepsen. Some of the conclusions were not very accurate (see https://github.com/jepsen-io/jepsen/issues/399 - "insumity" was an intern in my team fyi). Would be nice if we can

Re: Rolling upgrade from 3.5 to 3.6 - expected behaviour

2020-02-11 Thread Michael Han
> > > > >> > > > > > >> > > > > > >> I am happy to work on this topic > > > > > >> > > > > > >>> - we need to update the Wiki about the working rolling upgrade > > > paths > >

Re: Rolling upgrade from 3.5 to 3.6 - expected behaviour

2020-02-10 Thread Michael Han
Kudos Enrico, very thorough work as the final gate keeper of the release! Now with this, I'd like to *vote a -1* on the 3.6.0 RC2. I'd recommend we fix this issue for 3.6.0. ZooKeeper is one of the rare piece of software that put so much emphasis on compatibilities thus it just works when

Re: [VOTE] Apache ZooKeeper release 3.6.0 candidate 2

2020-02-08 Thread Michael Han
+1. - verified checksum/sig - verified release notes. - verified regenerated documentations. - verified both java and c unit tests pass. - verified with a few jetty admin commands and zk cli commands. On Sat, Feb 8, 2020 at 10:22 AM Flavio Junqueira wrote: > +1 binding > > - Built from

Re: [ANNOUNCE] Enrico Olivelli new ZooKeeper PMC Member

2020-01-21 Thread Michael Han
Congrats, Enrico! On Tue, Jan 21, 2020 at 1:57 PM Jordan Zimmerman wrote: > Well deserved. Congratulations. > > > Jordan Zimmerman > > > On Jan 21, 2020, at 4:40 PM, Flavio Junqueira wrote: > > > > I'm pleased to announce that Enrico Olivelli recently became the newest >

Re: Hadoop logo

2019-12-12 Thread Michael Han
+1 I do see a book keeper gif file in repo, should remove that one too. On my wish list: redesign of the ZooKeeper logo :) On Thu, Dec 12, 2019 at 7:44 AM Enrico Olivelli wrote: > +1 > > Maybe we should also check if we have old pages about Bookkeeper project. > It was a subproject of ZK but

Re: Drop ANT build pull request

2019-11-24 Thread Michael Han
>> ZooKeeper_UT_Stress (hanm’s private job - not sure if needed) I just deleted it. Thanks guys for taking care of the build system. On Fri, Nov 22, 2019 at 3:05 AM Enrico Olivelli wrote: > Il giorno ven 22 nov 2019 alle ore 11:16 Andor Molnar > ha > scritto: > > > Here’s another thing.

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 2

2019-10-01 Thread Michael Han
>> How about officially dropping netty support from 3.4 and asking people to move to the new version +1. This sounds a good opportunity to deprecate 3.4 branch. On Tue, Oct 1, 2019 at 8:00 AM Enrico Olivelli wrote: > Il giorno mar 1 ott 2019 alle ore 16:15 Patrick Hunt ha > scritto: > > >

Re: Releasing 3.6.0 - ALPHA or not ?

2019-10-01 Thread Michael Han
I am leaning towards release master as 3.6.0 as well, not with any suffix. We don't have any pending unstable API for 3.6 (like dynamic reconfiguration to 3.5) that justify the added overheads of using a non standard, ZooKeeper specific versioning scheme for master branch. See

[jira] [Created] (ZOOKEEPER-3561) Generalize target authentication scheme for ZooKeeper authentication enforcement.

2019-09-26 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3561: -- Summary: Generalize target authentication scheme for ZooKeeper authentication enforcement. Key: ZOOKEEPER-3561 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3561

[jira] [Created] (ZOOKEEPER-3560) Add response cache to serve get children (2) requests.

2019-09-26 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3560: -- Summary: Add response cache to serve get children (2) requests. Key: ZOOKEEPER-3560 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3560 Project: ZooKeeper

Re: [jira] [Commented] (ZOOKEEPER-3556) Dynamic configuration file can not be updated automatically after some zookeeper servers of zk cluster are down

2019-09-25 Thread Michael Han
>> There were recently a post here from someone who has implemented this Maybe this one? http://zookeeper-user.578899.n2.nabble.com/About-ZooKeeper-Dynamic-Reconfiguration-td7584271.html On Wed, Sep 25, 2019 at 9:19 PM Alexander Shraer wrote: > There were recently a post here from someone who

Re: PoweredBy Zookeeper

2019-09-24 Thread Michael Han
link to the doc: https://github.com/apache/zookeeper/blob/master/zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md On Tue, Sep 24, 2019 at 4:36 AM Enrico Olivelli wrote: > Cool > > I am not sure, do we have to wait for 3.6 release before updating the > website? > > Enrico > > Il

Re: maven command to run a specific test in a test case.

2019-09-20 Thread Michael Han
ncoding: UTF-8 > OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac" > > Patrick > > > On Fri, Sep 20, 2019 at 2:27 PM Michael Han wrote: > > > Thanks Andor, I tried that before but got some errors (still trying

Re: maven command to run a specific test in a test case.

2019-09-20 Thread Michael Han
just figured out, here is one concrete example: mvn test -DfailIfNoTests=false -Dtest=CreateTest#testCreate I have to set the "-DfailIfNoTests=false" to skip the modules that don't have a test. On Fri, Sep 20, 2019 at 2:27 PM Michael Han wrote: > Thanks Andor, I tried that b

Re: maven command to run a specific test in a test case.

2019-09-20 Thread Michael Han
20, 2019 at 11:08 PM Andor Molnar wrote: > > > I usually use: > > > > mvn verify -Dtest=bar > > > > Which runs the entire testcase. Not sure about how to run single test > > method. > > > > Andor > > > > > > > > On Fri, S

maven command to run a specific test in a test case.

2019-09-20 Thread Michael Han
In ant, we can execute a single test "foo" in a test case "bar" like this: *ant -Dtestcase=bar -Dtest.method=foo* What's the corresponding maven command? Cheers Michael.

[jira] [Created] (ZOOKEEPER-3548) Redundant zxid check in SnapStream.isValidSnapshot

2019-09-16 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3548: -- Summary: Redundant zxid check in SnapStream.isValidSnapshot Key: ZOOKEEPER-3548 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3548 Project: ZooKeeper

Re: PoweredBy Zookeeper

2019-09-13 Thread Michael Han
Nice list on the Curator wiki page! The pull request already include contents from ZooKeeper wiki, and it added additional contents. Probably we should also add contents to ZooKeeper wiki? I feel the documentation might have a wider audience than the wiki (which is less known). >> Usually

Re: Subscribing to security@

2019-08-30 Thread Michael Han
iiuc, I did through emailing security-subscr...@zookeeper.apache.org. On Fri, Aug 30, 2019 at 11:16 AM Enrico Olivelli wrote: > Hello, > How can I subscribe to secur...@zookeeper.apache.org? > > There is no way to subscribe using committers self service app > > > Enrico >

Re: Cutting Zookeeper 3.5.6

2019-08-30 Thread Michael Han
can want until early next week. > Otherwise I will start tonight (within 6-7 hours) > > Enrico > > > > Don't know what shape the solution should be but don't think it requires > > that much code - just thinking and community agreement. > > > > > > On Thu,

Re: Cutting Zookeeper 3.5.6

2019-08-29 Thread Michael Han
ZOOKEEPER-3056 would be nice to have, I'll try to have a patch ready soon, but it's not a blocker given workarounds available (unless community votes we really need this for 3.5.6). On Thu, Aug 29, 2019 at 8:16 AM Zili Chen wrote: > Great! > > IIRC it is possible to add a customized kanban on

Re: thoughts about extension to multi semantics

2019-08-17 Thread Michael Han
to multi actually be used? > > > > On Fri, Aug 16, 2019 at 8:28 PM Michael Han wrote: > > > This sounds a nice feature to me as it enables user to do more without > > obvious downside. It could be useful in cases like state management where > > the st

Re: thoughts about extension to multi semantics

2019-08-16 Thread Michael Han
This sounds a nice feature to me as it enables user to do more without obvious downside. It could be useful in cases like state management where the state is stored in a fine grained approach across multiple zNode, instead of in a single zNode. On Fri, Aug 16, 2019 at 11:52 AM Ted Dunning wrote:

Re: [Request For Review] ZOOKEEPER-3474 a.k.a GH-1028

2019-08-08 Thread Michael Han
t; tison. > > > Zili Chen 于2019年8月8日周四 上午9:20写道: > > > @Michael > > > > FYI, it is possible by properly setting and updating suppressing rules. > > > > Best, > > tison. > > > > > > Michael Han 于2019年8月8日周四 上午9:12写道: > > > &

Re: [Request For Review] ZOOKEEPER-3474 a.k.a GH-1028

2019-08-07 Thread Michael Han
I think a good approach is doing this incrementally. Doing this all at once over entire server code base will make life much harder for those who maintain their own ZooKeeper forks and has internal patches, and the change itself will be impossible to review (even though most changes are

Re: KIP-500: Replace ZooKeeper with a Self-Managed Metadata Quorum

2019-08-07 Thread Michael Han
Related discussions: https://lists.apache.org/list.html?d...@kafka.apache.org:lte=1M:KIP-500 >> Why would this lead to any discrepancy? It seems to me that the controller, will read an even newer state in such a scenario. I think in this case the Kafka side of expectation is not just be able to

Re: KIP-500: Replace ZooKeeper with a Self-Managed Metadata Quorum

2019-08-02 Thread Michael Han
some time. > It > > would be interesting to collect a few of these use cases from the > > community, esp downstreams, and evaluate performance, see if we can > > address. > > > > Patrick > > > > On Fri, Aug 2, 2019 at 11:03 AM Michael Han wrote: > >

Re: KIP-500: Replace ZooKeeper with a Self-Managed Metadata Quorum

2019-08-02 Thread Michael Han
; Patrick > > On Fri, Aug 2, 2019 at 11:03 AM Michael Han wrote: > > > Folks, > > > > Some of you might already see this. Comments? > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quo

KIP-500: Replace ZooKeeper with a Self-Managed Metadata Quorum

2019-08-02 Thread Michael Han
Folks, Some of you might already see this. Comments? https://cwiki.apache.org/confluence/display/KAFKA/KIP-500%3A+Replace+ZooKeeper+with+a+Self-Managed+Metadata+Quorum What caught my eyes are: *Worse still, although ZooKeeper is the store of record, the state in ZooKeeper often doesn't match

[jira] [Created] (ZOOKEEPER-3483) Flaky test: org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testCollectStats

2019-08-01 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3483: -- Summary: Flaky test: org.apache.zookeeper.server.util.RequestPathMetricsCollectorTest.testCollectStats Key: ZOOKEEPER-3483 URL: https://issues.apache.org/jira/browse

Re: Leader election logging during reconfiguration

2019-07-30 Thread Michael Han
>> we should measure the total time more accurately +1 - it would be good to have a new metric to measure reconfiguration time, and leaving existing LE time metric dedicated to measure the conventional FLE time. Mixing both (as of today) will provide some confusing insights on how long the

Re: C client reviews needed

2019-07-29 Thread Michael Han
I'll start looking this week. On Sun, Jul 28, 2019 at 11:02 PM Enrico Olivelli wrote: > Hello folks, > We have a bunch of pending requests about the C client. > > is there any reviewer available to help merging them ? > > we are talking about SSL support (cool!) and a few bugfixes > > Enrico >

Re: complete quota system proposal

2019-07-18 Thread Michael Han
tion based on metrics inside server/client > > On Wed, Jul 17, 2019 at 8:02 PM Michael Han wrote: > > > >> a more complete quota/throttling system would be valuable here > > > > Absolutely. This will improve the stability of a shared zookeeper > cluster, > &g

Re: complete quota system proposal

2019-07-17 Thread Michael Han
>> a more complete quota/throttling system would be valuable here Absolutely. This will improve the stability of a shared zookeeper cluster, which is a very common use case. Because the lack of enforce quota (and other soft isolation mechanisms such as flow control / request limiting), the usual

[jira] [Created] (ZOOKEEPER-3448) Introduce MessageTracker to assist debug leader and leaner connectivity issues

2019-06-28 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3448: -- Summary: Introduce MessageTracker to assist debug leader and leaner connectivity issues Key: ZOOKEEPER-3448 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3448

[jira] [Created] (ZOOKEEPER-3439) Observability improvements on client / server connection close

2019-06-21 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3439: -- Summary: Observability improvements on client / server connection close Key: ZOOKEEPER-3439 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3439 Project

[jira] [Created] (ZOOKEEPER-3430) Observability improvement: provide top N read / write path queries

2019-06-17 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3430: -- Summary: Observability improvement: provide top N read / write path queries Key: ZOOKEEPER-3430 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3430 Project

Re: PostCommit- CI job ? Where it is ?

2019-06-13 Thread Michael Han
em for ZooKeeper - move remaining > > > (nkalmar: rev 6af151a7e44760c33165e58d3b33a4d2760283a4) > > > * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/ > > > MetricsContext.java > > > * (edit) zookeeper-server/src/main/java/org/apache/zookee

Re: PostCommit- CI job ? Where it is ?

2019-06-11 Thread Michael Han
Hi Enrico, I don't think it's a post commit job that adds the "Issue resolved by pull request" comment (if this is the comment you were referring to.). This was added by the merge script through JIRA api. On Mon, Jun 10, 2019 at 1:34 PM Enrico Olivelli wrote: > Hi ZooKeepers, > I am

[jira] [Created] (ZOOKEEPER-3427) Introduce SnapshotComparer that assists debugging with snapshots.

2019-06-11 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3427: -- Summary: Introduce SnapshotComparer that assists debugging with snapshots. Key: ZOOKEEPER-3427 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3427 Project

[jira] [Created] (ZOOKEEPER-3419) Backup and recovery support

2019-06-06 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3419: -- Summary: Backup and recovery support Key: ZOOKEEPER-3419 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3419 Project: ZooKeeper Issue Type: New

[jira] [Created] (ZOOKEEPER-3418) Improve quorum throughput through eager ACL checks of requests on local servers

2019-06-06 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3418: -- Summary: Improve quorum throughput through eager ACL checks of requests on local servers Key: ZOOKEEPER-3418 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3418

[jira] [Created] (ZOOKEEPER-3416) Remove redundant ServerCnxnFactoryAccessor

2019-06-05 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3416: -- Summary: Remove redundant ServerCnxnFactoryAccessor Key: ZOOKEEPER-3416 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3416 Project: ZooKeeper

Re: [ANNOUNCE] New ZooKeeper committer: Norbert Kalmar

2019-05-29 Thread Michael Han
Congratulations Norbert! On Tue, May 28, 2019 at 2:29 PM Dinesh Appavoo wrote: > Awesome. Congrats Norbert! > > On Tue, May 28, 2019 at 10:51 AM Brian Nixon > wrote: > > > Congrats, Norbert! Well earned. > > > > On Mon, May 27, 2019 at 3:49 AM Andor Molnar > > > wrote: > > > > >

Re: [ANNOUNCE] New ZooKeeper committer: Enrico Olivelli

2019-05-29 Thread Michael Han
Congratulations Enrico! On Tue, May 28, 2019 at 2:05 PM Dinesh Appavoo wrote: > Great news. Congrats Enrico! > > On Tue, May 28, 2019 at 10:51 AM Brian Nixon > wrote: > > > Awesome! Congrats, Enrico! > > > > On Mon, May 27, 2019 at 3:56 AM Andor Molnar > > > wrote: > > > > > Congratulations

[jira] [Resolved] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

2019-05-21 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-1000. Resolution: Duplicate > Provide SSL in zookeeper to be able to run cross co

[jira] [Commented] (ZOOKEEPER-1000) Provide SSL in zookeeper to be able to run cross colos.

2019-05-21 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845426#comment-16845426 ] Michael Han commented on ZOOKEEPER-1000: Agreed, this sounds like a dup we can close for now

[jira] [Created] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.

2019-05-21 Thread Michael Han (JIRA)
Michael Han created ZOOKEEPER-3399: -- Summary: Remove logging in getGlobalOutstandingLimit for optimal performance. Key: ZOOKEEPER-3399 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399

Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6

2019-05-13 Thread Michael Han
+1. - verified checksum/sig. - source build, unit tests pass. - rat tool output looks ok. - verified cluster with different sizes with smoke tests. - release notes, license, notice looks good. On Sun, May 12, 2019 at 10:40 AM sandeep shrids wrote: > Hi, > > +1 > Performed the following checks

Re: why not disable sync API in libzkst.a?

2019-05-08 Thread Michael Han
Hi Shuxin, What's the zk client version you are testing? Sync apis were removed from c client in https://issues.apache.org/jira/browse/ZOOKEEPER-761, but it's only done for 3.5.3 and master branch only. There was a discussion in JIRA regarding whether or not to do the same for 3.4 branch which

Re: [Suggestion] Use Co-authored-by in commit messages

2019-05-08 Thread Michael Han
>> My proposal is to use github's feature of Co-author +1. The commit script would have to be updated to incorporate this feature. >> if someone participate in the review of PR, no matter whether he/she is a committer, we all need include his/her name We already do this when commit a change so

Re: [ANNOUNCE] New ZooKeeper PMC member: Andor Molnar

2019-05-08 Thread Michael Han
Congratulations, Andor! On Mon, Apr 29, 2019 at 9:10 AM Brian Nixon wrote: > Awesome! Congrats, Andor, you've been doing great work! > > > On Mon, Apr 29, 2019 at 7:31 AM Patrick Hunt wrote: > > > Kudos Andor! > > > > Patrick > > > > On Mon, Apr 29, 2019 at 2:07 AM Enrico Olivelli > > wrote:

[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend

2019-04-09 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814023#comment-16814023 ] Michael Han commented on ZOOKEEPER-3352: I don't see an obvious gain of using a LSM tree

Re: Zookeeper java client - a first step

2019-01-13 Thread Michael Han
+1. Good time to revisit https://issues.apache.org/jira/browse/ZOOKEEPER-233 On Sun, Jan 13, 2019 at 8:54 AM Enrico Olivelli wrote: > Hi guys, > We tried to separate java client from zookeeper-server package but > currently it is not possible without breaking changes. > > I think we can still

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-13 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741714#comment-16741714 ] Michael Han commented on ZOOKEEPER-3240: [~nixon] : bq. so the Leader is unable to sense

[jira] [Commented] (ZOOKEEPER-3240) Close socket on Learner shutdown to avoid dangling socket

2019-01-11 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740161#comment-16740161 ] Michael Han commented on ZOOKEEPER-3240: [~nixon] Good catch, the fix looks reasonable

Re: Question about the leader-based atomic broadcast

2019-01-09 Thread Michael Han
First of all, these questions are more related to implementation details rather than the Zab protocol itself. My answer thus is a reflection of the current ZK implementation. Zab itself could be implemented differently though. >> When will the leader delete the message from its FIFO queue? A

[jira] [Commented] (ZOOKEEPER-3180) Add response cache to improve the throughput of read heavy traffic

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719752#comment-16719752 ] Michael Han commented on ZOOKEEPER-3180: My experience with JVM GC and ZooKeeper is GC

Re: Migrating ZooKeeper to GitBox

2018-12-12 Thread Michael Han
+1 on voluntarily request to move. On Wed, Dec 12, 2018 at 11:36 AM Patrick Hunt wrote: > Probably minor, but note there are some website pages that will also need > to be updated: > e.g. https://zookeeper.apache.org/git.html > > Patrick > > On Wed, Dec 12, 2018 at 10:58 AM Enrico Olivelli >

[jira] [Commented] (ZOOKEEPER-3211) zookeeper standalone mode,found a high level bug in kernel of centos7.0 ,zookeeper Server's tcp/ip socket connections(default 60 ) are CLOSE_WAIT ,this lead to zk

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719736#comment-16719736 ] Michael Han commented on ZOOKEEPER-3211: {quote}Have similar defects been solved in 3.4.13

Re: Leader election

2018-12-12 Thread Michael Han
>> Can we reduce this time by configuring "syncLimit" and "tickTime" to let's say 5 seconds? Can we have a strong guarantee on this time bound? It's not possible to guarantee the time bound, because of FLP impossibility (reliable failure detection is not possible in async environment). Though

[jira] [Commented] (ZOOKEEPER-3211) zookeeper standalone mode,found a high level bug in kernel of centos7.0 ,zookeeper Server's tcp/ip socket connections(default 60 ) are CLOSE_WAIT ,this lead to zk

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719680#comment-16719680 ] Michael Han commented on ZOOKEEPER-3211: [~yss] Have you tried newer version of stable

[jira] [Commented] (ZOOKEEPER-3214) Flaky test: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719671#comment-16719671 ] Michael Han commented on ZOOKEEPER-3214: Thanks for reporting the flaky test. It's important

[jira] [Reopened] (ZOOKEEPER-3141) testLeaderElectionWithDisloyalVoter is flaky

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han reopened ZOOKEEPER-3141: Reopen this issue because this test was observed similar symptom recently as reported

[jira] [Resolved] (ZOOKEEPER-3214) Flaky test: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter

2018-12-12 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Han resolved ZOOKEEPER-3214. Resolution: Duplicate > Flaky t

Re: Leader election

2018-12-06 Thread Michael Han
Tweak timeout is tempting as your solution might work most of the time yet fail in certain cases (which others have pointed out). If the goal is absolute correctness then we should avoid timeout, which does not guarantee correctness as it only makes the problem hard to manifest. Fencing is the

[jira] [Commented] (ZOOKEEPER-3188) Improve resilience to network

2018-12-06 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16712162#comment-16712162 ] Michael Han commented on ZOOKEEPER-3188: Appreciate detailed reply, agree on replies on 1

[jira] [Commented] (ZOOKEEPER-2778) Potential server deadlock between follower sync with leader and follower receiving external connection requests.

2018-11-20 Thread Michael Han (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693936#comment-16693936 ] Michael Han commented on ZOOKEEPER-2778: I have to refresh my memory on this issue, but now

  1   2   3   4   5   6   7   8   9   10   >