[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/466 ---

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-24 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183664859 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -1897,6 +1896,12 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-24 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183664194 --- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py --- @@ -213,7 +213,13 @@ def metric_init(params=None):

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183565978 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -1897,6 +1896,12 @@ server.3=zoo3:2888:3888 zk_pending_syncs

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-23 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183565848 --- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py --- @@ -213,7 +213,13 @@ def metric_init(params=None):

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-21 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183201618 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java --- @@ -106,10 +104,10 @@ public String toString() { private final

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-21 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r183201663 --- Diff: src/java/main/org/apache/zookeeper/server/command/StatCommand.java --- @@ -64,8 +64,8 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-19 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182698169 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-18 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182459083 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-18 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182332830 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-18 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182325325 --- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java --- @@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-17 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182196539 --- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java --- @@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-17 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r182196063 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-16 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r181829051 --- Diff: src/java/main/org/apache/zookeeper/server/admin/Commands.java --- @@ -329,12 +329,20 @@ public CommandResponse run(ZooKeeperServer zkServer,

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-16 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r181817033 --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java --- @@ -75,9 +79,9 @@ public void commandRun() {

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-16 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r181824379 --- Diff: src/java/main/org/apache/zookeeper/server/admin/Commands.java --- @@ -329,12 +329,20 @@ public CommandResponse run(ZooKeeperServer zkServer,

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-16 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r181822557 --- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java --- @@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-04-16 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/466#discussion_r181823105 --- Diff: src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java --- @@ -84,4 +92,17 @@ public void testSendCloseSession() throws Exception

[GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...

2018-02-16 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/466 ZOOKEEPER-2940. Deal with maxbuffer as it relates to large requests from clients This PR covers the other part of Jute buffer monitoring which relates to client response sizes.