[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user afine closed the pull request at: https://github.com/apache/zookeeper/pull/232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117658709 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -96,21 +97,20 @@ /** * This is a completely open ACL .

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117658774 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -96,21 +97,20 @@ /** * This is a completely open ACL .

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117358635 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r117228583 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r113032380 --- Diff: src/java/main/org/apache/jute/compiler/JBuffer.java --- @@ -41,6 +41,20 @@ public String genCppGetSet(String fname, int fIdx) { public

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r113032297 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r113011930 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r112841400 --- Diff: src/java/main/org/apache/jute/compiler/JBuffer.java --- @@ -41,6 +41,20 @@ public String genCppGetSet(String fname, int fIdx) {

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/232#discussion_r112841388 --- Diff: src/java/main/org/apache/jute/compiler/JType.java --- @@ -27,7 +27,7 @@ private String mCName; private String mCppName;

[GitHub] zookeeper pull request #232: ZOOKEEPER-2731: Cleanup findbug warnings in bra...

GitHub user afine opened a pull request: https://github.com/apache/zookeeper/pull/232 ZOOKEEPER-2731: Cleanup findbug warnings in branch-3.4: Malicious code vulnerability Warnings There are two interesting parts to this change. The first is in the Jute compiler. Fields