Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238787735
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -69,7 +69,7 @@ public void sendCloseSession() { }
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238786172
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -151,12 +148,17 @@ void sendBufferSync(ByteBuffer bb) {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238794022
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238788593
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238788174
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -235,10 +237,12 @@ void handleWrite(SelectionKey k)
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238790553
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r238789004
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r231199414
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r231194896
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r231189992
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user tumativ commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r231110582
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973324
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DumbWatcher.java ---
@@ -69,7 +69,7 @@ public void sendCloseSession() { }
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973619
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -151,12 +148,17 @@ void sendBufferSync(ByteBuffer bb) {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230974144
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973727
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java
---
@@ -235,10 +237,12 @@ void handleWrite(SelectionKey k)
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973999
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230975652
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ---
@@ -68,29 +70,74 @@
private volatile boolean
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r230973904
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229934430
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229934517
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229935808
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229937485
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229938031
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
---
@@ -67,7 +67,10 @@
SNAP_COUNT(new
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229934995
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229936526
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229870463
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java ---
@@ -68,29 +70,74 @@
private volatile boolean
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/684#discussion_r229871456
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed to the
GitHub user enixon opened a pull request:
https://github.com/apache/zookeeper/pull/684
ZOOKEEPER-3180: Add response cache to improve the throughput of read â¦
â¦heavy traffic
Introduces a ResponseCache that interacts with ServerCnxn to cache the
serialized response for
28 matches
Mail list logo
