[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410685#comment-15410685 ] Flavio Junqueira commented on ZOOKEEPER-1742: - Sounds good [~hanm]. > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410315#comment-15410315 ] Michael Han commented on ZOOKEEPER-1742: The latest patch attached here does not apply unfortunately... One observation is the patch uses compile time interception which only works for source files we can instrument - so it is not semantically equivalent to the ld wrap option which also replaced calls from stand libraries (for functions such as calloc we are mocking in test.). Maybe that is why some of UTs were failing when we first tried the patch? For OS X, there is standard practice to simulate ld wrap option as described in TR [1], section 'Macintosh OS X function wrapping', and I tested it work for me locally, so we can explore that approach. I'll give a stab on this if no one else is interested. This approach requires link to shared library so created ZOOKEEPER-2505 to track that. I think we can keep the ld wrap option as is and add wrap option simulator for OSX specifically - so we can run c test on mac and meanwhile have minimum impact on other platforms. [1]https://wwwold.cs.umd.edu/Library/TRs/CS-TR-4585/CS-TR-4585.pdf > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720280#comment-14720280 ] Chris Chen commented on ZOOKEEPER-1742: --- I take that back, it looks like the solaris toolchain is using the GNU linker? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14720274#comment-14720274 ] Chris Chen commented on ZOOKEEPER-1742: --- Any word? It looks like some work was done similar to this for ZOOKEEPER-1077 make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831348#comment-13831348 ] Flavio Junqueira commented on ZOOKEEPER-1742: - What I'm hearing is that no one is confident that we have the right solution quite yet, so I propose we bump it to 3.4.7, 3.5.0. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.7, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830747#comment-13830747 ] Benjamin Reed commented on ZOOKEEPER-1742: -- here is the message that failed to post last night: i took a look at simply disabling the tests that don't work. for zktest-st i could get all but a dozen tests to pass, but there are so many tests that fail on zktest-mt that it becomes worthless. i suggest that we ignore this issue for the next release. in short. i concur with german. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830163#comment-13830163 ] Germán Blanco commented on ZOOKEEPER-1742: -- OK, I can confirm that it would take me around a month to figure this out :-(. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830195#comment-13830195 ] Flavio Junqueira commented on ZOOKEEPER-1742: - [~breed], I'd like to get this into 3.4.6. Have you tested with trunk only? If the patch is good for 3.4.6, we can have checked in to branch 3.4. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830577#comment-13830577 ] Benjamin Reed commented on ZOOKEEPER-1742: -- it doesn't work on 3.4 either :( make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830596#comment-13830596 ] Hadoop QA commented on ZOOKEEPER-1742: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615451/ZOOKEEPER-1742-3.4.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 35 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1802//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829739#comment-13829739 ] Benjamin Reed commented on ZOOKEEPER-1742: -- this still fails for me on my mac. i think the time mocking doesn't seem to be working properly. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829755#comment-13829755 ] Germán Blanco commented on ZOOKEEPER-1742: -- Hello [~breed], thank you very much for testing! It also fails for me on mac, even though it works in Ubuntu, but it is very difficult for me to find the origin of the problem. Could you please give me a few more details on this time mocking problem? Which function or module is it where there is time mocking involved? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825163#comment-13825163 ] Germán Blanco commented on ZOOKEEPER-1742: -- I am using the GNU utilities. Are you? I think the only non-GNU tool that I used was ld. The warnings don't seem difficult to avoid, though, I can give it a try this evening. Regarding the wrappers.opt and wrappers-mt.opt files, the reference to those should be removed in the patch. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825186#comment-13825186
]
Flavio Junqueira commented on ZOOKEEPER-1742:
-
yeah, I'm not sure. as far as I can tell, they are all ports of gnu tools to
mac os x. for example, make --help:
{noformat}
...
This program built for i386-apple-darwin11.3.0
Report bugs to bug-m...@gnu.org
{noformat}
autoreconf
{noformat}
...
Report bugs to bug-autoc...@gnu.org.
GNU Autoconf home page: http://www.gnu.org/software/autoconf/.
General help using GNU software: http://www.gnu.org/gethelp/.
{noformat}
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.5, 3.5.0
Reporter: Flavio Junqueira
Assignee: Germán Blanco
Fix For: 3.4.6, 3.5.0
Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch,
ZOOKEEPER-1742.patch
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825328#comment-13825328 ] Hadoop QA commented on ZOOKEEPER-1742: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614388/ZOOKEEPER-1742-3.4.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 29 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1782//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825567#comment-13825567 ] Hadoop QA commented on ZOOKEEPER-1742: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614431/ZOOKEEPER-1742.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1785//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1785//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1785//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825637#comment-13825637 ] Germán Blanco commented on ZOOKEEPER-1742: -- I mean AM_PROG_AR. Would it make sense to update the tools? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825678#comment-13825678 ] Hadoop QA commented on ZOOKEEPER-1742: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614453/ZOOKEEPER-1742.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1787//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1787//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1787//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13825753#comment-13825753 ] Hadoop QA commented on ZOOKEEPER-1742: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614460/ZOOKEEPER-1742.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1788//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13826189#comment-13826189 ] Germán Blanco commented on ZOOKEEPER-1742: -- Same failure, I guess I will have to wait until ZOOKEEPER-1805 is solved. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824802#comment-13824802
]
Flavio Junqueira commented on ZOOKEEPER-1742:
-
The patch for 3.4 seems to work fine, just a couple of things I wanted to run
by you. When I run autoreconf, I'm getting a bunch warning:
{noformat}
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.cc: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.h: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:92: warning: shell cat ${srcdir}/tests/wrappers.opt: non-POSIX
variable name
Makefile.am:92: (probably a GNU make extension)
Makefile.am:105: warning: shell cat ${srcdir}/tests/wrappers-mt.opt: non-POSIX
variable name
Makefile.am:105: (probably a GNU make extension)
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libhashtable.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libhashtable.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:48: while processing Libtool library 'libzkmt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkmt_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_mt.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:53: while processing Libtool library 'libzookeeper_mt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_st.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:35: while processing Libtool library 'libzookeeper_st.la'
{noformat}
Is this expected?
Also, there are these two error messages that seem to be harmless, but they are
there:
{noformat}
cat: ./tests/wrappers.opt: No such file or directory
cat: ./tests/wrappers-mt.opt: No such file or directory
{noformat}
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.5, 3.5.0
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
Fix For: 3.4.6, 3.5.0
Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch,
ZOOKEEPER-1742.patch
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822633#comment-13822633 ] Hadoop QA commented on ZOOKEEPER-1742: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613870/ZOOKEEPER-1742.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//console This message is automatically generated. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.5, 3.5.0 Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821276#comment-13821276 ] Flavio Junqueira commented on ZOOKEEPER-1742: - Ok, I'm hearing two options: # We disable tests # We leave as is The problem with the second option is that it is preventing me from running tests altogether on mac os for the C client. Do you think you can propose a patch, [~breed]? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13819839#comment-13819839 ] Benjamin Reed commented on ZOOKEEPER-1742: -- doing the tests on mac osx is hard because the linker does not have the functionality that we need to hook into the mock framework. it's only a subset of the tests, so we would still have some coverage on osx. to really fix it we should probably move to a robust cross-platform mock framework. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811314#comment-13811314 ] Benjamin Reed commented on ZOOKEEPER-1742: -- i propose that i open up another issue to not build these tests on the Mac and do a patch there and then lower the priority of this issue. does that sound ok? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811391#comment-13811391 ] Flavio Junqueira commented on ZOOKEEPER-1742: - If we disable the tests for on Mac OS, aren't we exposing ourselves to trouble? The tests are there for a reason, but granted that I can't remember what these tests are doing, so it is not clear how critical it is that we run them on Mac OS. Just so that I understand, trying to fix the tests so that they run on Mac OS would be hard? They are running on Ubuntu fine now, is it right? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811769#comment-13811769 ] Patrick Hunt commented on ZOOKEEPER-1742: - bq. They are running on Ubuntu fine now, is it right? correct in my case (ubuntu 13.10) make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811035#comment-13811035 ] Flavio Junqueira commented on ZOOKEEPER-1742: - [~breed], [~abranzyck], do you guys think there is any chance we can try to fix this issue for 3.4.6? I'd really like to have this in for 3.4.6. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811063#comment-13811063 ] Germán Blanco commented on ZOOKEEPER-1742: -- Sorry but I can't help any more here. So far I haven't looked into the C code at all, and I think it would take me around a month to figure out what is going on. On top of that I don't have easy access to a Mac. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804281#comment-13804281 ] Flavio Junqueira commented on ZOOKEEPER-1742: - That's odd... Do you think the test failures are related to your patch? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804602#comment-13804602 ] Germán Blanco commented on ZOOKEEPER-1742: -- The test cases that fail in Linux must be related with the patch, since it is the only thing changed and the test cases passed without the patch. They don't look directly related with the changes, though. That is, at a first sight, they don't look like failures related with the counters that are updated in the functions that are wrapped. So it is probably some side effect, or an error in my changes. My guess about the test cases that fail in Mac and don't fail in Linux is that they are related with the new environment. That could be libraries, compiler, operating system or any other part that is new; and it could be generic to all macos users or specific to the environment that I used (Mac OSX 10.8.5, gcc 4.7.3). If anybody else has access to a mac, we can see if it fails in the same test cases or not, maybe that helps. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800119#comment-13800119 ] Flavio Junqueira commented on ZOOKEEPER-1742: - make test for me still fails because of the --wrap option. I tried German's patch but it doesn't apply to b3.4. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800144#comment-13800144 ] Germán Blanco commented on ZOOKEEPER-1742: -- I will prepare the patch for branch 3.4. It will be interesting to see if passes a different set of test cases there. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798128#comment-13798128 ] Patrick Hunt commented on ZOOKEEPER-1742: - With ZOOKEEPER-1646 and ZOOKEEPER-1795 fixed the c client tests are passing for me on Ubuntu Raring on both branch-3.4 and trunk. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1742.patch There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797589#comment-13797589
]
Germán Blanco commented on ZOOKEEPER-1742:
--
Last comment was not complete. It fails in that test case both in Mac and
Linux, but it fails in more test cases in Mac:
{noformat}
tests/TestZookeeperClose.cc:127: Assertion: equality assertion failed
[Expected: 0, Actual : -4]
tests/TestOperations.cc:270: Assertion: equality assertion failed [Expected: 1,
Actual : 0]
tests/TestOperations.cc:339: Assertion: assertion failed [Expression:
timeMock==zh-last_recv]
tests/TestOperations.cc:407: Assertion: equality assertion failed [Expected: 1,
Actual : 0]
tests/TestOperations.cc:212: Assertion: equality assertion failed [Expected:
-7, Actual : 0]
Failures !!!
Run: 41 Failure total: 5 Failures: 5 Errors: 0
FAIL: zktest-mt
===
ZooKeeper server startedRunning
.
.
.
Zookeeper_close::testCloseUnconnected1 : elapsed 87 : OK
Zookeeper_close::testCloseConnected1Assertion failed: (cptr), function
zookeeper_process, file src/zookeeper.c, line 2649.
{noformat}
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
Fix For: 3.4.6, 3.5.0
Attachments: ZOOKEEPER-1742.patch
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794391#comment-13794391 ] Patrick Hunt commented on ZOOKEEPER-1742: - Sounds good, here: ZOOKEEPER-1795 make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793718#comment-13793718 ] Germán Blanco commented on ZOOKEEPER-1742: -- I need a bit of help here. I have tried using dlsym instead of the --wrap linker option, but I found an error when doing it. It is most likely due to the corresponding shared library not being loaded in memory when calling dlsym. I will need to look it up, unless there is a different way to solve this ... The dlsym method will not work for the functions that are not in shared libraries (e.g. deliverWatchers), and for those I was thinking in using a new macro and compiling a new version of the libraries for use only in test. In that new version of the library, all the calls to functions that are now wrapped will have wrap_ appended to their name. The wrapper function in the test code will have this name (wrap_ appended) and call the original function. Will that work for all functions? That means, also for those that are now wrapped but are not part of the zookeeper library code (e.g. calloc). If that works, then I would use the same method for all those wrapped functions, and this method is portable to all platforms. Can anybody please answer this question? make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793719#comment-13793719 ] Germán Blanco commented on ZOOKEEPER-1742: -- More specifically, what I am worrying about is that the linker option --wrap might replace not only the function calls within the zookeeper code but also other calls to these functions in e.g. the shared libraries. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793925#comment-13793925 ] Benjamin Reed commented on ZOOKEEPER-1742: -- the --wrap is only used with the tests, so it shouldn't be a problem in general. i think the reason the dlsym isn't working is because we are linking with the static libraries as you mention. we should really be linking to the shared libraries. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793927#comment-13793927 ] Benjamin Reed commented on ZOOKEEPER-1742: -- @pat you should split out the ubuntu build problem. there are just some unistd.h includes missing make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
RE: [jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
Ben, What are the tests that we would need to disable? If any have any concrete insight here, could you please add to the jira? Thanks, -Flavio -Original Message- From: Benjamin Reed [mailto:br...@apache.org] Sent: 10 October 2013 04:22 To: dev@zookeeper.apache.org Subject: Re: [jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos i've been looking into the --wrap issue. the linker on osx just doesn't support it, and the functionality is pretty magical. i think we should just disable the tests that use them on osx On Wed, Oct 9, 2013 at 10:18 AM, Patrick Hunt (JIRA) j...@apache.orgwrote: [ https://issues.apache.org/jira/browse/ZOOKEEPER- 1742?page=com.atlassia n.jira.plugin.system.issuetabpanels:comment- tabpanelfocusedCommentId= 13790630#comment-13790630] Patrick Hunt commented on ZOOKEEPER-1742: - Should we split these out? How do you want to handle it? The failing test is a blocker for 3.4.6 IMO. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791232#comment-13791232
]
Germán Blanco commented on ZOOKEEPER-1742:
--
I think I could fix the ld -wrap option issue in Mac OSX. There is a proposal
here:
https://discussions.apple.com/thread/617779?start=0tstart=0
I have already tried this in Utils.h, and it works for external functions
(those that are not defined in the zookeeper library):
{noformat}
#define DECLARE_WRAPPER(ret,sym,sig) \
typedef ret (*fptr_##sym) sig; extern C ret sym sig
#define CALL_REAL(sym,params) \
(*((fptr_##sym)dlsym(RTLD_NEXT, sym))) params
{noformat}
For the functions in the zookeeper library that are wrapped, the easiest
solution for me would be to use a different version of the zookeeper library
for the tests, changing the name of these functions.
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
Fix For: 3.4.6, 3.5.0
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791352#comment-13791352 ] Flavio Junqueira commented on ZOOKEEPER-1742: - [~abranzyck], do you think you can generate a patch? I'm also not sure what you mean with using a different version of the zookeeper library for the tests. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791425#comment-13791425 ] Germán Blanco commented on ZOOKEEPER-1742: -- I will give it a try, it will take around a week though. The current test programs for the C API are linked to the same library that is part of the release, that is the library that is used for the client applications. In order for the test to work without the wrap option, one possibility would be to create a different library with just a few function names changed (those functions that are now *wrapped*) and use this library only for the test programs. If I find out how to link the test programs with the shared library version instead of the static library maybe that wouldn't be necessary. If anybody can tell me how to do that, please do. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790623#comment-13790623
]
Patrick Hunt commented on ZOOKEEPER-1742:
-
Seems there is an issue as well for Ubuntu (I'm on 13.04), however I'm only
seeing it on trunk and not branch 34
{noformat}
make check
make zktest-st zktest-mt
make[1]: Entering directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
g++ -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -DUSE_STATIC_LIB
-DZKSERVER_CMD=\./tests/zkServer.sh\ -DZOO_IPV6_ENABLED -g -O2 -MT
zktest_st-TestReconfigServer.o -MD -MP -MF
.deps/zktest_st-TestReconfigServer.Tpo -c -o zktest_st-TestReconfigServer.o
`test -f 'tests/TestReconfigServer.cc' || echo './'`tests/TestReconfigServer.cc
tests/TestReconfigServer.cc: In member function ‘bool
TestReconfigServer::waitForConnected(zhandle_t*, uint32_t)’:
tests/TestReconfigServer.cc:128:16: error: ‘sleep’ was not declared in this
scope
make[1]: *** [zktest_st-TestReconfigServer.o] Error 1
make[1]: Leaving directory `/home/phunt/dev/svn/svn-zookeeper/src/c'
make: *** [check-am] Error 2
{noformat}
I have
{noformat}
g++ --version
g++ (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
{noformat}
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
Fix For: 3.4.6, 3.5.0
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790630#comment-13790630 ] Patrick Hunt commented on ZOOKEEPER-1742: - Should we split these out? How do you want to handle it? The failing test is a blocker for 3.4.6 IMO. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790629#comment-13790629
]
Patrick Hunt commented on ZOOKEEPER-1742:
-
Also I'm seeing this fail consistently in branch34
{noformat}
Zookeeper_watchers::testDefaultSessionWatcher1zktest-mt: tests/ZKMocks.cc:271:
SyncedBoolCondition DeliverWatchersWrapper::isDelivered() const: Assertion
`i1000' failed.
{noformat}
make check doesn't work on macos
--
Key: ZOOKEEPER-1742
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
Project: ZooKeeper
Issue Type: Bug
Reporter: Flavio Junqueira
Assignee: Benjamin Reed
Fix For: 3.4.6, 3.5.0
There are two problems I have spotted when running make check with the C
client. First, it complains that the sleep call is not defined in two test
files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
Including unistd.h works. The second problem is with linker options. It
complains that --wrap is not a valid. I'm not sure how to deal with this
one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789361#comment-13789361 ] Patrick Hunt commented on ZOOKEEPER-1742: - Does this mean that we can't compile the c client on macos? If so we should increase the priority IMO. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) make check doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789362#comment-13789362 ] Flavio Junqueira commented on ZOOKEEPER-1742: - We can build the C client, but we can't run tests. At least I couldn't make it work on my computer, but I haven't had the time to look into it again. make check doesn't work on macos -- Key: ZOOKEEPER-1742 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Project: ZooKeeper Issue Type: Bug Reporter: Flavio Junqueira Assignee: Benjamin Reed Fix For: 3.4.6, 3.5.0 There are two problems I have spotted when running make check with the C client. First, it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker options. It complains that --wrap is not a valid. I'm not sure how to deal with this one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
