:
>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Enrico Olivelli mentioned you on ZOOKEEPER-1416
> ---
>
> [~jithingirish] I am sorry, th
elcome.
>
I am sorry but I don't know the C client code.
Let's see the C client experts advices
Enrico
> Thanks
> Jithin
>
> On Fri, Jul 29, 2022 at 4:53 AM Enrico Olivelli (Jira)
> wrote:
>
> >
> > [
> >
> htt
:
>
> [
> https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Enrico Olivelli mentioned you on ZOOKEEPER-1416
> ---
>
> [~jithingirish] I am sorry, th
sive watches (ZOOKEEPER-1416) PR is ready. But, I'm
> concerned about an assumption I've made. I worry about event ordering
> regarding multiple writes from multiple clients and watchers. Here's my
> assumption:
>
> If you successfully set a Persistent watcher (i.e. you get confirmation vi
The Persistent/Recursive watches (ZOOKEEPER-1416) PR is ready. But, I'm
concerned about an assumption I've made. I worry about event ordering regarding
multiple writes from multiple clients and watchers. Here's my assumption:
If you successfully set a Persistent watcher (i.e. you get
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3829/
###
## LAST 60 LINES OF THE CONSOLE
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3780/
###
## LAST 60 LINES OF THE CONSOLE
eolivelli commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-494151273
@anmolnar did you have time to review this patch ?
Honestly I would like to see something like these new features in ZooKeeper
cc
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785667#comment-16785667
]
Gus Heck commented on ZOOKEEPER-1416:
-
This looks interesting. Solr essentially achieves
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459339636
@Randgalt deal.
This is an automated message from the Apache Git Service
Randgalt commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459338439
@anmolnar it has ample reviews above. Let's review it before I spend time
rebasing. It can be validated in its current state. If the result
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459337076
@Randgalt I guarantee that I will review it, but cannot guarantee it will
eventually be merged
Randgalt commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459329021
> Sounds like a great new feature for 3.6
> Would you mind rebasing it on master?
@anmolnar it depends on how likely it is
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3731/
###
## LAST 60 LINES OF THE CONSOLE
anmolnar commented on issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch
URL: https://github.com/apache/zookeeper/pull/136#issuecomment-459004064
@Randgalt Sounds like a great new feature for 3.6
Would you mind rebasing it on master
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521452#comment-16521452
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. Here are the results of testing the latest
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3696/
###
## LAST 60 LINES OF THE CONSOLE
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-1416:
--
Labels: pull-request-available (was: )
> Persistent Recursive Wa
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/136
News on this great feature?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190448#comment-16190448
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
re: ACL and recursive watches...
ZooKeeper.exists() does not check ACLs so I assert that the current
behavior of this PR doesn't violate the current behavior. i.e. in ZooKeeper you
can
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16190291#comment-16190291
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
One of our devs, @alexbrasetvik, asked about ACLs and recursive watches. It
turns out this PR is not handling that and needs to. I'll submit support for
this soon.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189258#comment-16189258
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
This PR and #332 are ready. How can we get this merged? @skamille ?
---
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3649/
###
## LAST 60 LINES OF THE CONSOLE
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189255#comment-16189255
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189254#comment-16189254
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179282#comment-16179282
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179266#comment-16179266
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179248#comment-16179248
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179249#comment-16179249
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
As promised - here's the project with the benchmarking stuff:
https://github.com/Randgalt/zkbench
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179236#comment-16179236
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
> does the new map in the watch structure break rolling upgrades
It would depend how you did it. If you upgraded all the ZK servers before
adding any persistent watches you'd be OK.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179195#comment-16179195
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179190#comment-16179190
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r140815418
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -40,50 +40,110 @@
class WatchManager {
private static final
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151001#comment-16151001
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user skamille commented on a diff
Github user skamille commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r136637514
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -40,50 +40,110 @@
class WatchManager {
private static final
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149328#comment-16149328
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149317#comment-16149317
]
Hadoop QA commented on ZOOKEEPER-1416:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133267#comment-16133267
]
Jordan Zimmerman commented on ZOOKEEPER-1416:
-
I ran a new benchmark (FYI - I'll make my
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133046#comment-16133046
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user skamille commented on the issue
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/136
> Per 3. This PR does not guarantee that you will see all events. I'll
double check the doc to make sure that that's clear. These watches behave
exactly as other watches in ZK other than they
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133039#comment-16133039
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user skamille commented on the issue
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/136
I want to make it clear that I'm not arguing against the feature, I just
want us to make sure that we're implementing it in a way that makes sense
absent the TreeSet use case, and that we at
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131435#comment-16131435
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
Another goal is feature parity with other consensus tools such as
etcd/consul. I added TTL nodes with this (and other) goals earlier in the year
(or was it last year?). Watches in consul are
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131426#comment-16131426
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user skamille commented on the issue
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/136
We have to remember that people who don't use TreeCache will still use this
feature. Not to say that we shouldn't keep it in mind as an important user, but
presumably people who don't actually
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129317#comment-16129317
]
Jordan Zimmerman commented on ZOOKEEPER-1416:
-
Regarding the performance numbers above
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129304#comment-16129304
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
Per 1. I posted some performance numbers in the issue. There's a definite
hit but it's worth it in my view. We should discuss this.
Per 2. What this PR is aimed at is users of Curator's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129299#comment-16129299
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user skamille commented on the issue
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/136
Questions I have about this from a high level design perspective:
1. As I asked on the mailing list, have we done load/performance testing or
addressed what that might look like in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129128#comment-16129128
]
Jordan Zimmerman commented on ZOOKEEPER-1416:
-
FYI - I did some micro benchmarking
g 10, 2017 at 1:44 PM, Jordan Zimmerman <
>>> jordan.zimmer...@elastic.co> wrote:
>>>
>>>> Friendly request for more movement on ZOOKEEPER-1416 - it's now been
>>>> reviewed by multiple people and even has a backport to 3.5.x
>>>> (ZOOKEEPER-28
ordan.zimmer...@elastic.co> wrote:
> >
> >> Friendly request for more movement on ZOOKEEPER-1416 - it's now been
> >> reviewed by multiple people and even has a backport to 3.5.x
> >> (ZOOKEEPER-2871). This feature will be a huge boon to large Zookeeper
> users
> >> and make the project more competitive with etcd et al.
> >>
> >> -Jordan
>
>
wrote:
>
>> Friendly request for more movement on ZOOKEEPER-1416 - it's now been
>> reviewed by multiple people and even has a backport to 3.5.x
>> (ZOOKEEPER-2871). This feature will be a huge boon to large Zookeeper users
>> and make the project more competitive with et
I plan on looking at this soon (within a week) if no one else gets to it.
On Thu, Aug 10, 2017 at 1:44 PM, Jordan Zimmerman <
jordan.zimmer...@elastic.co> wrote:
> Friendly request for more movement on ZOOKEEPER-1416 - it's now been
> reviewed by multiple people and even has a backp
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122520#comment-16122520
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132592200
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -74,12 +74,16 @@
public final int createTTL = 21;
+
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122481#comment-16122481
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132588619
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -74,12 +74,16 @@
public final int createTTL = 21;
+
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122415#comment-16122415
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132579217
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122395#comment-16122395
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132576447
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -74,12 +74,16 @@
public final int createTTL = 21;
+
Friendly request for more movement on ZOOKEEPER-1416 - it's now been reviewed
by multiple people and even has a backport to 3.5.x (ZOOKEEPER-2871). This
feature will be a huge boon to large Zookeeper users and make the project more
competitive with etcd et al.
-Jordan
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121059#comment-16121059
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
/332
> Port ZOOKEEPER-1416 to 3.5.x
>
>
> Key: ZOOKEEPER-2871
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2871
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: c cli
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121047#comment-16121047
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
GitHub user Randgalt opened a pull request
GitHub user Randgalt opened a pull request:
https://github.com/apache/zookeeper/pull/332
Port of ZOOKEEPER-1416 Persistent Recursive Watches
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2871
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120989#comment-16120989
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman reassigned ZOOKEEPER-2871:
---
Assignee: Jordan Zimmerman
> Port ZOOKEEPER-1416 to 3.
Jordan Zimmerman created ZOOKEEPER-2871:
---
Summary: Port ZOOKEEPER-1416 to 3.5.x
Key: ZOOKEEPER-2871
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2871
Project: ZooKeeper
Issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120481#comment-16120481
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120479#comment-16120479
]
Hadoop QA commented on ZOOKEEPER-1416:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120448#comment-16120448
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on the issue
Github user Randgalt commented on the issue:
https://github.com/apache/zookeeper/pull/136
@afine issues addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119044#comment-16119044
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119045#comment-16119045
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132034244
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter,
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132034154
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119042#comment-16119042
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132034008
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -74,12 +74,16 @@
public final int createTTL = 21;
+
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119006#comment-16119006
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user Randgalt commented on a diff
Github user Randgalt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132027605
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132006551
--- Diff:
src/java/test/org/apache/zookeeper/test/PersistentWatcherTest.java ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118997#comment-16118997
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118996#comment-16118996
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118992#comment-16118992
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118994#comment-16118994
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118995#comment-16118995
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118993#comment-16118993
]
ASF GitHub Bot commented on ZOOKEEPER-1416:
---
Github user afine commented on a diff
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r131271126
--- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java ---
@@ -74,12 +74,16 @@
public final int createTTL = 21;
+
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132023758
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132025725
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/136#discussion_r132024228
--- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java ---
@@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter,
boolean
1 - 100 of 267 matches
Mail list logo
