Re: getShopConfVar: "module:" prefix

2018-01-15 Thread K1 G.
Hi robert,

I think the module prefix in the oxconfig table is fine, also using it with
getShopConfVar does not sound new for me. But I remember I fixed a module
about a year ago by adding that prefix so I agree that it probably was
added some time ago.

You should give the method getConfigParam a try, personally I think it's
easier to use. The only drawback is that you have to use a unique name for
you config parameter to avoid collisions with other modules.

I can't tell you the version number when things changed, but maybe it helps
to know that the prefix is added when using the metadata and module
settings in the admin area and often modules that are trying to store
config values by their own running into situation described by you.

best regards

K1



Am 15.01.2018 12:53 schrieb "Robert Rosendahl" :

Hi,

I just noticed that one of my modules doesn't return its oxconfig settings
anymore. I fetch the settings via
  oxRegistry::getConfig()->getShopConfVar('blGhApiAllowNonSsl', null,
'ghoxid2greyhoundconnect');

The oxmodule column in the database, however, contains
"module:ghoxid2greyhoundconnect'". The "module:" prefix is probably added
by the admin config page (extended from ghOxid2GreyhoundAdminConfig). If I
fetch the setting with
  oxRegistry::getConfig()->getShopConfVar('blGhApiAllowNonSsl', null,
'module:ghoxid2greyhoundconnect');
then I get the correct value. So it seems that I need to add the "module:"
prefix in the getShopConfVar() call.

Has this behaviour changed somehow - and if so, do you know since which
version?

I have several versions of OXID CE with which I test our modules, but I
think I upgraded some of them from one minor version to the next. In my
OXID CE 4.9, for example, I have settings with both
'ghoxid2greyhoundconnect' and 'module:ghoxid2greyhoundconnect' in my
oxconfig table. So these might have been duplicated when i upgraded the
shop at some time and I probably didn't notice because the module just kept
using the old settings (I haven't changed them in a while). :-D

Now I've set up a fresh CE 4.10 and found that the module didn't get the
oxconfig settings.

I just need to know which versions of my module to fix. I've taken a look
at the changelog in the OXID bugtracker, but couldn't find anything
relating to getShopConfVar...

Cheers,
  Robert


getShopConfVar: "module:" prefix

2018-01-15 Thread Robert Rosendahl
Hi,

I just noticed that one of my modules doesn't return its oxconfig settings 
anymore. I fetch the settings via
oxRegistry::getConfig()->getShopConfVar('blGhApiAllowNonSsl', null, 
'ghoxid2greyhoundconnect');

The oxmodule column in the database, however, contains 
"module:ghoxid2greyhoundconnect'". The "module:" prefix is probably added by 
the admin config page (extended from ghOxid2GreyhoundAdminConfig). If I fetch 
the setting with
oxRegistry::getConfig()->getShopConfVar('blGhApiAllowNonSsl', null, 
'module:ghoxid2greyhoundconnect');
then I get the correct value. So it seems that I need to add the "module:" 
prefix in the getShopConfVar() call.

Has this behaviour changed somehow - and if so, do you know since which version?

I have several versions of OXID CE with which I test our modules, but I think I 
upgraded some of them from one minor version to the next. In my OXID CE 4.9, 
for example, I have settings with both 'ghoxid2greyhoundconnect' and 
'module:ghoxid2greyhoundconnect' in my oxconfig table. So these might have been 
duplicated when i upgraded the shop at some time and I probably didn't notice 
because the module just kept using the old settings (I haven't changed them in 
a while). :-D

Now I've set up a fresh CE 4.10 and found that the module didn't get the 
oxconfig settings.

I just need to know which versions of my module to fix. I've taken a look at 
the changelog in the OXID bugtracker, but couldn't find anything relating to 
getShopConfVar...

Cheers,
Robert