Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Benjamin Smedberg
On 1/17/2014 4:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. Does this mean that the moving GC is also enabled, or is that a later step? If we see an increase in the crash rate for nightly builds, is it likely that they will share a

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Terrence Cole
On 01/18/2014 07:08 AM, Benjamin Smedberg wrote: On 1/17/2014 4:24 PM, Terrence Cole wrote: Exact stack rooting is now enabled by default on desktop builds of firefox. Does this mean that the moving GC is also enabled, or is that a later step? No, moving GC is a later step. We are targeting

Re: Ideas for making it easier and less error prone for Firefox OS partners to expose certified only APIs

2014-01-18 Thread Anne van Kesteren
On Fri, Jan 17, 2014 at 9:44 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: Can anybody think of other similar techniques which we can adopt to improve our story here? Suggestions on WebIDL annotations, code changes, documentation, etc. are much appreciated! If they implement and expose

Re: Exact rooting is now enabled on desktop

2014-01-18 Thread Andrew McCreight
- Original Message - Great question! We have a tool called GC zeal in builds with --enable-gc-zeal and in all debug builds unconditionally. It adds a small runtime overhead, but gives us fine-grained control over when GC's happen and adds several verification modes for debugging

Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-18 Thread Matthew N.
Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred Reviewer review code in the related

Re: Toolkit sub-module Preferred Reviewers who are not Toolkit Peers

2014-01-18 Thread Ms2ger
On 01/18/2014 08:51 PM, Matthew N. wrote: Hello, What does it mean to be a Preferred Reviewer (previously called a peer) in a Toolkit sub-module[1] and not be on the list of Toolkit Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. Specifically: 1) Can a Preferred