Re: Getting rid of already_AddRefed?

2014-08-14 Thread Neil
Aryeh Gregor wrote: for instance, here's a real-world bit of code from nsWSRunObject: if ((aRun-mRightType WSType::block) IsBlockNode(nsCOMPtrnsINode(GetWSBoundingParent( { GetWSBoundingParent() returns an already_AddRefednsINode Well there's your problem:

Re: Upcoming changes to Mac package layout, signing

2014-08-14 Thread Stephen Pohl
On 8/14/14, 5:02 AM, Neil wrote: Benjamin Smedberg wrote: On 8/13/2014 3:34 AM, Philipp Kewisch wrote: Does this also affect binary extensions in any way? I'd imagine that globally installed extensions would break signing if placed incorrectly. You cannot place anything in the Firefox

Re: Getting rid of already_AddRefed?

2014-08-14 Thread Aryeh Gregor
On Thu, Aug 14, 2014 at 12:00 PM, Neil n...@parkwaycc.co.uk wrote: Well there's your problem: GetWSBoundingParent doesn't need to own the nodes it works on. Editing code is ancient, poorly maintained, and not performance-sensitive, so personally, I don't ever use raw pointers as local variables

Re: Getting rid of already_AddRefed?

2014-08-14 Thread Ehsan Akhgari
On Thu, Aug 14, 2014 at 10:02 AM, Aryeh Gregor a...@aryeh.name wrote: On Thu, Aug 14, 2014 at 12:00 PM, Neil n...@parkwaycc.co.uk wrote: Well there's your problem: GetWSBoundingParent doesn't need to own the nodes it works on. Editing code is ancient, poorly maintained, and not

WebGL doc plan review request

2014-08-14 Thread Eric Shepherd
We're getting ready for, at some point soon (we hope), documenting WebGL. To do that, we've written up a documentation plan. But it needs to be reviewed to be sure we didn't miss anything, and that our plan is logical. We've asked a few specific people for their thoughts, but I'd love more

Re: Intent to implement: Prerendering API

2014-08-14 Thread Ehsan Akhgari
On 2014-08-14, 1:44 AM, Ilya Grigorik wrote: On Wed, Aug 13, 2014 at 5:16 PM, Jonas Sicking jo...@sicking.cc wrote: On Wed, Aug 13, 2014 at 12:24 PM, Ilya Grigorik igrigo...@gmail.com wrote: On Tue, Aug 12, 2014 at 3:17 PM, Jonas Sicking jo...@sicking.cc wrote: Do you really think that

Re: Non-Trivial SpecialPowers Usage Considered Harmful

2014-08-14 Thread Ehsan Akhgari
On 2014-08-13, 7:38 PM, Bobby Holley wrote: On Wed, Aug 13, 2014 at 3:13 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: Note that anything tested in mochitest-chrome is not tested on Firefox OS at all, which is a *great* reason to avoid writing mochitest-chrome at all costs. Well, until bug

hg.mozilla.org: status update

2014-08-14 Thread Laura Thomson
Hi all, This is not a final RFO (reason for outage) as we need to continue observations, but we have solved a major problem and hg is looking healthy now. = tl;dr = Since July 17, hg.mozilla.org has been experiencing a series of outages, resulting in sheriffs needing to close the trees.

Re: Intent to implement: Prerendering API

2014-08-14 Thread Gavin Sharp
On Thu, Aug 14, 2014 at 8:32 AM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: In this context, an app that performs in-place updates, as opposed to full page reloads, when transitioning between different views. The views can use different JS, CSS, and so on. To achieve this, you have to build

Re: External dependent tests in gecko and gaia

2014-08-14 Thread Jonathan Griffin
I think this is a great idea, although like others have said, I'd like to have this implemented inside the test manifests, regardless of directory structure. A related piece is reporting; for years, we've had tests like this run on separate systems, reporting to custom dashboards, because

Re: Non-backward compatible changes to JS 'let' semantics

2014-08-14 Thread Chris Peterson
On 8/13/14 3:02 PM, Shu-yu Guo wrote: About not changing the behavior for chrome JS, the prospect of having chrome JS becoming more divergent from standard JS is unwelcome to me. Having additional, orthogonal features is one thing, but a fundamental feature with the same syntax that behaves

Re: External dependent tests in gecko and gaia

2014-08-14 Thread Edwin Wong
I think we're all in agreement. Adding support for manifest and mach/make option with the specific directory makes sense. To summarize: * land tests in a directory name external so it's easily identified as needing external access. * implement support in test manifest and mach/make to enable

Re: Intent to implement: Prerendering API

2014-08-14 Thread Jonas Sicking
On Thu, Aug 14, 2014 at 10:28 AM, Gavin Sharp ga...@gavinsharp.com wrote: On Thu, Aug 14, 2014 at 8:32 AM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: In this context, an app that performs in-place updates, as opposed to full page reloads, when transitioning between different views. The

Re: External dependent tests in gecko and gaia

2014-08-14 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/14/2014 08:22 PM, Edwin Wong wrote: I think we're all in agreement. Adding support for manifest and mach/make option with the specific directory makes sense. To summarize: * land tests in a directory name external so it's easily

Re: Intent to implement: Prerendering API

2014-08-14 Thread John Schoenick
On 08/14/2014 11:48 AM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 10:28 AM, Gavin Sharp ga...@gavinsharp.com wrote: On Thu, Aug 14, 2014 at 8:32 AM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: In this context, an app that performs in-place updates, as opposed to full page reloads, when

Re: Intent to implement: Prerendering API

2014-08-14 Thread Jonas Sicking
On Thu, Aug 14, 2014 at 12:37 PM, John Schoenick jschoen...@mozilla.com wrote: On 08/14/2014 11:48 AM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 10:28 AM, Gavin Sharp ga...@gavinsharp.com wrote: On Thu, Aug 14, 2014 at 8:32 AM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: In this

Regarding: Java Deployment Toolkit (click-to-play) has been blocked for your protection.

2014-08-14 Thread Myron
If there was an archive of messages to search I would have and maybe not be posting this query, but reading through a few other forums and bugzilla I've ended up with a major headache so I really looking for an intelligent and simple answer. Ok, so the Java Deployment Toolkit has a (or has) a

Re: Intent to implement: Prerendering API

2014-08-14 Thread John Schoenick
On 08/14/2014 12:50 PM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 12:37 PM, John Schoenick jschoen...@mozilla.com wrote: On 08/14/2014 11:48 AM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 10:28 AM, Gavin Sharp ga...@gavinsharp.com wrote: On Thu, Aug 14, 2014 at 8:32 AM, Ehsan Akhgari

Re: External dependent tests in gecko and gaia

2014-08-14 Thread Edwin Wong
Hi Ms2ger, Thanks for calling me on that, just trying to move things along. Test location and using manifests concepts can also be decoupled. Wherever the location the tests, we will use manifests to define it’s execution. There isn’t really any other way around that. So now the decision

Re: Help for new MDN page on testing frameworks (technical and editorial)

2014-08-14 Thread Martijn
Hi Paolo, This looks really nice, thanks! I have some suggestions. I think an extra column, with what kind of level style test (Unit/integration/UI) it is, would be nice. It seems like mach help shows some more kinds of tests, you might want to look at those. Regards, Martijn On Wed, Aug 13,

Re: External dependent tests in gecko and gaia

2014-08-14 Thread Ehsan Akhgari
On 2014-08-14, 5:00 PM, Edwin Wong wrote: Hi Ms2ger, Thanks for calling me on that, just trying to move things along. Test location and using manifests concepts can also be decoupled. Wherever the location the tests, we will use manifests to define it’s execution. There isn’t really any

Re: Intent to implement: Prerendering API

2014-08-14 Thread Ehsan Akhgari
On 2014-08-14, 4:53 PM, John Schoenick wrote: On 08/14/2014 12:50 PM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 12:37 PM, John Schoenick jschoen...@mozilla.com wrote: On 08/14/2014 11:48 AM, Jonas Sicking wrote: On Thu, Aug 14, 2014 at 10:28 AM, Gavin Sharp ga...@gavinsharp.com wrote: On

New QE-Verify Flag in Bugzilla

2014-08-14 Thread Marc Schifer
A short while ago we had a discussion about how to stream line some QA processes (Desktop QA - Bugzilla keywords: Proposal on dev-quality) and reduce the bug spam generated by setting keywords and whiteboard tags (Bugspam generated by the new process on firefox-dev). The final resolution of

Re: Non-backward compatible changes to JS 'let' semantics

2014-08-14 Thread Jeff Walden
On 08/14/2014 10:57 AM, Chris Peterson wrote: Does chrome and add-on JS code default to JSVERSION_1_8? It defaults to the latest version, whatever that is, so warning doesn't end up being reasonable. I do not think the SpiderMonkey team is smart enough to have implemented both the old