Re: Should &&/|| really be at the end of lines?

On Saturday, February 18, 2017 at 10:50:24 AM UTC+11, Boris Zbarsky wrote: > On 2/17/17 5:44 PM, gsqu...@mozilla.com wrote: > > - People who stick with the official parser will only ever see that > > (pushing to mozreview will reformat everything to the official style). > > Not all reviews go

Re: Should &&/|| really be at the end of lines?

On 2017/02/18 7:28, Bobby Holley wrote: On Fri, Feb 17, 2017 at 2:18 PM, wrote: Hi again Nick, Someone made me realize that I didn't fully read your message, sorry for that. I now see that as well as &&/||, you have grepped for other operators, and shown that the

Re: Should &&/|| really be at the end of lines?

On 2/17/17 5:44 PM, gsquel...@mozilla.com wrote: - People who stick with the official parser will only ever see that (pushing to mozreview will reformat everything to the official style). Not all reviews go through mozreview. -Boris ___

Re: Should &&/|| really be at the end of lines?

After dealing with bugs that only happen in PGO builds, I would be worried about bugs in the code-formatting-rewriter. The value doesn't seem worth the risk to me. - jared On Fri, Feb 17, 2017 at 5:44 PM, wrote: > On Saturday, February 18, 2017 at 9:29:06 AM UTC+11,

Re: Should &&/|| really be at the end of lines?

On Saturday, February 18, 2017 at 9:29:06 AM UTC+11, Bobby Holley wrote: > On Fri, Feb 17, 2017 at 2:18 PM, wrote: > > > Hi again Nick, > > > > Someone made me realize that I didn't fully read your message, sorry for > > that. > > > > I now see that as well as &&/||, you

Re: Should &&/|| really be at the end of lines?

On Fri, Feb 17, 2017 at 2:18 PM, wrote: > Hi again Nick, > > Someone made me realize that I didn't fully read your message, sorry for > that. > > I now see that as well as &&/||, you have grepped for other operators, and > shown that the overwhelming usage is to put all of

Re: Should &&/|| really be at the end of lines?

Hi again Nick, Someone made me realize that I didn't fully read your message, sorry for that. I now see that as well as &&/||, you have grepped for other operators, and shown that the overwhelming usage is to put all of them at the end of lines! In light of this, and from what others here have

Re: Intent to implement and ship CSS 'appearance' with '-webkit-appearance' as an alias. Unship '-moz-appearance'.

On 2/16/17 8:22 PM, Boris Zbarsky wrote: I'm 99% sure there are pages (including some produced by Google and Facebook, last I checked) that do server-side sniffing and send only -moz-appearance to Firefox and only -webkit-appearance to Chrome and "appearance" to no one at all. Yeah, this

Re: Tool for converting C++ standard library naming style to Gecko naming style?

Le 17/02/2017 à 19:54, Birunthan Mohanathas a écrit : > On 16 February 2017 at 13:41, Henri Sivonen wrote: >> Is there some kind of tool, similar to ./mach clang-format for >> whitespace, that changes identifies from C++ standard library style to >> Gecko style? > Yes,

Re: Tool for converting C++ standard library naming style to Gecko naming style?

On 16 February 2017 at 13:41, Henri Sivonen wrote: > Is there some kind of tool, similar to ./mach clang-format for > whitespace, that changes identifies from C++ standard library style to > Gecko style? Yes, clang-tidy has the readability-identifier-naming check:

Re: Intent to unship: xml:base attribute

On 2017-02-16 6:06 PM, Xidorn Quan wrote: > On Fri, Feb 17, 2017, at 01:38 AM, Ehsan Akhgari wrote: >> On 2017-02-16 1:51 AM, Xidorn Quan wrote: >>> Tracking bug: https://bugzilla.mozilla.org/show_bug.cgi?id=903372 >>> >>> Summary: >>> * It has been removed from the spec years ago. >>> * No other

Re: Should &&/|| really be at the end of lines?

On Thu, Feb 16, 2017 at 11:39 PM, David Major wrote: > One thing I like about trailing operators is that they tend to match > what you'd find in bullet-point prose. Here's a made-up example: > > You can apply for a refund of your travel insurance policy if: > * You cancel

Re: Should &&/|| really be at the end of lines?

On Fri, Feb 17, 2017 at 5:28 PM, wrote: > Of course grepping agrees with you, since it's been the coding style so > far! ;-) > I was hoping to change that, if most people agreed. > Isn't the current style that && and || go at the end but other operators go at the start?

Re: Intent to implement and ship CSS 'appearance' with '-webkit-appearance' as an alias. Unship '-moz-appearance'.

Sorry to not have chimed in before, but needed to do a bit of research in webcompat bugs. TLDR: removing -moz-appearance will break some sites. At least Japan airlines. Le 11 févr. 2017 à 07:27, Mats Palmgren a écrit : > Status in other implementations: No other UA