Re: Future of out-of-tree spell checkers?

2017-04-18 Thread Ehsan Akhgari
On 2017-04-18 2:38 AM, Henri Sivonen wrote: > On Sat, Apr 15, 2017 at 8:06 PM, Ehsan Akhgari > wrote: >> On 2017-03-27 3:30 AM, Henri Sivonen wrote: >>> 2) We couldn't trigger a libvoikko autoupdate on Windows/Mac if there >>> was a crasher bug in the library. (I'd

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Justin Dolske
On Tue, Apr 18, 2017 at 4:22 PM, Ehsan Akhgari wrote: > All in all we have a lot of ongoing projects and they each have > different scales and different degrees of risk associated with them, and > we are trying hard to be really careful on what project depends on what >

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Jack Moffitt
I was not saying the plans don't make sense, only that the ordering turns out to be unfortunate. I am also not suggesting we modify the plan, as the WebRender trajectory is not conducive to being a blocker for any work planed for 57 (as has been pointed out). I do think people should keep

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Chris Peterson
On 2017-04-18 4:22 PM, Ehsan Akhgari wrote: The last time I checked with the graphics team, at this point it's completely unclear whether Quantum Render is going to make it, and as such, it's not reasonable for us to depend on anything that WebRender provides for Photon, because if QR wouldn't

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Ehsan Akhgari
On 2017-04-18 1:53 PM, Justin Dolske wrote: > > > On Tue, Apr 18, 2017 at 1:19 AM, Jack Moffitt > wrote: > > > Another really nice effort that is starting to unfold and I'm super > excited > > about is the new Photon performance project >

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread smaug
On 04/18/2017 04:24 PM, Ehsan Akhgari wrote: On 2017-04-18 12:30 AM, Mike Hommey wrote: I've yet to see that to happen. What is crucial is fast way to browse through the blame in time. So commit messages should be short and descriptive. Telling what and why. (I very often need to go back to CVS

Re: window.find dialog feature broken in Firefox 53 (a.k.a., Late Intent to Unship: window.find's dialog support)

2017-04-18 Thread Liz Henry (:lizzard)
Just a quick note that I'm not going to consider this a release blocker for 53. We don't think this is commonly used API, and it is non-standard. We can think about it as a fix to include for a potential 53 dot release a couple of weeks from now. Best, Liz On Tue, Apr 18, 2017 at 11:15 AM,

window.find dialog feature broken in Firefox 53 (a.k.a., Late Intent to Unship: window.find's dialog support)

2017-04-18 Thread Mike Conley
Hello release-drivers (with dev-platform cc'd), TL;DR: The non-standard window.find feature[1] has, historically, been able to open up a dialog for the user to enter more strings to find on the page[2]. It turns out that the dialog portion of that API has been broken for all users with e10s

LocaleService::GetRequestedLocale(s) / SetRequestedLocales

2017-04-18 Thread zbraniecki
Hi all, The latest update in the locale rearchitecture is that we now have three methods on LocaleService that should be used to operate on the requested locales: LocaleService::GetRequestedLocales LocaleService::GetRequestedLocale LocaleService::SetRequestedLocales Please, use them instead

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Jared Wein
But what we *can* do is have communications with the WebRender devs to see that our approaches (which have been mostly vetted by graphics and layout people already) will continue to perform well (and possibly better) in WebRender. On Tue, Apr 18, 2017 at 1:53 PM, Justin Dolske

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Justin Dolske
On Tue, Apr 18, 2017 at 1:19 AM, Jack Moffitt wrote: > > Another really nice effort that is starting to unfold and I'm super > excited > > about is the new Photon performance project > > , which is a > focused > > effort on

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Daniel Holbert
The very basics (at least) are semi-documented here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment I frequently point people at that ^^ when they get it wrong (and e.g. use the bug title as the commit message). ~Daniel

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Boris Zbarsky
On 4/18/17 3:00 AM, Anne van Kesteren wrote: On Mon, Apr 17, 2017 at 5:16 PM, Boris Zbarsky wrote: A quick reminder to patch authors and reviewers. Is this documented somewhere so you can just point folks to documentation if they get it wrong? Not yet. As this thread

Re: new configure option: --enable-debug-rust

2017-04-18 Thread Josh Matthews
Since the subject and the body disagree on what the actual option is called, let me be clear - the correct option is --enable-rust-debug. Cheers, Josh On 2017-04-15 12:46 AM, Nathan Froyd wrote: Bug 1353810, recently merged to central, adds a new configure option --enable-debug-rust. This

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Milan Sreckovic
Jack are you speaking in the context of Servo? From the Quantum Render (Gecko with the WebRender evolution we're working on) point of view, Proton should not count on anything getting better. In other words, design for Firefox 55 and assume things will not get worse. If you need them to get

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Eric Rescorla
On Tue, Apr 18, 2017 at 4:19 AM, Jack Moffitt wrote: > > Another really nice effort that is starting to unfold and I'm super > excited > > about is the new Photon performance project > > , which is a > focused > > effort on

Project Dawn or the end of Aurora

2017-04-18 Thread Sylvestre Ledru
As described in the post on the Hacks blog , we are changing the release mechanism of Firefox. What In order to address the complexity and cycle length issues, the release management team, in coordination with Firefox

Re: [stylo-team] new configure option: --enable-debug-rust

2017-04-18 Thread Bobby Holley
This is awesome - thanks Nathan! On Fri, Apr 14, 2017 at 10:46 PM, Nathan Froyd wrote: > Bug 1353810, recently merged to central, adds a new configure option > --enable-debug-rust. This option enables compiling the Rust code > in-tree with debug-friendly settings (no

Re: windows build anti-virus exclusion list?

2017-04-18 Thread Marco Bonardo
On Fri, Mar 17, 2017 at 7:20 PM, Ben Kelly wrote: > On Fri, Mar 17, 2017 at 1:36 PM, Ted Mielczarek > wrote: > > With defender > disabled the best I can get is 18min. This is on one of the new lenovo > p710 machines with 16 xeon cores. > Just to add

[Firefox Desktop] Issues found: April 10th to April 14th

2017-04-18 Thread Cornel Ionce
Hi everyone, Here's the list of new issues found and filed by the Desktop Release QA Team last week, *April 10 - April 14* (week 15). Additional details on the team's priorities last week, as well as the plans for the current week are available at:

Re: W3C Candidate Recommendation: requestIdleCallback (deadline today)

2017-04-18 Thread Anne van Kesteren
On Tue, Apr 18, 2017 at 10:16 AM, L. David Baron wrote: > If there are comments you think Mozilla should send as part of the > review, please say so in this thread. Ideally, such comments should > link to github issues filed against the specification. (I'd note, > however,

Re: Quantum Flow Engineering Newsletter #5

2017-04-18 Thread Jack Moffitt
> Another really nice effort that is starting to unfold and I'm super excited > about is the new Photon performance project > , which is a focused > effort on the front-end performance. This includes everything from > engineering the new UI

W3C Candidate Recommendation: requestIdleCallback (deadline today)

2017-04-18 Thread L. David Baron
Sorry for sending this out late (i.e., the deadline is in just under 20 hours), but... A W3C Candidate Recommendation is available for the membership of W3C (including Mozilla) to vote on, before it proceeds to the final stages of being a W3C Proposed Recommendation and W3C Recomendation:

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Mike Hommey
On Tue, Apr 18, 2017 at 03:42:40AM +0300, smaug wrote: > On 04/18/2017 03:12 AM, gsquel...@mozilla.com wrote: > > On Tuesday, April 18, 2017 at 11:58:11 AM UTC+12, smaug wrote: > > > On 04/18/2017 02:36 AM, Gregory Szorc wrote: > > > > On Mon, Apr 17, 2017 at 4:10 PM, smaug

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Mike Hommey
On Mon, Apr 17, 2017 at 09:34:39PM -0400, Ben Kelly wrote: > On Mon, Apr 17, 2017 at 9:21 PM, Nicholas Nethercote > wrote: > > > > That is why we have links to the bug. Bug should always be the unite of > > > truth telling > > > why some change was done. Bugs tend to

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Mike Hommey
On Tue, Apr 18, 2017 at 02:58:05AM +0300, smaug wrote: > On 04/18/2017 02:36 AM, Gregory Szorc wrote: > > On Mon, Apr 17, 2017 at 4:10 PM, smaug wrote: > > > > > On 04/17/2017 06:16 PM, Boris Zbarsky wrote: > > > > > > > A quick reminder to patch authors and reviewers. > > > >

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Mike Hommey
On Tue, Apr 18, 2017 at 02:10:21AM +0300, smaug wrote: > On 04/17/2017 06:16 PM, Boris Zbarsky wrote: > > A quick reminder to patch authors and reviewers. > > > > Changesets should have commit messages. The commit message should describe > > not just the "what" of the change but also the "why".

Re: A reminder about commit messages: they should be useful

2017-04-18 Thread Gregory Szorc
On Mon, Apr 17, 2017 at 10:36 PM, Steve Fink wrote: > On 04/17/2017 08:11 PM, Nicholas Nethercote wrote: > >> On Tue, Apr 18, 2017 at 11:34 AM, Ben Kelly wrote: >> >> I don't object to people writing longer commit messages, but that >>> information needs

Re: Future of out-of-tree spell checkers?

2017-04-18 Thread Henri Sivonen
On Sat, Apr 15, 2017 at 8:06 PM, Ehsan Akhgari wrote: > On 2017-03-27 3:30 AM, Henri Sivonen wrote: >> 2) We couldn't trigger a libvoikko autoupdate on Windows/Mac if there >> was a crasher bug in the library. (I'd expect the distros to take care >> of pushing an update