Re: Please do not use GetNativePath and GetNativeTarget in XP code and Windows-specific code

2017-11-29 Thread Anne van Kesteren
On Thu, Nov 30, 2017 at 12:00 AM, Kris Maglione wrote: > I don't think this is true. The native filename isn't even available to JS, > which always deals with UTF-16 strings. JS deals with 16-bit unsigned integers. In particular, you can represent lone surrogates in JS,

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Karl Dubost
Le 30 nov. 2017 à 02:42, Emilio Cobos Álvarez a écrit : > On 11/29/2017 06:36 PM, Mike Taylor wrote: >> This is a pretty widely used mechanism to target styles for Gecko. Would it >> be possible to disable in non-release for a few releases to sniff out any >> major

Re: Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread L. David Baron
On Thursday 2017-11-30 08:21 +1100, Xidorn Quan wrote: > On Thu, Nov 30, 2017, at 07:16 AM, Mats Palmgren wrote: > > I think supporting only a subset of the valid values for a property > > is problematic. > > > > CSS conformance rules says: > > "[...] the user agent must parse the value according

Re: Please do not use GetNativePath and GetNativeTarget in XP code and Windows-specific code

2017-11-29 Thread Kris Maglione
On Thu, Nov 30, 2017 at 11:09:07AM +1300, Karl Tomlinson wrote: The native bytes may not be valid UTF-8, and so if the character encoding is UTF-8, then there may not be a valid `path` that can be encoded to produce the same `nativePath`. I think you mean "is not UTF-8"? It is

Re: Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread Xidorn Quan
On Thu, Nov 30, 2017, at 07:16 AM, Mats Palmgren wrote: > I think supporting only a subset of the valid values for a property > is problematic. > > CSS conformance rules says: > "[...] the user agent must parse the value according to the property > definition. This means that the user agent must

Browser Architecture Newsletter 5

2017-11-29 Thread Dave Townsend
Welcome to the exciting fifth instalment in our series of Browser Architecture Newsletters! Storage and Sync We are pleased to report that the Sync and Storage roadmap proposal successfully passed review by dcamp. Thanks to the 20+ people from around the organization who helped us build

Re: Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread Mats Palmgren
On 11/29/17 12:03 PM, Ting-Yu Lin wrote: We can ship all the properties in this module at once, or we could probably divide it into two stages, and ship it to the user incrementally. For example, stage 1 is to ship shape-outside" (except value) and "shape-margin", and stage 2 is to ship the

Re: Please do not use GetNativePath and GetNativeTarget in XP code and Windows-specific code

2017-11-29 Thread Kris Maglione
We should really mark these functions as deprecated, or add some sort of static analysis to make it more difficult to misuse them. It's not obvious when/where these functions should/shouldn't be used. On Thu, Nov 30, 2017 at 01:08:14AM +0900, Masatoshi Kimura wrote: On Windows, the native

Re: Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread James Graham
On 29/11/17 11:03, Ting-Yu Lin wrote: CSS Shapes Module Level 1 [1] defines three properties: "shape-outside", "shape-margin", and "shape-image-threshold" (used with shape-outside: ), which allows the users to define non-rectangular shapes for floating elements. See the previous discussion for

Re: Phabricator/Lando update, November 2017

2017-11-29 Thread Mark Côté
On Wednesday, 29 November 2017 12:43:58 UTC-5, Steve Fink wrote: > On 11/29/2017 08:35 AM, Mark Côté wrote: > > I posted an update on Phabricator and Lando to my blog a couple weeks ago, > > but I figured I should share it here too: > >

Re: Phabricator/Lando update, November 2017

2017-11-29 Thread Mark Côté
Right, I should have mentioned that. We are working right now on enforcing MFA for Phabricator via BMO. See https://bugzilla.mozilla.org/show_bug.cgi?id=1393950. Should go out next week. Mark On Nov 29, 2017 12:41 PM, "Andreas Tolfsen" wrote: > Also sprach Mark Côté: > > > We were

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Boris Zbarsky
On 11/29/17 12:42 PM, Emilio Cobos Álvarez wrote: Another thing we could try to do if plain unshipping fails would be to just hide the regex matching function, which IIUC would prevent the security issue too. But hiding it behind a pref on non-release for now sounds good. Boris, would you also

Re: Phabricator/Lando update, November 2017

2017-11-29 Thread Steve Fink
On 11/29/2017 08:35 AM, Mark Côté wrote: I posted an update on Phabricator and Lando to my blog a couple weeks ago, but I figured I should share it here too: https://mrcote.info/blog/2017/11/17/phabricator-and-lando-november-update/ There are two important points: 1. Our Phabricator instance

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Emilio Cobos Álvarez
On 11/29/2017 06:36 PM, Mike Taylor wrote: > >> On Nov 29, 2017, at 10:53 AM, Emilio Cobos Álvarez wrote: >> >> In bug 1035091 I intend to remove support for the @-moz-document CSS >> rule in content pages (more exactly in author stylesheets). > > This is a pretty widely used

Re: Phabricator/Lando update, November 2017

2017-11-29 Thread Andreas Tolfsen
Also sprach Mark Côté: > We were hesitant to advertise this too widely in order not to create > any confusion around the Quantum release, but now that that has > settled down I am told it should be fine for anyone to start using > it. The instance is at https://phabricator.services.mozilla.com/

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Mike Taylor
> On Nov 29, 2017, at 10:53 AM, Emilio Cobos Álvarez wrote: > > In bug 1035091 I intend to remove support for the @-moz-document CSS > rule in content pages (more exactly in author stylesheets). This is a pretty widely used mechanism to target styles for Gecko. Would it be

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Boris Zbarsky
On 11/29/17 11:53 AM, Emilio Cobos Álvarez wrote: Let me know if there's any concern on doing this. @-moz-document url-prefix() { /* rules go here */ } at least used to be a somewhat common way to have "Firefox-only" rules on web pages.

Re: Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Xidorn Quan
On Thu, Nov 30, 2017, at 03:53 AM, Emilio Cobos Álvarez wrote: > Hi again, > > In bug 1035091 I intend to remove support for the @-moz-document CSS > rule in content pages (more exactly in author stylesheets). > > The reasoning for this, apart from it being a non-standard mozilla-only > CSS

Intent to unship: @-moz-document from content pages.

2017-11-29 Thread Emilio Cobos Álvarez
Hi again, In bug 1035091 I intend to remove support for the @-moz-document CSS rule in content pages (more exactly in author stylesheets). The reasoning for this, apart from it being a non-standard mozilla-only CSS feature, is that it's a possible security risk in presence of CSS injection

Intent to unship -moz-border-*-colors from content pages.

2017-11-29 Thread Emilio Cobos Álvarez
Hi dev-platform@, In bug 1417200, I intend to hide the -moz-border-top-colors, -moz-border-bottom-colors, -moz-border-left-colors, and -moz-border-right-colors from content pages. The reasons for doing this are multiple: * Non-standard properties. * Kinda-weird, in the sense that the

Re: Using icecream distributed compiler with a mac...

2017-11-29 Thread Sylvestre Ledru
On 29/11/2017 17:10, Jean-Yves Avenard wrote: > Hi there. > > Last week I spent a bit of time getting icecream working and usable with > mac builds (on mac). [...] > Note for whomever is maintaining the icecream boxes in the various offices: > Current version of Debian/Ubuntu are running an old

Using icecream distributed compiler with a mac...

2017-11-29 Thread Jean-Yves Avenard
Hi there. Last week I spent a bit of time getting icecream working and usable with mac builds (on mac). The generated binary can be used with a debugger, all stack traces are good. The repository with the various required files and the steps to follow are available there.

Please do not use GetNativePath and GetNativeTarget in XP code and Windows-specific code

2017-11-29 Thread Masatoshi Kimura
On Windows, the native charset is not UTF-8. Using these functions will cause bugs such as [1] or [2]. Note that you can't simply replace all GetNative(Target|Path) to Get(Target|Path) + NS_ConvertUTF16toUTF8. It will make things *worse*. If you are using the path in logs or serialization formats

Re: Proposal to remove the xpfe autocomplete bindings and the xpfe/components/autocomplete directory

2017-11-29 Thread Brian Grinstead
This has now landed - it was moved into comm-central in Bug 1418512 and removed from mozilla-central in Bug 1417119. Brian > On Nov 14, 2017, at 9:25 AM, Brian Grinstead wrote: > > That makes sense. I went ahead and filed Bug 1417119 for the removal from > m-c, and we

Re: Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread Geoffrey Sneddon
On Wed, Nov 29, 2017 at 11:03 AM, Ting-Yu Lin wrote: > CSS Shapes Module Level 1 [1] defines three properties: "shape-outside", > "shape-margin", and "shape-image-threshold" (used with shape-outside: > ), which allows the users to define non-rectangular shapes for > floating

Intent to ship: CSS Shapes Module Level 1 (partial)

2017-11-29 Thread Ting-Yu Lin
CSS Shapes Module Level 1 [1] defines three properties: "shape-outside", "shape-margin", and "shape-image-threshold" (used with shape-outside: ), which allows the users to define non-rectangular shapes for floating elements. See the previous discussion for the main bug, pref, and examples in the