Re: Coding style: brace initialization syntax

2018-06-05 Thread gsquelart
On Wednesday, June 6, 2018 at 5:35:59 AM UTC+10, Boris Zbarsky wrote: > On 6/5/18 3:10 PM, Emilio Cobos Álvarez wrote: > > I personally would prefer one space at each side when using braces: > > > >  , mFoo { 0 } > > I think the reason people tend to think of this as not wanting spaces is >

Re: OrangeFactor/Intermittent Failures View Update

2018-06-05 Thread Robert O'Callahan
Thank you very very much for making this information public again! Rob -- Su ot deraeppa sah dna Rehtaf eht htiw saw hcihw, efil lanrete eht uoy ot mialcorp ew dna, ti ot yfitset dna ti nees evah ew; deraeppa efil eht. Efil fo Drow eht gninrecnoc mialcorp ew siht - dehcuot evah sdnah ruo dna ta

Re: Coding style: brace initialization syntax

2018-06-05 Thread Boris Zbarsky
On 6/5/18 3:10 PM, Emilio Cobos Álvarez wrote: I personally would prefer one space at each side when using braces:  , mFoo { 0 } I think the reason people tend to think of this as not wanting spaces is that they are thinking of it as a constructor call. The parentheses syntax for

Re: Coding style: brace initialization syntax

2018-06-05 Thread Emilio Cobos Álvarez
On 06/05/2018 06:48 PM, Eric Rahm wrote: Reading back through I think the consensus, at least for initializer lists was: 1. Prefer parenthesis, ie: , mBool(true) 2. If using braces, maintain the same spacing you would use with parenthesis, ie: , mStructWithoutCtor{42} 1.

Re: Coding style: brace initialization syntax

2018-06-05 Thread Eric Rahm
Reading back through I think the consensus, at least for initializer lists was: 1. Prefer parenthesis, ie: , mBool(true) 2. If using braces, maintain the same spacing you would use with parenthesis, ie: , mStructWithoutCtor{42} 1. was pragmatic as this is what we already do, 2.

Introducing #ci and the ciduty team

2018-06-05 Thread Jordan Lund
Hi all, If you contribute to the development of Firefox, the changes outlined in this post will impact you. tl;dr - What’s changing: - Firefox continuous integration (firefox-ci) based discussions #releng, #buildduty, aed #taskcluster are being moved to the newly created #ci IRC

OrangeFactor/Intermittent Failures View Update

2018-06-05 Thread Sarah Clements
Hi! As of today, the OrangeFactor url is redirecting to Intermittent Failures View as part of the decommission process. The API's that replace OrangeFactors API's are Failures, FailuresByBug and FailureCount (you can find more info in

[desktop] Bugs logged by Desktop Release QA in the last 16 days

2018-06-05 Thread Bogdan Maris
Hello, Here's the list of new issues found and filed by the Desktop Release QA team last two weeks. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://tinyurl.com/ybeh964m Bugs logged by Desktop Release QA in the last 16

Re: Coding style: brace initialization syntax

2018-06-05 Thread Jean-Yves Avenard
> On 5 Jun 2018, at 12:54 pm, bposteln...@mozilla.com wrote: > > I would like to resurrect this thread since it would help us a lot for bug > 1453795 to come up to a consensus on when to use bracelets and when to use > parenthesis. Also I must point out a thing here, that was also mentioned

Re: Coding style: brace initialization syntax

2018-06-05 Thread bpostelnicu
I would like to resurrect this thread since it would help us a lot for bug 1453795 to come up to a consensus on when to use bracelets and when to use parenthesis. Also I must point out a thing here, that was also mentioned here earlier, that there are situations where we cannot use parenthesis.

Intent to ship: New AltGr key behavior on Windows

2018-06-05 Thread Masayuki Nakano
Google suggested that browsers shouldn't set ctrlKey and altKey to true for keyboard events during AltGr key is pressed on Windows. We will follow the new behavior for compatibility with Chromium and better accessibility for some language users. https://github.com/w3c/uievents/issues/147