Re: Proposal to remove unnecessary [type] attributes on script tags in mozilla-central

> I'm writing to the list in order to: > 2) See if there are any general best-practices for getting this type of > change reviewed / landed. For example, should we prefer separate commits / > reviews per directory, or does a single tree-wide commit make sense? > > Please include the string "#

Re: Improving our usage of Bugzilla

Does performance work count as "enhancement" or "task"? On one hand, it's not strictly refactoring.. On the other hand, it is not development of a new feature, per the proposed description of enhancement. On Tue, Mar 12, 2019 at 3:20 PM Onno Ekker wrote: > On 12/03/2019 18:59, Sylvestre Ledru

Skipping changesets when viewing blame

If you ran `mach bootstrap` or `mach vcs-setup` in the last month, you should already have a new hg command alias called `smart-annotate`, which runs `hg annotate` while ignoring some predefined changesets. The primary use case is to ignore (semi-)automatic code-formatting changes. The list of

Re: Upcoming changes to our C++ Coding Style

On Thu, Nov 22, 2018 at 3:07 PM Ehsan Akhgari wrote: > Felipe, gps and I talked a bit about adding a similar > .hg-blame-ignore-revs file in the tree which can contain Mercurial sha1 > changeset IDs for the rewrite commits to be skipped over, and people would > be able to use the file through

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

> > > > >Also note that dealing with the "importance" of a page is not just a > >matter of visibility and focus. There are other factors to take into > >account such as if the page is playing audio or video (like listening to > >music on YouTube), if it's self-updating and so on. > > Absolutely >

Intent to Ship: Enterprise Policies

Summary: The Enterprise Policies manager is a feature to allow administrators to configure and lock some aspects of Firefox across several machines in an enterprise deployment. We intend to enable it right now so that it rolls out normally through the beta cycle, where we'll gather feedback from

Re: Changes to tab min-width

I like having this option back, as I know this was a feature that a lot of people liked in the past. (even though I'm personally ok with the 100px width) I've been trying to use the new default (50px) for a couple of hours, and it felt surprisingly unusable, in a way that I couldn't quite figure

Re: disabled non-e10s tests on trunk

I ran some scripts that I had to find out tests that are *fully* disabled on e10s, and posted the results to https://bugzilla.mozilla.org/show_bug.cgi?id=1376934 In summary: mochitest-plain: 49 tests browser-chrome: 15 tests devtools: 86 tests Note that the script evaluates the skip-if condition

Re: ESlint rule 'no-arbitrary-setTimeout' enabled on xpcshell tests

I'll note that requestFlakyTimeout is only enabled for mochitest-plain at the moment: http://searchfox.org/mozilla-central/source/testing/ mochitest/tests/SimpleTest/SimpleTest.js#666 So browser-chrome / a11y / chrome tests are still able to use non-0 timeouts. Cheers, Felipe On Fri, Jul 28,

Re: Profiling nightlies on Mac - what tools are used?

The Activity Monitor has a built-in process sampling tool that is very handy and I use it every now and then. On Mon, Jun 19, 2017 at 7:40 PM, Kearwood Kip Gilbert wrote: > I would add to this Apple’s “OpenGL Profiler”: > >

Intent to implement: Dynamic blocklist to disallow plugins triggered from specified 3rd-party domains

Summary: This intent covers adding a dynamic blocklist (to be stored/updated through Shavar) to disallow plugins running on specific domains when they are in a 3rd-party context (e.g. a 3rd party iframe). Motivation: Flash and other plugins are still a primary target for malware authors and

Re: Checkin-needed requests - Please include complete information in the commit message :)

Is there a way to make the checkin-needed flag generate a template comment (like the approval-* ones do) with something like this? (Or encourage people to use the per-patch checkin? flag) """ Has this patch been through try? [ Yes / No, I believe it's not necessary ] Does this patch contain the

Re: Testing Wanted: APZ Scrollbar dragging

Hey Jonas, this second issue that you're seeing is tracked at https://bugzilla.mozilla.org/show_bug.cgi?id=1257862 Cheers, Felipe On Tue, Mar 29, 2016 at 5:55 PM, Jonas Sicking wrote: > Hi Benoit, > > There's two problems that I've seen related to scrolling, and so >

Re: Intent to enable e10s by default when running tests locally

Yeah, that sounds like another good outcome of replacing --e10s with --disable-e10s. On Thu, Mar 24, 2016 at 3:59 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote: > On Thu, Mar 24, 2016 at 2:10 PM, Felipe G <fel...@gmail.com> wrote: > >> Yeah, --e10s enables e10s in t

Re: Intent to enable e10s by default when running tests locally

Yeah, --e10s enables e10s in the browser for mochitest-chrome. However, the test harness is a .xul file opened in a tab, and that runs that tab as non-remote, so for most tests it ends up testing the same thing as not using --e10s. Other tabs and/or windows opened manually by the test would be

Re: Status: e10s on 45, 46, and 47

On Mon, Mar 7, 2016 at 2:27 PM, Ehsan Akhgari wrote: > Hi Jim, > > On 2016-03-07 10:25 AM, Jim Mathies wrote: > > Users involved in this experiment will: > > > > - not have addons installed > > - will not have used accessibility recently (including touch screen > users)

e10s tests

(cross-posted to fx-dev and dev.platform) As we drive towards shipping e10s, we are working on making sure that our tests work with e10s. As you already know, there's a number of tests that are disabled from running on e10s, and we need to enable them. We've created a spreadsheet that lists every

Re: How to efficiently walk the DOM tree and its strings

Chrome imports a JS script into the webpage and this script does all the translation work. Felipe On Mon, Mar 3, 2014 at 4:31 PM, Jeff Muizelaar jmuizel...@mozilla.comwrote: On Mar 3, 2014, at 2:28 PM, Felipe G fel...@gmail.com wrote: Hi everyone, I'm working on a feature to offer webpage

Re: How to efficiently walk the DOM tree and its strings

Thanks for the feedback so far! If I go with the clone route (to work on the snapshot'ed version of the data), how can I later associate the cloned nodes to the original nodes from the document? One way that I thought is to set a a userdata on the DOM nodes and then use the clone handler

Re: How to efficiently walk the DOM tree and its strings

, 2014 at 8:47 AM, Felipe G fel...@gmail.com wrote: If I go with the clone route (to work on the snapshot'ed version of the data), how can I later associate the cloned nodes to the original nodes from the document? One way that I thought is to set a a userdata on the DOM nodes and then use

How to efficiently walk the DOM tree and its strings

Hi everyone, I'm working on a feature to offer webpage translation in Firefox. Translation involves, quite unsurprisingly, a lot of DOM and strings manipulation. Since DOM access only happens in the main thread, it brings the question of how to do it properly without causing jank. This is the use

Re: How to efficiently walk the DOM tree and its strings

of it on that page's renderer thread. On Mon, Mar 3, 2014 at 4:31 PM, Jeff Muizelaar jmuizel...@mozilla.comwrote: On Mar 3, 2014, at 2:28 PM, Felipe G fel...@gmail.com wrote: Hi everyone, I'm working on a feature to offer webpage translation in Firefox. Translation involves, quite unsurprisingly

Fwd: How to efficiently walk the DOM tree and its strings

On Mon, Mar 3, 2014 at 5:19 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 3/3/14 2:28 PM, Felipe G wrote: A possible solution to that is to only pause the page that is being translated (with, say, EnterModalState) until we can finish working on it, while letting other pages and the UI work